More logging around failed response parsing

DataDog · Feb 14, 2019 · 2b74f7e · 2b74f7e
1 parent 2dcf6d4
commit 2b74f7e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/encoder.cpp b/src/encoder.cpp
@@ -60,7 +60,7 @@ void AgentHttpEncoder::handleResponse(const std::string& response) {
       }
       sampler_->configure(config[priority_sampling_key]);
     } catch (const json::parse_error&) {
-      std::cerr << "Unable to parse response from agent" << std::endl;
+      std::cerr << "Unable to parse response from agent. Response was: " << response << std::endl;
       return;
     }
   }

diff --git a/test/agent_writer_test.cpp b/test/agent_writer_test.cpp
@@ -93,7 +93,9 @@ TEST_CASE("writer") {
     std::stringstream error_message;
     std::streambuf* stderr = std::cerr.rdbuf(error_message.rdbuf());
     writer.flush(std::chrono::seconds(10));
-    REQUIRE(error_message.str() == "Unable to parse response from agent\n");
+    REQUIRE(error_message.str() ==
+            ("Unable to parse response from agent. Response was: "
+             "// What?! This isn't JSON! Everyone knows real JSON doesn't have comments...\n"));
     std::cerr.rdbuf(stderr);  // Restore stderr.
     REQUIRE(sampler->config == "");
   }