Merge pull request #83 from DataDog/cgilmour/operation-name

Make operation_name_override only apply to span name
DataDog · Jan 30, 2019 · 2dcf6d4 · 2dcf6d4
2 parents ea185e7 + d9e4f29
commit 2dcf6d4
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/src/span.cpp b/src/span.cpp
@@ -126,7 +126,6 @@ void Span::FinishWithOptions(
   if (operation_name_override_ != "") {
     span_->meta[operation_name_tag] = span_->name;
     span_->name = operation_name_override_;
-    span_->resource = operation_name_override_;
   }
   // Apply special tags.
   // If we add any more cases; then abstract this. For now, KISS.

diff --git a/test/span_test.cpp b/test/span_test.cpp
@@ -255,7 +255,7 @@ TEST_CASE("span") {
     REQUIRE(result->meta ==
             std::unordered_map<std::string, std::string>{{"operation", "original span name"}});
     REQUIRE(result->name == "overridden operation name");
-    REQUIRE(result->resource == "overridden operation name");
+    REQUIRE(result->resource == "original resource");
     REQUIRE(result->service == "original service");
     REQUIRE(result->type == "original type");
   }