Fix integration tests in the CI #80
Conversation
albertvaka
force-pushed
the
albertvaka/update-xcode-ci
branch
from
7f6c8e2 to
c574c47
Compare
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| xcode: ["13.3.1", "14.0", "14.1", "14.2"] | ||
| xcode: ["Xcode_14.3"] |
There was a problem hiding this comment.
Maybe several Xcode version were selected here to test using several compiler versions. Are we ok dropping those?
There was a problem hiding this comment.
Only Xcode 14.1 and later are available on the macOS 13 runners (which I had to upgrade to because of the new version of opentelemetry-swift), I can re-add 14.1 and 14.2 though if we want to make sure it continues to build there.
There was a problem hiding this comment.
👍🏼 14.2 and 14.3.1 might make sense since they use two different swift stack https://swiftversion.net/ no need for 14.1.
There was a problem hiding this comment.
Do you recommend having both 14.3 and 14.3.1 in addition ot 14.2? Or just 14.2 and 14.3.1 should be enough?
There was a problem hiding this comment.
Just 14.2 and 14.3.1 should be enough. The later fixed a bug on 14.3 so having both isn't necessary.
Co-authored-by: David Bonnet <david.bonnet85@gmail.com>
Passing pipeline: https://github.com/DataDog/dd-sdk-swift-testing/actions/runs/6469451790
[1] For some reason that I don't understand, even though we are targeting macos 10.13, I was getting compilation errors because of some macos 13-only code in the opentelemetry-swift dependency even when that code is behind an
ifdeffor macos 13+. Instead of trying to solve this, I went ahead and bumped the macos version we build on to 13, which also required bumping Xcode.