Taint gson sources (deserialization) v1.4 and v1.5 #6084
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redacts values based on a list of predefined words name are normalized in lower case and by removing special characters: `@`, `$`, `-` and `_` Redaction happening at: - expression language for reference, index and getmember operations - serialization for snapshot or template values including maps - capture of the values from instrumentation For conditions (log or span decoration probes) evaluation of a redacted values triggers an evaluation exception that will be reported as evaluation error into a snapshot.
|
This PR will be resumed one we are able to remove elements from tainted objects |
jandro996
commented
Oct 23, 2023
| } | ||
|
|
||
| @Override | ||
| public void adviceTransformations(AdviceTransformation transformation) { |
There was a problem hiding this comment.
Needs to add more advices:
(InputStream, String)
ReInit(InputStream)
ReInit(StringReader)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Add instrumentation to com.google.gson.JsonParserJavacc
Motivation
Add gson source propagation for v1.4 and v1.5
Additional Notes
related with #6056
This PR is not completed, for ReInit method instrumentation we need to check if the input is tainted and if check if the JsonParserJavacc instance is tainted and remove it from the tainted objects.
Right now there is no mechanism to allow the removal of tainted objects (This will impact performance)
Jira ticket: APPSEC-11795