-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dead code from profiler #6115
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardstartin
added
the
tag: no release notes
Changes to exclude from release notes
label
Oct 30, 2023
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 54 cases. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.23.0-SNAPSHOT~8dd22988e1, baseline=1.23.0-SNAPSHOT~eeb3363de9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.019 s) : 0, 1018656
Total [baseline] (9.214 s) : 0, 9213895
Agent [candidate] (1.021 s) : 0, 1021011
Total [candidate] (9.228 s) : 0, 9227639
section appsec
Agent [baseline] (1.106 s) : 0, 1106373
Total [baseline] (9.296 s) : 0, 9295707
Agent [candidate] (1.107 s) : 0, 1107071
Total [candidate] (9.346 s) : 0, 9346353
section iast
Agent [baseline] (1.145 s) : 0, 1145072
Total [baseline] (9.436 s) : 0, 9436138
Agent [candidate] (1.154 s) : 0, 1154035
Total [candidate] (9.51 s) : 0, 9509898
section profiling
Agent [baseline] (1.195 s) : 0, 1195021
Total [baseline] (9.447 s) : 0, 9447135
Agent [candidate] (1.194 s) : 0, 1194230
Total [candidate] (9.471 s) : 0, 9470508
gantt
title petclinic - break down per module: candidate=1.23.0-SNAPSHOT~8dd22988e1, baseline=1.23.0-SNAPSHOT~eeb3363de9
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (636.255 ms) : 0, 636255
BytebuddyAgent [candidate] (638.027 ms) : 0, 638027
GlobalTracer [baseline] (292.061 ms) : 0, 292061
GlobalTracer [candidate] (292.775 ms) : 0, 292775
AppSec [baseline] (49.238 ms) : 0, 49238
AppSec [candidate] (49.103 ms) : 0, 49103
Remote Config [baseline] (680.7 µs) : 0, 681
Remote Config [candidate] (680.873 µs) : 0, 681
Telemetry [baseline] (6.052 ms) : 0, 6052
Telemetry [candidate] (6.088 ms) : 0, 6088
section appsec
BytebuddyAgent [baseline] (636.416 ms) : 0, 636416
BytebuddyAgent [candidate] (637.49 ms) : 0, 637490
GlobalTracer [baseline] (291.228 ms) : 0, 291228
GlobalTracer [candidate] (292.043 ms) : 0, 292043
AppSec [baseline] (138.173 ms) : 0, 138173
AppSec [candidate] (137.002 ms) : 0, 137002
Remote Config [baseline] (638.299 µs) : 0, 638
Remote Config [candidate] (637.557 µs) : 0, 638
Telemetry [baseline] (5.667 ms) : 0, 5667
Telemetry [candidate] (5.68 ms) : 0, 5680
section iast
BytebuddyAgent [baseline] (765.489 ms) : 0, 765489
BytebuddyAgent [candidate] (773.352 ms) : 0, 773352
GlobalTracer [baseline] (272.444 ms) : 0, 272444
GlobalTracer [candidate] (274.243 ms) : 0, 274243
AppSec [baseline] (48.136 ms) : 0, 48136
AppSec [candidate] (47.205 ms) : 0, 47205
IAST [baseline] (13.981 ms) : 0, 13981
IAST [candidate] (16.341 ms) : 0, 16341
Remote Config [baseline] (1.232 ms) : 0, 1232
Remote Config [candidate] (608.048 µs) : 0, 608
Telemetry [baseline] (9.525 ms) : 0, 9525
Telemetry [candidate] (7.552 ms) : 0, 7552
section profiling
BytebuddyAgent [baseline] (647.986 ms) : 0, 647986
BytebuddyAgent [candidate] (649.349 ms) : 0, 649349
GlobalTracer [baseline] (357.321 ms) : 0, 357321
GlobalTracer [candidate] (356.029 ms) : 0, 356029
AppSec [baseline] (49.651 ms) : 0, 49651
AppSec [candidate] (49.203 ms) : 0, 49203
Remote Config [baseline] (647.218 µs) : 0, 647
Remote Config [candidate] (639.539 µs) : 0, 640
Telemetry [baseline] (6.079 ms) : 0, 6079
Telemetry [candidate] (6.029 ms) : 0, 6029
ProfilingAgent [baseline] (80.148 ms) : 0, 80148
ProfilingAgent [candidate] (79.621 ms) : 0, 79621
Profiling [baseline] (80.172 ms) : 0, 80172
Profiling [candidate] (79.645 ms) : 0, 79645
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.23.0-SNAPSHOT~8dd22988e1, baseline=1.23.0-SNAPSHOT~eeb3363de9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.022 s) : 0, 1022303
Total [baseline] (8.743 s) : 0, 8742657
Agent [candidate] (1.034 s) : 0, 1034395
Total [candidate] (8.747 s) : 0, 8746901
section iast
Agent [baseline] (1.151 s) : 0, 1150531
Total [baseline] (9.232 s) : 0, 9231626
Agent [candidate] (1.147 s) : 0, 1147246
Total [candidate] (9.235 s) : 0, 9234856
section iast_TELEMETRY_OFF
Agent [baseline] (1.137 s) : 0, 1136980
Total [baseline] (9.198 s) : 0, 9197686
Agent [candidate] (1.137 s) : 0, 1136980
Total [candidate] (9.191 s) : 0, 9190566
gantt
title insecure-bank - break down per module: candidate=1.23.0-SNAPSHOT~8dd22988e1, baseline=1.23.0-SNAPSHOT~eeb3363de9
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (639.748 ms) : 0, 639748
BytebuddyAgent [candidate] (646.523 ms) : 0, 646523
GlobalTracer [baseline] (291.918 ms) : 0, 291918
GlobalTracer [candidate] (296.462 ms) : 0, 296462
AppSec [baseline] (49.36 ms) : 0, 49360
AppSec [candidate] (49.654 ms) : 0, 49654
Remote Config [baseline] (680.957 µs) : 0, 681
Remote Config [candidate] (700.523 µs) : 0, 701
Telemetry [baseline] (6.053 ms) : 0, 6053
Telemetry [candidate] (6.184 ms) : 0, 6184
section iast
BytebuddyAgent [baseline] (769.325 ms) : 0, 769325
BytebuddyAgent [candidate] (768.044 ms) : 0, 768044
GlobalTracer [baseline] (273.182 ms) : 0, 273182
GlobalTracer [candidate] (272.763 ms) : 0, 272763
AppSec [baseline] (47.015 ms) : 0, 47015
AppSec [candidate] (46.953 ms) : 0, 46953
IAST [baseline] (16.345 ms) : 0, 16345
IAST [candidate] (16.944 ms) : 0, 16944
Remote Config [baseline] (1.205 ms) : 0, 1205
Remote Config [candidate] (590.587 µs) : 0, 591
Telemetry [baseline] (9.0 ms) : 0, 9000
Telemetry [candidate] (7.49 ms) : 0, 7490
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (759.043 ms) : 0, 759043
BytebuddyAgent [candidate] (758.647 ms) : 0, 758647
GlobalTracer [baseline] (272.369 ms) : 0, 272369
GlobalTracer [candidate] (271.706 ms) : 0, 271706
AppSec [baseline] (46.321 ms) : 0, 46321
AppSec [candidate] (45.932 ms) : 0, 45932
IAST [baseline] (16.844 ms) : 0, 16844
IAST [candidate] (16.866 ms) : 0, 16866
Remote Config [baseline] (631.6 µs) : 0, 632
Remote Config [candidate] (604.6 µs) : 0, 605
Telemetry [baseline] (7.498 ms) : 0, 7498
Telemetry [candidate] (8.929 ms) : 0, 8929
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.23.0-SNAPSHOT~8dd22988e1, baseline=1.23.0-SNAPSHOT~eeb3363de9
dateFormat X
axisFormat %s
section baseline
no_agent (1.33 ms) : 1310, 1349
. : milestone, 1330,
appsec (1.702 ms) : 1678, 1727
. : milestone, 1702,
iast (1.465 ms) : 1441, 1490
. : milestone, 1465,
profiling (1.464 ms) : 1439, 1488
. : milestone, 1464,
tracing (1.424 ms) : 1399, 1449
. : milestone, 1424,
section candidate
no_agent (1.332 ms) : 1313, 1351
. : milestone, 1332,
appsec (1.703 ms) : 1679, 1727
. : milestone, 1703,
iast (1.457 ms) : 1433, 1481
. : milestone, 1457,
profiling (1.483 ms) : 1459, 1508
. : milestone, 1483,
tracing (1.429 ms) : 1404, 1453
. : milestone, 1429,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.23.0-SNAPSHOT~8dd22988e1, baseline=1.23.0-SNAPSHOT~eeb3363de9
dateFormat X
axisFormat %s
section baseline
no_agent (361.896 µs) : 342, 382
. : milestone, 362,
iast (465.483 µs) : 444, 487
. : milestone, 465,
iast_FULL (522.412 µs) : 502, 543
. : milestone, 522,
iast_INACTIVE (429.215 µs) : 409, 450
. : milestone, 429,
iast_TELEMETRY_OFF (467.346 µs) : 446, 489
. : milestone, 467,
tracing (432.854 µs) : 412, 454
. : milestone, 433,
section candidate
no_agent (364.706 µs) : 344, 385
. : milestone, 365,
iast (464.968 µs) : 444, 486
. : milestone, 465,
iast_FULL (525.288 µs) : 505, 546
. : milestone, 525,
iast_INACTIVE (433.468 µs) : 412, 455
. : milestone, 433,
iast_TELEMETRY_OFF (459.714 µs) : 438, 481
. : milestone, 460,
tracing (430.248 µs) : 409, 452
. : milestone, 430,
|
jbachorik
approved these changes
Oct 30, 2023
ygree
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: profiling
Profiling
tag: no release notes
Changes to exclude from release notes
type: refactoring
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Jira ticket: [PROJ-IDENT]