Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add git repository and sha in RC request tags #6143

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Add git repository and sha in RC request tags #6143

merged 1 commit into from
Nov 3, 2023

Conversation

jpbempel
Copy link
Member

@jpbempel jpbempel commented Nov 3, 2023 •
edited by jira bot
Loading

What Does This Do

Send git repository url and git commit sha as tags on each Remote Config request

Motivation

Transmit git metadata to link with SCI for Dynamic Instrumentation through heartbeats

Additional Notes

Jira ticket: DEBUG-1831

@jpbempel jpbempel requested a review from a team as a code owner November 3, 2023 10:50
@jpbempel jpbempel requested review from dougqh and ygree November 3, 2023 10:50
@jpbempel jpbempel added the comp: debugger Dynamic Instrumentation label Nov 3, 2023
@pr-commenter
Copy link

pr-commenter bot commented Nov 3, 2023 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
commit 1.23.0-SNAPSHOT~38ee52be0e 1.23.0-SNAPSHOT~fe96bf2922
config baseline candidate
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 cases.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.23.0-SNAPSHOT~fe96bf2922, baseline=1.23.0-SNAPSHOT~38ee52be0e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.045 s) : 0, 1044854
Total [baseline] (8.799 s) : 0, 8798805
Agent [candidate] (1.047 s) : 0, 1046758
Total [candidate] (8.797 s) : 0, 8796686
section iast
Agent [baseline] (1.152 s) : 0, 1151654
Total [baseline] (9.309 s) : 0, 9308530
Agent [candidate] (1.154 s) : 0, 1153895
Total [candidate] (9.327 s) : 0, 9326518
section iast_TELEMETRY_OFF
Agent [baseline] (1.146 s) : 0, 1146000
Total [baseline] (9.287 s) : 0, 9287163
Agent [candidate] (1.145 s) : 0, 1145000
Total [candidate] (9.3 s) : 0, 9300078
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.045 s -
Agent iast 1.152 s 106.8 ms (10.2%)
Agent iast_TELEMETRY_OFF 1.146 s 101.145 ms (9.7%)
Total tracing 8.799 s -
Total iast 9.309 s 509.725 ms (5.8%)
Total iast_TELEMETRY_OFF 9.287 s 488.359 ms (5.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.047 s -
Agent iast 1.154 s 107.137 ms (10.2%)
Agent iast_TELEMETRY_OFF 1.145 s 98.242 ms (9.4%)
Total tracing 8.797 s -
Total iast 9.327 s 529.832 ms (6.0%)
Total iast_TELEMETRY_OFF 9.3 s 503.392 ms (5.7%) 
gantt
    title insecure-bank - break down per module: candidate=1.23.0-SNAPSHOT~fe96bf2922, baseline=1.23.0-SNAPSHOT~38ee52be0e

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (651.89 ms) : 0, 651890
BytebuddyAgent [candidate] (652.243 ms) : 0, 652243
GlobalTracer [baseline] (296.891 ms) : 0, 296891
GlobalTracer [candidate] (297.636 ms) : 0, 297636
AppSec [baseline] (49.164 ms) : 0, 49164
AppSec [candidate] (49.864 ms) : 0, 49864
Remote Config [baseline] (712.881 µs) : 0, 713
Remote Config [candidate] (713.505 µs) : 0, 714
Telemetry [baseline] (11.457 ms) : 0, 11457
Telemetry [candidate] (11.578 ms) : 0, 11578
section iast
BytebuddyAgent [baseline] (764.732 ms) : 0, 764732
BytebuddyAgent [candidate] (767.025 ms) : 0, 767025
GlobalTracer [baseline] (273.95 ms) : 0, 273950
GlobalTracer [candidate] (274.837 ms) : 0, 274837
AppSec [baseline] (46.572 ms) : 0, 46572
AppSec [candidate] (46.675 ms) : 0, 46675
IAST [baseline] (18.115 ms) : 0, 18115
IAST [candidate] (18.605 ms) : 0, 18605
Remote Config [baseline] (570.68 µs) : 0, 571
Remote Config [candidate] (576.709 µs) : 0, 577
Telemetry [baseline] (13.24 ms) : 0, 13240
Telemetry [candidate] (11.821 ms) : 0, 11821
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (758.98 ms) : 0, 758980
BytebuddyAgent [candidate] (759.791 ms) : 0, 759791
GlobalTracer [baseline] (274.606 ms) : 0, 274606
GlobalTracer [candidate] (274.928 ms) : 0, 274928
AppSec [baseline] (46.793 ms) : 0, 46793
AppSec [candidate] (46.887 ms) : 0, 46887
IAST [baseline] (18.222 ms) : 0, 18222
IAST [candidate] (17.959 ms) : 0, 17959
Remote Config [baseline] (564.41 µs) : 0, 564
Remote Config [candidate] (574.208 µs) : 0, 574
Telemetry [baseline] (12.469 ms) : 0, 12469
Telemetry [candidate] (10.44 ms) : 0, 10440
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.23.0-SNAPSHOT~fe96bf2922, baseline=1.23.0-SNAPSHOT~38ee52be0e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.042 s) : 0, 1042252
Total [baseline] (9.339 s) : 0, 9339152
Agent [candidate] (1.044 s) : 0, 1044069
Total [candidate] (9.284 s) : 0, 9284190
section appsec
Agent [baseline] (1.12 s) : 0, 1120203
Total [baseline] (9.416 s) : 0, 9415685
Agent [candidate] (1.121 s) : 0, 1121414
Total [candidate] (9.408 s) : 0, 9408074
section iast
Agent [baseline] (1.149 s) : 0, 1149435
Total [baseline] (9.519 s) : 0, 9519033
Agent [candidate] (1.161 s) : 0, 1160999
Total [candidate] (9.58 s) : 0, 9579846
section profiling
Agent [baseline] (1.227 s) : 0, 1226951
Total [baseline] (9.541 s) : 0, 9541429
Agent [candidate] (1.218 s) : 0, 1218070
Total [candidate] (9.517 s) : 0, 9517193
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.042 s -
Agent appsec 1.12 s 77.951 ms (7.5%)
Agent iast 1.149 s 107.183 ms (10.3%)
Agent profiling 1.227 s 184.699 ms (17.7%)
Total tracing 9.339 s -
Total appsec 9.416 s 76.532 ms (0.8%)
Total iast 9.519 s 179.881 ms (1.9%)
Total profiling 9.541 s 202.277 ms (2.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.044 s -
Agent appsec 1.121 s 77.345 ms (7.4%)
Agent iast 1.161 s 116.931 ms (11.2%)
Agent profiling 1.218 s 174.001 ms (16.7%)
Total tracing 9.284 s -
Total appsec 9.408 s 123.884 ms (1.3%)
Total iast 9.58 s 295.656 ms (3.2%)
Total profiling 9.517 s 233.003 ms (2.5%) 
gantt
    title petclinic - break down per module: candidate=1.23.0-SNAPSHOT~fe96bf2922, baseline=1.23.0-SNAPSHOT~38ee52be0e

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (650.365 ms) : 0, 650365
BytebuddyAgent [candidate] (651.036 ms) : 0, 651036
GlobalTracer [baseline] (295.754 ms) : 0, 295754
GlobalTracer [candidate] (296.64 ms) : 0, 296640
AppSec [baseline] (49.333 ms) : 0, 49333
AppSec [candidate] (49.643 ms) : 0, 49643
Remote Config [baseline] (712.825 µs) : 0, 713
Remote Config [candidate] (705.287 µs) : 0, 705
Telemetry [baseline] (11.531 ms) : 0, 11531
Telemetry [candidate] (11.381 ms) : 0, 11381
section appsec
BytebuddyAgent [baseline] (645.819 ms) : 0, 645819
BytebuddyAgent [candidate] (646.649 ms) : 0, 646649
GlobalTracer [baseline] (293.892 ms) : 0, 293892
GlobalTracer [candidate] (294.155 ms) : 0, 294155
AppSec [baseline] (138.626 ms) : 0, 138626
AppSec [candidate] (138.746 ms) : 0, 138746
Remote Config [baseline] (655.895 µs) : 0, 656
Remote Config [candidate] (651.62 µs) : 0, 652
Telemetry [baseline] (6.875 ms) : 0, 6875
Telemetry [candidate] (6.881 ms) : 0, 6881
section iast
BytebuddyAgent [baseline] (764.839 ms) : 0, 764839
BytebuddyAgent [candidate] (772.336 ms) : 0, 772336
GlobalTracer [baseline] (274.399 ms) : 0, 274399
GlobalTracer [candidate] (276.42 ms) : 0, 276420
AppSec [baseline] (46.594 ms) : 0, 46594
AppSec [candidate] (47.093 ms) : 0, 47093
Remote Config [baseline] (570.555 µs) : 0, 571
Remote Config [candidate] (567.91 µs) : 0, 568
Telemetry [baseline] (11.855 ms) : 0, 11855
Telemetry [candidate] (11.899 ms) : 0, 11899
IAST [baseline] (16.785 ms) : 0, 16785
IAST [candidate] (18.019 ms) : 0, 18019
section profiling
ProfilingAgent [baseline] (89.258 ms) : 0, 89258
ProfilingAgent [candidate] (87.824 ms) : 0, 87824
BytebuddyAgent [baseline] (660.37 ms) : 0, 660370
BytebuddyAgent [candidate] (656.206 ms) : 0, 656206
GlobalTracer [baseline] (361.049 ms) : 0, 361049
GlobalTracer [candidate] (358.671 ms) : 0, 358671
AppSec [baseline] (49.634 ms) : 0, 49634
AppSec [candidate] (49.218 ms) : 0, 49218
Remote Config [baseline] (646.759 µs) : 0, 647
Remote Config [candidate] (641.716 µs) : 0, 642
Telemetry [baseline] (11.383 ms) : 0, 11383
Telemetry [candidate] (11.349 ms) : 0, 11349
Profiling [baseline] (89.282 ms) : 0, 89282
Profiling [candidate] (87.848 ms) : 0, 87848
Loading

Load

Parameters

Baseline Candidate
commit 1.23.0-SNAPSHOT~38ee52be0e 1.23.0-SNAPSHOT~fe96bf2922
config baseline candidate
end_time 2023-11-03T14:00:01 2023-11-03T14:16:29
start_time 2023-11-03T13:59:49 2023-11-03T14:16:16
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.23.0-SNAPSHOT~fe96bf2922, baseline=1.23.0-SNAPSHOT~38ee52be0e
    dateFormat X
    axisFormat %s
section baseline
no_agent (363.764 µs) : 343, 385
.   : milestone, 364,
iast (454.583 µs) : 434, 475
.   : milestone, 455,
iast_FULL (520.639 µs) : 500, 541
.   : milestone, 521,
iast_INACTIVE (436.022 µs) : 415, 457
.   : milestone, 436,
iast_TELEMETRY_OFF (453.749 µs) : 433, 474
.   : milestone, 454,
tracing (429.758 µs) : 409, 450
.   : milestone, 430,
section candidate
no_agent (361.645 µs) : 341, 382
.   : milestone, 362,
iast (458.075 µs) : 437, 479
.   : milestone, 458,
iast_FULL (514.36 µs) : 494, 535
.   : milestone, 514,
iast_INACTIVE (432.73 µs) : 412, 454
.   : milestone, 433,
iast_TELEMETRY_OFF (458.824 µs) : 437, 480
.   : milestone, 459,
tracing (421.683 µs) : 402, 442
.   : milestone, 422,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 363.764 µs [342.602 µs, 384.927 µs] -
iast 454.583 µs [433.858 µs, 475.308 µs] 90.819 µs (25.0%)
iast_FULL 520.639 µs [499.878 µs, 541.4 µs] 156.875 µs (43.1%)
iast_INACTIVE 436.022 µs [414.765 µs, 457.28 µs] 72.258 µs (19.9%)
iast_TELEMETRY_OFF 453.749 µs [433.014 µs, 474.484 µs] 89.985 µs (24.7%)
tracing 429.758 µs [409.028 µs, 450.489 µs] 65.994 µs (18.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 361.645 µs [341.375 µs, 381.916 µs] -
iast 458.075 µs [437.482 µs, 478.668 µs] 96.429 µs (26.7%)
iast_FULL 514.36 µs [493.726 µs, 534.994 µs] 152.715 µs (42.2%)
iast_INACTIVE 432.73 µs [411.863 µs, 453.597 µs] 71.085 µs (19.7%)
iast_TELEMETRY_OFF 458.824 µs [437.468 µs, 480.179 µs] 97.178 µs (26.9%)
tracing 421.683 µs [401.508 µs, 441.858 µs] 60.037 µs (16.6%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.23.0-SNAPSHOT~fe96bf2922, baseline=1.23.0-SNAPSHOT~38ee52be0e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.353 ms) : 1334, 1373
.   : milestone, 1353,
appsec (1.707 ms) : 1682, 1732
.   : milestone, 1707,
iast (1.471 ms) : 1447, 1496
.   : milestone, 1471,
profiling (1.471 ms) : 1446, 1496
.   : milestone, 1471,
tracing (1.464 ms) : 1440, 1489
.   : milestone, 1464,
section candidate
no_agent (1.334 ms) : 1315, 1353
.   : milestone, 1334,
appsec (1.691 ms) : 1665, 1716
.   : milestone, 1691,
iast (1.481 ms) : 1457, 1505
.   : milestone, 1481,
profiling (1.445 ms) : 1420, 1469
.   : milestone, 1445,
tracing (1.468 ms) : 1443, 1492
.   : milestone, 1468,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.353 ms [1.334 ms, 1.373 ms] -
appsec 1.707 ms [1.682 ms, 1.732 ms] 353.503 µs (26.1%)
iast 1.471 ms [1.447 ms, 1.496 ms] 117.72 µs (8.7%)
profiling 1.471 ms [1.446 ms, 1.496 ms] 117.75 µs (8.7%)
tracing 1.464 ms [1.44 ms, 1.489 ms] 111.0 µs (8.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.334 ms [1.315 ms, 1.353 ms] -
appsec 1.691 ms [1.665 ms, 1.716 ms] 356.591 µs (26.7%)
iast 1.481 ms [1.457 ms, 1.505 ms] 146.926 µs (11.0%)
profiling 1.445 ms [1.42 ms, 1.469 ms] 110.454 µs (8.3%)
tracing 1.468 ms [1.443 ms, 1.492 ms] 133.399 µs (10.0%)

@jpbempel
Add git repository and sha in RC request tags
fe96bf2 
Send git repository url and git commit sha as tags on each Remote
Config request
@jpbempel jpbempel force-pushed the jpbempel/git-metadata-rc-req branch from 410239f to fe96bf2 Compare November 3, 2023 13:34
OmerRaviv
OmerRaviv approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@OmerRaviv OmerRaviv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpbempel jpbempel merged commit 30d66b4 into master Nov 3, 2023
10 of 11 checks passed
@jpbempel jpbempel deleted the jpbempel/git-metadata-rc-req branch November 3, 2023 17:33
@github-actions github-actions bot added this to the 1.23.0 milestone Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmerRaviv OmerRaviv OmerRaviv approved these changes

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jpbempel @OmerRaviv