Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flip flag for resource name tagging #6144

Merged
merged 2 commits into from
Nov 3, 2023
Merged

flip flag for resource name tagging #6144

merged 2 commits into from
Nov 3, 2023

Conversation

richardstartin
Copy link
Member

@richardstartin richardstartin commented Nov 3, 2023 •
edited by jira bot
Loading

What Does This Do

Flips the flag on enabling this, I don't think we actually need this attribute on samples, though users might still find it helpful to enable for resource name tagging to e.g. get CPU time by gRPC method.

Motivation

Additional Notes

Jira ticket: PROF-8531

@richardstartin richardstartin added tag: no release notes Changes to exclude from release notes comp: profiling Profiling labels Nov 3, 2023
@pr-commenter
Copy link

pr-commenter bot commented Nov 3, 2023

Benchmarks

Startup

Parameters

Baseline Candidate
commit 1.23.0-SNAPSHOT~496ad30179 1.23.0-SNAPSHOT~f6f9103f8c
config baseline candidate
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
module Agent Agent
parent None None
variant iast iast

Summary

Found 3 performance improvements and 1 performance regressions! Performance is the same for 50 cases.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:insecure-bank:iast:IAST worse
[+1.010ms; +6.314ms] or [+6.826%; +42.656%]		 18.465ms 14.803ms
scenario:petclinic:iast:Remote Config better
[-96.996µs; -21.622µs] or [-15.913%; -3.547%]		 550.227µs 609.536µs
scenario:petclinic:profiling:ProfilingAgent better
[-8.936ms; -5.133ms] or [-10.062%; -5.781%]		 81.771ms 88.806ms
scenario:petclinic:profiling:Profiling better
[-8.936ms; -5.133ms] or [-10.059%; -5.779%]		 81.795ms 88.830ms
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.23.0-SNAPSHOT~f6f9103f8c, baseline=1.23.0-SNAPSHOT~496ad30179

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.033 s) : 0, 1032835
Total [baseline] (8.775 s) : 0, 8774565
Agent [candidate] (1.035 s) : 0, 1034956
Total [candidate] (8.788 s) : 0, 8788335
section iast
Agent [baseline] (1.15 s) : 0, 1149621
Total [baseline] (9.311 s) : 0, 9310961
Agent [candidate] (1.161 s) : 0, 1160973
Total [candidate] (9.346 s) : 0, 9345689
section iast_TELEMETRY_OFF
Agent [baseline] (1.152 s) : 0, 1152025
Total [baseline] (9.278 s) : 0, 9277905
Agent [candidate] (1.138 s) : 0, 1138345
Total [candidate] (9.292 s) : 0, 9291900
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.033 s -
Agent iast 1.15 s 116.786 ms (11.3%)
Agent iast_TELEMETRY_OFF 1.152 s 119.19 ms (11.5%)
Total tracing 8.775 s -
Total iast 9.311 s 536.396 ms (6.1%)
Total iast_TELEMETRY_OFF 9.278 s 503.34 ms (5.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.035 s -
Agent iast 1.161 s 126.017 ms (12.2%)
Agent iast_TELEMETRY_OFF 1.138 s 103.389 ms (10.0%)
Total tracing 8.788 s -
Total iast 9.346 s 557.354 ms (6.3%)
Total iast_TELEMETRY_OFF 9.292 s 503.565 ms (5.7%) 
gantt
    title insecure-bank - break down per module: candidate=1.23.0-SNAPSHOT~f6f9103f8c, baseline=1.23.0-SNAPSHOT~496ad30179

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (643.979 ms) : 0, 643979
BytebuddyAgent [candidate] (643.605 ms) : 0, 643605
GlobalTracer [baseline] (293.538 ms) : 0, 293538
GlobalTracer [candidate] (293.5 ms) : 0, 293500
AppSec [baseline] (48.828 ms) : 0, 48828
AppSec [candidate] (49.38 ms) : 0, 49380
Remote Config [baseline] (689.154 µs) : 0, 689
Remote Config [candidate] (681.945 µs) : 0, 682
Telemetry [baseline] (11.347 ms) : 0, 11347
Telemetry [candidate] (13.347 ms) : 0, 13347
section iast
BytebuddyAgent [baseline] (764.004 ms) : 0, 764004
BytebuddyAgent [candidate] (770.148 ms) : 0, 770148
GlobalTracer [baseline] (274.309 ms) : 0, 274309
GlobalTracer [candidate] (277.054 ms) : 0, 277054
AppSec [baseline] (46.85 ms) : 0, 46850
AppSec [candidate] (46.923 ms) : 0, 46923
IAST [baseline] (14.803 ms) : 0, 14803
IAST [candidate] (18.465 ms) : 0, 18465
Remote Config [baseline] (555.193 µs) : 0, 555
Remote Config [candidate] (567.787 µs) : 0, 568
Telemetry [baseline] (14.582 ms) : 0, 14582
Telemetry [candidate] (13.1 ms) : 0, 13100
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (764.413 ms) : 0, 764413
BytebuddyAgent [candidate] (755.931 ms) : 0, 755931
GlobalTracer [baseline] (276.19 ms) : 0, 276190
GlobalTracer [candidate] (274.413 ms) : 0, 274413
AppSec [baseline] (46.981 ms) : 0, 46981
AppSec [candidate] (46.365 ms) : 0, 46365
IAST [baseline] (17.447 ms) : 0, 17447
IAST [candidate] (14.908 ms) : 0, 14908
Remote Config [baseline] (575.594 µs) : 0, 576
Remote Config [candidate] (549.514 µs) : 0, 550
Telemetry [baseline] (11.815 ms) : 0, 11815
Telemetry [candidate] (11.872 ms) : 0, 11872
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.23.0-SNAPSHOT~f6f9103f8c, baseline=1.23.0-SNAPSHOT~496ad30179

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.035 s) : 0, 1035044
Total [baseline] (9.328 s) : 0, 9328329
Agent [candidate] (1.041 s) : 0, 1040989
Total [candidate] (9.296 s) : 0, 9295623
section appsec
Agent [baseline] (1.123 s) : 0, 1123087
Total [baseline] (9.443 s) : 0, 9442983
Agent [candidate] (1.124 s) : 0, 1123525
Total [candidate] (9.467 s) : 0, 9466985
section iast
Agent [baseline] (1.167 s) : 0, 1167228
Total [baseline] (9.617 s) : 0, 9617343
Agent [candidate] (1.151 s) : 0, 1151401
Total [candidate] (9.51 s) : 0, 9509845
section profiling
Agent [baseline] (1.221 s) : 0, 1220986
Total [baseline] (9.542 s) : 0, 9542343
Agent [candidate] (1.227 s) : 0, 1227241
Total [candidate] (9.55 s) : 0, 9550020
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.035 s -
Agent appsec 1.123 s 88.043 ms (8.5%)
Agent iast 1.167 s 132.184 ms (12.8%)
Agent profiling 1.221 s 185.942 ms (18.0%)
Total tracing 9.328 s -
Total appsec 9.443 s 114.654 ms (1.2%)
Total iast 9.617 s 289.014 ms (3.1%)
Total profiling 9.542 s 214.014 ms (2.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.041 s -
Agent appsec 1.124 s 82.536 ms (7.9%)
Agent iast 1.151 s 110.412 ms (10.6%)
Agent profiling 1.227 s 186.252 ms (17.9%)
Total tracing 9.296 s -
Total appsec 9.467 s 171.362 ms (1.8%)
Total iast 9.51 s 214.222 ms (2.3%)
Total profiling 9.55 s 254.396 ms (2.7%) 
gantt
    title petclinic - break down per module: candidate=1.23.0-SNAPSHOT~f6f9103f8c, baseline=1.23.0-SNAPSHOT~496ad30179

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (646.274 ms) : 0, 646274
BytebuddyAgent [candidate] (648.515 ms) : 0, 648515
GlobalTracer [baseline] (293.711 ms) : 0, 293711
GlobalTracer [candidate] (296.482 ms) : 0, 296482
AppSec [baseline] (48.604 ms) : 0, 48604
AppSec [candidate] (49.289 ms) : 0, 49289
Remote Config [baseline] (692.016 µs) : 0, 692
Remote Config [candidate] (694.043 µs) : 0, 694
Telemetry [baseline] (11.259 ms) : 0, 11259
Telemetry [candidate] (11.396 ms) : 0, 11396
section appsec
BytebuddyAgent [baseline] (646.372 ms) : 0, 646372
BytebuddyAgent [candidate] (646.807 ms) : 0, 646807
GlobalTracer [baseline] (295.966 ms) : 0, 295966
GlobalTracer [candidate] (295.68 ms) : 0, 295680
AppSec [baseline] (138.66 ms) : 0, 138660
AppSec [candidate] (139.105 ms) : 0, 139105
Remote Config [baseline] (648.47 µs) : 0, 648
Remote Config [candidate] (654.761 µs) : 0, 655
Telemetry [baseline] (6.952 ms) : 0, 6952
Telemetry [candidate] (6.874 ms) : 0, 6874
section iast
BytebuddyAgent [baseline] (777.405 ms) : 0, 777405
BytebuddyAgent [candidate] (764.715 ms) : 0, 764715
GlobalTracer [baseline] (277.499 ms) : 0, 277499
GlobalTracer [candidate] (274.735 ms) : 0, 274735
AppSec [baseline] (47.206 ms) : 0, 47206
AppSec [candidate] (46.413 ms) : 0, 46413
IAST [baseline] (16.527 ms) : 0, 16527
IAST [candidate] (18.827 ms) : 0, 18827
Remote Config [baseline] (609.536 µs) : 0, 610
Remote Config [candidate] (550.227 µs) : 0, 550
Telemetry [baseline] (12.958 ms) : 0, 12958
Telemetry [candidate] (11.694 ms) : 0, 11694
section profiling
BytebuddyAgent [baseline] (656.364 ms) : 0, 656364
BytebuddyAgent [candidate] (665.303 ms) : 0, 665303
GlobalTracer [baseline] (360.028 ms) : 0, 360028
GlobalTracer [candidate] (362.758 ms) : 0, 362758
AppSec [baseline] (49.499 ms) : 0, 49499
AppSec [candidate] (49.925 ms) : 0, 49925
Remote Config [baseline] (642.911 µs) : 0, 643
Remote Config [candidate] (657.298 µs) : 0, 657
Telemetry [baseline] (11.335 ms) : 0, 11335
Telemetry [candidate] (11.515 ms) : 0, 11515
ProfilingAgent [baseline] (88.806 ms) : 0, 88806
ProfilingAgent [candidate] (81.771 ms) : 0, 81771
Profiling [baseline] (88.83 ms) : 0, 88830
Profiling [candidate] (81.795 ms) : 0, 81795
Loading

Load

Parameters

Baseline Candidate
commit 1.23.0-SNAPSHOT~496ad30179 1.23.0-SNAPSHOT~f6f9103f8c
config baseline candidate
end_time 2023-11-03T11:15:00 2023-11-03T11:31:27
start_time 2023-11-03T11:14:47 2023-11-03T11:31:14
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.23.0-SNAPSHOT~f6f9103f8c, baseline=1.23.0-SNAPSHOT~496ad30179
    dateFormat X
    axisFormat %s
section baseline
no_agent (359.314 µs) : 339, 379
.   : milestone, 359,
iast (459.16 µs) : 438, 480
.   : milestone, 459,
iast_FULL (524.314 µs) : 503, 545
.   : milestone, 524,
iast_INACTIVE (430.307 µs) : 409, 451
.   : milestone, 430,
iast_TELEMETRY_OFF (459.674 µs) : 438, 481
.   : milestone, 460,
tracing (431.611 µs) : 410, 453
.   : milestone, 432,
section candidate
no_agent (359.313 µs) : 339, 379
.   : milestone, 359,
iast (465.227 µs) : 444, 487
.   : milestone, 465,
iast_FULL (522.19 µs) : 501, 543
.   : milestone, 522,
iast_INACTIVE (432.285 µs) : 411, 454
.   : milestone, 432,
iast_TELEMETRY_OFF (462.173 µs) : 441, 484
.   : milestone, 462,
tracing (431.179 µs) : 410, 453
.   : milestone, 431,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 359.314 µs [339.181 µs, 379.447 µs] -
iast 459.16 µs [438.2 µs, 480.12 µs] 99.846 µs (27.8%)
iast_FULL 524.314 µs [503.455 µs, 545.172 µs] 164.999 µs (45.9%)
iast_INACTIVE 430.307 µs [409.358 µs, 451.257 µs] 70.993 µs (19.8%)
iast_TELEMETRY_OFF 459.674 µs [437.928 µs, 481.42 µs] 100.36 µs (27.9%)
tracing 431.611 µs [410.354 µs, 452.867 µs] 72.296 µs (20.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 359.313 µs [339.455 µs, 379.171 µs] -
iast 465.227 µs [443.758 µs, 486.697 µs] 105.915 µs (29.5%)
iast_FULL 522.19 µs [501.441 µs, 542.939 µs] 162.877 µs (45.3%)
iast_INACTIVE 432.285 µs [410.763 µs, 453.806 µs] 72.972 µs (20.3%)
iast_TELEMETRY_OFF 462.173 µs [440.676 µs, 483.671 µs] 102.861 µs (28.6%)
tracing 431.179 µs [409.516 µs, 452.842 µs] 71.866 µs (20.0%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.23.0-SNAPSHOT~f6f9103f8c, baseline=1.23.0-SNAPSHOT~496ad30179
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.332 ms) : 1313, 1352
.   : milestone, 1332,
appsec (1.691 ms) : 1666, 1715
.   : milestone, 1691,
iast (1.473 ms) : 1449, 1497
.   : milestone, 1473,
profiling (1.464 ms) : 1439, 1488
.   : milestone, 1464,
tracing (1.458 ms) : 1434, 1483
.   : milestone, 1458,
section candidate
no_agent (1.329 ms) : 1310, 1348
.   : milestone, 1329,
appsec (1.718 ms) : 1693, 1742
.   : milestone, 1718,
iast (1.492 ms) : 1468, 1516
.   : milestone, 1492,
profiling (1.456 ms) : 1431, 1481
.   : milestone, 1456,
tracing (1.457 ms) : 1432, 1481
.   : milestone, 1457,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.332 ms [1.313 ms, 1.352 ms] -
appsec 1.691 ms [1.666 ms, 1.715 ms] 358.334 µs (26.9%)
iast 1.473 ms [1.449 ms, 1.497 ms] 141.046 µs (10.6%)
profiling 1.464 ms [1.439 ms, 1.488 ms] 131.16 µs (9.8%)
tracing 1.458 ms [1.434 ms, 1.483 ms] 125.988 µs (9.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.329 ms [1.31 ms, 1.348 ms] -
appsec 1.718 ms [1.693 ms, 1.742 ms] 388.896 µs (29.3%)
iast 1.492 ms [1.468 ms, 1.516 ms] 163.271 µs (12.3%)
profiling 1.456 ms [1.431 ms, 1.481 ms] 127.386 µs (9.6%)
tracing 1.457 ms [1.432 ms, 1.481 ms] 127.805 µs (9.6%)

@richardstartin richardstartin marked this pull request as ready for review November 3, 2023 11:51
@richardstartin richardstartin requested a review from a team as a code owner November 3, 2023 11:51
@richardstartin richardstartin merged commit 38ee52b into master Nov 3, 2023
10 of 11 checks passed
@richardstartin richardstartin deleted the rgs/disable-resource-name-tagging-by-default branch November 3, 2023 12:23
@github-actions github-actions bot added this to the 1.23.0 milestone Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbachorik jbachorik jbachorik approved these changes

Assignees
No one assigned
Labels
comp: profiling Profiling tag: no release notes Changes to exclude from release notes
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@richardstartin @jbachorik