Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default versions of Datadog Javac plugin and Jacoco plugin injected by CI Visibility #6166

Merged
merged 2 commits into from
Nov 11, 2023
Merged

Update default versions of Datadog Javac plugin and Jacoco plugin injected by CI Visibility #6166

merged 2 commits into from
Nov 11, 2023

Conversation

nikita-tkachenko-datadog
Copy link
Contributor

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented Nov 8, 2023 •
edited by jira bot
Loading

What Does This Do

Updates default versions of DD Javac plugin and Jacoco plugin injected by CI Visibility.

Motivation

Newer versions of the plugins contain improvements and bugfixes.

Jira ticket: CIVIS-7945

@nikita-tkachenko-datadog nikita-tkachenko-datadog added the comp: ci visibility Continuous Integration Visibility label Nov 8, 2023
@pr-commenter
Copy link

pr-commenter bot commented Nov 8, 2023 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
commit 1.23.0-SNAPSHOT~2e6162bf24 1.23.0-SNAPSHOT~abbb594f8d
config baseline candidate
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 cases.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.23.0-SNAPSHOT~abbb594f8d, baseline=1.23.0-SNAPSHOT~2e6162bf24

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.04 s) : 0, 1040420
Total [baseline] (9.327 s) : 0, 9327043
Agent [candidate] (1.036 s) : 0, 1035664
Total [candidate] (9.308 s) : 0, 9307565
section appsec
Agent [baseline] (1.127 s) : 0, 1127210
Total [baseline] (9.427 s) : 0, 9426731
Agent [candidate] (1.128 s) : 0, 1127703
Total [candidate] (9.399 s) : 0, 9398647
section iast
Agent [baseline] (1.147 s) : 0, 1146542
Total [baseline] (9.457 s) : 0, 9457179
Agent [candidate] (1.156 s) : 0, 1155958
Total [candidate] (9.476 s) : 0, 9475741
section profiling
Agent [baseline] (1.217 s) : 0, 1216556
Total [baseline] (9.577 s) : 0, 9576887
Agent [candidate] (1.219 s) : 0, 1218677
Total [candidate] (9.52 s) : 0, 9520048
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.04 s -
Agent appsec 1.127 s 86.79 ms (8.3%)
Agent iast 1.147 s 106.122 ms (10.2%)
Agent profiling 1.217 s 176.136 ms (16.9%)
Total tracing 9.327 s -
Total appsec 9.427 s 99.688 ms (1.1%)
Total iast 9.457 s 130.136 ms (1.4%)
Total profiling 9.577 s 249.843 ms (2.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.036 s -
Agent appsec 1.128 s 92.039 ms (8.9%)
Agent iast 1.156 s 120.293 ms (11.6%)
Agent profiling 1.219 s 183.013 ms (17.7%)
Total tracing 9.308 s -
Total appsec 9.399 s 91.081 ms (1.0%)
Total iast 9.476 s 168.175 ms (1.8%)
Total profiling 9.52 s 212.483 ms (2.3%) 
gantt
    title petclinic - break down per module: candidate=1.23.0-SNAPSHOT~abbb594f8d, baseline=1.23.0-SNAPSHOT~2e6162bf24

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (648.9 ms) : 0, 648900
BytebuddyAgent [candidate] (645.814 ms) : 0, 645814
GlobalTracer [baseline] (295.405 ms) : 0, 295405
GlobalTracer [candidate] (294.497 ms) : 0, 294497
AppSec [baseline] (49.294 ms) : 0, 49294
AppSec [candidate] (48.949 ms) : 0, 48949
Remote Config [baseline] (703.692 µs) : 0, 704
Remote Config [candidate] (695.708 µs) : 0, 696
Telemetry [baseline] (11.362 ms) : 0, 11362
Telemetry [candidate] (11.305 ms) : 0, 11305
section appsec
BytebuddyAgent [baseline] (649.493 ms) : 0, 649493
BytebuddyAgent [candidate] (650.432 ms) : 0, 650432
GlobalTracer [baseline] (296.217 ms) : 0, 296217
GlobalTracer [candidate] (296.206 ms) : 0, 296206
AppSec [baseline] (139.336 ms) : 0, 139336
AppSec [candidate] (138.839 ms) : 0, 138839
Remote Config [baseline] (654.308 µs) : 0, 654
Remote Config [candidate] (649.478 µs) : 0, 649
Telemetry [baseline] (6.927 ms) : 0, 6927
Telemetry [candidate] (6.919 ms) : 0, 6919
section iast
BytebuddyAgent [baseline] (763.398 ms) : 0, 763398
BytebuddyAgent [candidate] (769.584 ms) : 0, 769584
GlobalTracer [baseline] (273.235 ms) : 0, 273235
GlobalTracer [candidate] (275.221 ms) : 0, 275221
AppSec [baseline] (46.377 ms) : 0, 46377
AppSec [candidate] (47.166 ms) : 0, 47166
Remote Config [baseline] (563.982 µs) : 0, 564
Remote Config [candidate] (582.492 µs) : 0, 582
Telemetry [baseline] (10.387 ms) : 0, 10387
Telemetry [candidate] (12.561 ms) : 0, 12561
IAST [baseline] (18.188 ms) : 0, 18188
IAST [candidate] (16.301 ms) : 0, 16301
section profiling
BytebuddyAgent [baseline] (654.46 ms) : 0, 654460
BytebuddyAgent [candidate] (656.642 ms) : 0, 656642
GlobalTracer [baseline] (357.519 ms) : 0, 357519
GlobalTracer [candidate] (357.963 ms) : 0, 357963
AppSec [baseline] (49.409 ms) : 0, 49409
AppSec [candidate] (49.209 ms) : 0, 49209
Remote Config [baseline] (634.494 µs) : 0, 634
Remote Config [candidate] (652.505 µs) : 0, 653
Telemetry [baseline] (11.175 ms) : 0, 11175
Telemetry [candidate] (11.268 ms) : 0, 11268
ProfilingAgent [baseline] (89.313 ms) : 0, 89313
ProfilingAgent [candidate] (88.457 ms) : 0, 88457
Profiling [baseline] (89.336 ms) : 0, 89336
Profiling [candidate] (88.481 ms) : 0, 88481
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.23.0-SNAPSHOT~abbb594f8d, baseline=1.23.0-SNAPSHOT~2e6162bf24

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.033 s) : 0, 1033464
Total [baseline] (8.783 s) : 0, 8783217
Agent [candidate] (1.034 s) : 0, 1034065
Total [candidate] (8.806 s) : 0, 8805979
section iast
Agent [baseline] (1.163 s) : 0, 1162877
Total [baseline] (9.371 s) : 0, 9371481
Agent [candidate] (1.151 s) : 0, 1151071
Total [candidate] (9.328 s) : 0, 9327634
section iast_TELEMETRY_OFF
Agent [baseline] (1.154 s) : 0, 1153907
Total [baseline] (9.304 s) : 0, 9303881
Agent [candidate] (1.148 s) : 0, 1148303
Total [candidate] (9.327 s) : 0, 9326597
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.033 s -
Agent iast 1.163 s 129.414 ms (12.5%)
Agent iast_TELEMETRY_OFF 1.154 s 120.444 ms (11.7%)
Total tracing 8.783 s -
Total iast 9.371 s 588.264 ms (6.7%)
Total iast_TELEMETRY_OFF 9.304 s 520.664 ms (5.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.034 s -
Agent iast 1.151 s 117.006 ms (11.3%)
Agent iast_TELEMETRY_OFF 1.148 s 114.238 ms (11.0%)
Total tracing 8.806 s -
Total iast 9.328 s 521.655 ms (5.9%)
Total iast_TELEMETRY_OFF 9.327 s 520.618 ms (5.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.23.0-SNAPSHOT~abbb594f8d, baseline=1.23.0-SNAPSHOT~2e6162bf24

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (644.487 ms) : 0, 644487
BytebuddyAgent [candidate] (644.566 ms) : 0, 644566
GlobalTracer [baseline] (293.614 ms) : 0, 293614
GlobalTracer [candidate] (294.074 ms) : 0, 294074
AppSec [baseline] (48.902 ms) : 0, 48902
AppSec [candidate] (48.999 ms) : 0, 48999
Remote Config [baseline] (697.988 µs) : 0, 698
Remote Config [candidate] (704.515 µs) : 0, 705
Telemetry [baseline] (11.275 ms) : 0, 11275
Telemetry [candidate] (11.3 ms) : 0, 11300
section iast
BytebuddyAgent [baseline] (773.676 ms) : 0, 773676
BytebuddyAgent [candidate] (764.994 ms) : 0, 764994
GlobalTracer [baseline] (276.849 ms) : 0, 276849
GlobalTracer [candidate] (274.016 ms) : 0, 274016
AppSec [baseline] (47.183 ms) : 0, 47183
AppSec [candidate] (46.806 ms) : 0, 46806
Remote Config [baseline] (602.85 µs) : 0, 603
Remote Config [candidate] (581.218 µs) : 0, 581
Telemetry [baseline] (11.958 ms) : 0, 11958
Telemetry [candidate] (11.875 ms) : 0, 11875
IAST [baseline] (17.787 ms) : 0, 17787
IAST [candidate] (18.267 ms) : 0, 18267
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (765.056 ms) : 0, 765056
BytebuddyAgent [candidate] (760.831 ms) : 0, 760831
GlobalTracer [baseline] (277.52 ms) : 0, 277520
GlobalTracer [candidate] (276.572 ms) : 0, 276572
AppSec [baseline] (46.918 ms) : 0, 46918
AppSec [candidate] (46.951 ms) : 0, 46951
Remote Config [baseline] (584.125 µs) : 0, 584
Remote Config [candidate] (564.524 µs) : 0, 565
Telemetry [baseline] (12.016 ms) : 0, 12016
Telemetry [candidate] (12.67 ms) : 0, 12670
IAST [baseline] (17.152 ms) : 0, 17152
IAST [candidate] (16.185 ms) : 0, 16185
Loading

Load

Parameters

Baseline Candidate
commit 1.23.0-SNAPSHOT~2e6162bf24 1.23.0-SNAPSHOT~abbb594f8d
config baseline candidate
end_time 2023-11-09T12:25:32 2023-11-09T12:41:59
start_time 2023-11-09T12:25:19 2023-11-09T12:41:47
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.23.0-SNAPSHOT~abbb594f8d, baseline=1.23.0-SNAPSHOT~2e6162bf24
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.349 ms) : 1329, 1368
.   : milestone, 1349,
appsec (1.721 ms) : 1695, 1746
.   : milestone, 1721,
iast (1.488 ms) : 1464, 1511
.   : milestone, 1488,
profiling (1.468 ms) : 1443, 1493
.   : milestone, 1468,
tracing (1.456 ms) : 1431, 1480
.   : milestone, 1456,
section candidate
no_agent (1.352 ms) : 1333, 1371
.   : milestone, 1352,
appsec (1.715 ms) : 1690, 1739
.   : milestone, 1715,
iast (1.487 ms) : 1462, 1511
.   : milestone, 1487,
profiling (1.461 ms) : 1436, 1486
.   : milestone, 1461,
tracing (1.45 ms) : 1425, 1474
.   : milestone, 1450,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.349 ms [1.329 ms, 1.368 ms] -
appsec 1.721 ms [1.695 ms, 1.746 ms] 372.255 µs (27.6%)
iast 1.488 ms [1.464 ms, 1.511 ms] 138.994 µs (10.3%)
profiling 1.468 ms [1.443 ms, 1.493 ms] 119.459 µs (8.9%)
tracing 1.456 ms [1.431 ms, 1.48 ms] 107.244 µs (8.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.352 ms [1.333 ms, 1.371 ms] -
appsec 1.715 ms [1.69 ms, 1.739 ms] 362.453 µs (26.8%)
iast 1.487 ms [1.462 ms, 1.511 ms] 134.132 µs (9.9%)
profiling 1.461 ms [1.436 ms, 1.486 ms] 108.757 µs (8.0%)
tracing 1.45 ms [1.425 ms, 1.474 ms] 97.13 µs (7.2%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.23.0-SNAPSHOT~abbb594f8d, baseline=1.23.0-SNAPSHOT~2e6162bf24
    dateFormat X
    axisFormat %s
section baseline
no_agent (362.639 µs) : 342, 383
.   : milestone, 363,
iast (456.581 µs) : 436, 477
.   : milestone, 457,
iast_FULL (525.675 µs) : 505, 547
.   : milestone, 526,
iast_INACTIVE (439.476 µs) : 419, 460
.   : milestone, 439,
iast_TELEMETRY_OFF (456.023 µs) : 436, 476
.   : milestone, 456,
tracing (445.84 µs) : 425, 467
.   : milestone, 446,
section candidate
no_agent (365.087 µs) : 344, 386
.   : milestone, 365,
iast (464.308 µs) : 444, 485
.   : milestone, 464,
iast_FULL (525.859 µs) : 505, 547
.   : milestone, 526,
iast_INACTIVE (440.816 µs) : 419, 462
.   : milestone, 441,
iast_TELEMETRY_OFF (457.653 µs) : 437, 478
.   : milestone, 458,
tracing (433.709 µs) : 413, 455
.   : milestone, 434,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 362.639 µs [342.18 µs, 383.097 µs] -
iast 456.581 µs [436.202 µs, 476.96 µs] 93.942 µs (25.9%)
iast_FULL 525.675 µs [504.653 µs, 546.696 µs] 163.036 µs (45.0%)
iast_INACTIVE 439.476 µs [418.692 µs, 460.259 µs] 76.837 µs (21.2%)
iast_TELEMETRY_OFF 456.023 µs [435.554 µs, 476.491 µs] 93.384 µs (25.8%)
tracing 445.84 µs [424.988 µs, 466.692 µs] 83.201 µs (22.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 365.087 µs [343.852 µs, 386.321 µs] -
iast 464.308 µs [443.682 µs, 484.934 µs] 99.222 µs (27.2%)
iast_FULL 525.859 µs [505.133 µs, 546.585 µs] 160.773 µs (44.0%)
iast_INACTIVE 440.816 µs [419.212 µs, 462.419 µs] 75.729 µs (20.7%)
iast_TELEMETRY_OFF 457.653 µs [436.827 µs, 478.479 µs] 92.567 µs (25.4%)
tracing 433.709 µs [412.782 µs, 454.637 µs] 68.623 µs (18.8%)

@nikita-tkachenko-datadog nikita-tkachenko-datadog marked this pull request as ready for review November 8, 2023 13:16
@nikita-tkachenko-datadog nikita-tkachenko-datadog requested a review from a team as a code owner November 8, 2023 13:16
@nikita-tkachenko-datadog nikita-tkachenko-datadog merged commit 768bfbd into master Nov 11, 2023
11 checks passed
@nikita-tkachenko-datadog nikita-tkachenko-datadog deleted the nikita-tkachenko/ci-vis-plugin-versions-bump branch November 11, 2023 11:12
@github-actions github-actions bot added this to the 1.24.0 milestone Nov 11, 2023
@PerfectSlayer PerfectSlayer changed the title Update default versions of DD Javac plugin and Jacoco plugin injected by CI Visibility Update default versions of Datadog Javac plugin and Jacoco plugin injected by CI Visibility Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ygree ygree ygree approved these changes

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

@juan-fernandez juan-fernandez Awaiting requested review from juan-fernandez juan-fernandez was automatically assigned from DataDog/ci-app-libraries-java

Assignees
No one assigned
Labels
comp: ci visibility Continuous Integration Visibility
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nikita-tkachenko-datadog @ygree