-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple gradle JDK from compile/test JDK #7506
base: master
Are you sure you want to change the base?
Conversation
dc1fa6e
to
702851a
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 3 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~22e3221d0f, baseline=1.46.0-SNAPSHOT~fbb36f9b5b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.053 s) : 0, 1053016
Total [baseline] (10.471 s) : 0, 10471152
Agent [candidate] (1.056 s) : 0, 1056222
Total [candidate] (10.514 s) : 0, 10514017
section appsec
Agent [baseline] (1.194 s) : 0, 1193773
Total [baseline] (10.771 s) : 0, 10770874
Agent [candidate] (1.195 s) : 0, 1194917
Total [candidate] (10.705 s) : 0, 10705404
section iast
Agent [baseline] (1.188 s) : 0, 1188461
Total [baseline] (10.946 s) : 0, 10945961
Agent [candidate] (1.183 s) : 0, 1182598
Total [candidate] (10.959 s) : 0, 10959008
section profiling
Agent [baseline] (1.26 s) : 0, 1259943
Total [baseline] (10.738 s) : 0, 10738410
Agent [candidate] (1.27 s) : 0, 1270457
Total [candidate] (10.928 s) : 0, 10928176
gantt
title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~22e3221d0f, baseline=1.46.0-SNAPSHOT~fbb36f9b5b
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (711.414 ms) : 0, 711414
BytebuddyAgent [candidate] (714.289 ms) : 0, 714289
GlobalTracer [baseline] (255.344 ms) : 0, 255344
GlobalTracer [candidate] (255.78 ms) : 0, 255780
AppSec [baseline] (57.032 ms) : 0, 57032
AppSec [candidate] (56.215 ms) : 0, 56215
Remote Config [baseline] (736.566 µs) : 0, 737
Remote Config [candidate] (746.297 µs) : 0, 746
Telemetry [baseline] (13.546 ms) : 0, 13546
Telemetry [candidate] (14.186 ms) : 0, 14186
section appsec
BytebuddyAgent [baseline] (734.891 ms) : 0, 734891
BytebuddyAgent [candidate] (735.645 ms) : 0, 735645
GlobalTracer [baseline] (254.051 ms) : 0, 254051
GlobalTracer [candidate] (253.929 ms) : 0, 253929
AppSec [baseline] (171.154 ms) : 0, 171154
AppSec [candidate] (171.686 ms) : 0, 171686
Remote Config [baseline] (678.959 µs) : 0, 679
Remote Config [candidate] (667.069 µs) : 0, 667
Telemetry [baseline] (8.252 ms) : 0, 8252
Telemetry [candidate] (8.224 ms) : 0, 8224
IAST [baseline] (19.429 ms) : 0, 19429
IAST [candidate] (19.445 ms) : 0, 19445
section iast
BytebuddyAgent [baseline] (837.433 ms) : 0, 837433
BytebuddyAgent [candidate] (831.631 ms) : 0, 831631
GlobalTracer [baseline] (246.504 ms) : 0, 246504
GlobalTracer [candidate] (246.622 ms) : 0, 246622
AppSec [baseline] (58.16 ms) : 0, 58160
AppSec [candidate] (58.056 ms) : 0, 58056
Remote Config [baseline] (686.959 µs) : 0, 687
Remote Config [candidate] (673.096 µs) : 0, 673
Telemetry [baseline] (8.836 ms) : 0, 8836
Telemetry [candidate] (8.814 ms) : 0, 8814
IAST [baseline] (21.696 ms) : 0, 21696
IAST [candidate] (21.741 ms) : 0, 21741
section profiling
BytebuddyAgent [baseline] (706.625 ms) : 0, 706625
BytebuddyAgent [candidate] (714.104 ms) : 0, 714104
GlobalTracer [baseline] (350.337 ms) : 0, 350337
GlobalTracer [candidate] (352.629 ms) : 0, 352629
AppSec [baseline] (55.067 ms) : 0, 55067
AppSec [candidate] (54.64 ms) : 0, 54640
Remote Config [baseline] (703.899 µs) : 0, 704
Remote Config [candidate] (711.939 µs) : 0, 712
Telemetry [baseline] (8.863 ms) : 0, 8863
Telemetry [candidate] (8.991 ms) : 0, 8991
ProfilingAgent [baseline] (96.271 ms) : 0, 96271
ProfilingAgent [candidate] (96.7 ms) : 0, 96700
Profiling [baseline] (96.296 ms) : 0, 96296
Profiling [candidate] (96.724 ms) : 0, 96724
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~22e3221d0f, baseline=1.46.0-SNAPSHOT~fbb36f9b5b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1059538
Total [baseline] (8.637 s) : 0, 8637020
Agent [candidate] (1.055 s) : 0, 1055394
Total [candidate] (8.606 s) : 0, 8606095
section iast
Agent [baseline] (1.187 s) : 0, 1187456
Total [baseline] (9.222 s) : 0, 9222455
Agent [candidate] (1.195 s) : 0, 1194636
Total [candidate] (9.209 s) : 0, 9209459
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.18 s) : 0, 1180123
Total [baseline] (9.161 s) : 0, 9160680
Agent [candidate] (1.182 s) : 0, 1182020
Total [candidate] (9.158 s) : 0, 9157935
section iast_TELEMETRY_OFF
Agent [baseline] (1.187 s) : 0, 1187297
Total [baseline] (9.248 s) : 0, 9247584
Agent [candidate] (1.176 s) : 0, 1175852
Total [candidate] (9.168 s) : 0, 9168001
gantt
title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~22e3221d0f, baseline=1.46.0-SNAPSHOT~fbb36f9b5b
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.684 ms) : 0, 717684
BytebuddyAgent [candidate] (716.699 ms) : 0, 716699
GlobalTracer [baseline] (256.814 ms) : 0, 256814
GlobalTracer [candidate] (256.358 ms) : 0, 256358
AppSec [baseline] (55.692 ms) : 0, 55692
AppSec [candidate] (55.692 ms) : 0, 55692
Remote Config [baseline] (750.33 µs) : 0, 750
Remote Config [candidate] (735.705 µs) : 0, 736
Telemetry [baseline] (13.601 ms) : 0, 13601
Telemetry [candidate] (10.871 ms) : 0, 10871
section iast
BytebuddyAgent [baseline] (836.97 ms) : 0, 836970
BytebuddyAgent [candidate] (840.206 ms) : 0, 840206
GlobalTracer [baseline] (246.464 ms) : 0, 246464
GlobalTracer [candidate] (249.558 ms) : 0, 249558
AppSec [baseline] (58.178 ms) : 0, 58178
AppSec [candidate] (58.475 ms) : 0, 58475
Remote Config [baseline] (674.159 µs) : 0, 674
Remote Config [candidate] (688.996 µs) : 0, 689
Telemetry [baseline] (8.79 ms) : 0, 8790
Telemetry [candidate] (8.878 ms) : 0, 8878
IAST [baseline] (21.311 ms) : 0, 21311
IAST [candidate] (21.697 ms) : 0, 21697
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (830.101 ms) : 0, 830101
BytebuddyAgent [candidate] (831.126 ms) : 0, 831126
GlobalTracer [baseline] (245.941 ms) : 0, 245941
GlobalTracer [candidate] (246.361 ms) : 0, 246361
AppSec [baseline] (58.132 ms) : 0, 58132
AppSec [candidate] (58.459 ms) : 0, 58459
Remote Config [baseline] (671.077 µs) : 0, 671
Remote Config [candidate] (676.097 µs) : 0, 676
Telemetry [baseline] (8.838 ms) : 0, 8838
Telemetry [candidate] (8.827 ms) : 0, 8827
IAST [baseline] (21.451 ms) : 0, 21451
IAST [candidate] (21.524 ms) : 0, 21524
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (834.905 ms) : 0, 834905
BytebuddyAgent [candidate] (827.052 ms) : 0, 827052
GlobalTracer [baseline] (247.775 ms) : 0, 247775
GlobalTracer [candidate] (246.195 ms) : 0, 246195
AppSec [baseline] (58.725 ms) : 0, 58725
AppSec [candidate] (57.587 ms) : 0, 57587
Remote Config [baseline] (672.188 µs) : 0, 672
Remote Config [candidate] (671.221 µs) : 0, 671
Telemetry [baseline] (8.819 ms) : 0, 8819
Telemetry [candidate] (8.636 ms) : 0, 8636
IAST [baseline] (21.338 ms) : 0, 21338
IAST [candidate] (20.716 ms) : 0, 20716
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~22e3221d0f, baseline=1.46.0-SNAPSHOT~fbb36f9b5b
dateFormat X
axisFormat %s
section baseline
no_agent (383.17 µs) : 363, 403
. : milestone, 383,
iast (510.465 µs) : 489, 532
. : milestone, 510,
iast_FULL (746.854 µs) : 725, 769
. : milestone, 747,
iast_GLOBAL (555.867 µs) : 534, 578
. : milestone, 556,
iast_HARDCODED_SECRET_DISABLED (520.309 µs) : 499, 542
. : milestone, 520,
iast_INACTIVE (464.173 µs) : 442, 486
. : milestone, 464,
iast_TELEMETRY_OFF (495.15 µs) : 474, 516
. : milestone, 495,
tracing (456.038 µs) : 435, 477
. : milestone, 456,
section candidate
no_agent (382.335 µs) : 362, 402
. : milestone, 382,
iast (515.402 µs) : 494, 537
. : milestone, 515,
iast_FULL (750.427 µs) : 728, 773
. : milestone, 750,
iast_GLOBAL (555.148 µs) : 534, 577
. : milestone, 555,
iast_HARDCODED_SECRET_DISABLED (519.266 µs) : 497, 541
. : milestone, 519,
iast_INACTIVE (465.226 µs) : 443, 487
. : milestone, 465,
iast_TELEMETRY_OFF (498.194 µs) : 477, 520
. : milestone, 498,
tracing (458.489 µs) : 438, 479
. : milestone, 458,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~22e3221d0f, baseline=1.46.0-SNAPSHOT~fbb36f9b5b
dateFormat X
axisFormat %s
section baseline
no_agent (1.383 ms) : 1364, 1402
. : milestone, 1383,
appsec (1.751 ms) : 1727, 1775
. : milestone, 1751,
appsec_no_iast (1.775 ms) : 1751, 1799
. : milestone, 1775,
iast (1.53 ms) : 1506, 1553
. : milestone, 1530,
profiling (1.544 ms) : 1519, 1569
. : milestone, 1544,
tracing (1.512 ms) : 1488, 1536
. : milestone, 1512,
section candidate
no_agent (1.356 ms) : 1337, 1376
. : milestone, 1356,
appsec (1.755 ms) : 1731, 1779
. : milestone, 1755,
appsec_no_iast (1.78 ms) : 1757, 1803
. : milestone, 1780,
iast (1.499 ms) : 1474, 1523
. : milestone, 1499,
profiling (1.517 ms) : 1493, 1540
. : milestone, 1517,
tracing (1.51 ms) : 1486, 1535
. : milestone, 1510,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~22e3221d0f, baseline=1.46.0-SNAPSHOT~fbb36f9b5b
dateFormat X
axisFormat %s
section baseline
no_agent (15.543 s) : 15543000, 15543000
. : milestone, 15543000,
appsec (15.226 s) : 15226000, 15226000
. : milestone, 15226000,
iast (18.592 s) : 18592000, 18592000
. : milestone, 18592000,
iast_GLOBAL (18.102 s) : 18102000, 18102000
. : milestone, 18102000,
profiling (14.97 s) : 14970000, 14970000
. : milestone, 14970000,
tracing (15.101 s) : 15101000, 15101000
. : milestone, 15101000,
section candidate
no_agent (14.805 s) : 14805000, 14805000
. : milestone, 14805000,
appsec (14.694 s) : 14694000, 14694000
. : milestone, 14694000,
iast (18.752 s) : 18752000, 18752000
. : milestone, 18752000,
iast_GLOBAL (18.143 s) : 18143000, 18143000
. : milestone, 18143000,
profiling (15.043 s) : 15043000, 15043000
. : milestone, 15043000,
tracing (15.001 s) : 15001000, 15001000
. : milestone, 15001000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~22e3221d0f, baseline=1.46.0-SNAPSHOT~fbb36f9b5b
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1457, 1480
. : milestone, 1469,
appsec (2.349 ms) : 2306, 2393
. : milestone, 2349,
iast (2.098 ms) : 2044, 2153
. : milestone, 2098,
iast_GLOBAL (2.146 ms) : 2091, 2201
. : milestone, 2146,
profiling (1.966 ms) : 1921, 2011
. : milestone, 1966,
tracing (1.942 ms) : 1900, 1984
. : milestone, 1942,
section candidate
no_agent (1.465 ms) : 1454, 1477
. : milestone, 1465,
appsec (2.352 ms) : 2309, 2395
. : milestone, 2352,
iast (2.093 ms) : 2038, 2147
. : milestone, 2093,
iast_GLOBAL (2.141 ms) : 2086, 2196
. : milestone, 2141,
profiling (1.949 ms) : 1905, 1992
. : milestone, 1949,
tracing (1.932 ms) : 1890, 1973
. : milestone, 1932,
|
702851a
to
d1abf3b
Compare
This pull request has been marked as stale because it has not had activity over the past quarter. It will be closed in 7 days if no further activity occurs. Feel free to reopen the PR if you are still working on it. |
0e79c09
to
0a43968
Compare
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 5 performance regressions! Performance is the same for 5 metrics, 5 unstable metrics.
See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (308.908 µs) : 275, 343
. : milestone, 309,
basic (316.53 µs) : 308, 325
. : milestone, 317,
loop (10.027 ms) : 10004, 10051
. : milestone, 10027,
section candidate
noprobe (313.13 µs) : 278, 349
. : milestone, 313,
basic (312.44 µs) : 304, 320
. : milestone, 312,
loop (10.718 ms) : 10678, 10757
. : milestone, 10718,
|
0a43968
to
40c09e8
Compare
40c09e8
to
7c20689
Compare
commit f2a064b Author: Santiago Mola <santiago.mola@datadoghq.com> Date: Fri Jan 17 12:03:48 2025 +0100 Disable selenium latestDepTest until fixed commit f0a832f Author: Santiago Mola <santiago.mola@datadoghq.com> Date: Thu Jan 16 23:06:21 2025 +0100 Decouple test JDK and gradle JDK in selenium latestDepTest
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issue[ ] Update the public documentation in case of new configuration flag or behaviorJira ticket: APMJAVA-1342