-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Troubleshoot 404s in Tomcat with AppSec enabled #7519
Troubleshoot 404s in Tomcat with AppSec enabled #7519
Conversation
Debugger benchmarksParameters
See matching parameters
SummaryFound 3 performance improvements and 0 performance regressions! Performance is the same for 6 metrics, 6 unstable metrics.
See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (288.583 µs) : 267, 311
. : milestone, 289,
basic (302.903 µs) : 295, 311
. : milestone, 303,
loop (10.477 ms) : 10441, 10513
. : milestone, 10477,
section candidate
noprobe (296.254 µs) : 263, 330
. : milestone, 296,
basic (290.191 µs) : 281, 300
. : milestone, 290,
loop (10.499 ms) : 10468, 10530
. : milestone, 10499,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 3 performance improvements and 1 performance regressions! Performance is the same for 45 metrics, 14 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~5a97672534, baseline=1.39.0-SNAPSHOT~115998f9f0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1048679
Total [baseline] (8.481 s) : 0, 8480649
Agent [candidate] (1.044 s) : 0, 1044375
Total [candidate] (8.477 s) : 0, 8477209
section iast
Agent [baseline] (1.181 s) : 0, 1180588
Total [baseline] (9.0 s) : 0, 9000093
Agent [candidate] (1.174 s) : 0, 1173802
Total [candidate] (9.022 s) : 0, 9022182
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.179 s) : 0, 1178825
Total [baseline] (8.972 s) : 0, 8972409
Agent [candidate] (1.173 s) : 0, 1172993
Total [candidate] (8.973 s) : 0, 8973126
section iast_TELEMETRY_OFF
Agent [baseline] (1.167 s) : 0, 1167167
Total [baseline] (8.951 s) : 0, 8951376
Agent [candidate] (1.173 s) : 0, 1172638
Total [candidate] (8.975 s) : 0, 8975372
gantt
title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~5a97672534, baseline=1.39.0-SNAPSHOT~115998f9f0
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (668.883 ms) : 0, 668883
BytebuddyAgent [candidate] (667.464 ms) : 0, 667464
GlobalTracer [baseline] (306.73 ms) : 0, 306730
GlobalTracer [candidate] (305.44 ms) : 0, 305440
AppSec [baseline] (51.364 ms) : 0, 51364
AppSec [candidate] (50.111 ms) : 0, 50111
Remote Config [baseline] (666.433 µs) : 0, 666
Remote Config [candidate] (683.613 µs) : 0, 684
Telemetry [baseline] (7.49 ms) : 0, 7490
Telemetry [candidate] (7.281 ms) : 0, 7281
section iast
BytebuddyAgent [baseline] (783.968 ms) : 0, 783968
BytebuddyAgent [candidate] (781.759 ms) : 0, 781759
GlobalTracer [baseline] (298.122 ms) : 0, 298122
GlobalTracer [candidate] (295.136 ms) : 0, 295136
AppSec [baseline] (50.665 ms) : 0, 50665
AppSec [candidate] (52.713 ms) : 0, 52713
IAST [baseline] (24.65 ms) : 0, 24650
IAST [candidate] (22.973 ms) : 0, 22973
Remote Config [baseline] (617.357 µs) : 0, 617
Remote Config [candidate] (606.672 µs) : 0, 607
Telemetry [baseline] (8.885 ms) : 0, 8885
Telemetry [candidate] (7.175 ms) : 0, 7175
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (782.836 ms) : 0, 782836
BytebuddyAgent [candidate] (781.918 ms) : 0, 781918
GlobalTracer [baseline] (297.678 ms) : 0, 297678
GlobalTracer [candidate] (295.717 ms) : 0, 295717
AppSec [baseline] (48.714 ms) : 0, 48714
AppSec [candidate] (52.344 ms) : 0, 52344
IAST [baseline] (26.618 ms) : 0, 26618
IAST [candidate] (21.925 ms) : 0, 21925
Remote Config [baseline] (596.23 µs) : 0, 596
Remote Config [candidate] (579.486 µs) : 0, 579
Telemetry [baseline] (8.707 ms) : 0, 8707
Telemetry [candidate] (7.003 ms) : 0, 7003
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (774.759 ms) : 0, 774759
BytebuddyAgent [candidate] (780.143 ms) : 0, 780143
GlobalTracer [baseline] (296.085 ms) : 0, 296085
GlobalTracer [candidate] (295.935 ms) : 0, 295935
AppSec [baseline] (49.453 ms) : 0, 49453
AppSec [candidate] (48.462 ms) : 0, 48462
IAST [baseline] (24.995 ms) : 0, 24995
IAST [candidate] (27.132 ms) : 0, 27132
Remote Config [baseline] (584.467 µs) : 0, 584
Remote Config [candidate] (608.026 µs) : 0, 608
Telemetry [baseline] (7.727 ms) : 0, 7727
Telemetry [candidate] (6.849 ms) : 0, 6849
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~5a97672534, baseline=1.39.0-SNAPSHOT~115998f9f0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1048854
Total [baseline] (10.344 s) : 0, 10344341
Agent [candidate] (1.042 s) : 0, 1041992
Total [candidate] (10.399 s) : 0, 10398740
section appsec
Agent [baseline] (1.18 s) : 0, 1179984
Total [baseline] (10.514 s) : 0, 10514054
Agent [candidate] (1.165 s) : 0, 1164541
Total [candidate] (10.451 s) : 0, 10451387
section iast
Agent [baseline] (1.181 s) : 0, 1181121
Total [baseline] (10.877 s) : 0, 10877471
Agent [candidate] (1.173 s) : 0, 1173294
Total [candidate] (10.83 s) : 0, 10829892
section profiling
Agent [baseline] (1.245 s) : 0, 1245099
Total [baseline] (10.543 s) : 0, 10543460
Agent [candidate] (1.243 s) : 0, 1243398
Total [candidate] (10.651 s) : 0, 10650522
gantt
title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~5a97672534, baseline=1.39.0-SNAPSHOT~115998f9f0
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (669.277 ms) : 0, 669277
BytebuddyAgent [candidate] (666.013 ms) : 0, 666013
GlobalTracer [baseline] (306.275 ms) : 0, 306275
GlobalTracer [candidate] (304.346 ms) : 0, 304346
AppSec [baseline] (51.607 ms) : 0, 51607
AppSec [candidate] (50.203 ms) : 0, 50203
Remote Config [baseline] (676.408 µs) : 0, 676
Remote Config [candidate] (687.077 µs) : 0, 687
Telemetry [baseline] (7.489 ms) : 0, 7489
Telemetry [candidate] (7.326 ms) : 0, 7326
section appsec
BytebuddyAgent [baseline] (684.201 ms) : 0, 684201
BytebuddyAgent [candidate] (677.77 ms) : 0, 677770
GlobalTracer [baseline] (302.984 ms) : 0, 302984
GlobalTracer [candidate] (298.134 ms) : 0, 298134
AppSec [baseline] (161.152 ms) : 0, 161152
AppSec [candidate] (155.283 ms) : 0, 155283
Remote Config [baseline] (649.3 µs) : 0, 649
Remote Config [candidate] (595.096 µs) : 0, 595
Telemetry [baseline] (8.109 ms) : 0, 8109
Telemetry [candidate] (8.801 ms) : 0, 8801
IAST [baseline] (18.405 ms) : 0, 18405
IAST [candidate] (20.933 ms) : 0, 20933
section iast
BytebuddyAgent [baseline] (785.559 ms) : 0, 785559
BytebuddyAgent [candidate] (782.35 ms) : 0, 782350
GlobalTracer [baseline] (298.635 ms) : 0, 298635
GlobalTracer [candidate] (295.509 ms) : 0, 295509
AppSec [baseline] (51.357 ms) : 0, 51357
AppSec [candidate] (49.282 ms) : 0, 49282
Remote Config [baseline] (617.32 µs) : 0, 617
Remote Config [candidate] (2.127 ms) : 0, 2127
Telemetry [baseline] (7.404 ms) : 0, 7404
Telemetry [candidate] (7.09 ms) : 0, 7090
IAST [baseline] (23.859 ms) : 0, 23859
IAST [candidate] (23.461 ms) : 0, 23461
section profiling
ProfilingAgent [baseline] (96.074 ms) : 0, 96074
ProfilingAgent [candidate] (95.113 ms) : 0, 95113
BytebuddyAgent [baseline] (663.502 ms) : 0, 663502
BytebuddyAgent [candidate] (663.254 ms) : 0, 663254
GlobalTracer [baseline] (388.136 ms) : 0, 388136
GlobalTracer [candidate] (388.83 ms) : 0, 388830
AppSec [baseline] (52.208 ms) : 0, 52208
AppSec [candidate] (51.177 ms) : 0, 51177
Remote Config [baseline] (677.559 µs) : 0, 678
Remote Config [candidate] (698.164 µs) : 0, 698
Telemetry [baseline] (7.304 ms) : 0, 7304
Telemetry [candidate] (7.221 ms) : 0, 7221
Profiling [baseline] (96.098 ms) : 0, 96098
Profiling [candidate] (95.138 ms) : 0, 95138
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~5a97672534, baseline=1.39.0-SNAPSHOT~115998f9f0
dateFormat X
axisFormat %s
section baseline
no_agent (366.755 µs) : 347, 386
. : milestone, 367,
iast (481.821 µs) : 460, 504
. : milestone, 482,
iast_FULL (554.018 µs) : 533, 575
. : milestone, 554,
iast_GLOBAL (498.273 µs) : 477, 519
. : milestone, 498,
iast_HARDCODED_SECRET_DISABLED (482.125 µs) : 460, 505
. : milestone, 482,
iast_INACTIVE (447.832 µs) : 427, 469
. : milestone, 448,
iast_TELEMETRY_OFF (475.956 µs) : 453, 499
. : milestone, 476,
tracing (433.006 µs) : 413, 453
. : milestone, 433,
section candidate
no_agent (367.08 µs) : 346, 389
. : milestone, 367,
iast (482.866 µs) : 462, 504
. : milestone, 483,
iast_FULL (549.735 µs) : 529, 571
. : milestone, 550,
iast_GLOBAL (506.665 µs) : 484, 529
. : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (476.247 µs) : 455, 497
. : milestone, 476,
iast_INACTIVE (454.291 µs) : 432, 477
. : milestone, 454,
iast_TELEMETRY_OFF (472.986 µs) : 451, 495
. : milestone, 473,
tracing (444.89 µs) : 424, 465
. : milestone, 445,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~5a97672534, baseline=1.39.0-SNAPSHOT~115998f9f0
dateFormat X
axisFormat %s
section baseline
no_agent (1.34 ms) : 1321, 1359
. : milestone, 1340,
appsec (1.718 ms) : 1695, 1741
. : milestone, 1718,
appsec_no_iast (1.709 ms) : 1685, 1734
. : milestone, 1709,
iast (1.471 ms) : 1449, 1493
. : milestone, 1471,
profiling (1.483 ms) : 1459, 1508
. : milestone, 1483,
tracing (1.47 ms) : 1447, 1494
. : milestone, 1470,
section candidate
no_agent (1.343 ms) : 1324, 1363
. : milestone, 1343,
appsec (1.71 ms) : 1686, 1735
. : milestone, 1710,
appsec_no_iast (1.7 ms) : 1676, 1724
. : milestone, 1700,
iast (1.458 ms) : 1435, 1480
. : milestone, 1458,
profiling (1.51 ms) : 1484, 1536
. : milestone, 1510,
tracing (1.462 ms) : 1437, 1486
. : milestone, 1462,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~5a97672534, baseline=1.39.0-SNAPSHOT~115998f9f0
dateFormat X
axisFormat %s
section baseline
no_agent (15.041 s) : 15041000, 15041000
. : milestone, 15041000,
appsec (15.22 s) : 15220000, 15220000
. : milestone, 15220000,
iast (18.73 s) : 18730000, 18730000
. : milestone, 18730000,
iast_GLOBAL (17.877 s) : 17877000, 17877000
. : milestone, 17877000,
profiling (15.205 s) : 15205000, 15205000
. : milestone, 15205000,
tracing (15.2 s) : 15200000, 15200000
. : milestone, 15200000,
section candidate
no_agent (15.031 s) : 15031000, 15031000
. : milestone, 15031000,
appsec (15.331 s) : 15331000, 15331000
. : milestone, 15331000,
iast (19.019 s) : 19019000, 19019000
. : milestone, 19019000,
iast_GLOBAL (17.658 s) : 17658000, 17658000
. : milestone, 17658000,
profiling (15.584 s) : 15584000, 15584000
. : milestone, 15584000,
tracing (14.999 s) : 14999000, 14999000
. : milestone, 14999000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~5a97672534, baseline=1.39.0-SNAPSHOT~115998f9f0
dateFormat X
axisFormat %s
section baseline
no_agent (1.457 ms) : 1445, 1468
. : milestone, 1457,
appsec (2.231 ms) : 2196, 2266
. : milestone, 2231,
iast (1.966 ms) : 1924, 2008
. : milestone, 1966,
iast_GLOBAL (2.019 ms) : 1975, 2063
. : milestone, 2019,
profiling (1.854 ms) : 1818, 1889
. : milestone, 1854,
tracing (1.838 ms) : 1806, 1871
. : milestone, 1838,
section candidate
no_agent (1.459 ms) : 1448, 1470
. : milestone, 1459,
appsec (2.217 ms) : 2182, 2251
. : milestone, 2217,
iast (1.964 ms) : 1922, 2005
. : milestone, 1964,
iast_GLOBAL (2.015 ms) : 1972, 2057
. : milestone, 2015,
profiling (1.863 ms) : 1828, 1898
. : milestone, 1863,
tracing (1.836 ms) : 1803, 1869
. : milestone, 1836,
|
What Does This Do
Add a few options to disable specific appsec instrumentations.
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]