-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider Maven wrapper a global change for job skip script #7623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smola
added
tag: no release notes
Changes to exclude from release notes
comp: tooling
Build & Tooling
labels
Sep 16, 2024
5 tasks
PerfectSlayer
approved these changes
Sep 16, 2024
smola
force-pushed
the
smola/do-not-skip-on-mvnw-change
branch
from
September 16, 2024 07:20
1308713
to
0b119c4
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~704f8581d3, baseline=1.40.0-SNAPSHOT~fbae5a1c16
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1064948
Total [baseline] (10.472 s) : 0, 10471798
Agent [candidate] (1.07 s) : 0, 1070297
Total [candidate] (10.48 s) : 0, 10480304
section appsec
Agent [baseline] (1.199 s) : 0, 1199252
Total [baseline] (10.642 s) : 0, 10641824
Agent [candidate] (1.204 s) : 0, 1203776
Total [candidate] (10.635 s) : 0, 10634655
section iast
Agent [baseline] (1.192 s) : 0, 1192479
Total [baseline] (10.916 s) : 0, 10916056
Agent [candidate] (1.192 s) : 0, 1192117
Total [candidate] (10.853 s) : 0, 10852744
section profiling
Agent [baseline] (1.275 s) : 0, 1275088
Total [baseline] (10.698 s) : 0, 10697675
Agent [candidate] (1.278 s) : 0, 1277535
Total [candidate] (10.655 s) : 0, 10655261
gantt
title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~704f8581d3, baseline=1.40.0-SNAPSHOT~fbae5a1c16
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (679.207 ms) : 0, 679207
BytebuddyAgent [candidate] (681.64 ms) : 0, 681640
GlobalTracer [baseline] (311.69 ms) : 0, 311690
GlobalTracer [candidate] (314.111 ms) : 0, 314111
AppSec [baseline] (51.979 ms) : 0, 51979
AppSec [candidate] (52.374 ms) : 0, 52374
Remote Config [baseline] (717.213 µs) : 0, 717
Remote Config [candidate] (728.066 µs) : 0, 728
Telemetry [baseline] (7.636 ms) : 0, 7636
Telemetry [candidate] (7.665 ms) : 0, 7665
section appsec
BytebuddyAgent [baseline] (700.305 ms) : 0, 700305
BytebuddyAgent [candidate] (702.667 ms) : 0, 702667
GlobalTracer [baseline] (303.98 ms) : 0, 303980
GlobalTracer [candidate] (305.573 ms) : 0, 305573
AppSec [baseline] (161.455 ms) : 0, 161455
AppSec [candidate] (162.043 ms) : 0, 162043
Remote Config [baseline] (650.244 µs) : 0, 650
Remote Config [candidate] (650.326 µs) : 0, 650
Telemetry [baseline] (9.101 ms) : 0, 9101
Telemetry [candidate] (8.33 ms) : 0, 8330
IAST [baseline] (20.017 ms) : 0, 20017
IAST [candidate] (21.476 ms) : 0, 21476
section iast
BytebuddyAgent [baseline] (792.705 ms) : 0, 792705
BytebuddyAgent [candidate] (792.501 ms) : 0, 792501
GlobalTracer [baseline] (300.958 ms) : 0, 300958
GlobalTracer [candidate] (300.805 ms) : 0, 300805
AppSec [baseline] (51.799 ms) : 0, 51799
AppSec [candidate] (52.66 ms) : 0, 52660
Remote Config [baseline] (665.645 µs) : 0, 666
Remote Config [candidate] (679.189 µs) : 0, 679
Telemetry [baseline] (7.347 ms) : 0, 7347
Telemetry [candidate] (7.371 ms) : 0, 7371
IAST [baseline] (25.253 ms) : 0, 25253
IAST [candidate] (24.316 ms) : 0, 24316
section profiling
BytebuddyAgent [baseline] (679.857 ms) : 0, 679857
BytebuddyAgent [candidate] (681.739 ms) : 0, 681739
GlobalTracer [baseline] (397.73 ms) : 0, 397730
GlobalTracer [candidate] (398.266 ms) : 0, 398266
AppSec [baseline] (53.03 ms) : 0, 53030
AppSec [candidate] (53.074 ms) : 0, 53074
Remote Config [baseline] (723.764 µs) : 0, 724
Remote Config [candidate] (721.913 µs) : 0, 722
Telemetry [baseline] (7.569 ms) : 0, 7569
Telemetry [candidate] (7.578 ms) : 0, 7578
ProfilingAgent [baseline] (97.674 ms) : 0, 97674
ProfilingAgent [candidate] (97.605 ms) : 0, 97605
Profiling [baseline] (97.698 ms) : 0, 97698
Profiling [candidate] (97.629 ms) : 0, 97629
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~704f8581d3, baseline=1.40.0-SNAPSHOT~fbae5a1c16
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.078 s) : 0, 1078025
Total [baseline] (8.596 s) : 0, 8596140
Agent [candidate] (1.069 s) : 0, 1069143
Total [candidate] (8.543 s) : 0, 8543229
section iast
Agent [baseline] (1.192 s) : 0, 1191731
Total [baseline] (9.007 s) : 0, 9007018
Agent [candidate] (1.192 s) : 0, 1192318
Total [candidate] (9.017 s) : 0, 9017183
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.19 s) : 0, 1190142
Total [baseline] (8.984 s) : 0, 8984374
Agent [candidate] (1.199 s) : 0, 1198939
Total [candidate] (8.979 s) : 0, 8979214
section iast_TELEMETRY_OFF
Agent [baseline] (1.199 s) : 0, 1199102
Total [baseline] (9.032 s) : 0, 9032309
Agent [candidate] (1.198 s) : 0, 1198237
Total [candidate] (9.016 s) : 0, 9015866
gantt
title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~704f8581d3, baseline=1.40.0-SNAPSHOT~fbae5a1c16
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.934 ms) : 0, 687934
BytebuddyAgent [candidate] (682.492 ms) : 0, 682492
GlobalTracer [baseline] (315.415 ms) : 0, 315415
GlobalTracer [candidate] (312.439 ms) : 0, 312439
AppSec [baseline] (52.345 ms) : 0, 52345
AppSec [candidate] (52.088 ms) : 0, 52088
Remote Config [baseline] (737.718 µs) : 0, 738
Remote Config [candidate] (720.945 µs) : 0, 721
Telemetry [baseline] (7.717 ms) : 0, 7717
Telemetry [candidate] (7.617 ms) : 0, 7617
section iast
BytebuddyAgent [baseline] (792.816 ms) : 0, 792816
BytebuddyAgent [candidate] (792.897 ms) : 0, 792897
GlobalTracer [baseline] (300.577 ms) : 0, 300577
GlobalTracer [candidate] (300.905 ms) : 0, 300905
AppSec [baseline] (54.377 ms) : 0, 54377
AppSec [candidate] (52.663 ms) : 0, 52663
IAST [baseline] (21.274 ms) : 0, 21274
IAST [candidate] (23.118 ms) : 0, 23118
Remote Config [baseline] (620.596 µs) : 0, 621
Remote Config [candidate] (1.415 ms) : 0, 1415
Telemetry [baseline] (8.281 ms) : 0, 8281
Telemetry [candidate] (7.511 ms) : 0, 7511
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (791.447 ms) : 0, 791447
BytebuddyAgent [candidate] (797.354 ms) : 0, 797354
GlobalTracer [baseline] (300.351 ms) : 0, 300351
GlobalTracer [candidate] (302.124 ms) : 0, 302124
AppSec [baseline] (53.525 ms) : 0, 53525
AppSec [candidate] (51.96 ms) : 0, 51960
IAST [baseline] (22.965 ms) : 0, 22965
IAST [candidate] (25.604 ms) : 0, 25604
Remote Config [baseline] (617.837 µs) : 0, 618
Remote Config [candidate] (612.053 µs) : 0, 612
Telemetry [baseline] (7.454 ms) : 0, 7454
Telemetry [candidate] (7.394 ms) : 0, 7394
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (796.632 ms) : 0, 796632
BytebuddyAgent [candidate] (796.411 ms) : 0, 796411
GlobalTracer [baseline] (303.334 ms) : 0, 303334
GlobalTracer [candidate] (302.859 ms) : 0, 302859
AppSec [baseline] (55.532 ms) : 0, 55532
AppSec [candidate] (54.517 ms) : 0, 54517
IAST [baseline] (20.985 ms) : 0, 20985
IAST [candidate] (21.802 ms) : 0, 21802
Remote Config [baseline] (607.87 µs) : 0, 608
Remote Config [candidate] (600.709 µs) : 0, 601
Telemetry [baseline] (8.132 ms) : 0, 8132
Telemetry [candidate] (8.109 ms) : 0, 8109
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~704f8581d3, baseline=1.40.0-SNAPSHOT~fbae5a1c16
dateFormat X
axisFormat %s
section baseline
no_agent (383.677 µs) : 364, 403
. : milestone, 384,
iast (485.166 µs) : 464, 507
. : milestone, 485,
iast_FULL (560.371 µs) : 539, 582
. : milestone, 560,
iast_GLOBAL (513.257 µs) : 492, 535
. : milestone, 513,
iast_HARDCODED_SECRET_DISABLED (493.805 µs) : 471, 517
. : milestone, 494,
iast_INACTIVE (456.251 µs) : 435, 477
. : milestone, 456,
iast_TELEMETRY_OFF (479.91 µs) : 457, 503
. : milestone, 480,
tracing (447.227 µs) : 426, 468
. : milestone, 447,
section candidate
no_agent (380.507 µs) : 361, 401
. : milestone, 381,
iast (489.075 µs) : 467, 511
. : milestone, 489,
iast_FULL (566.943 µs) : 546, 588
. : milestone, 567,
iast_GLOBAL (525.535 µs) : 502, 549
. : milestone, 526,
iast_HARDCODED_SECRET_DISABLED (494.586 µs) : 472, 517
. : milestone, 495,
iast_INACTIVE (454.713 µs) : 434, 476
. : milestone, 455,
iast_TELEMETRY_OFF (482.056 µs) : 460, 504
. : milestone, 482,
tracing (445.184 µs) : 424, 466
. : milestone, 445,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~704f8581d3, baseline=1.40.0-SNAPSHOT~fbae5a1c16
dateFormat X
axisFormat %s
section baseline
no_agent (1.337 ms) : 1317, 1356
. : milestone, 1337,
appsec (1.71 ms) : 1686, 1734
. : milestone, 1710,
appsec_no_iast (1.736 ms) : 1712, 1760
. : milestone, 1736,
iast (1.472 ms) : 1449, 1495
. : milestone, 1472,
profiling (1.508 ms) : 1485, 1530
. : milestone, 1508,
tracing (1.463 ms) : 1438, 1487
. : milestone, 1463,
section candidate
no_agent (1.338 ms) : 1319, 1358
. : milestone, 1338,
appsec (1.727 ms) : 1703, 1752
. : milestone, 1727,
appsec_no_iast (1.73 ms) : 1706, 1755
. : milestone, 1730,
iast (1.476 ms) : 1453, 1498
. : milestone, 1476,
profiling (1.489 ms) : 1465, 1512
. : milestone, 1489,
tracing (1.477 ms) : 1453, 1502
. : milestone, 1477,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~704f8581d3, baseline=1.40.0-SNAPSHOT~fbae5a1c16
dateFormat X
axisFormat %s
section baseline
no_agent (1.465 ms) : 1454, 1477
. : milestone, 1465,
appsec (2.296 ms) : 2256, 2337
. : milestone, 2296,
iast (2.048 ms) : 1999, 2097
. : milestone, 2048,
iast_GLOBAL (2.112 ms) : 2061, 2163
. : milestone, 2112,
profiling (1.938 ms) : 1897, 1979
. : milestone, 1938,
tracing (1.908 ms) : 1870, 1947
. : milestone, 1908,
section candidate
no_agent (1.463 ms) : 1452, 1474
. : milestone, 1463,
appsec (2.288 ms) : 2248, 2328
. : milestone, 2288,
iast (2.038 ms) : 1990, 2086
. : milestone, 2038,
iast_GLOBAL (2.092 ms) : 2042, 2142
. : milestone, 2092,
profiling (2.401 ms) : 2216, 2586
. : milestone, 2401,
tracing (1.908 ms) : 1870, 1946
. : milestone, 1908,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~704f8581d3, baseline=1.40.0-SNAPSHOT~fbae5a1c16
dateFormat X
axisFormat %s
section baseline
no_agent (15.035 s) : 15035000, 15035000
. : milestone, 15035000,
appsec (15.199 s) : 15199000, 15199000
. : milestone, 15199000,
iast (18.978 s) : 18978000, 18978000
. : milestone, 18978000,
iast_GLOBAL (18.071 s) : 18071000, 18071000
. : milestone, 18071000,
profiling (15.357 s) : 15357000, 15357000
. : milestone, 15357000,
tracing (14.974 s) : 14974000, 14974000
. : milestone, 14974000,
section candidate
no_agent (15.527 s) : 15527000, 15527000
. : milestone, 15527000,
appsec (15.104 s) : 15104000, 15104000
. : milestone, 15104000,
iast (19.283 s) : 19283000, 19283000
. : milestone, 19283000,
iast_GLOBAL (18.09 s) : 18090000, 18090000
. : milestone, 18090000,
profiling (15.35 s) : 15350000, 15350000
. : milestone, 15350000,
tracing (15.261 s) : 15261000, 15261000
. : milestone, 15261000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]