Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow enabling experimental JVMTI wallclock sampler #7641

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Allow enabling experimental JVMTI wallclock sampler #7641

merged 1 commit into from
Sep 19, 2024

Conversation

jbachorik
Copy link
Contributor

@jbachorik jbachorik commented Sep 18, 2024 •
edited by jira bot
Loading

What Does This Do

This adds the config flag to enable the experimental JVMTI wallclock samplers

Motivation

Need to try this feature in dogfooding first and for that we need a way to enable it.

Additional Notes

Contributor Checklist

Jira ticket: PROF-10079

@jbachorik jbachorik added tag: no release notes Changes to exclude from release notes comp: profiling Profiling labels Sep 18, 2024
@jbachorik jbachorik requested review from a team as code owners September 18, 2024 16:12
@jbachorik jbachorik requested a review from mcculls September 18, 2024 16:12
@pr-commenter
Copy link

pr-commenter bot commented Sep 18, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jb/jvmti_sampler
git_commit_date 1726674508 1726675807
git_commit_sha 3c0cbd7 f59c400
release_version 1.40.0-SNAPSHOT~3c0cbd7307 1.40.0-SNAPSHOT~f59c400c61
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1726678214 1726678214
ci_job_id 643808111 643808111
ci_pipeline_id 44605756 44605756
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~f59c400c61, baseline=1.40.0-SNAPSHOT~3c0cbd7307

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1065138
Total [baseline] (8.537 s) : 0, 8536903
Agent [candidate] (1.061 s) : 0, 1060905
Total [candidate] (8.523 s) : 0, 8523070
section iast
Agent [baseline] (1.207 s) : 0, 1207060
Total [baseline] (9.062 s) : 0, 9062098
Agent [candidate] (1.188 s) : 0, 1188256
Total [candidate] (9.008 s) : 0, 9007873
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.197 s) : 0, 1197248
Total [baseline] (8.986 s) : 0, 8986367
Agent [candidate] (1.197 s) : 0, 1197338
Total [candidate] (9.026 s) : 0, 9025881
section iast_TELEMETRY_OFF
Agent [baseline] (1.186 s) : 0, 1185719
Total [baseline] (8.987 s) : 0, 8986698
Agent [candidate] (1.185 s) : 0, 1185211
Total [candidate] (8.985 s) : 0, 8985298
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.065 s -
Agent iast 1.207 s 141.922 ms (13.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.197 s 132.111 ms (12.4%)
Agent iast_TELEMETRY_OFF 1.186 s 120.581 ms (11.3%)
Total tracing 8.537 s -
Total iast 9.062 s 525.195 ms (6.2%)
Total iast_HARDCODED_SECRET_DISABLED 8.986 s 449.464 ms (5.3%)
Total iast_TELEMETRY_OFF 8.987 s 449.795 ms (5.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.061 s -
Agent iast 1.188 s 127.351 ms (12.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.197 s 136.433 ms (12.9%)
Agent iast_TELEMETRY_OFF 1.185 s 124.306 ms (11.7%)
Total tracing 8.523 s -
Total iast 9.008 s 484.803 ms (5.7%)
Total iast_HARDCODED_SECRET_DISABLED 9.026 s 502.81 ms (5.9%)
Total iast_TELEMETRY_OFF 8.985 s 462.228 ms (5.4%) 
gantt
    title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~f59c400c61, baseline=1.40.0-SNAPSHOT~3c0cbd7307

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (680.75 ms) : 0, 680750
BytebuddyAgent [candidate] (677.827 ms) : 0, 677827
GlobalTracer [baseline] (310.302 ms) : 0, 310302
GlobalTracer [candidate] (309.15 ms) : 0, 309150
AppSec [baseline] (52.291 ms) : 0, 52291
AppSec [candidate] (52.206 ms) : 0, 52206
Remote Config [baseline] (669.561 µs) : 0, 670
Remote Config [candidate] (665.449 µs) : 0, 665
Telemetry [baseline] (7.469 ms) : 0, 7469
Telemetry [candidate] (7.482 ms) : 0, 7482
section iast
BytebuddyAgent [baseline] (804.73 ms) : 0, 804730
BytebuddyAgent [candidate] (791.315 ms) : 0, 791315
GlobalTracer [baseline] (302.602 ms) : 0, 302602
GlobalTracer [candidate] (298.202 ms) : 0, 298202
AppSec [baseline] (54.469 ms) : 0, 54469
AppSec [candidate] (55.085 ms) : 0, 55085
IAST [baseline] (23.481 ms) : 0, 23481
IAST [candidate] (21.972 ms) : 0, 21972
Remote Config [baseline] (620.075 µs) : 0, 620
Remote Config [candidate] (626.923 µs) : 0, 627
Telemetry [baseline] (7.37 ms) : 0, 7370
Telemetry [candidate] (7.404 ms) : 0, 7404
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (797.239 ms) : 0, 797239
BytebuddyAgent [candidate] (797.584 ms) : 0, 797584
GlobalTracer [baseline] (300.429 ms) : 0, 300429
GlobalTracer [candidate] (300.03 ms) : 0, 300030
AppSec [baseline] (53.485 ms) : 0, 53485
AppSec [candidate] (52.745 ms) : 0, 52745
IAST [baseline] (24.387 ms) : 0, 24387
IAST [candidate] (25.408 ms) : 0, 25408
Remote Config [baseline] (630.212 µs) : 0, 630
Remote Config [candidate] (587.342 µs) : 0, 587
Telemetry [baseline] (7.379 ms) : 0, 7379
Telemetry [candidate] (7.262 ms) : 0, 7262
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (788.601 ms) : 0, 788601
BytebuddyAgent [candidate] (787.994 ms) : 0, 787994
GlobalTracer [baseline] (298.722 ms) : 0, 298722
GlobalTracer [candidate] (298.485 ms) : 0, 298485
AppSec [baseline] (53.915 ms) : 0, 53915
AppSec [candidate] (55.022 ms) : 0, 55022
IAST [baseline] (22.267 ms) : 0, 22267
IAST [candidate] (21.415 ms) : 0, 21415
Remote Config [baseline] (603.006 µs) : 0, 603
Remote Config [candidate] (599.485 µs) : 0, 599
Telemetry [baseline] (8.01 ms) : 0, 8010
Telemetry [candidate] (8.076 ms) : 0, 8076
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~f59c400c61, baseline=1.40.0-SNAPSHOT~3c0cbd7307

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.068 s) : 0, 1067972
Total [baseline] (10.413 s) : 0, 10413062
Agent [candidate] (1.069 s) : 0, 1069009
Total [candidate] (10.358 s) : 0, 10357633
section appsec
Agent [baseline] (1.203 s) : 0, 1202763
Total [baseline] (10.69 s) : 0, 10690118
Agent [candidate] (1.2 s) : 0, 1200293
Total [candidate] (10.631 s) : 0, 10631126
section iast
Agent [baseline] (1.186 s) : 0, 1186495
Total [baseline] (10.81 s) : 0, 10810297
Agent [candidate] (1.189 s) : 0, 1188862
Total [candidate] (10.822 s) : 0, 10821966
section profiling
Agent [baseline] (1.262 s) : 0, 1261974
Total [baseline] (10.596 s) : 0, 10595711
Agent [candidate] (1.261 s) : 0, 1261031
Total [candidate] (10.54 s) : 0, 10539807
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.068 s -
Agent appsec 1.203 s 134.79 ms (12.6%)
Agent iast 1.186 s 118.523 ms (11.1%)
Agent profiling 1.262 s 194.002 ms (18.2%)
Total tracing 10.413 s -
Total appsec 10.69 s 277.056 ms (2.7%)
Total iast 10.81 s 397.235 ms (3.8%)
Total profiling 10.596 s 182.649 ms (1.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.069 s -
Agent appsec 1.2 s 131.284 ms (12.3%)
Agent iast 1.189 s 119.853 ms (11.2%)
Agent profiling 1.261 s 192.021 ms (18.0%)
Total tracing 10.358 s -
Total appsec 10.631 s 273.493 ms (2.6%)
Total iast 10.822 s 464.333 ms (4.5%)
Total profiling 10.54 s 182.174 ms (1.8%) 
gantt
    title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~f59c400c61, baseline=1.40.0-SNAPSHOT~3c0cbd7307

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.216 ms) : 0, 682216
BytebuddyAgent [candidate] (682.989 ms) : 0, 682989
GlobalTracer [baseline] (311.088 ms) : 0, 311088
GlobalTracer [candidate] (311.129 ms) : 0, 311129
AppSec [baseline] (52.832 ms) : 0, 52832
AppSec [candidate] (52.945 ms) : 0, 52945
Remote Config [baseline] (670.714 µs) : 0, 671
Remote Config [candidate] (677.584 µs) : 0, 678
Telemetry [baseline] (7.52 ms) : 0, 7520
Telemetry [candidate] (7.59 ms) : 0, 7590
section appsec
BytebuddyAgent [baseline] (703.602 ms) : 0, 703602
BytebuddyAgent [candidate] (702.582 ms) : 0, 702582
GlobalTracer [baseline] (304.396 ms) : 0, 304396
GlobalTracer [candidate] (303.023 ms) : 0, 303023
AppSec [baseline] (161.099 ms) : 0, 161099
AppSec [candidate] (161.721 ms) : 0, 161721
IAST [baseline] (19.953 ms) : 0, 19953
IAST [candidate] (21.421 ms) : 0, 21421
Remote Config [baseline] (647.013 µs) : 0, 647
Remote Config [candidate] (637.936 µs) : 0, 638
Telemetry [baseline] (9.429 ms) : 0, 9429
Telemetry [candidate] (7.999 ms) : 0, 7999
section iast
BytebuddyAgent [baseline] (790.2 ms) : 0, 790200
BytebuddyAgent [candidate] (791.446 ms) : 0, 791446
GlobalTracer [baseline] (297.998 ms) : 0, 297998
GlobalTracer [candidate] (298.521 ms) : 0, 298521
AppSec [baseline] (52.4 ms) : 0, 52400
AppSec [candidate] (51.478 ms) : 0, 51478
IAST [baseline] (24.275 ms) : 0, 24275
IAST [candidate] (26.01 ms) : 0, 26010
Remote Config [baseline] (665.337 µs) : 0, 665
Remote Config [candidate] (597.246 µs) : 0, 597
Telemetry [baseline] (7.373 ms) : 0, 7373
Telemetry [candidate] (7.21 ms) : 0, 7210
section profiling
BytebuddyAgent [baseline] (671.008 ms) : 0, 671008
BytebuddyAgent [candidate] (672.167 ms) : 0, 672167
GlobalTracer [baseline] (394.656 ms) : 0, 394656
GlobalTracer [candidate] (393.819 ms) : 0, 393819
AppSec [baseline] (53.388 ms) : 0, 53388
AppSec [candidate] (53.044 ms) : 0, 53044
Remote Config [baseline] (660.069 µs) : 0, 660
Remote Config [candidate] (656.686 µs) : 0, 657
Telemetry [baseline] (7.439 ms) : 0, 7439
Telemetry [candidate] (7.429 ms) : 0, 7429
ProfilingAgent [baseline] (96.84 ms) : 0, 96840
ProfilingAgent [candidate] (95.976 ms) : 0, 95976
Profiling [baseline] (96.863 ms) : 0, 96863
Profiling [candidate] (95.999 ms) : 0, 95999
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-09-18T16:20:56 2024-09-18T16:27:46
git_branch master jb/jvmti_sampler
git_commit_date 1726674508 1726675807
git_commit_sha 3c0cbd7 f59c400
release_version 1.40.0-SNAPSHOT~3c0cbd7307 1.40.0-SNAPSHOT~f59c400c61
start_time 2024-09-18T16:20:42 2024-09-18T16:27:33
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1726677211 1726677211
ci_job_id 643808112 643808112
ci_pipeline_id 44605756 44605756
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~f59c400c61, baseline=1.40.0-SNAPSHOT~3c0cbd7307
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.335 ms) : 1315, 1356
.   : milestone, 1335,
appsec (1.727 ms) : 1703, 1751
.   : milestone, 1727,
appsec_no_iast (1.703 ms) : 1679, 1727
.   : milestone, 1703,
iast (1.462 ms) : 1439, 1485
.   : milestone, 1462,
profiling (1.482 ms) : 1459, 1505
.   : milestone, 1482,
tracing (1.453 ms) : 1428, 1478
.   : milestone, 1453,
section candidate
no_agent (1.34 ms) : 1321, 1359
.   : milestone, 1340,
appsec (1.717 ms) : 1692, 1742
.   : milestone, 1717,
appsec_no_iast (1.741 ms) : 1717, 1766
.   : milestone, 1741,
iast (1.478 ms) : 1456, 1501
.   : milestone, 1478,
profiling (1.475 ms) : 1452, 1498
.   : milestone, 1475,
tracing (1.458 ms) : 1434, 1482
.   : milestone, 1458,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.335 ms [1.315 ms, 1.356 ms] -
appsec 1.727 ms [1.703 ms, 1.751 ms] 391.367 µs (29.3%)
appsec_no_iast 1.703 ms [1.679 ms, 1.727 ms] 367.572 µs (27.5%)
iast 1.462 ms [1.439 ms, 1.485 ms] 126.838 µs (9.5%)
profiling 1.482 ms [1.459 ms, 1.505 ms] 146.651 µs (11.0%)
tracing 1.453 ms [1.428 ms, 1.478 ms] 117.264 µs (8.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.34 ms [1.321 ms, 1.359 ms] -
appsec 1.717 ms [1.692 ms, 1.742 ms] 377.037 µs (28.1%)
appsec_no_iast 1.741 ms [1.717 ms, 1.766 ms] 401.43 µs (30.0%)
iast 1.478 ms [1.456 ms, 1.501 ms] 138.415 µs (10.3%)
profiling 1.475 ms [1.452 ms, 1.498 ms] 134.741 µs (10.1%)
tracing 1.458 ms [1.434 ms, 1.482 ms] 118.013 µs (8.8%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~f59c400c61, baseline=1.40.0-SNAPSHOT~3c0cbd7307
    dateFormat X
    axisFormat %s
section baseline
no_agent (369.776 µs) : 350, 389
.   : milestone, 370,
iast (479.907 µs) : 459, 501
.   : milestone, 480,
iast_FULL (548.898 µs) : 528, 570
.   : milestone, 549,
iast_GLOBAL (497.6 µs) : 476, 519
.   : milestone, 498,
iast_HARDCODED_SECRET_DISABLED (484.346 µs) : 463, 506
.   : milestone, 484,
iast_INACTIVE (449.129 µs) : 428, 470
.   : milestone, 449,
iast_TELEMETRY_OFF (475.488 µs) : 452, 499
.   : milestone, 475,
tracing (437.166 µs) : 417, 458
.   : milestone, 437,
section candidate
no_agent (374.66 µs) : 354, 395
.   : milestone, 375,
iast (478.274 µs) : 457, 500
.   : milestone, 478,
iast_FULL (545.561 µs) : 524, 567
.   : milestone, 546,
iast_GLOBAL (509.92 µs) : 489, 531
.   : milestone, 510,
iast_HARDCODED_SECRET_DISABLED (481.899 µs) : 461, 503
.   : milestone, 482,
iast_INACTIVE (439.753 µs) : 419, 460
.   : milestone, 440,
iast_TELEMETRY_OFF (477.938 µs) : 455, 501
.   : milestone, 478,
tracing (441.25 µs) : 421, 462
.   : milestone, 441,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 369.776 µs [350.383 µs, 389.169 µs] -
iast 479.907 µs [458.641 µs, 501.172 µs] 110.131 µs (29.8%)
iast_FULL 548.898 µs [527.766 µs, 570.03 µs] 179.122 µs (48.4%)
iast_GLOBAL 497.6 µs [476.472 µs, 518.728 µs] 127.824 µs (34.6%)
iast_HARDCODED_SECRET_DISABLED 484.346 µs [463.161 µs, 505.532 µs] 114.57 µs (31.0%)
iast_INACTIVE 449.129 µs [428.104 µs, 470.154 µs] 79.353 µs (21.5%)
iast_TELEMETRY_OFF 475.488 µs [452.451 µs, 498.524 µs] 105.712 µs (28.6%)
tracing 437.166 µs [416.508 µs, 457.824 µs] 67.39 µs (18.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 374.66 µs [354.143 µs, 395.178 µs] -
iast 478.274 µs [456.795 µs, 499.752 µs] 103.613 µs (27.7%)
iast_FULL 545.561 µs [524.446 µs, 566.675 µs] 170.9 µs (45.6%)
iast_GLOBAL 509.92 µs [488.564 µs, 531.277 µs] 135.26 µs (36.1%)
iast_HARDCODED_SECRET_DISABLED 481.899 µs [460.818 µs, 502.979 µs] 107.238 µs (28.6%)
iast_INACTIVE 439.753 µs [419.484 µs, 460.023 µs] 65.093 µs (17.4%)
iast_TELEMETRY_OFF 477.938 µs [454.945 µs, 500.931 µs] 103.278 µs (27.6%)
tracing 441.25 µs [420.578 µs, 461.922 µs] 66.59 µs (17.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jb/jvmti_sampler
git_commit_date 1726674508 1726675807
git_commit_sha 3c0cbd7 f59c400
release_version 1.40.0-SNAPSHOT~3c0cbd7307 1.40.0-SNAPSHOT~f59c400c61
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1726677737 1726677737
ci_job_id 643808113 643808113
ci_pipeline_id 44605756 44605756
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~f59c400c61, baseline=1.40.0-SNAPSHOT~3c0cbd7307
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.477 ms) : 1466, 1489
.   : milestone, 1477,
appsec (2.313 ms) : 2272, 2354
.   : milestone, 2313,
iast (2.073 ms) : 2023, 2124
.   : milestone, 2073,
iast_GLOBAL (2.116 ms) : 2065, 2167
.   : milestone, 2116,
profiling (1.942 ms) : 1901, 1982
.   : milestone, 1942,
tracing (1.913 ms) : 1875, 1951
.   : milestone, 1913,
section candidate
no_agent (1.476 ms) : 1465, 1488
.   : milestone, 1476,
appsec (2.303 ms) : 2262, 2344
.   : milestone, 2303,
iast (2.072 ms) : 2021, 2123
.   : milestone, 2072,
iast_GLOBAL (2.104 ms) : 2053, 2154
.   : milestone, 2104,
profiling (1.951 ms) : 1911, 1991
.   : milestone, 1951,
tracing (1.921 ms) : 1882, 1960
.   : milestone, 1921,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.477 ms [1.466 ms, 1.489 ms] -
appsec 2.313 ms [2.272 ms, 2.354 ms] 835.754 µs (56.6%)
iast 2.073 ms [2.023 ms, 2.124 ms] 596.01 µs (40.3%)
iast_GLOBAL 2.116 ms [2.065 ms, 2.167 ms] 638.434 µs (43.2%)
profiling 1.942 ms [1.901 ms, 1.982 ms] 464.529 µs (31.4%)
tracing 1.913 ms [1.875 ms, 1.951 ms] 435.523 µs (29.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.476 ms [1.465 ms, 1.488 ms] -
appsec 2.303 ms [2.262 ms, 2.344 ms] 826.613 µs (56.0%)
iast 2.072 ms [2.021 ms, 2.123 ms] 595.469 µs (40.3%)
iast_GLOBAL 2.104 ms [2.053 ms, 2.154 ms] 627.235 µs (42.5%)
profiling 1.951 ms [1.911 ms, 1.991 ms] 474.339 µs (32.1%)
tracing 1.921 ms [1.882 ms, 1.96 ms] 444.255 µs (30.1%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~f59c400c61, baseline=1.40.0-SNAPSHOT~3c0cbd7307
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.02 s) : 15020000, 15020000
.   : milestone, 15020000,
appsec (15.236 s) : 15236000, 15236000
.   : milestone, 15236000,
iast (18.876 s) : 18876000, 18876000
.   : milestone, 18876000,
iast_GLOBAL (17.952 s) : 17952000, 17952000
.   : milestone, 17952000,
profiling (15.401 s) : 15401000, 15401000
.   : milestone, 15401000,
tracing (15.069 s) : 15069000, 15069000
.   : milestone, 15069000,
section candidate
no_agent (15.833 s) : 15833000, 15833000
.   : milestone, 15833000,
appsec (15.059 s) : 15059000, 15059000
.   : milestone, 15059000,
iast (18.713 s) : 18713000, 18713000
.   : milestone, 18713000,
iast_GLOBAL (17.972 s) : 17972000, 17972000
.   : milestone, 17972000,
profiling (15.126 s) : 15126000, 15126000
.   : milestone, 15126000,
tracing (15.289 s) : 15289000, 15289000
.   : milestone, 15289000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.02 s [15.02 s, 15.02 s] -
appsec 15.236 s [15.236 s, 15.236 s] 216.0 ms (1.4%)
iast 18.876 s [18.876 s, 18.876 s] 3.856 s (25.7%)
iast_GLOBAL 17.952 s [17.952 s, 17.952 s] 2.932 s (19.5%)
profiling 15.401 s [15.401 s, 15.401 s] 381.0 ms (2.5%)
tracing 15.069 s [15.069 s, 15.069 s] 49.0 ms (0.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.833 s [15.833 s, 15.833 s] -
appsec 15.059 s [15.059 s, 15.059 s] -774.0 ms (-4.9%)
iast 18.713 s [18.713 s, 18.713 s] 2.88 s (18.2%)
iast_GLOBAL 17.972 s [17.972 s, 17.972 s] 2.139 s (13.5%)
profiling 15.126 s [15.126 s, 15.126 s] -707.0 ms (-4.5%)
tracing 15.289 s [15.289 s, 15.289 s] -544.0 ms (-3.4%)

@jbachorik jbachorik merged commit 662bb0c into master Sep 19, 2024
102 of 104 checks passed
@jbachorik jbachorik deleted the jb/jvmti_sampler branch September 19, 2024 08:27
@github-actions github-actions bot added this to the 1.40.0 milestone Sep 19, 2024
@jbachorik jbachorik changed the title Allow enabling experimenta JVMTI wallclock sampler Allow enabling experimental JVMTI wallclock sampler Sep 19, 2024
@jbachorik jbachorik mentioned this pull request Sep 19, 2024
Merged
jordan-wong pushed a commit that referenced this pull request Sep 23, 2024
@jbachorik @jordan-wong
Allow enabling experimenta JVMTI wallclock sampler (#7641)
fc4a4b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardstartin richardstartin richardstartin approved these changes

@mcculls mcculls Awaiting requested review from mcculls mcculls is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: profiling Profiling tag: no release notes Changes to exclude from release notes
Projects
None yet
Milestone
1.40.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jbachorik @richardstartin