Add propagation to String strip methods (reverted) #7651

Mariovido · 2024-09-20T07:34:27Z

What Does This Do

This adds the instrumentation to propagate the taint values through the methods of String called strip, stripLeading and stripTrailing. This method are only available from version 11 of Java.

Motivation

Increase propagation of String methods

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Squash your commits prior merging or merge using GitHub's Squash and merge
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: APPSEC-5757

pr-commenter · 2024-09-20T08:12:46Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mario.vidal/increase_string_taint
git_commit_date	1727079626	1727081355
git_commit_sha	`5ca0c5b`	`d1f0038`
release_version	1.40.0-SNAPSHOT~5ca0c5bab6	1.40.0-SNAPSHOT~d1f0038212

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1727083803	1727083803
ci_job_id	647779101	647779101
ci_pipeline_id	44888804	44888804
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~d1f0038212, baseline=1.40.0-SNAPSHOT~5ca0c5bab6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.077 s) : 0, 1077288
Total [baseline] (8.571 s) : 0, 8570502
Agent [candidate] (1.065 s) : 0, 1064674
Total [candidate] (8.568 s) : 0, 8568229
section iast
Agent [baseline] (1.19 s) : 0, 1190113
Total [baseline] (8.997 s) : 0, 8996819
Agent [candidate] (1.202 s) : 0, 1202065
Total [candidate] (9.052 s) : 0, 9052060
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.195 s) : 0, 1195090
Total [baseline] (8.973 s) : 0, 8973065
Agent [candidate] (1.192 s) : 0, 1191650
Total [candidate] (9.01 s) : 0, 9009890
section iast_TELEMETRY_OFF
Agent [baseline] (1.187 s) : 0, 1187313
Total [baseline] (9.01 s) : 0, 9009542
Agent [candidate] (1.189 s) : 0, 1188831
Total [candidate] (9.018 s) : 0, 9018004

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.077 s	-
Agent	iast	1.19 s	112.824 ms (10.5%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.195 s	117.801 ms (10.9%)
Agent	iast_TELEMETRY_OFF	1.187 s	110.024 ms (10.2%)
Total	tracing	8.571 s	-
Total	iast	8.997 s	426.317 ms (5.0%)
Total	iast_HARDCODED_SECRET_DISABLED	8.973 s	402.563 ms (4.7%)
Total	iast_TELEMETRY_OFF	9.01 s	439.04 ms (5.1%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.065 s	-
Agent	iast	1.202 s	137.391 ms (12.9%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.192 s	126.976 ms (11.9%)
Agent	iast_TELEMETRY_OFF	1.189 s	124.156 ms (11.7%)
Total	tracing	8.568 s	-
Total	iast	9.052 s	483.831 ms (5.6%)
Total	iast_HARDCODED_SECRET_DISABLED	9.01 s	441.661 ms (5.2%)
Total	iast_TELEMETRY_OFF	9.018 s	449.774 ms (5.2%)

gantt
    title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~d1f0038212, baseline=1.40.0-SNAPSHOT~5ca0c5bab6

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (689.112 ms) : 0, 689112
BytebuddyAgent [candidate] (679.405 ms) : 0, 679405
GlobalTracer [baseline] (311.965 ms) : 0, 311965
GlobalTracer [candidate] (309.399 ms) : 0, 309399
AppSec [baseline] (54.078 ms) : 0, 54078
AppSec [candidate] (53.924 ms) : 0, 53924
Remote Config [baseline] (662.491 µs) : 0, 662
Remote Config [candidate] (662.652 µs) : 0, 663
Telemetry [baseline] (7.616 ms) : 0, 7616
Telemetry [candidate] (7.624 ms) : 0, 7624
section iast
BytebuddyAgent [baseline] (791.934 ms) : 0, 791934
BytebuddyAgent [candidate] (799.887 ms) : 0, 799887
GlobalTracer [baseline] (298.43 ms) : 0, 298430
GlobalTracer [candidate] (301.107 ms) : 0, 301107
AppSec [baseline] (55.658 ms) : 0, 55658
AppSec [candidate] (57.034 ms) : 0, 57034
IAST [baseline] (22.7 ms) : 0, 22700
IAST [candidate] (22.431 ms) : 0, 22431
Remote Config [baseline] (637.735 µs) : 0, 638
Remote Config [candidate] (627.265 µs) : 0, 627
Telemetry [baseline] (7.036 ms) : 0, 7036
Telemetry [candidate] (7.139 ms) : 0, 7139
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (794.852 ms) : 0, 794852
BytebuddyAgent [candidate] (792.604 ms) : 0, 792604
GlobalTracer [baseline] (299.695 ms) : 0, 299695
GlobalTracer [candidate] (298.909 ms) : 0, 298909
AppSec [baseline] (53.509 ms) : 0, 53509
AppSec [candidate] (55.69 ms) : 0, 55690
IAST [baseline] (25.466 ms) : 0, 25466
IAST [candidate] (22.893 ms) : 0, 22893
Remote Config [baseline] (662.615 µs) : 0, 663
Remote Config [candidate] (678.438 µs) : 0, 678
Telemetry [baseline] (7.138 ms) : 0, 7138
Telemetry [candidate] (7.15 ms) : 0, 7150
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (788.47 ms) : 0, 788470
BytebuddyAgent [candidate] (790.31 ms) : 0, 790310
GlobalTracer [baseline] (299.058 ms) : 0, 299058
GlobalTracer [candidate] (299.146 ms) : 0, 299146
AppSec [baseline] (55.208 ms) : 0, 55208
AppSec [candidate] (57.459 ms) : 0, 57459
IAST [baseline] (22.489 ms) : 0, 22489
IAST [candidate] (20.661 ms) : 0, 20661
Remote Config [baseline] (1.404 ms) : 0, 1404
Remote Config [candidate] (597.616 µs) : 0, 598
Telemetry [baseline] (6.985 ms) : 0, 6985
Telemetry [candidate] (6.918 ms) : 0, 6918

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~d1f0038212, baseline=1.40.0-SNAPSHOT~5ca0c5bab6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.074 s) : 0, 1074265
Total [baseline] (10.437 s) : 0, 10437005
Agent [candidate] (1.075 s) : 0, 1074764
Total [candidate] (10.426 s) : 0, 10425847
section appsec
Agent [baseline] (1.201 s) : 0, 1200604
Total [baseline] (10.621 s) : 0, 10621224
Agent [candidate] (1.204 s) : 0, 1203642
Total [candidate] (10.648 s) : 0, 10648003
section iast
Agent [baseline] (1.193 s) : 0, 1193079
Total [baseline] (10.889 s) : 0, 10888694
Agent [candidate] (1.193 s) : 0, 1193298
Total [candidate] (10.802 s) : 0, 10802191
section profiling
Agent [baseline] (1.268 s) : 0, 1268053
Total [baseline] (10.723 s) : 0, 10722534
Agent [candidate] (1.269 s) : 0, 1268695
Total [candidate] (10.534 s) : 0, 10534288

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.074 s	-
Agent	appsec	1.201 s	126.339 ms (11.8%)
Agent	iast	1.193 s	118.814 ms (11.1%)
Agent	profiling	1.268 s	193.789 ms (18.0%)
Total	tracing	10.437 s	-
Total	appsec	10.621 s	184.218 ms (1.8%)
Total	iast	10.889 s	451.689 ms (4.3%)
Total	profiling	10.723 s	285.528 ms (2.7%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.075 s	-
Agent	appsec	1.204 s	128.878 ms (12.0%)
Agent	iast	1.193 s	118.534 ms (11.0%)
Agent	profiling	1.269 s	193.932 ms (18.0%)
Total	tracing	10.426 s	-
Total	appsec	10.648 s	222.156 ms (2.1%)
Total	iast	10.802 s	376.344 ms (3.6%)
Total	profiling	10.534 s	108.44 ms (1.0%)

gantt
    title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~d1f0038212, baseline=1.40.0-SNAPSHOT~5ca0c5bab6

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.265 ms) : 0, 686265
BytebuddyAgent [candidate] (686.069 ms) : 0, 686069
GlobalTracer [baseline] (311.933 ms) : 0, 311933
GlobalTracer [candidate] (312.052 ms) : 0, 312052
AppSec [baseline] (53.856 ms) : 0, 53856
AppSec [candidate] (54.536 ms) : 0, 54536
Remote Config [baseline] (668.307 µs) : 0, 668
Remote Config [candidate] (663.012 µs) : 0, 663
Telemetry [baseline] (7.723 ms) : 0, 7723
Telemetry [candidate] (7.673 ms) : 0, 7673
section appsec
BytebuddyAgent [baseline] (701.294 ms) : 0, 701294
BytebuddyAgent [candidate] (703.796 ms) : 0, 703796
GlobalTracer [baseline] (302.811 ms) : 0, 302811
GlobalTracer [candidate] (304.288 ms) : 0, 304288
AppSec [baseline] (162.97 ms) : 0, 162970
AppSec [candidate] (163.132 ms) : 0, 163132
IAST [baseline] (22.882 ms) : 0, 22882
IAST [candidate] (19.85 ms) : 0, 19850
Remote Config [baseline] (643.143 µs) : 0, 643
Remote Config [candidate] (633.864 µs) : 0, 634
Telemetry [baseline] (7.794 ms) : 0, 7794
Telemetry [candidate] (8.137 ms) : 0, 8137
section iast
BytebuddyAgent [baseline] (793.222 ms) : 0, 793222
BytebuddyAgent [candidate] (794.157 ms) : 0, 794157
GlobalTracer [baseline] (299.279 ms) : 0, 299279
GlobalTracer [candidate] (299.349 ms) : 0, 299349
AppSec [baseline] (53.582 ms) : 0, 53582
AppSec [candidate] (55.333 ms) : 0, 55333
IAST [baseline] (25.52 ms) : 0, 25520
IAST [candidate] (22.971 ms) : 0, 22971
Remote Config [baseline] (630.36 µs) : 0, 630
Remote Config [candidate] (631.463 µs) : 0, 631
Telemetry [baseline] (7.107 ms) : 0, 7107
Telemetry [candidate] (7.136 ms) : 0, 7136
section profiling
BytebuddyAgent [baseline] (675.021 ms) : 0, 675021
BytebuddyAgent [candidate] (674.645 ms) : 0, 674645
GlobalTracer [baseline] (394.817 ms) : 0, 394817
GlobalTracer [candidate] (395.393 ms) : 0, 395393
AppSec [baseline] (54.546 ms) : 0, 54546
AppSec [candidate] (54.977 ms) : 0, 54977
Remote Config [baseline] (643.218 µs) : 0, 643
Remote Config [candidate] (651.63 µs) : 0, 652
Telemetry [baseline] (7.439 ms) : 0, 7439
Telemetry [candidate] (7.488 ms) : 0, 7488
ProfilingAgent [baseline] (96.976 ms) : 0, 96976
ProfilingAgent [candidate] (96.964 ms) : 0, 96964
Profiling [baseline] (96.999 ms) : 0, 96999
Profiling [candidate] (96.987 ms) : 0, 96987

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-09-23T09:00:38	2024-09-23T09:07:27
git_branch	master	mario.vidal/increase_string_taint
git_commit_date	1727079626	1727081355
git_commit_sha	`5ca0c5b`	`d1f0038`
release_version	1.40.0-SNAPSHOT~5ca0c5bab6	1.40.0-SNAPSHOT~d1f0038212
start_time	2024-09-23T09:00:24	2024-09-23T09:07:14

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1727082793	1727082793
ci_job_id	647779102	647779102
ci_pipeline_id	44888804	44888804
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~d1f0038212, baseline=1.40.0-SNAPSHOT~5ca0c5bab6
    dateFormat X
    axisFormat %s
section baseline
no_agent (376.777 µs) : 357, 396
.   : milestone, 377,
iast (490.009 µs) : 468, 512
.   : milestone, 490,
iast_FULL (552.525 µs) : 531, 574
.   : milestone, 553,
iast_GLOBAL (501.207 µs) : 480, 522
.   : milestone, 501,
iast_HARDCODED_SECRET_DISABLED (479.162 µs) : 458, 500
.   : milestone, 479,
iast_INACTIVE (450.218 µs) : 429, 471
.   : milestone, 450,
iast_TELEMETRY_OFF (476.318 µs) : 454, 499
.   : milestone, 476,
tracing (442.851 µs) : 422, 464
.   : milestone, 443,
section candidate
no_agent (371.306 µs) : 351, 391
.   : milestone, 371,
iast (481.409 µs) : 460, 503
.   : milestone, 481,
iast_FULL (557.475 µs) : 536, 579
.   : milestone, 557,
iast_GLOBAL (513.457 µs) : 491, 535
.   : milestone, 513,
iast_HARDCODED_SECRET_DISABLED (483.909 µs) : 462, 506
.   : milestone, 484,
iast_INACTIVE (453.715 µs) : 432, 475
.   : milestone, 454,
iast_TELEMETRY_OFF (474.811 µs) : 452, 497
.   : milestone, 475,
tracing (446.741 µs) : 426, 468
.   : milestone, 447,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	376.777 µs [357.181 µs, 396.372 µs]	-
iast	490.009 µs [468.336 µs, 511.682 µs]	113.232 µs (30.1%)
iast_FULL	552.525 µs [531.442 µs, 573.608 µs]	175.748 µs (46.6%)
iast_GLOBAL	501.207 µs [480.258 µs, 522.156 µs]	124.43 µs (33.0%)
iast_HARDCODED_SECRET_DISABLED	479.162 µs [458.213 µs, 500.11 µs]	102.385 µs (27.2%)
iast_INACTIVE	450.218 µs [429.349 µs, 471.086 µs]	73.441 µs (19.5%)
iast_TELEMETRY_OFF	476.318 µs [453.936 µs, 498.701 µs]	99.541 µs (26.4%)
tracing	442.851 µs [422.19 µs, 463.512 µs]	66.074 µs (17.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	371.306 µs [351.409 µs, 391.202 µs]	-
iast	481.409 µs [460.083 µs, 502.734 µs]	110.103 µs (29.7%)
iast_FULL	557.475 µs [536.164 µs, 578.786 µs]	186.169 µs (50.1%)
iast_GLOBAL	513.457 µs [491.416 µs, 535.498 µs]	142.151 µs (38.3%)
iast_HARDCODED_SECRET_DISABLED	483.909 µs [462.2 µs, 505.618 µs]	112.603 µs (30.3%)
iast_INACTIVE	453.715 µs [432.027 µs, 475.402 µs]	82.409 µs (22.2%)
iast_TELEMETRY_OFF	474.811 µs [452.467 µs, 497.154 µs]	103.505 µs (27.9%)
tracing	446.741 µs [425.943 µs, 467.539 µs]	75.435 µs (20.3%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~d1f0038212, baseline=1.40.0-SNAPSHOT~5ca0c5bab6
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.338 ms) : 1319, 1357
.   : milestone, 1338,
appsec (1.725 ms) : 1702, 1748
.   : milestone, 1725,
appsec_no_iast (1.715 ms) : 1690, 1740
.   : milestone, 1715,
iast (1.462 ms) : 1440, 1484
.   : milestone, 1462,
profiling (1.477 ms) : 1452, 1502
.   : milestone, 1477,
tracing (1.455 ms) : 1431, 1479
.   : milestone, 1455,
section candidate
no_agent (1.346 ms) : 1327, 1365
.   : milestone, 1346,
appsec (1.717 ms) : 1693, 1740
.   : milestone, 1717,
appsec_no_iast (1.721 ms) : 1696, 1745
.   : milestone, 1721,
iast (1.478 ms) : 1455, 1501
.   : milestone, 1478,
profiling (1.481 ms) : 1456, 1505
.   : milestone, 1481,
tracing (1.483 ms) : 1459, 1507
.   : milestone, 1483,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.338 ms [1.319 ms, 1.357 ms]	-
appsec	1.725 ms [1.702 ms, 1.748 ms]	386.592 µs (28.9%)
appsec_no_iast	1.715 ms [1.69 ms, 1.74 ms]	376.41 µs (28.1%)
iast	1.462 ms [1.44 ms, 1.484 ms]	123.936 µs (9.3%)
profiling	1.477 ms [1.452 ms, 1.502 ms]	138.593 µs (10.4%)
tracing	1.455 ms [1.431 ms, 1.479 ms]	116.673 µs (8.7%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.346 ms [1.327 ms, 1.365 ms]	-
appsec	1.717 ms [1.693 ms, 1.74 ms]	370.471 µs (27.5%)
appsec_no_iast	1.721 ms [1.696 ms, 1.745 ms]	374.51 µs (27.8%)
iast	1.478 ms [1.455 ms, 1.501 ms]	131.301 µs (9.8%)
profiling	1.481 ms [1.456 ms, 1.505 ms]	134.3 µs (10.0%)
tracing	1.483 ms [1.459 ms, 1.507 ms]	137.043 µs (10.2%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mario.vidal/increase_string_taint
git_commit_date	1727079626	1727081355
git_commit_sha	`5ca0c5b`	`d1f0038`
release_version	1.40.0-SNAPSHOT~5ca0c5bab6	1.40.0-SNAPSHOT~d1f0038212

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1727083314	1727083314
ci_job_id	647779103	647779103
ci_pipeline_id	44888804	44888804
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~d1f0038212, baseline=1.40.0-SNAPSHOT~5ca0c5bab6
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.885 s) : 14885000, 14885000
.   : milestone, 14885000,
appsec (15.052 s) : 15052000, 15052000
.   : milestone, 15052000,
iast (18.788 s) : 18788000, 18788000
.   : milestone, 18788000,
iast_GLOBAL (18.215 s) : 18215000, 18215000
.   : milestone, 18215000,
profiling (15.525 s) : 15525000, 15525000
.   : milestone, 15525000,
tracing (15.307 s) : 15307000, 15307000
.   : milestone, 15307000,
section candidate
no_agent (15.36 s) : 15360000, 15360000
.   : milestone, 15360000,
appsec (15.328 s) : 15328000, 15328000
.   : milestone, 15328000,
iast (18.647 s) : 18647000, 18647000
.   : milestone, 18647000,
iast_GLOBAL (18.143 s) : 18143000, 18143000
.   : milestone, 18143000,
profiling (15.164 s) : 15164000, 15164000
.   : milestone, 15164000,
tracing (14.902 s) : 14902000, 14902000
.   : milestone, 14902000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.885 s [14.885 s, 14.885 s]	-
appsec	15.052 s [15.052 s, 15.052 s]	167.0 ms (1.1%)
iast	18.788 s [18.788 s, 18.788 s]	3.903 s (26.2%)
iast_GLOBAL	18.215 s [18.215 s, 18.215 s]	3.33 s (22.4%)
profiling	15.525 s [15.525 s, 15.525 s]	640.0 ms (4.3%)
tracing	15.307 s [15.307 s, 15.307 s]	422.0 ms (2.8%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.36 s [15.36 s, 15.36 s]	-
appsec	15.328 s [15.328 s, 15.328 s]	-32.0 ms (-0.2%)
iast	18.647 s [18.647 s, 18.647 s]	3.287 s (21.4%)
iast_GLOBAL	18.143 s [18.143 s, 18.143 s]	2.783 s (18.1%)
profiling	15.164 s [15.164 s, 15.164 s]	-196.0 ms (-1.3%)
tracing	14.902 s [14.902 s, 14.902 s]	-458.0 ms (-3.0%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~d1f0038212, baseline=1.40.0-SNAPSHOT~5ca0c5bab6
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.463 ms) : 1452, 1475
.   : milestone, 1463,
appsec (2.312 ms) : 2272, 2353
.   : milestone, 2312,
iast (2.06 ms) : 2010, 2110
.   : milestone, 2060,
iast_GLOBAL (2.088 ms) : 2037, 2138
.   : milestone, 2088,
profiling (1.915 ms) : 1876, 1954
.   : milestone, 1915,
tracing (1.893 ms) : 1855, 1931
.   : milestone, 1893,
section candidate
no_agent (1.463 ms) : 1451, 1474
.   : milestone, 1463,
appsec (2.309 ms) : 2269, 2350
.   : milestone, 2309,
iast (2.064 ms) : 2014, 2115
.   : milestone, 2064,
iast_GLOBAL (2.101 ms) : 2050, 2153
.   : milestone, 2101,
profiling (2.419 ms) : 2229, 2608
.   : milestone, 2419,
tracing (1.893 ms) : 1855, 1931
.   : milestone, 1893,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.463 ms [1.452 ms, 1.475 ms]	-
appsec	2.312 ms [2.272 ms, 2.353 ms]	849.104 µs (58.0%)
iast	2.06 ms [2.01 ms, 2.11 ms]	596.597 µs (40.8%)
iast_GLOBAL	2.088 ms [2.037 ms, 2.138 ms]	624.514 µs (42.7%)
profiling	1.915 ms [1.876 ms, 1.954 ms]	451.971 µs (30.9%)
tracing	1.893 ms [1.855 ms, 1.931 ms]	429.487 µs (29.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.463 ms [1.451 ms, 1.474 ms]	-
appsec	2.309 ms [2.269 ms, 2.35 ms]	846.608 µs (57.9%)
iast	2.064 ms [2.014 ms, 2.115 ms]	601.588 µs (41.1%)
iast_GLOBAL	2.101 ms [2.05 ms, 2.153 ms]	638.595 µs (43.7%)
profiling	2.419 ms [2.229 ms, 2.608 ms]	955.946 µs (65.4%)
tracing	1.893 ms [1.855 ms, 1.931 ms]	430.55 µs (29.4%)

dd-java-agent/agent-iast/src/test/groovy/com/datadog/iast/propagation/StringModuleTest.groovy

...g-11/src/test/groovy/datadog/trace/instrumentation/java/lang/jdk11/StringCallSiteTest.groovy

smola

Looks good. A couple of minor issues and we're good to go.

dd-java-agent/agent-iast/src/main/java/com/datadog/iast/propagation/StringModuleImpl.java

manuel-alvarez-alvarez

LGTM, nice one!

This reverts commit 8da3e7a.

Fix styles

707f88d

Mariovido added the inst: java Core Java language instrumentation label Sep 20, 2024

Add supressFbWarning to pass check_base

6a6872a

PerfectSlayer added the comp: asm iast Application Security Management (IAST) label Sep 20, 2024

smola requested changes Sep 20, 2024

View reviewed changes

Mariovido added 3 commits September 20, 2024 11:21

Update tests

4ab949a

Fix StringCallSiteTest

fb3c2b7

Fix tests

86cfbb8

Mariovido marked this pull request as ready for review September 20, 2024 11:52

Mariovido requested review from a team as code owners September 20, 2024 11:52

Mariovido requested review from smola and manuel-alvarez-alvarez September 20, 2024 11:52

Fix typos

10517d1

smola requested changes Sep 23, 2024

View reviewed changes

dd-java-agent/agent-iast/src/main/java/com/datadog/iast/propagation/StringModuleImpl.java Outdated Show resolved Hide resolved

dd-java-agent/agent-iast/src/main/java/com/datadog/iast/propagation/StringModuleImpl.java Outdated Show resolved Hide resolved

Minor changes

6d35d2e

smola approved these changes Sep 23, 2024

View reviewed changes

manuel-alvarez-alvarez approved these changes Sep 23, 2024

View reviewed changes

Merge branch 'master' into mario.vidal/increase_string_taint

d1f0038

Mariovido merged commit 8da3e7a into master Sep 23, 2024
97 of 101 checks passed

Mariovido deleted the mario.vidal/increase_string_taint branch September 23, 2024 10:18

github-actions bot added this to the 1.40.0 milestone Sep 23, 2024

Mariovido restored the mario.vidal/increase_string_taint branch September 23, 2024 11:11

smola added a commit that referenced this pull request Sep 23, 2024

Revert "Add propagation to String strip methods (#7651)"

b2e9256

This reverts commit 8da3e7a.

smola mentioned this pull request Sep 23, 2024

Revert "Add propagation to String strip methods (#7651)" #7664

Merged

5 tasks

smola added the tag: no release notes Changes to exclude from release notes label Sep 23, 2024

smola changed the title ~~Add propagation to String strip methods~~ Add propagation to String strip methods (reverted) Sep 23, 2024

Mariovido deleted the mario.vidal/increase_string_taint branch September 23, 2024 11:15

smola added a commit that referenced this pull request Sep 23, 2024

Revert "Add propagation to String strip methods (#7651)" (#7664)

5057f98

This reverts commit 8da3e7a.

jordan-wong pushed a commit that referenced this pull request Sep 23, 2024

Add propagation to String strip methods (#7651)

f63d265

jordan-wong pushed a commit that referenced this pull request Sep 23, 2024

Revert "Add propagation to String strip methods (#7651)" (#7664)

02e651a

This reverts commit 8da3e7a.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add propagation to String strip methods (reverted) #7651

Add propagation to String strip methods (reverted) #7651

Mariovido commented Sep 20, 2024 •

edited

Loading

pr-commenter bot commented Sep 20, 2024 •

edited

Loading

smola left a comment

manuel-alvarez-alvarez left a comment

Add propagation to String strip methods (reverted) #7651

Add propagation to String strip methods (reverted) #7651

Conversation

Mariovido commented Sep 20, 2024 • edited Loading

What Does This Do

Motivation

Additional Notes

Contributor Checklist

pr-commenter bot commented Sep 20, 2024 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

smola left a comment

Choose a reason for hiding this comment

manuel-alvarez-alvarez left a comment

Choose a reason for hiding this comment

Mariovido commented Sep 20, 2024 •

edited

Loading

pr-commenter bot commented Sep 20, 2024 •

edited

Loading