Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy weblog app #7658

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Remove legacy weblog app #7658

merged 1 commit into from
Sep 23, 2024

Conversation

smola
Copy link
Member

@smola smola commented Sep 20, 2024 •
edited
Loading

What Does This Do

Removes appsec weblog test app. This is largely superseded by smoke tests and system tests.

Motivation

Additional Notes

Contributor Checklist

@smola smola added tag: no release notes Changes to exclude from release notes type: refactoring comp: asm waf Application Security Management (WAF) labels Sep 20, 2024
@pr-commenter
Copy link

pr-commenter bot commented Sep 20, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master smola/remove-legacy-weblog
git_commit_date 1726843314 1726843766
git_commit_sha f681000 cf854f6
release_version 1.40.0-SNAPSHOT~f6810002f7 1.40.0-SNAPSHOT~cf854f62f6
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1726846324 1726846324
ci_job_id 646618185 646618185
ci_pipeline_id 44800431 44800431
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~cf854f62f6, baseline=1.40.0-SNAPSHOT~f6810002f7

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.07 s) : 0, 1070385
Total [baseline] (8.577 s) : 0, 8576960
Agent [candidate] (1.067 s) : 0, 1066550
Total [candidate] (8.562 s) : 0, 8561713
section iast
Agent [baseline] (1.195 s) : 0, 1194513
Total [baseline] (9.027 s) : 0, 9026977
Agent [candidate] (1.195 s) : 0, 1194874
Total [candidate] (9.018 s) : 0, 9018354
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.201 s) : 0, 1201432
Total [baseline] (9.036 s) : 0, 9035979
Agent [candidate] (1.193 s) : 0, 1193231
Total [candidate] (9.007 s) : 0, 9006804
section iast_TELEMETRY_OFF
Agent [baseline] (1.19 s) : 0, 1189727
Total [baseline] (9.009 s) : 0, 9009063
Agent [candidate] (1.206 s) : 0, 1206335
Total [candidate] (9.101 s) : 0, 9101418
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.07 s -
Agent iast 1.195 s 124.128 ms (11.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.201 s 131.047 ms (12.2%)
Agent iast_TELEMETRY_OFF 1.19 s 119.343 ms (11.1%)
Total tracing 8.577 s -
Total iast 9.027 s 450.016 ms (5.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.036 s 459.018 ms (5.4%)
Total iast_TELEMETRY_OFF 9.009 s 432.103 ms (5.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.067 s -
Agent iast 1.195 s 128.324 ms (12.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.193 s 126.68 ms (11.9%)
Agent iast_TELEMETRY_OFF 1.206 s 139.785 ms (13.1%)
Total tracing 8.562 s -
Total iast 9.018 s 456.641 ms (5.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.007 s 445.09 ms (5.2%)
Total iast_TELEMETRY_OFF 9.101 s 539.705 ms (6.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~cf854f62f6, baseline=1.40.0-SNAPSHOT~f6810002f7

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.222 ms) : 0, 683222
BytebuddyAgent [candidate] (680.203 ms) : 0, 680203
GlobalTracer [baseline] (311.253 ms) : 0, 311253
GlobalTracer [candidate] (310.386 ms) : 0, 310386
AppSec [baseline] (53.861 ms) : 0, 53861
AppSec [candidate] (53.989 ms) : 0, 53989
Remote Config [baseline] (675.377 µs) : 0, 675
Remote Config [candidate] (670.289 µs) : 0, 670
Telemetry [baseline] (7.615 ms) : 0, 7615
Telemetry [candidate] (7.55 ms) : 0, 7550
section iast
BytebuddyAgent [baseline] (794.587 ms) : 0, 794587
BytebuddyAgent [candidate] (794.092 ms) : 0, 794092
GlobalTracer [baseline] (299.616 ms) : 0, 299616
GlobalTracer [candidate] (300.018 ms) : 0, 300018
AppSec [baseline] (57.339 ms) : 0, 57339
AppSec [candidate] (55.193 ms) : 0, 55193
Remote Config [baseline] (622.747 µs) : 0, 623
Remote Config [candidate] (599.236 µs) : 0, 599
Telemetry [baseline] (7.398 ms) : 0, 7398
Telemetry [candidate] (7.369 ms) : 0, 7369
IAST [baseline] (21.14 ms) : 0, 21140
IAST [candidate] (23.792 ms) : 0, 23792
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (798.75 ms) : 0, 798750
BytebuddyAgent [candidate] (793.288 ms) : 0, 793288
GlobalTracer [baseline] (301.149 ms) : 0, 301149
GlobalTracer [candidate] (299.234 ms) : 0, 299234
AppSec [baseline] (55.523 ms) : 0, 55523
AppSec [candidate] (53.583 ms) : 0, 53583
Remote Config [baseline] (636.269 µs) : 0, 636
Remote Config [candidate] (609.909 µs) : 0, 610
Telemetry [baseline] (8.262 ms) : 0, 8262
Telemetry [candidate] (8.206 ms) : 0, 8206
IAST [baseline] (23.219 ms) : 0, 23219
IAST [candidate] (24.534 ms) : 0, 24534
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (790.058 ms) : 0, 790058
BytebuddyAgent [candidate] (801.0 ms) : 0, 801000
GlobalTracer [baseline] (300.016 ms) : 0, 300016
GlobalTracer [candidate] (304.066 ms) : 0, 304066
AppSec [baseline] (54.576 ms) : 0, 54576
AppSec [candidate] (54.71 ms) : 0, 54710
Remote Config [baseline] (612.097 µs) : 0, 612
Remote Config [candidate] (2.211 ms) : 0, 2211
Telemetry [baseline] (7.301 ms) : 0, 7301
Telemetry [candidate] (7.55 ms) : 0, 7550
IAST [baseline] (23.379 ms) : 0, 23379
IAST [candidate] (22.853 ms) : 0, 22853
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~cf854f62f6, baseline=1.40.0-SNAPSHOT~f6810002f7

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.07 s) : 0, 1070493
Total [baseline] (10.416 s) : 0, 10416251
Agent [candidate] (1.074 s) : 0, 1074336
Total [candidate] (10.474 s) : 0, 10474426
section appsec
Agent [baseline] (1.211 s) : 0, 1211499
Total [baseline] (10.658 s) : 0, 10657706
Agent [candidate] (1.207 s) : 0, 1206750
Total [candidate] (10.605 s) : 0, 10605240
section iast
Agent [baseline] (1.192 s) : 0, 1191967
Total [baseline] (10.871 s) : 0, 10871099
Agent [candidate] (1.191 s) : 0, 1191257
Total [candidate] (10.848 s) : 0, 10848131
section profiling
Agent [baseline] (1.29 s) : 0, 1289831
Total [baseline] (10.657 s) : 0, 10657400
Agent [candidate] (1.269 s) : 0, 1268674
Total [candidate] (10.659 s) : 0, 10659204
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.07 s -
Agent appsec 1.211 s 141.007 ms (13.2%)
Agent iast 1.192 s 121.475 ms (11.3%)
Agent profiling 1.29 s 219.338 ms (20.5%)
Total tracing 10.416 s -
Total appsec 10.658 s 241.455 ms (2.3%)
Total iast 10.871 s 454.847 ms (4.4%)
Total profiling 10.657 s 241.149 ms (2.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.074 s -
Agent appsec 1.207 s 132.414 ms (12.3%)
Agent iast 1.191 s 116.921 ms (10.9%)
Agent profiling 1.269 s 194.338 ms (18.1%)
Total tracing 10.474 s -
Total appsec 10.605 s 130.815 ms (1.2%)
Total iast 10.848 s 373.705 ms (3.6%)
Total profiling 10.659 s 184.779 ms (1.8%) 
gantt
    title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~cf854f62f6, baseline=1.40.0-SNAPSHOT~f6810002f7

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.952 ms) : 0, 683952
BytebuddyAgent [candidate] (685.297 ms) : 0, 685297
GlobalTracer [baseline] (310.714 ms) : 0, 310714
GlobalTracer [candidate] (312.684 ms) : 0, 312684
AppSec [baseline] (53.755 ms) : 0, 53755
AppSec [candidate] (54.186 ms) : 0, 54186
Remote Config [baseline] (667.803 µs) : 0, 668
Remote Config [candidate] (671.166 µs) : 0, 671
Telemetry [baseline] (7.555 ms) : 0, 7555
Telemetry [candidate] (7.659 ms) : 0, 7659
section appsec
BytebuddyAgent [baseline] (707.828 ms) : 0, 707828
BytebuddyAgent [candidate] (705.473 ms) : 0, 705473
GlobalTracer [baseline] (306.438 ms) : 0, 306438
GlobalTracer [candidate] (305.377 ms) : 0, 305377
AppSec [baseline] (163.443 ms) : 0, 163443
AppSec [candidate] (162.968 ms) : 0, 162968
Remote Config [baseline] (670.81 µs) : 0, 671
Remote Config [candidate] (645.905 µs) : 0, 646
Telemetry [baseline] (8.555 ms) : 0, 8555
Telemetry [candidate] (8.16 ms) : 0, 8160
IAST [baseline] (21.532 ms) : 0, 21532
IAST [candidate] (20.734 ms) : 0, 20734
section iast
BytebuddyAgent [baseline] (792.692 ms) : 0, 792692
BytebuddyAgent [candidate] (791.93 ms) : 0, 791930
GlobalTracer [baseline] (299.251 ms) : 0, 299251
GlobalTracer [candidate] (299.354 ms) : 0, 299354
AppSec [baseline] (55.532 ms) : 0, 55532
AppSec [candidate] (55.143 ms) : 0, 55143
Remote Config [baseline] (614.462 µs) : 0, 614
Remote Config [candidate] (639.07 µs) : 0, 639
Telemetry [baseline] (7.366 ms) : 0, 7366
Telemetry [candidate] (7.46 ms) : 0, 7460
IAST [baseline] (22.769 ms) : 0, 22769
IAST [candidate] (23.021 ms) : 0, 23021
section profiling
BytebuddyAgent [baseline] (687.898 ms) : 0, 687898
BytebuddyAgent [candidate] (674.613 ms) : 0, 674613
GlobalTracer [baseline] (401.705 ms) : 0, 401705
GlobalTracer [candidate] (396.121 ms) : 0, 396121
AppSec [baseline] (55.427 ms) : 0, 55427
AppSec [candidate] (54.75 ms) : 0, 54750
Remote Config [baseline] (670.457 µs) : 0, 670
Remote Config [candidate] (654.646 µs) : 0, 655
Telemetry [baseline] (7.599 ms) : 0, 7599
Telemetry [candidate] (7.461 ms) : 0, 7461
ProfilingAgent [baseline] (97.498 ms) : 0, 97498
ProfilingAgent [candidate] (96.828 ms) : 0, 96828
Profiling [baseline] (97.522 ms) : 0, 97522
Profiling [candidate] (96.851 ms) : 0, 96851
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-09-20T15:02:37 2024-09-20T15:09:27
git_branch master smola/remove-legacy-weblog
git_commit_date 1726843314 1726843766
git_commit_sha f681000 cf854f6
release_version 1.40.0-SNAPSHOT~f6810002f7 1.40.0-SNAPSHOT~cf854f62f6
start_time 2024-09-20T15:02:24 2024-09-20T15:09:13
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1726845312 1726845312
ci_job_id 646618186 646618186
ci_pipeline_id 44800431 44800431
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~cf854f62f6, baseline=1.40.0-SNAPSHOT~f6810002f7
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.335 ms) : 1315, 1355
.   : milestone, 1335,
appsec (1.718 ms) : 1693, 1742
.   : milestone, 1718,
appsec_no_iast (1.728 ms) : 1704, 1752
.   : milestone, 1728,
iast (1.479 ms) : 1457, 1501
.   : milestone, 1479,
profiling (1.48 ms) : 1457, 1502
.   : milestone, 1480,
tracing (1.448 ms) : 1424, 1473
.   : milestone, 1448,
section candidate
no_agent (1.33 ms) : 1310, 1349
.   : milestone, 1330,
appsec (1.726 ms) : 1704, 1748
.   : milestone, 1726,
appsec_no_iast (1.712 ms) : 1687, 1736
.   : milestone, 1712,
iast (1.49 ms) : 1468, 1512
.   : milestone, 1490,
profiling (1.482 ms) : 1459, 1505
.   : milestone, 1482,
tracing (1.464 ms) : 1440, 1489
.   : milestone, 1464,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.335 ms [1.315 ms, 1.355 ms] -
appsec 1.718 ms [1.693 ms, 1.742 ms] 383.162 µs (28.7%)
appsec_no_iast 1.728 ms [1.704 ms, 1.752 ms] 393.212 µs (29.5%)
iast 1.479 ms [1.457 ms, 1.501 ms] 144.445 µs (10.8%)
profiling 1.48 ms [1.457 ms, 1.502 ms] 145.064 µs (10.9%)
tracing 1.448 ms [1.424 ms, 1.473 ms] 113.83 µs (8.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.33 ms [1.31 ms, 1.349 ms] -
appsec 1.726 ms [1.704 ms, 1.748 ms] 396.319 µs (29.8%)
appsec_no_iast 1.712 ms [1.687 ms, 1.736 ms] 381.969 µs (28.7%)
iast 1.49 ms [1.468 ms, 1.512 ms] 160.558 µs (12.1%)
profiling 1.482 ms [1.459 ms, 1.505 ms] 152.127 µs (11.4%)
tracing 1.464 ms [1.44 ms, 1.489 ms] 134.795 µs (10.1%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~cf854f62f6, baseline=1.40.0-SNAPSHOT~f6810002f7
    dateFormat X
    axisFormat %s
section baseline
no_agent (372.132 µs) : 352, 392
.   : milestone, 372,
iast (477.19 µs) : 456, 498
.   : milestone, 477,
iast_FULL (551.961 µs) : 531, 573
.   : milestone, 552,
iast_GLOBAL (507.365 µs) : 486, 529
.   : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (481.998 µs) : 460, 504
.   : milestone, 482,
iast_INACTIVE (450.183 µs) : 429, 472
.   : milestone, 450,
iast_TELEMETRY_OFF (476.866 µs) : 454, 500
.   : milestone, 477,
tracing (443.267 µs) : 423, 464
.   : milestone, 443,
section candidate
no_agent (370.536 µs) : 351, 390
.   : milestone, 371,
iast (476.105 µs) : 455, 497
.   : milestone, 476,
iast_FULL (556.215 µs) : 535, 578
.   : milestone, 556,
iast_GLOBAL (505.119 µs) : 483, 527
.   : milestone, 505,
iast_HARDCODED_SECRET_DISABLED (483.434 µs) : 462, 505
.   : milestone, 483,
iast_INACTIVE (448.366 µs) : 427, 470
.   : milestone, 448,
iast_TELEMETRY_OFF (476.139 µs) : 453, 499
.   : milestone, 476,
tracing (438.922 µs) : 419, 459
.   : milestone, 439,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 372.132 µs [352.499 µs, 391.765 µs] -
iast 477.19 µs [456.055 µs, 498.324 µs] 105.058 µs (28.2%)
iast_FULL 551.961 µs [530.92 µs, 573.002 µs] 179.829 µs (48.3%)
iast_GLOBAL 507.365 µs [485.947 µs, 528.782 µs] 135.232 µs (36.3%)
iast_HARDCODED_SECRET_DISABLED 481.998 µs [460.368 µs, 503.629 µs] 109.866 µs (29.5%)
iast_INACTIVE 450.183 µs [428.666 µs, 471.7 µs] 78.051 µs (21.0%)
iast_TELEMETRY_OFF 476.866 µs [453.731 µs, 500.001 µs] 104.734 µs (28.1%)
tracing 443.267 µs [422.875 µs, 463.66 µs] 71.135 µs (19.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.536 µs [350.666 µs, 390.406 µs] -
iast 476.105 µs [454.993 µs, 497.216 µs] 105.569 µs (28.5%)
iast_FULL 556.215 µs [534.722 µs, 577.709 µs] 185.68 µs (50.1%)
iast_GLOBAL 505.119 µs [482.927 µs, 527.311 µs] 134.583 µs (36.3%)
iast_HARDCODED_SECRET_DISABLED 483.434 µs [462.161 µs, 504.707 µs] 112.898 µs (30.5%)
iast_INACTIVE 448.366 µs [426.912 µs, 469.82 µs] 77.83 µs (21.0%)
iast_TELEMETRY_OFF 476.139 µs [453.281 µs, 498.998 µs] 105.603 µs (28.5%)
tracing 438.922 µs [418.632 µs, 459.212 µs] 68.386 µs (18.5%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master smola/remove-legacy-weblog
git_commit_date 1726843314 1726843766
git_commit_sha f681000 cf854f6
release_version 1.40.0-SNAPSHOT~f6810002f7 1.40.0-SNAPSHOT~cf854f62f6
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1726845833 1726845833
ci_job_id 646618187 646618187
ci_pipeline_id 44800431 44800431
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~cf854f62f6, baseline=1.40.0-SNAPSHOT~f6810002f7
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.084 s) : 15084000, 15084000
.   : milestone, 15084000,
appsec (14.992 s) : 14992000, 14992000
.   : milestone, 14992000,
iast (18.567 s) : 18567000, 18567000
.   : milestone, 18567000,
iast_GLOBAL (17.961 s) : 17961000, 17961000
.   : milestone, 17961000,
profiling (15.187 s) : 15187000, 15187000
.   : milestone, 15187000,
tracing (15.336 s) : 15336000, 15336000
.   : milestone, 15336000,
section candidate
no_agent (15.09 s) : 15090000, 15090000
.   : milestone, 15090000,
appsec (15.303 s) : 15303000, 15303000
.   : milestone, 15303000,
iast (18.791 s) : 18791000, 18791000
.   : milestone, 18791000,
iast_GLOBAL (18.329 s) : 18329000, 18329000
.   : milestone, 18329000,
profiling (15.073 s) : 15073000, 15073000
.   : milestone, 15073000,
tracing (15.221 s) : 15221000, 15221000
.   : milestone, 15221000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.084 s [15.084 s, 15.084 s] -
appsec 14.992 s [14.992 s, 14.992 s] -92.0 ms (-0.6%)
iast 18.567 s [18.567 s, 18.567 s] 3.483 s (23.1%)
iast_GLOBAL 17.961 s [17.961 s, 17.961 s] 2.877 s (19.1%)
profiling 15.187 s [15.187 s, 15.187 s] 103.0 ms (0.7%)
tracing 15.336 s [15.336 s, 15.336 s] 252.0 ms (1.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.09 s [15.09 s, 15.09 s] -
appsec 15.303 s [15.303 s, 15.303 s] 213.0 ms (1.4%)
iast 18.791 s [18.791 s, 18.791 s] 3.701 s (24.5%)
iast_GLOBAL 18.329 s [18.329 s, 18.329 s] 3.239 s (21.5%)
profiling 15.073 s [15.073 s, 15.073 s] -17.0 ms (-0.1%)
tracing 15.221 s [15.221 s, 15.221 s] 131.0 ms (0.9%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~cf854f62f6, baseline=1.40.0-SNAPSHOT~f6810002f7
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.465 ms) : 1454, 1477
.   : milestone, 1465,
appsec (2.309 ms) : 2268, 2350
.   : milestone, 2309,
iast (2.066 ms) : 2015, 2117
.   : milestone, 2066,
iast_GLOBAL (2.094 ms) : 2043, 2145
.   : milestone, 2094,
profiling (1.925 ms) : 1885, 1964
.   : milestone, 1925,
tracing (1.893 ms) : 1855, 1932
.   : milestone, 1893,
section candidate
no_agent (1.465 ms) : 1454, 1477
.   : milestone, 1465,
appsec (2.299 ms) : 2258, 2339
.   : milestone, 2299,
iast (2.053 ms) : 2004, 2103
.   : milestone, 2053,
iast_GLOBAL (2.099 ms) : 2048, 2150
.   : milestone, 2099,
profiling (1.92 ms) : 1881, 1960
.   : milestone, 1920,
tracing (1.895 ms) : 1856, 1933
.   : milestone, 1895,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.465 ms [1.454 ms, 1.477 ms] -
appsec 2.309 ms [2.268 ms, 2.35 ms] 843.87 µs (57.6%)
iast 2.066 ms [2.015 ms, 2.117 ms] 600.166 µs (41.0%)
iast_GLOBAL 2.094 ms [2.043 ms, 2.145 ms] 628.402 µs (42.9%)
profiling 1.925 ms [1.885 ms, 1.964 ms] 459.2 µs (31.3%)
tracing 1.893 ms [1.855 ms, 1.932 ms] 427.762 µs (29.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.465 ms [1.454 ms, 1.477 ms] -
appsec 2.299 ms [2.258 ms, 2.339 ms] 833.696 µs (56.9%)
iast 2.053 ms [2.004 ms, 2.103 ms] 588.388 µs (40.2%)
iast_GLOBAL 2.099 ms [2.048 ms, 2.15 ms] 633.796 µs (43.3%)
profiling 1.92 ms [1.881 ms, 1.96 ms] 455.33 µs (31.1%)
tracing 1.895 ms [1.856 ms, 1.933 ms] 429.527 µs (29.3%)

PerfectSlayer
PerfectSlayer approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean up 🧹

@smola smola marked this pull request as ready for review September 23, 2024 07:13
@smola smola requested review from a team as code owners September 23, 2024 07:13
manuel-alvarez-alvarez
manuel-alvarez-alvarez reviewed Sep 23, 2024
View reviewed changes
...sec/weblog/weblog-common/src/main/java/io/sqreen/testapp/imitation/VulnerableExecutions.java
* @return the evaluation result in string format
* @throws ScriptException
*/
public static String eval(final String valueToEval, String strategy, Object controller)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is interesting for the Q4 OKRs (next to other eval injections in the jvm)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. I expect it to come back in smoke tests, system tests, etc.

@smola smola merged commit 5ca0c5b into master Sep 23, 2024
104 checks passed
@smola smola deleted the smola/remove-legacy-weblog branch September 23, 2024 08:20
@github-actions github-actions bot added this to the 1.40.0 milestone Sep 23, 2024
jordan-wong pushed a commit that referenced this pull request Sep 23, 2024
@smola @jordan-wong
Remove legacy weblog app (#7658)
a1e8378
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jandro996 jandro996 jandro996 approved these changes

@ValentinZakharov ValentinZakharov ValentinZakharov approved these changes

@manuel-alvarez-alvarez manuel-alvarez-alvarez manuel-alvarez-alvarez approved these changes

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@Mariovido Mariovido Awaiting requested review from Mariovido Mariovido is a code owner automatically assigned from DataDog/asm-java

Assignees
No one assigned
Labels
comp: asm waf Application Security Management (WAF) tag: no release notes Changes to exclude from release notes type: refactoring
Projects
None yet
Milestone
1.40.0
Development

Successfully merging this pull request may close these issues.
5 participants
@smola @PerfectSlayer @manuel-alvarez-alvarez @ValentinZakharov @jandro996