-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade testcontainers #7688
Merged
Merged
Upgrade testcontainers #7688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PerfectSlayer
added
tag: no release notes
Changes to exclude from release notes
comp: tooling
Build & Tooling
labels
Sep 26, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~5c40bb68c9, baseline=1.40.0-SNAPSHOT~1392830fdb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1066561
Total [baseline] (8.542 s) : 0, 8542349
Agent [candidate] (1.067 s) : 0, 1067245
Total [candidate] (8.54 s) : 0, 8540468
section iast
Agent [baseline] (1.188 s) : 0, 1187801
Total [baseline] (8.981 s) : 0, 8980846
Agent [candidate] (1.194 s) : 0, 1194399
Total [candidate] (9.08 s) : 0, 9080123
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.199 s) : 0, 1198811
Total [baseline] (9.034 s) : 0, 9034084
Agent [candidate] (1.194 s) : 0, 1193738
Total [candidate] (9.025 s) : 0, 9024903
section iast_TELEMETRY_OFF
Agent [baseline] (1.197 s) : 0, 1197351
Total [baseline] (9.079 s) : 0, 9079416
Agent [candidate] (1.19 s) : 0, 1189927
Total [candidate] (9.072 s) : 0, 9072005
gantt
title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~5c40bb68c9, baseline=1.40.0-SNAPSHOT~1392830fdb
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (680.823 ms) : 0, 680823
BytebuddyAgent [candidate] (681.04 ms) : 0, 681040
GlobalTracer [baseline] (309.896 ms) : 0, 309896
GlobalTracer [candidate] (310.471 ms) : 0, 310471
AppSec [baseline] (53.942 ms) : 0, 53942
AppSec [candidate] (53.817 ms) : 0, 53817
Remote Config [baseline] (675.719 µs) : 0, 676
Remote Config [candidate] (676.583 µs) : 0, 677
Telemetry [baseline] (7.611 ms) : 0, 7611
Telemetry [candidate] (7.599 ms) : 0, 7599
section iast
BytebuddyAgent [baseline] (790.792 ms) : 0, 790792
BytebuddyAgent [candidate] (793.345 ms) : 0, 793345
GlobalTracer [baseline] (297.736 ms) : 0, 297736
GlobalTracer [candidate] (300.094 ms) : 0, 300094
AppSec [baseline] (52.857 ms) : 0, 52857
AppSec [candidate] (53.649 ms) : 0, 53649
IAST [baseline] (25.183 ms) : 0, 25183
IAST [candidate] (24.979 ms) : 0, 24979
Remote Config [baseline] (620.649 µs) : 0, 621
Remote Config [candidate] (618.57 µs) : 0, 619
Telemetry [baseline] (6.964 ms) : 0, 6964
Telemetry [candidate] (7.979 ms) : 0, 7979
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (798.174 ms) : 0, 798174
BytebuddyAgent [candidate] (794.167 ms) : 0, 794167
GlobalTracer [baseline] (300.259 ms) : 0, 300259
GlobalTracer [candidate] (299.294 ms) : 0, 299294
AppSec [baseline] (53.538 ms) : 0, 53538
AppSec [candidate] (55.946 ms) : 0, 55946
IAST [baseline] (25.456 ms) : 0, 25456
IAST [candidate] (22.843 ms) : 0, 22843
Remote Config [baseline] (613.681 µs) : 0, 614
Remote Config [candidate] (649.823 µs) : 0, 650
Telemetry [baseline] (7.053 ms) : 0, 7053
Telemetry [candidate] (7.103 ms) : 0, 7103
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (795.57 ms) : 0, 795570
BytebuddyAgent [candidate] (790.183 ms) : 0, 790183
GlobalTracer [baseline] (300.98 ms) : 0, 300980
GlobalTracer [candidate] (299.651 ms) : 0, 299651
AppSec [baseline] (55.499 ms) : 0, 55499
AppSec [candidate] (56.142 ms) : 0, 56142
IAST [baseline] (23.834 ms) : 0, 23834
IAST [candidate] (22.605 ms) : 0, 22605
Remote Config [baseline] (649.128 µs) : 0, 649
Remote Config [candidate] (620.783 µs) : 0, 621
Telemetry [baseline] (7.084 ms) : 0, 7084
Telemetry [candidate] (6.991 ms) : 0, 6991
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~5c40bb68c9, baseline=1.40.0-SNAPSHOT~1392830fdb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1064898
Total [baseline] (10.407 s) : 0, 10407472
Agent [candidate] (1.073 s) : 0, 1073082
Total [candidate] (10.443 s) : 0, 10442506
section appsec
Agent [baseline] (1.208 s) : 0, 1207722
Total [baseline] (10.673 s) : 0, 10672591
Agent [candidate] (1.202 s) : 0, 1201911
Total [candidate] (10.588 s) : 0, 10587904
section iast
Agent [baseline] (1.191 s) : 0, 1190882
Total [baseline] (10.933 s) : 0, 10932722
Agent [candidate] (1.189 s) : 0, 1189493
Total [candidate] (10.84 s) : 0, 10840175
section profiling
Agent [baseline] (1.266 s) : 0, 1265571
Total [baseline] (10.611 s) : 0, 10611458
Agent [candidate] (1.271 s) : 0, 1270998
Total [candidate] (10.584 s) : 0, 10584328
gantt
title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~5c40bb68c9, baseline=1.40.0-SNAPSHOT~1392830fdb
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (679.843 ms) : 0, 679843
BytebuddyAgent [candidate] (684.776 ms) : 0, 684776
GlobalTracer [baseline] (309.443 ms) : 0, 309443
GlobalTracer [candidate] (311.833 ms) : 0, 311833
AppSec [baseline] (53.758 ms) : 0, 53758
AppSec [candidate] (54.406 ms) : 0, 54406
Remote Config [baseline] (669.098 µs) : 0, 669
Remote Config [candidate] (671.439 µs) : 0, 671
Telemetry [baseline] (7.637 ms) : 0, 7637
Telemetry [candidate] (7.698 ms) : 0, 7698
section appsec
BytebuddyAgent [baseline] (705.965 ms) : 0, 705965
BytebuddyAgent [candidate] (703.264 ms) : 0, 703264
GlobalTracer [baseline] (304.903 ms) : 0, 304903
GlobalTracer [candidate] (303.398 ms) : 0, 303398
AppSec [baseline] (163.607 ms) : 0, 163607
AppSec [candidate] (163.306 ms) : 0, 163306
IAST [baseline] (20.754 ms) : 0, 20754
IAST [candidate] (19.825 ms) : 0, 19825
Remote Config [baseline] (655.607 µs) : 0, 656
Remote Config [candidate] (638.627 µs) : 0, 639
Telemetry [baseline] (8.556 ms) : 0, 8556
Telemetry [candidate] (7.772 ms) : 0, 7772
section iast
BytebuddyAgent [baseline] (792.559 ms) : 0, 792559
BytebuddyAgent [candidate] (791.94 ms) : 0, 791940
GlobalTracer [baseline] (298.513 ms) : 0, 298513
GlobalTracer [candidate] (298.41 ms) : 0, 298410
AppSec [baseline] (54.812 ms) : 0, 54812
AppSec [candidate] (55.177 ms) : 0, 55177
IAST [baseline] (23.737 ms) : 0, 23737
IAST [candidate] (22.717 ms) : 0, 22717
Remote Config [baseline] (625.293 µs) : 0, 625
Remote Config [candidate] (624.176 µs) : 0, 624
Telemetry [baseline] (7.014 ms) : 0, 7014
Telemetry [candidate] (7.025 ms) : 0, 7025
section profiling
BytebuddyAgent [baseline] (675.626 ms) : 0, 675626
BytebuddyAgent [candidate] (679.087 ms) : 0, 679087
GlobalTracer [baseline] (392.773 ms) : 0, 392773
GlobalTracer [candidate] (392.962 ms) : 0, 392962
AppSec [baseline] (54.641 ms) : 0, 54641
AppSec [candidate] (55.161 ms) : 0, 55161
Remote Config [baseline] (651.936 µs) : 0, 652
Remote Config [candidate] (658.872 µs) : 0, 659
Telemetry [baseline] (7.422 ms) : 0, 7422
Telemetry [candidate] (7.483 ms) : 0, 7483
ProfilingAgent [baseline] (95.967 ms) : 0, 95967
ProfilingAgent [candidate] (96.86 ms) : 0, 96860
Profiling [baseline] (95.99 ms) : 0, 95990
Profiling [candidate] (96.884 ms) : 0, 96884
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~5c40bb68c9, baseline=1.40.0-SNAPSHOT~1392830fdb
dateFormat X
axisFormat %s
section baseline
no_agent (1.344 ms) : 1325, 1364
. : milestone, 1344,
appsec (1.723 ms) : 1699, 1747
. : milestone, 1723,
appsec_no_iast (1.722 ms) : 1697, 1747
. : milestone, 1722,
iast (1.469 ms) : 1446, 1492
. : milestone, 1469,
profiling (1.469 ms) : 1444, 1494
. : milestone, 1469,
tracing (1.454 ms) : 1430, 1479
. : milestone, 1454,
section candidate
no_agent (1.333 ms) : 1313, 1352
. : milestone, 1333,
appsec (1.688 ms) : 1664, 1711
. : milestone, 1688,
appsec_no_iast (1.695 ms) : 1671, 1719
. : milestone, 1695,
iast (1.464 ms) : 1442, 1486
. : milestone, 1464,
profiling (1.466 ms) : 1442, 1490
. : milestone, 1466,
tracing (1.452 ms) : 1428, 1477
. : milestone, 1452,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~5c40bb68c9, baseline=1.40.0-SNAPSHOT~1392830fdb
dateFormat X
axisFormat %s
section baseline
no_agent (369.315 µs) : 350, 389
. : milestone, 369,
iast (487.498 µs) : 466, 509
. : milestone, 487,
iast_FULL (553.011 µs) : 532, 574
. : milestone, 553,
iast_GLOBAL (503.838 µs) : 482, 526
. : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (486.161 µs) : 465, 508
. : milestone, 486,
iast_INACTIVE (441.685 µs) : 421, 463
. : milestone, 442,
iast_TELEMETRY_OFF (468.207 µs) : 446, 491
. : milestone, 468,
tracing (436.808 µs) : 417, 457
. : milestone, 437,
section candidate
no_agent (368.214 µs) : 348, 389
. : milestone, 368,
iast (481.578 µs) : 460, 503
. : milestone, 482,
iast_FULL (551.11 µs) : 530, 573
. : milestone, 551,
iast_GLOBAL (500.086 µs) : 479, 521
. : milestone, 500,
iast_HARDCODED_SECRET_DISABLED (479.929 µs) : 458, 501
. : milestone, 480,
iast_INACTIVE (442.164 µs) : 422, 463
. : milestone, 442,
iast_TELEMETRY_OFF (475.088 µs) : 452, 498
. : milestone, 475,
tracing (440.826 µs) : 420, 461
. : milestone, 441,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~5c40bb68c9, baseline=1.40.0-SNAPSHOT~1392830fdb
dateFormat X
axisFormat %s
section baseline
no_agent (15.158 s) : 15158000, 15158000
. : milestone, 15158000,
appsec (15.14 s) : 15140000, 15140000
. : milestone, 15140000,
iast (18.806 s) : 18806000, 18806000
. : milestone, 18806000,
iast_GLOBAL (18.262 s) : 18262000, 18262000
. : milestone, 18262000,
profiling (15.128 s) : 15128000, 15128000
. : milestone, 15128000,
tracing (14.988 s) : 14988000, 14988000
. : milestone, 14988000,
section candidate
no_agent (14.92 s) : 14920000, 14920000
. : milestone, 14920000,
appsec (15.049 s) : 15049000, 15049000
. : milestone, 15049000,
iast (18.516 s) : 18516000, 18516000
. : milestone, 18516000,
iast_GLOBAL (17.883 s) : 17883000, 17883000
. : milestone, 17883000,
profiling (14.886 s) : 14886000, 14886000
. : milestone, 14886000,
tracing (15.329 s) : 15329000, 15329000
. : milestone, 15329000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~5c40bb68c9, baseline=1.40.0-SNAPSHOT~1392830fdb
dateFormat X
axisFormat %s
section baseline
no_agent (1.462 ms) : 1451, 1474
. : milestone, 1462,
appsec (2.327 ms) : 2287, 2368
. : milestone, 2327,
iast (2.07 ms) : 2019, 2120
. : milestone, 2070,
iast_GLOBAL (2.1 ms) : 2049, 2150
. : milestone, 2100,
profiling (1.923 ms) : 1883, 1963
. : milestone, 1923,
tracing (1.891 ms) : 1853, 1928
. : milestone, 1891,
section candidate
no_agent (1.459 ms) : 1448, 1470
. : milestone, 1459,
appsec (2.296 ms) : 2256, 2337
. : milestone, 2296,
iast (2.05 ms) : 2000, 2100
. : milestone, 2050,
iast_GLOBAL (2.103 ms) : 2052, 2155
. : milestone, 2103,
profiling (1.912 ms) : 1872, 1951
. : milestone, 1912,
tracing (1.896 ms) : 1858, 1934
. : milestone, 1896,
|
amarziali
approved these changes
Sep 27, 2024
smola
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: tooling
Build & Tooling
tag: dependencies
Dependencies related changes
tag: no release notes
Changes to exclude from release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR upgrades testcontainers and makes sure every module use the project ones.
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]