Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove internal dd.trace.scope.inherit.async.propagation feature flag #7958

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Remove internal dd.trace.scope.inherit.async.propagation feature flag #7958

merged 1 commit into from
Nov 15, 2024

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Nov 14, 2024 •
edited
Loading

What Does This Do

Removes the internal dd.trace.scope.inherit.async.propagation feature flag, which has always defaulted to true

Motivation

This flag was added in #1850 (v0.64.0) in case we needed to revert the fixed behaviour, but we have never needed to do that. Removing it simplifies some of the code and helps with future refactoring.

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@mcculls
Remove old internal feature-flag to help simplify the scope code.
6a10d2c 
This flag was added in #1850 (v0.64.0) in case we needed to revert the new behaviour, but we have never needed to do that.
@mcculls mcculls changed the title Remove old internal feature-flag to help simplify the scope code. Remove internal dd.trace.scope.inherit.async.propagation feature flag Nov 14, 2024
@mcculls mcculls changed the title Remove internal dd.trace.scope.inherit.async.propagation feature flag Remove internal dd.trace.scope.inherit.async.propagation feature flag Nov 14, 2024
@pr-commenter
Copy link

pr-commenter bot commented Nov 14, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/remove-inherit-async-propagation-flag
git_commit_date 1731601861 1731603262
git_commit_sha 105c9dc 6a10d2c
release_version 1.43.0-SNAPSHOT~105c9dc224 1.43.0-SNAPSHOT~6a10d2c35b
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1731605761 1731605761
ci_job_id 707386628 707386628
ci_pipeline_id 49042223 49042223
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 9 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~6a10d2c35b, baseline=1.43.0-SNAPSHOT~105c9dc224

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.092 s) : 0, 1091777
Total [baseline] (8.607 s) : 0, 8606991
Agent [candidate] (1.086 s) : 0, 1085913
Total [candidate] (8.579 s) : 0, 8579307
section iast
Agent [baseline] (1.221 s) : 0, 1220837
Total [baseline] (9.211 s) : 0, 9210849
Agent [candidate] (1.212 s) : 0, 1211687
Total [candidate] (9.14 s) : 0, 9140239
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.21 s) : 0, 1210162
Total [baseline] (9.115 s) : 0, 9114714
Agent [candidate] (1.22 s) : 0, 1219693
Total [candidate] (9.174 s) : 0, 9173569
section iast_TELEMETRY_OFF
Agent [baseline] (1.214 s) : 0, 1214262
Total [baseline] (9.171 s) : 0, 9170886
Agent [candidate] (1.225 s) : 0, 1225261
Total [candidate] (9.168 s) : 0, 9168269
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.092 s -
Agent iast 1.221 s 129.06 ms (11.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.21 s 118.385 ms (10.8%)
Agent iast_TELEMETRY_OFF 1.214 s 122.485 ms (11.2%)
Total tracing 8.607 s -
Total iast 9.211 s 603.858 ms (7.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.115 s 507.723 ms (5.9%)
Total iast_TELEMETRY_OFF 9.171 s 563.895 ms (6.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.086 s -
Agent iast 1.212 s 125.774 ms (11.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.22 s 133.78 ms (12.3%)
Agent iast_TELEMETRY_OFF 1.225 s 139.347 ms (12.8%)
Total tracing 8.579 s -
Total iast 9.14 s 560.932 ms (6.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.174 s 594.261 ms (6.9%)
Total iast_TELEMETRY_OFF 9.168 s 588.962 ms (6.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~6a10d2c35b, baseline=1.43.0-SNAPSHOT~105c9dc224

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (693.985 ms) : 0, 693985
BytebuddyAgent [candidate] (689.283 ms) : 0, 689283
GlobalTracer [baseline] (317.184 ms) : 0, 317184
GlobalTracer [candidate] (317.066 ms) : 0, 317066
AppSec [baseline] (54.52 ms) : 0, 54520
AppSec [candidate] (54.392 ms) : 0, 54392
Remote Config [baseline] (697.407 µs) : 0, 697
Remote Config [candidate] (679.365 µs) : 0, 679
Telemetry [baseline] (11.482 ms) : 0, 11482
Telemetry [candidate] (10.657 ms) : 0, 10657
section iast
BytebuddyAgent [baseline] (811.545 ms) : 0, 811545
BytebuddyAgent [candidate] (805.205 ms) : 0, 805205
GlobalTracer [baseline] (307.618 ms) : 0, 307618
GlobalTracer [candidate] (305.96 ms) : 0, 305960
AppSec [baseline] (57.713 ms) : 0, 57713
AppSec [candidate] (57.707 ms) : 0, 57707
IAST [baseline] (21.76 ms) : 0, 21760
IAST [candidate] (20.767 ms) : 0, 20767
Remote Config [baseline] (628.137 µs) : 0, 628
Remote Config [candidate] (618.194 µs) : 0, 618
Telemetry [baseline] (7.644 ms) : 0, 7644
Telemetry [candidate] (7.553 ms) : 0, 7553
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (804.064 ms) : 0, 804064
BytebuddyAgent [candidate] (810.27 ms) : 0, 810270
GlobalTracer [baseline] (305.936 ms) : 0, 305936
GlobalTracer [candidate] (307.888 ms) : 0, 307888
AppSec [baseline] (57.49 ms) : 0, 57490
AppSec [candidate] (58.17 ms) : 0, 58170
IAST [baseline] (20.624 ms) : 0, 20624
IAST [candidate] (21.088 ms) : 0, 21088
Remote Config [baseline] (638.292 µs) : 0, 638
Remote Config [candidate] (628.305 µs) : 0, 628
Telemetry [baseline] (7.598 ms) : 0, 7598
Telemetry [candidate] (7.724 ms) : 0, 7724
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (806.429 ms) : 0, 806429
BytebuddyAgent [candidate] (813.868 ms) : 0, 813868
GlobalTracer [baseline] (307.145 ms) : 0, 307145
GlobalTracer [candidate] (309.314 ms) : 0, 309314
AppSec [baseline] (58.229 ms) : 0, 58229
AppSec [candidate] (58.401 ms) : 0, 58401
IAST [baseline] (20.498 ms) : 0, 20498
IAST [candidate] (21.45 ms) : 0, 21450
Remote Config [baseline] (622.758 µs) : 0, 623
Remote Config [candidate] (629.861 µs) : 0, 630
Telemetry [baseline] (7.416 ms) : 0, 7416
Telemetry [candidate] (7.581 ms) : 0, 7581
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~6a10d2c35b, baseline=1.43.0-SNAPSHOT~105c9dc224

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1086311
Total [baseline] (10.384 s) : 0, 10383829
Agent [candidate] (1.086 s) : 0, 1085913
Total [candidate] (10.411 s) : 0, 10411337
section appsec
Agent [baseline] (1.218 s) : 0, 1217934
Total [baseline] (10.741 s) : 0, 10740793
Agent [candidate] (1.218 s) : 0, 1218318
Total [candidate] (10.735 s) : 0, 10734955
section iast
Agent [baseline] (1.212 s) : 0, 1211945
Total [baseline] (10.884 s) : 0, 10884430
Agent [candidate] (1.216 s) : 0, 1216362
Total [candidate] (10.876 s) : 0, 10876335
section profiling
Agent [baseline] (1.289 s) : 0, 1289315
Total [baseline] (10.775 s) : 0, 10774809
Agent [candidate] (1.28 s) : 0, 1280496
Total [candidate] (10.759 s) : 0, 10758978
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.086 s -
Agent appsec 1.218 s 131.624 ms (12.1%)
Agent iast 1.212 s 125.634 ms (11.6%)
Agent profiling 1.289 s 203.004 ms (18.7%)
Total tracing 10.384 s -
Total appsec 10.741 s 356.964 ms (3.4%)
Total iast 10.884 s 500.601 ms (4.8%)
Total profiling 10.775 s 390.98 ms (3.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.086 s -
Agent appsec 1.218 s 132.404 ms (12.2%)
Agent iast 1.216 s 130.449 ms (12.0%)
Agent profiling 1.28 s 194.583 ms (17.9%)
Total tracing 10.411 s -
Total appsec 10.735 s 323.618 ms (3.1%)
Total iast 10.876 s 464.998 ms (4.5%)
Total profiling 10.759 s 347.641 ms (3.3%) 
gantt
    title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~6a10d2c35b, baseline=1.43.0-SNAPSHOT~105c9dc224

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (689.508 ms) : 0, 689508
BytebuddyAgent [candidate] (688.993 ms) : 0, 688993
GlobalTracer [baseline] (317.155 ms) : 0, 317155
GlobalTracer [candidate] (317.068 ms) : 0, 317068
AppSec [baseline] (54.438 ms) : 0, 54438
AppSec [candidate] (54.612 ms) : 0, 54612
Remote Config [baseline] (674.847 µs) : 0, 675
Remote Config [candidate] (691.358 µs) : 0, 691
Telemetry [baseline] (10.699 ms) : 0, 10699
Telemetry [candidate] (10.752 ms) : 0, 10752
section appsec
BytebuddyAgent [baseline] (705.353 ms) : 0, 705353
BytebuddyAgent [candidate] (705.803 ms) : 0, 705803
GlobalTracer [baseline] (313.98 ms) : 0, 313980
GlobalTracer [candidate] (314.052 ms) : 0, 314052
AppSec [baseline] (166.626 ms) : 0, 166626
AppSec [candidate] (166.095 ms) : 0, 166095
Remote Config [baseline] (631.674 µs) : 0, 632
Remote Config [candidate] (637.529 µs) : 0, 638
Telemetry [baseline] (7.817 ms) : 0, 7817
Telemetry [candidate] (8.183 ms) : 0, 8183
IAST [baseline] (19.551 ms) : 0, 19551
IAST [candidate] (19.517 ms) : 0, 19517
section iast
BytebuddyAgent [baseline] (805.134 ms) : 0, 805134
BytebuddyAgent [candidate] (808.042 ms) : 0, 808042
GlobalTracer [baseline] (306.0 ms) : 0, 306000
GlobalTracer [candidate] (307.559 ms) : 0, 307559
AppSec [baseline] (56.4 ms) : 0, 56400
AppSec [candidate] (56.954 ms) : 0, 56954
Remote Config [baseline] (609.544 µs) : 0, 610
Remote Config [candidate] (624.422 µs) : 0, 624
Telemetry [baseline] (7.556 ms) : 0, 7556
Telemetry [candidate] (7.545 ms) : 0, 7545
IAST [baseline] (22.421 ms) : 0, 22421
IAST [candidate] (21.733 ms) : 0, 21733
section profiling
BytebuddyAgent [baseline] (686.364 ms) : 0, 686364
BytebuddyAgent [candidate] (681.685 ms) : 0, 681685
GlobalTracer [baseline] (402.649 ms) : 0, 402649
GlobalTracer [candidate] (399.67 ms) : 0, 399670
AppSec [baseline] (55.059 ms) : 0, 55059
AppSec [candidate] (54.795 ms) : 0, 54795
Remote Config [baseline] (675.411 µs) : 0, 675
Remote Config [candidate] (670.915 µs) : 0, 671
Telemetry [baseline] (14.7 ms) : 0, 14700
Telemetry [candidate] (12.722 ms) : 0, 12722
ProfilingAgent [baseline] (90.419 ms) : 0, 90419
ProfilingAgent [candidate] (91.919 ms) : 0, 91919
Profiling [baseline] (90.443 ms) : 0, 90443
Profiling [candidate] (91.942 ms) : 0, 91942
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-11-14T17:06:17 2024-11-14T17:13:13
git_branch master mcculls/remove-inherit-async-propagation-flag
git_commit_date 1731601861 1731603262
git_commit_sha 105c9dc 6a10d2c
release_version 1.43.0-SNAPSHOT~105c9dc224 1.43.0-SNAPSHOT~6a10d2c35b
start_time 2024-11-14T17:06:04 2024-11-14T17:13:00
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1731604744 1731604744
ci_job_id 707386629 707386629
ci_pipeline_id 49042223 49042223
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~6a10d2c35b, baseline=1.43.0-SNAPSHOT~105c9dc224
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.348 ms) : 1329, 1367
.   : milestone, 1348,
appsec (1.753 ms) : 1730, 1775
.   : milestone, 1753,
appsec_no_iast (1.76 ms) : 1735, 1784
.   : milestone, 1760,
iast (1.491 ms) : 1468, 1513
.   : milestone, 1491,
profiling (1.491 ms) : 1468, 1514
.   : milestone, 1491,
tracing (1.467 ms) : 1442, 1492
.   : milestone, 1467,
section candidate
no_agent (1.345 ms) : 1326, 1364
.   : milestone, 1345,
appsec (1.74 ms) : 1715, 1765
.   : milestone, 1740,
appsec_no_iast (1.727 ms) : 1703, 1752
.   : milestone, 1727,
iast (1.489 ms) : 1467, 1511
.   : milestone, 1489,
profiling (1.513 ms) : 1489, 1538
.   : milestone, 1513,
tracing (1.485 ms) : 1461, 1509
.   : milestone, 1485,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.348 ms [1.329 ms, 1.367 ms] -
appsec 1.753 ms [1.73 ms, 1.775 ms] 404.486 µs (30.0%)
appsec_no_iast 1.76 ms [1.735 ms, 1.784 ms] 411.402 µs (30.5%)
iast 1.491 ms [1.468 ms, 1.513 ms] 142.504 µs (10.6%)
profiling 1.491 ms [1.468 ms, 1.514 ms] 142.807 µs (10.6%)
tracing 1.467 ms [1.442 ms, 1.492 ms] 118.788 µs (8.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.345 ms [1.326 ms, 1.364 ms] -
appsec 1.74 ms [1.715 ms, 1.765 ms] 394.876 µs (29.4%)
appsec_no_iast 1.727 ms [1.703 ms, 1.752 ms] 382.369 µs (28.4%)
iast 1.489 ms [1.467 ms, 1.511 ms] 144.189 µs (10.7%)
profiling 1.513 ms [1.489 ms, 1.538 ms] 168.418 µs (12.5%)
tracing 1.485 ms [1.461 ms, 1.509 ms] 139.971 µs (10.4%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~6a10d2c35b, baseline=1.43.0-SNAPSHOT~105c9dc224
    dateFormat X
    axisFormat %s
section baseline
no_agent (369.892 µs) : 350, 390
.   : milestone, 370,
iast (488.567 µs) : 467, 510
.   : milestone, 489,
iast_FULL (647.863 µs) : 626, 669
.   : milestone, 648,
iast_GLOBAL (509.067 µs) : 488, 530
.   : milestone, 509,
iast_HARDCODED_SECRET_DISABLED (483.616 µs) : 463, 505
.   : milestone, 484,
iast_INACTIVE (453.59 µs) : 432, 475
.   : milestone, 454,
iast_TELEMETRY_OFF (475.059 µs) : 454, 496
.   : milestone, 475,
tracing (458.877 µs) : 438, 480
.   : milestone, 459,
section candidate
no_agent (370.622 µs) : 351, 390
.   : milestone, 371,
iast (487.378 µs) : 466, 509
.   : milestone, 487,
iast_FULL (647.646 µs) : 626, 669
.   : milestone, 648,
iast_GLOBAL (510.55 µs) : 489, 532
.   : milestone, 511,
iast_HARDCODED_SECRET_DISABLED (483.225 µs) : 462, 504
.   : milestone, 483,
iast_INACTIVE (452.612 µs) : 432, 474
.   : milestone, 453,
iast_TELEMETRY_OFF (477.235 µs) : 456, 499
.   : milestone, 477,
tracing (445.901 µs) : 426, 466
.   : milestone, 446,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 369.892 µs [350.214 µs, 389.569 µs] -
iast 488.567 µs [467.226 µs, 509.908 µs] 118.675 µs (32.1%)
iast_FULL 647.863 µs [626.41 µs, 669.315 µs] 277.971 µs (75.1%)
iast_GLOBAL 509.067 µs [488.072 µs, 530.063 µs] 139.176 µs (37.6%)
iast_HARDCODED_SECRET_DISABLED 483.616 µs [462.554 µs, 504.678 µs] 113.725 µs (30.7%)
iast_INACTIVE 453.59 µs [431.798 µs, 475.383 µs] 83.699 µs (22.6%)
iast_TELEMETRY_OFF 475.059 µs [454.005 µs, 496.113 µs] 105.167 µs (28.4%)
tracing 458.877 µs [437.787 µs, 479.968 µs] 88.986 µs (24.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.622 µs [351.284 µs, 389.959 µs] -
iast 487.378 µs [466.128 µs, 508.627 µs] 116.756 µs (31.5%)
iast_FULL 647.646 µs [625.908 µs, 669.385 µs] 277.025 µs (74.7%)
iast_GLOBAL 510.55 µs [489.167 µs, 531.932 µs] 139.928 µs (37.8%)
iast_HARDCODED_SECRET_DISABLED 483.225 µs [462.22 µs, 504.229 µs] 112.603 µs (30.4%)
iast_INACTIVE 452.612 µs [431.679 µs, 473.545 µs] 81.991 µs (22.1%)
iast_TELEMETRY_OFF 477.235 µs [455.776 µs, 498.694 µs] 106.614 µs (28.8%)
tracing 445.901 µs [425.539 µs, 466.263 µs] 75.279 µs (20.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/remove-inherit-async-propagation-flag
git_commit_date 1731601861 1731603262
git_commit_sha 105c9dc 6a10d2c
release_version 1.43.0-SNAPSHOT~105c9dc224 1.43.0-SNAPSHOT~6a10d2c35b
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1731605271 1731605271
ci_job_id 707386631 707386631
ci_pipeline_id 49042223 49042223
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~6a10d2c35b, baseline=1.43.0-SNAPSHOT~105c9dc224
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.606 s) : 15606000, 15606000
.   : milestone, 15606000,
appsec (15.152 s) : 15152000, 15152000
.   : milestone, 15152000,
iast (18.88 s) : 18880000, 18880000
.   : milestone, 18880000,
iast_GLOBAL (18.155 s) : 18155000, 18155000
.   : milestone, 18155000,
profiling (15.578 s) : 15578000, 15578000
.   : milestone, 15578000,
tracing (15.179 s) : 15179000, 15179000
.   : milestone, 15179000,
section candidate
no_agent (14.804 s) : 14804000, 14804000
.   : milestone, 14804000,
appsec (15.159 s) : 15159000, 15159000
.   : milestone, 15159000,
iast (18.706 s) : 18706000, 18706000
.   : milestone, 18706000,
iast_GLOBAL (18.101 s) : 18101000, 18101000
.   : milestone, 18101000,
profiling (14.86 s) : 14860000, 14860000
.   : milestone, 14860000,
tracing (15.176 s) : 15176000, 15176000
.   : milestone, 15176000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.606 s [15.606 s, 15.606 s] -
appsec 15.152 s [15.152 s, 15.152 s] -454.0 ms (-2.9%)
iast 18.88 s [18.88 s, 18.88 s] 3.274 s (21.0%)
iast_GLOBAL 18.155 s [18.155 s, 18.155 s] 2.549 s (16.3%)
profiling 15.578 s [15.578 s, 15.578 s] -28.0 ms (-0.2%)
tracing 15.179 s [15.179 s, 15.179 s] -427.0 ms (-2.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.804 s [14.804 s, 14.804 s] -
appsec 15.159 s [15.159 s, 15.159 s] 355.0 ms (2.4%)
iast 18.706 s [18.706 s, 18.706 s] 3.902 s (26.4%)
iast_GLOBAL 18.101 s [18.101 s, 18.101 s] 3.297 s (22.3%)
profiling 14.86 s [14.86 s, 14.86 s] 56.0 ms (0.4%)
tracing 15.176 s [15.176 s, 15.176 s] 372.0 ms (2.5%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~6a10d2c35b, baseline=1.43.0-SNAPSHOT~105c9dc224
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.461 ms) : 1450, 1472
.   : milestone, 1461,
appsec (2.32 ms) : 2279, 2361
.   : milestone, 2320,
iast (2.071 ms) : 2019, 2123
.   : milestone, 2071,
iast_GLOBAL (2.115 ms) : 2063, 2168
.   : milestone, 2115,
profiling (1.929 ms) : 1887, 1970
.   : milestone, 1929,
tracing (1.919 ms) : 1879, 1959
.   : milestone, 1919,
section candidate
no_agent (1.464 ms) : 1453, 1475
.   : milestone, 1464,
appsec (2.33 ms) : 2289, 2372
.   : milestone, 2330,
iast (2.066 ms) : 2014, 2118
.   : milestone, 2066,
iast_GLOBAL (2.124 ms) : 2072, 2176
.   : milestone, 2124,
profiling (1.948 ms) : 1904, 1991
.   : milestone, 1948,
tracing (1.919 ms) : 1879, 1958
.   : milestone, 1919,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.461 ms [1.45 ms, 1.472 ms] -
appsec 2.32 ms [2.279 ms, 2.361 ms] 859.214 µs (58.8%)
iast 2.071 ms [2.019 ms, 2.123 ms] 609.626 µs (41.7%)
iast_GLOBAL 2.115 ms [2.063 ms, 2.168 ms] 654.246 µs (44.8%)
profiling 1.929 ms [1.887 ms, 1.97 ms] 467.596 µs (32.0%)
tracing 1.919 ms [1.879 ms, 1.959 ms] 458.121 µs (31.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.464 ms [1.453 ms, 1.475 ms] -
appsec 2.33 ms [2.289 ms, 2.372 ms] 866.391 µs (59.2%)
iast 2.066 ms [2.014 ms, 2.118 ms] 602.242 µs (41.1%)
iast_GLOBAL 2.124 ms [2.072 ms, 2.176 ms] 660.226 µs (45.1%)
profiling 1.948 ms [1.904 ms, 1.991 ms] 483.739 µs (33.0%)
tracing 1.919 ms [1.879 ms, 1.958 ms] 454.614 µs (31.1%)

@mcculls mcculls marked this pull request as ready for review November 14, 2024 18:22
@mcculls mcculls requested review from a team as code owners November 14, 2024 18:22
@mcculls mcculls requested a review from amarziali November 14, 2024 18:22
amarziali
amarziali approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@amarziali amarziali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup

@mcculls mcculls merged commit 92eab56 into master Nov 15, 2024
115 checks passed
@mcculls mcculls deleted the mcculls/remove-inherit-async-propagation-flag branch November 15, 2024 09:44
@github-actions github-actions bot added this to the 1.43.0 milestone Nov 15, 2024
@mcculls mcculls added the tag: no release notes Changes to exclude from release notes label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarziali amarziali amarziali approved these changes

Assignees
No one assigned
Labels
comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring
Projects
None yet
Milestone
1.43.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mcculls @amarziali