Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test name uniqueness #7960

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Fix test name uniqueness #7960

merged 1 commit into from
Nov 19, 2024

Conversation

PerfectSlayer
Copy link
Contributor

@PerfectSlayer PerfectSlayer commented Nov 14, 2024 •
edited
Loading

What Does This Do

This PR fixes test name uniqueness.

Motivation

This will help with CI monitoring to keep track of test execution.

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@PerfectSlayer PerfectSlayer requested review from a team as code owners November 14, 2024 17:43
@PerfectSlayer PerfectSlayer added comp: testing Testing tag: no release notes Changes to exclude from release notes labels Nov 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@PerfectSlayer PerfectSlayer enabled auto-merge (squash) November 14, 2024 17:53
@pr-commenter
Copy link

pr-commenter bot commented Nov 14, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/ci
git_commit_date 1731601861 1731606148
git_commit_sha 105c9dc 87d8c80
release_version 1.43.0-SNAPSHOT~105c9dc224 1.43.0-SNAPSHOT~87d8c80453
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1731608526 1731608526
ci_job_id 707494464 707494464
ci_pipeline_id 49052533 49052533
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~87d8c80453, baseline=1.43.0-SNAPSHOT~105c9dc224

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.078 s) : 0, 1078178
Total [baseline] (8.549 s) : 0, 8548527
Agent [candidate] (1.086 s) : 0, 1086203
Total [candidate] (8.591 s) : 0, 8590869
section iast
Agent [baseline] (1.208 s) : 0, 1207611
Total [baseline] (9.152 s) : 0, 9151535
Agent [candidate] (1.203 s) : 0, 1203393
Total [candidate] (9.109 s) : 0, 9108884
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.206 s) : 0, 1206234
Total [baseline] (9.084 s) : 0, 9083920
Agent [candidate] (1.216 s) : 0, 1215698
Total [candidate] (9.108 s) : 0, 9107985
section iast_TELEMETRY_OFF
Agent [baseline] (1.199 s) : 0, 1198599
Total [baseline] (9.106 s) : 0, 9106115
Agent [candidate] (1.202 s) : 0, 1202050
Total [candidate] (9.133 s) : 0, 9133126
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.078 s -
Agent iast 1.208 s 129.433 ms (12.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.206 s 128.056 ms (11.9%)
Agent iast_TELEMETRY_OFF 1.199 s 120.42 ms (11.2%)
Total tracing 8.549 s -
Total iast 9.152 s 603.007 ms (7.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.084 s 535.393 ms (6.3%)
Total iast_TELEMETRY_OFF 9.106 s 557.588 ms (6.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.086 s -
Agent iast 1.203 s 117.19 ms (10.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.216 s 129.495 ms (11.9%)
Agent iast_TELEMETRY_OFF 1.202 s 115.847 ms (10.7%)
Total tracing 8.591 s -
Total iast 9.109 s 518.015 ms (6.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.108 s 517.116 ms (6.0%)
Total iast_TELEMETRY_OFF 9.133 s 542.257 ms (6.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~87d8c80453, baseline=1.43.0-SNAPSHOT~105c9dc224

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.752 ms) : 0, 685752
BytebuddyAgent [candidate] (692.094 ms) : 0, 692094
GlobalTracer [baseline] (313.543 ms) : 0, 313543
GlobalTracer [candidate] (316.638 ms) : 0, 316638
AppSec [baseline] (54.146 ms) : 0, 54146
AppSec [candidate] (54.401 ms) : 0, 54401
Remote Config [baseline] (682.181 µs) : 0, 682
Remote Config [candidate] (695.156 µs) : 0, 695
Telemetry [baseline] (10.438 ms) : 0, 10438
Telemetry [candidate] (8.639 ms) : 0, 8639
section iast
BytebuddyAgent [baseline] (803.834 ms) : 0, 803834
BytebuddyAgent [candidate] (801.11 ms) : 0, 801110
GlobalTracer [baseline] (303.757 ms) : 0, 303757
GlobalTracer [candidate] (303.203 ms) : 0, 303203
AppSec [baseline] (56.902 ms) : 0, 56902
AppSec [candidate] (56.327 ms) : 0, 56327
Remote Config [baseline] (631.848 µs) : 0, 632
Remote Config [candidate] (598.801 µs) : 0, 599
Telemetry [baseline] (7.414 ms) : 0, 7414
Telemetry [candidate] (7.321 ms) : 0, 7321
IAST [baseline] (21.402 ms) : 0, 21402
IAST [candidate] (21.176 ms) : 0, 21176
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (802.134 ms) : 0, 802134
BytebuddyAgent [candidate] (809.577 ms) : 0, 809577
GlobalTracer [baseline] (303.886 ms) : 0, 303886
GlobalTracer [candidate] (306.851 ms) : 0, 306851
AppSec [baseline] (55.376 ms) : 0, 55376
AppSec [candidate] (57.307 ms) : 0, 57307
Remote Config [baseline] (622.695 µs) : 0, 623
Remote Config [candidate] (614.175 µs) : 0, 614
Telemetry [baseline] (7.415 ms) : 0, 7415
Telemetry [candidate] (7.404 ms) : 0, 7404
IAST [baseline] (23.178 ms) : 0, 23178
IAST [candidate] (20.168 ms) : 0, 20168
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (796.609 ms) : 0, 796609
BytebuddyAgent [candidate] (799.441 ms) : 0, 799441
GlobalTracer [baseline] (303.097 ms) : 0, 303097
GlobalTracer [candidate] (303.162 ms) : 0, 303162
AppSec [baseline] (57.498 ms) : 0, 57498
AppSec [candidate] (56.809 ms) : 0, 56809
Remote Config [baseline] (594.708 µs) : 0, 595
Remote Config [candidate] (624.764 µs) : 0, 625
Telemetry [baseline] (7.27 ms) : 0, 7270
Telemetry [candidate] (7.263 ms) : 0, 7263
IAST [baseline] (19.906 ms) : 0, 19906
IAST [candidate] (21.105 ms) : 0, 21105
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~87d8c80453, baseline=1.43.0-SNAPSHOT~105c9dc224

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.079 s) : 0, 1079161
Total [baseline] (10.366 s) : 0, 10366241
Agent [candidate] (1.081 s) : 0, 1081017
Total [candidate] (10.371 s) : 0, 10370783
section appsec
Agent [baseline] (1.213 s) : 0, 1212721
Total [baseline] (10.638 s) : 0, 10637557
Agent [candidate] (1.216 s) : 0, 1216199
Total [candidate] (10.73 s) : 0, 10729898
section iast
Agent [baseline] (1.214 s) : 0, 1214495
Total [baseline] (10.913 s) : 0, 10912991
Agent [candidate] (1.206 s) : 0, 1205985
Total [candidate] (10.89 s) : 0, 10889913
section profiling
Agent [baseline] (1.286 s) : 0, 1286132
Total [baseline] (10.711 s) : 0, 10711011
Agent [candidate] (1.276 s) : 0, 1275656
Total [candidate] (10.735 s) : 0, 10734870
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.079 s -
Agent appsec 1.213 s 133.56 ms (12.4%)
Agent iast 1.214 s 135.334 ms (12.5%)
Agent profiling 1.286 s 206.97 ms (19.2%)
Total tracing 10.366 s -
Total appsec 10.638 s 271.316 ms (2.6%)
Total iast 10.913 s 546.75 ms (5.3%)
Total profiling 10.711 s 344.77 ms (3.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.081 s -
Agent appsec 1.216 s 135.182 ms (12.5%)
Agent iast 1.206 s 124.967 ms (11.6%)
Agent profiling 1.276 s 194.639 ms (18.0%)
Total tracing 10.371 s -
Total appsec 10.73 s 359.115 ms (3.5%)
Total iast 10.89 s 519.13 ms (5.0%)
Total profiling 10.735 s 364.087 ms (3.5%) 
gantt
    title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~87d8c80453, baseline=1.43.0-SNAPSHOT~105c9dc224

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.649 ms) : 0, 684649
BytebuddyAgent [candidate] (685.615 ms) : 0, 685615
GlobalTracer [baseline] (313.831 ms) : 0, 313831
GlobalTracer [candidate] (314.948 ms) : 0, 314948
AppSec [baseline] (53.808 ms) : 0, 53808
AppSec [candidate] (53.964 ms) : 0, 53964
Remote Config [baseline] (674.785 µs) : 0, 675
Remote Config [candidate] (676.714 µs) : 0, 677
Telemetry [baseline] (12.599 ms) : 0, 12599
Telemetry [candidate] (12.175 ms) : 0, 12175
section appsec
BytebuddyAgent [baseline] (702.525 ms) : 0, 702525
BytebuddyAgent [candidate] (704.861 ms) : 0, 704861
GlobalTracer [baseline] (311.777 ms) : 0, 311777
GlobalTracer [candidate] (312.75 ms) : 0, 312750
AppSec [baseline] (167.448 ms) : 0, 167448
AppSec [candidate] (166.31 ms) : 0, 166310
Remote Config [baseline] (630.66 µs) : 0, 631
Remote Config [candidate] (634.709 µs) : 0, 635
Telemetry [baseline] (7.423 ms) : 0, 7423
Telemetry [candidate] (7.445 ms) : 0, 7445
IAST [baseline] (18.686 ms) : 0, 18686
IAST [candidate] (21.069 ms) : 0, 21069
section iast
BytebuddyAgent [baseline] (808.699 ms) : 0, 808699
BytebuddyAgent [candidate] (801.791 ms) : 0, 801791
GlobalTracer [baseline] (305.304 ms) : 0, 305304
GlobalTracer [candidate] (304.006 ms) : 0, 304006
AppSec [baseline] (57.935 ms) : 0, 57935
AppSec [candidate] (56.707 ms) : 0, 56707
Remote Config [baseline] (617.868 µs) : 0, 618
Remote Config [candidate] (623.845 µs) : 0, 624
Telemetry [baseline] (7.449 ms) : 0, 7449
Telemetry [candidate] (7.435 ms) : 0, 7435
IAST [baseline] (20.714 ms) : 0, 20714
IAST [candidate] (21.779 ms) : 0, 21779
section profiling
BytebuddyAgent [baseline] (686.243 ms) : 0, 686243
BytebuddyAgent [candidate] (679.913 ms) : 0, 679913
GlobalTracer [baseline] (401.432 ms) : 0, 401432
GlobalTracer [candidate] (398.146 ms) : 0, 398146
AppSec [baseline] (54.858 ms) : 0, 54858
AppSec [candidate] (54.446 ms) : 0, 54446
Remote Config [baseline] (689.616 µs) : 0, 690
Remote Config [candidate] (662.768 µs) : 0, 663
Telemetry [baseline] (10.676 ms) : 0, 10676
Telemetry [candidate] (13.415 ms) : 0, 13415
ProfilingAgent [baseline] (93.18 ms) : 0, 93180
ProfilingAgent [candidate] (90.276 ms) : 0, 90276
Profiling [baseline] (93.204 ms) : 0, 93204
Profiling [candidate] (90.299 ms) : 0, 90299
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-11-14T17:54:47 2024-11-14T18:01:41
git_branch master bbujon/ci
git_commit_date 1731601861 1731606148
git_commit_sha 105c9dc 87d8c80
release_version 1.43.0-SNAPSHOT~105c9dc224 1.43.0-SNAPSHOT~87d8c80453
start_time 2024-11-14T17:54:33 2024-11-14T18:01:28
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1731607652 1731607652
ci_job_id 707494466 707494466
ci_pipeline_id 49052533 49052533
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~87d8c80453, baseline=1.43.0-SNAPSHOT~105c9dc224
    dateFormat X
    axisFormat %s
section baseline
no_agent (373.659 µs) : 353, 395
.   : milestone, 374,
iast (491.544 µs) : 470, 513
.   : milestone, 492,
iast_FULL (644.831 µs) : 623, 666
.   : milestone, 645,
iast_GLOBAL (517.675 µs) : 496, 539
.   : milestone, 518,
iast_HARDCODED_SECRET_DISABLED (489.002 µs) : 468, 510
.   : milestone, 489,
iast_INACTIVE (453.655 µs) : 432, 475
.   : milestone, 454,
iast_TELEMETRY_OFF (477.194 µs) : 456, 498
.   : milestone, 477,
tracing (448.468 µs) : 427, 470
.   : milestone, 448,
section candidate
no_agent (373.622 µs) : 354, 393
.   : milestone, 374,
iast (483.156 µs) : 462, 504
.   : milestone, 483,
iast_FULL (642.407 µs) : 620, 664
.   : milestone, 642,
iast_GLOBAL (512.104 µs) : 491, 533
.   : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (487.021 µs) : 466, 508
.   : milestone, 487,
iast_INACTIVE (450.093 µs) : 429, 471
.   : milestone, 450,
iast_TELEMETRY_OFF (478.705 µs) : 457, 500
.   : milestone, 479,
tracing (447.201 µs) : 426, 469
.   : milestone, 447,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 373.659 µs [352.721 µs, 394.597 µs] -
iast 491.544 µs [469.861 µs, 513.228 µs] 117.885 µs (31.5%)
iast_FULL 644.831 µs [623.473 µs, 666.19 µs] 271.172 µs (72.6%)
iast_GLOBAL 517.675 µs [496.303 µs, 539.046 µs] 144.015 µs (38.5%)
iast_HARDCODED_SECRET_DISABLED 489.002 µs [467.954 µs, 510.05 µs] 115.343 µs (30.9%)
iast_INACTIVE 453.655 µs [432.154 µs, 475.156 µs] 79.996 µs (21.4%)
iast_TELEMETRY_OFF 477.194 µs [456.292 µs, 498.097 µs] 103.535 µs (27.7%)
tracing 448.468 µs [427.033 µs, 469.903 µs] 74.809 µs (20.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 373.622 µs [353.919 µs, 393.324 µs] -
iast 483.156 µs [461.82 µs, 504.492 µs] 109.534 µs (29.3%)
iast_FULL 642.407 µs [620.479 µs, 664.336 µs] 268.786 µs (71.9%)
iast_GLOBAL 512.104 µs [490.928 µs, 533.281 µs] 138.483 µs (37.1%)
iast_HARDCODED_SECRET_DISABLED 487.021 µs [465.967 µs, 508.076 µs] 113.4 µs (30.4%)
iast_INACTIVE 450.093 µs [429.268 µs, 470.918 µs] 76.471 µs (20.5%)
iast_TELEMETRY_OFF 478.705 µs [457.075 µs, 500.334 µs] 105.083 µs (28.1%)
tracing 447.201 µs [425.871 µs, 468.53 µs] 73.579 µs (19.7%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~87d8c80453, baseline=1.43.0-SNAPSHOT~105c9dc224
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.341 ms) : 1321, 1360
.   : milestone, 1341,
appsec (1.727 ms) : 1703, 1751
.   : milestone, 1727,
appsec_no_iast (1.734 ms) : 1710, 1759
.   : milestone, 1734,
iast (1.506 ms) : 1483, 1528
.   : milestone, 1506,
profiling (1.488 ms) : 1465, 1511
.   : milestone, 1488,
tracing (1.476 ms) : 1451, 1500
.   : milestone, 1476,
section candidate
no_agent (1.348 ms) : 1328, 1369
.   : milestone, 1348,
appsec (1.753 ms) : 1729, 1777
.   : milestone, 1753,
appsec_no_iast (1.716 ms) : 1691, 1742
.   : milestone, 1716,
iast (1.483 ms) : 1461, 1505
.   : milestone, 1483,
profiling (1.504 ms) : 1481, 1527
.   : milestone, 1504,
tracing (1.481 ms) : 1456, 1506
.   : milestone, 1481,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.341 ms [1.321 ms, 1.36 ms] -
appsec 1.727 ms [1.703 ms, 1.751 ms] 386.579 µs (28.8%)
appsec_no_iast 1.734 ms [1.71 ms, 1.759 ms] 393.786 µs (29.4%)
iast 1.506 ms [1.483 ms, 1.528 ms] 165.137 µs (12.3%)
profiling 1.488 ms [1.465 ms, 1.511 ms] 147.224 µs (11.0%)
tracing 1.476 ms [1.451 ms, 1.5 ms] 135.198 µs (10.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.348 ms [1.328 ms, 1.369 ms] -
appsec 1.753 ms [1.729 ms, 1.777 ms] 404.459 µs (30.0%)
appsec_no_iast 1.716 ms [1.691 ms, 1.742 ms] 367.978 µs (27.3%)
iast 1.483 ms [1.461 ms, 1.505 ms] 134.717 µs (10.0%)
profiling 1.504 ms [1.481 ms, 1.527 ms] 155.228 µs (11.5%)
tracing 1.481 ms [1.456 ms, 1.506 ms] 132.286 µs (9.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/ci
git_commit_date 1731601861 1731606148
git_commit_sha 105c9dc 87d8c80
release_version 1.43.0-SNAPSHOT~105c9dc224 1.43.0-SNAPSHOT~87d8c80453
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1731608081 1731608081
ci_job_id 707494468 707494468
ci_pipeline_id 49052533 49052533
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~87d8c80453, baseline=1.43.0-SNAPSHOT~105c9dc224
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.392 s) : 15392000, 15392000
.   : milestone, 15392000,
appsec (15.171 s) : 15171000, 15171000
.   : milestone, 15171000,
iast (18.589 s) : 18589000, 18589000
.   : milestone, 18589000,
iast_GLOBAL (18.077 s) : 18077000, 18077000
.   : milestone, 18077000,
profiling (15.082 s) : 15082000, 15082000
.   : milestone, 15082000,
tracing (15.035 s) : 15035000, 15035000
.   : milestone, 15035000,
section candidate
no_agent (15.047 s) : 15047000, 15047000
.   : milestone, 15047000,
appsec (15.016 s) : 15016000, 15016000
.   : milestone, 15016000,
iast (18.87 s) : 18870000, 18870000
.   : milestone, 18870000,
iast_GLOBAL (18.522 s) : 18522000, 18522000
.   : milestone, 18522000,
profiling (15.171 s) : 15171000, 15171000
.   : milestone, 15171000,
tracing (15.187 s) : 15187000, 15187000
.   : milestone, 15187000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.392 s [15.392 s, 15.392 s] -
appsec 15.171 s [15.171 s, 15.171 s] -221.0 ms (-1.4%)
iast 18.589 s [18.589 s, 18.589 s] 3.197 s (20.8%)
iast_GLOBAL 18.077 s [18.077 s, 18.077 s] 2.685 s (17.4%)
profiling 15.082 s [15.082 s, 15.082 s] -310.0 ms (-2.0%)
tracing 15.035 s [15.035 s, 15.035 s] -357.0 ms (-2.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.047 s [15.047 s, 15.047 s] -
appsec 15.016 s [15.016 s, 15.016 s] -31.0 ms (-0.2%)
iast 18.87 s [18.87 s, 18.87 s] 3.823 s (25.4%)
iast_GLOBAL 18.522 s [18.522 s, 18.522 s] 3.475 s (23.1%)
profiling 15.171 s [15.171 s, 15.171 s] 124.0 ms (0.8%)
tracing 15.187 s [15.187 s, 15.187 s] 140.0 ms (0.9%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~87d8c80453, baseline=1.43.0-SNAPSHOT~105c9dc224
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.463 ms) : 1452, 1475
.   : milestone, 1463,
appsec (2.345 ms) : 2304, 2387
.   : milestone, 2345,
iast (2.076 ms) : 2024, 2129
.   : milestone, 2076,
iast_GLOBAL (2.107 ms) : 2055, 2159
.   : milestone, 2107,
profiling (1.937 ms) : 1895, 1979
.   : milestone, 1937,
tracing (1.914 ms) : 1874, 1953
.   : milestone, 1914,
section candidate
no_agent (1.467 ms) : 1456, 1479
.   : milestone, 1467,
appsec (2.338 ms) : 2297, 2379
.   : milestone, 2338,
iast (2.089 ms) : 2037, 2142
.   : milestone, 2089,
iast_GLOBAL (2.118 ms) : 2065, 2170
.   : milestone, 2118,
profiling (1.945 ms) : 1903, 1988
.   : milestone, 1945,
tracing (1.918 ms) : 1878, 1957
.   : milestone, 1918,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.463 ms [1.452 ms, 1.475 ms] -
appsec 2.345 ms [2.304 ms, 2.387 ms] 882.114 µs (60.3%)
iast 2.076 ms [2.024 ms, 2.129 ms] 612.895 µs (41.9%)
iast_GLOBAL 2.107 ms [2.055 ms, 2.159 ms] 643.629 µs (44.0%)
profiling 1.937 ms [1.895 ms, 1.979 ms] 473.665 µs (32.4%)
tracing 1.914 ms [1.874 ms, 1.953 ms] 450.257 µs (30.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.456 ms, 1.479 ms] -
appsec 2.338 ms [2.297 ms, 2.379 ms] 871.287 µs (59.4%)
iast 2.089 ms [2.037 ms, 2.142 ms] 622.081 µs (42.4%)
iast_GLOBAL 2.118 ms [2.065 ms, 2.17 ms] 650.548 µs (44.3%)
profiling 1.945 ms [1.903 ms, 1.988 ms] 478.141 µs (32.6%)
tracing 1.918 ms [1.878 ms, 1.957 ms] 450.6 µs (30.7%)

jandro996
jandro996 approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@jandro996 jandro996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PerfectSlayer PerfectSlayer merged commit 137948f into master Nov 19, 2024
109 of 110 checks passed
@PerfectSlayer PerfectSlayer deleted the bbujon/ci branch November 19, 2024 13:14
@github-actions github-actions bot added this to the 1.43.0 milestone Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jandro996 jandro996 jandro996 approved these changes

@smola smola Awaiting requested review from smola smola is a code owner automatically assigned from DataDog/asm-java

Assignees
No one assigned
Labels
comp: testing Testing tag: no release notes Changes to exclude from release notes
Projects
None yet
Milestone
1.43.0
Development

Successfully merging this pull request may close these issues.
2 participants
@PerfectSlayer @jandro996