Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Grizzly instrumentation to check active span instead of scope #7982

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Update Grizzly instrumentation to check active span instead of scope #7982

merged 1 commit into from
Nov 28, 2024

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Nov 20, 2024 •
edited
Loading

Motivation

We don't need access to the scope, checking to see if there's an active span is enough.

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@mcculls mcculls added inst: others All other instrumentations tag: no release notes Changes to exclude from release notes type: refactoring labels Nov 20, 2024
@pr-commenter
Copy link

pr-commenter bot commented Nov 20, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/grizzly-prefer-active-span-check
git_commit_date 1732745437 1732751405
git_commit_sha 600378f 99a337f
release_version 1.44.0-SNAPSHOT~600378f050 1.44.0-SNAPSHOT~99a337f4a8
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1732753858 1732753858
ci_job_id 722512171 722512171
ci_pipeline_id 50088737 50088737
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 9 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.44.0-SNAPSHOT~99a337f4a8, baseline=1.44.0-SNAPSHOT~600378f050

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.097 s) : 0, 1097382
Total [baseline] (8.691 s) : 0, 8690886
Agent [candidate] (1.095 s) : 0, 1094957
Total [candidate] (8.699 s) : 0, 8699038
section iast
Agent [baseline] (1.226 s) : 0, 1225619
Total [baseline] (9.238 s) : 0, 9238287
Agent [candidate] (1.223 s) : 0, 1222920
Total [candidate] (9.23 s) : 0, 9229609
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.218 s) : 0, 1218438
Total [baseline] (9.161 s) : 0, 9161304
Agent [candidate] (1.222 s) : 0, 1222366
Total [candidate] (9.208 s) : 0, 9207736
section iast_TELEMETRY_OFF
Agent [baseline] (1.225 s) : 0, 1224781
Total [baseline] (9.231 s) : 0, 9230803
Agent [candidate] (1.217 s) : 0, 1217063
Total [candidate] (9.18 s) : 0, 9179732
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.097 s -
Agent iast 1.226 s 128.237 ms (11.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.218 s 121.056 ms (11.0%)
Agent iast_TELEMETRY_OFF 1.225 s 127.398 ms (11.6%)
Total tracing 8.691 s -
Total iast 9.238 s 547.401 ms (6.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.161 s 470.419 ms (5.4%)
Total iast_TELEMETRY_OFF 9.231 s 539.918 ms (6.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.095 s -
Agent iast 1.223 s 127.963 ms (11.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.222 s 127.409 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.217 s 122.106 ms (11.2%)
Total tracing 8.699 s -
Total iast 9.23 s 530.571 ms (6.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.208 s 508.697 ms (5.8%)
Total iast_TELEMETRY_OFF 9.18 s 480.694 ms (5.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.44.0-SNAPSHOT~99a337f4a8, baseline=1.44.0-SNAPSHOT~600378f050

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (699.066 ms) : 0, 699066
BytebuddyAgent [candidate] (697.432 ms) : 0, 697432
GlobalTracer [baseline] (318.706 ms) : 0, 318706
GlobalTracer [candidate] (319.06 ms) : 0, 319060
AppSec [baseline] (55.156 ms) : 0, 55156
AppSec [candidate] (54.72 ms) : 0, 54720
Remote Config [baseline] (693.012 µs) : 0, 693
Remote Config [candidate] (693.565 µs) : 0, 694
Telemetry [baseline] (9.915 ms) : 0, 9915
Telemetry [candidate] (9.237 ms) : 0, 9237
section iast
BytebuddyAgent [baseline] (816.421 ms) : 0, 816421
BytebuddyAgent [candidate] (814.315 ms) : 0, 814315
GlobalTracer [baseline] (307.548 ms) : 0, 307548
GlobalTracer [candidate] (307.045 ms) : 0, 307045
AppSec [baseline] (57.879 ms) : 0, 57879
AppSec [candidate] (57.574 ms) : 0, 57574
Remote Config [baseline] (639.981 µs) : 0, 640
Remote Config [candidate] (647.033 µs) : 0, 647
Telemetry [baseline] (7.524 ms) : 0, 7524
Telemetry [candidate] (7.597 ms) : 0, 7597
IAST [baseline] (21.746 ms) : 0, 21746
IAST [candidate] (21.9 ms) : 0, 21900
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (811.324 ms) : 0, 811324
BytebuddyAgent [candidate] (813.977 ms) : 0, 813977
GlobalTracer [baseline] (306.444 ms) : 0, 306444
GlobalTracer [candidate] (307.626 ms) : 0, 307626
AppSec [baseline] (57.694 ms) : 0, 57694
AppSec [candidate] (57.944 ms) : 0, 57944
Remote Config [baseline] (646.0 µs) : 0, 646
Remote Config [candidate] (630.38 µs) : 0, 630
Telemetry [baseline] (7.558 ms) : 0, 7558
Telemetry [candidate] (7.494 ms) : 0, 7494
IAST [baseline] (21.018 ms) : 0, 21018
IAST [candidate] (20.876 ms) : 0, 20876
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (815.398 ms) : 0, 815398
BytebuddyAgent [candidate] (809.537 ms) : 0, 809537
GlobalTracer [baseline] (308.6 ms) : 0, 308600
GlobalTracer [candidate] (306.937 ms) : 0, 306937
AppSec [baseline] (56.665 ms) : 0, 56665
AppSec [candidate] (57.531 ms) : 0, 57531
Remote Config [baseline] (624.469 µs) : 0, 624
Remote Config [candidate] (626.343 µs) : 0, 626
Telemetry [baseline] (7.426 ms) : 0, 7426
Telemetry [candidate] (7.443 ms) : 0, 7443
IAST [baseline] (22.173 ms) : 0, 22173
IAST [candidate] (21.255 ms) : 0, 21255
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.44.0-SNAPSHOT~99a337f4a8, baseline=1.44.0-SNAPSHOT~600378f050

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.091 s) : 0, 1090749
Total [baseline] (10.418 s) : 0, 10418417
Agent [candidate] (1.093 s) : 0, 1092890
Total [candidate] (10.415 s) : 0, 10415022
section appsec
Agent [baseline] (1.232 s) : 0, 1232161
Total [baseline] (10.82 s) : 0, 10819804
Agent [candidate] (1.231 s) : 0, 1231275
Total [candidate] (10.715 s) : 0, 10715216
section iast
Agent [baseline] (1.229 s) : 0, 1229314
Total [baseline] (11.033 s) : 0, 11032802
Agent [candidate] (1.237 s) : 0, 1236708
Total [candidate] (11.018 s) : 0, 11017742
section profiling
Agent [baseline] (1.321 s) : 0, 1321044
Total [baseline] (10.847 s) : 0, 10846689
Agent [candidate] (1.328 s) : 0, 1327612
Total [candidate] (10.852 s) : 0, 10852239
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.091 s -
Agent appsec 1.232 s 141.412 ms (13.0%)
Agent iast 1.229 s 138.565 ms (12.7%)
Agent profiling 1.321 s 230.295 ms (21.1%)
Total tracing 10.418 s -
Total appsec 10.82 s 401.387 ms (3.9%)
Total iast 11.033 s 614.385 ms (5.9%)
Total profiling 10.847 s 428.271 ms (4.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.093 s -
Agent appsec 1.231 s 138.385 ms (12.7%)
Agent iast 1.237 s 143.818 ms (13.2%)
Agent profiling 1.328 s 234.722 ms (21.5%)
Total tracing 10.415 s -
Total appsec 10.715 s 300.193 ms (2.9%)
Total iast 11.018 s 602.719 ms (5.8%)
Total profiling 10.852 s 437.217 ms (4.2%) 
gantt
    title petclinic - break down per module: candidate=1.44.0-SNAPSHOT~99a337f4a8, baseline=1.44.0-SNAPSHOT~600378f050

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (694.835 ms) : 0, 694835
BytebuddyAgent [candidate] (695.105 ms) : 0, 695105
GlobalTracer [baseline] (318.273 ms) : 0, 318273
GlobalTracer [candidate] (318.462 ms) : 0, 318462
AppSec [baseline] (54.815 ms) : 0, 54815
AppSec [candidate] (54.877 ms) : 0, 54877
Remote Config [baseline] (684.69 µs) : 0, 685
Remote Config [candidate] (705.177 µs) : 0, 705
Telemetry [baseline] (8.392 ms) : 0, 8392
Telemetry [candidate] (9.931 ms) : 0, 9931
section appsec
BytebuddyAgent [baseline] (714.862 ms) : 0, 714862
BytebuddyAgent [candidate] (715.128 ms) : 0, 715128
GlobalTracer [baseline] (316.927 ms) : 0, 316927
GlobalTracer [candidate] (316.957 ms) : 0, 316957
AppSec [baseline] (167.078 ms) : 0, 167078
AppSec [candidate] (166.7 ms) : 0, 166700
IAST [baseline] (19.73 ms) : 0, 19730
IAST [candidate] (18.956 ms) : 0, 18956
Remote Config [baseline] (647.508 µs) : 0, 648
Remote Config [candidate] (642.135 µs) : 0, 642
Telemetry [baseline] (8.967 ms) : 0, 8967
Telemetry [candidate] (8.56 ms) : 0, 8560
section iast
BytebuddyAgent [baseline] (819.192 ms) : 0, 819192
BytebuddyAgent [candidate] (824.187 ms) : 0, 824187
GlobalTracer [baseline] (308.671 ms) : 0, 308671
GlobalTracer [candidate] (310.653 ms) : 0, 310653
AppSec [baseline] (58.339 ms) : 0, 58339
AppSec [candidate] (56.795 ms) : 0, 56795
IAST [baseline] (21.085 ms) : 0, 21085
IAST [candidate] (22.872 ms) : 0, 22872
Remote Config [baseline] (638.383 µs) : 0, 638
Remote Config [candidate] (654.187 µs) : 0, 654
Telemetry [baseline] (7.55 ms) : 0, 7550
Telemetry [candidate] (7.636 ms) : 0, 7636
section profiling
BytebuddyAgent [baseline] (690.029 ms) : 0, 690029
BytebuddyAgent [candidate] (695.024 ms) : 0, 695024
GlobalTracer [baseline] (435.601 ms) : 0, 435601
GlobalTracer [candidate] (437.337 ms) : 0, 437337
AppSec [baseline] (53.811 ms) : 0, 53811
AppSec [candidate] (53.858 ms) : 0, 53858
Remote Config [baseline] (659.596 µs) : 0, 660
Remote Config [candidate] (666.634 µs) : 0, 667
Telemetry [baseline] (7.791 ms) : 0, 7791
Telemetry [candidate] (7.653 ms) : 0, 7653
ProfilingAgent [baseline] (93.996 ms) : 0, 93996
ProfilingAgent [candidate] (93.58 ms) : 0, 93580
Profiling [baseline] (94.02 ms) : 0, 94020
Profiling [candidate] (93.603 ms) : 0, 93603
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-11-28T00:00:56 2024-11-28T00:07:53
git_branch master mcculls/grizzly-prefer-active-span-check
git_commit_date 1732745437 1732751405
git_commit_sha 600378f 99a337f
release_version 1.44.0-SNAPSHOT~600378f050 1.44.0-SNAPSHOT~99a337f4a8
start_time 2024-11-28T00:00:43 2024-11-28T00:07:39
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1732752824 1732752824
ci_job_id 722512172 722512172
ci_pipeline_id 50088737 50088737
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~99a337f4a8, baseline=1.44.0-SNAPSHOT~600378f050
    dateFormat X
    axisFormat %s
section baseline
no_agent (375.204 µs) : 355, 396
.   : milestone, 375,
iast (478.735 µs) : 458, 500
.   : milestone, 479,
iast_FULL (647.79 µs) : 626, 669
.   : milestone, 648,
iast_GLOBAL (512.629 µs) : 491, 534
.   : milestone, 513,
iast_HARDCODED_SECRET_DISABLED (495.883 µs) : 473, 518
.   : milestone, 496,
iast_INACTIVE (447.855 µs) : 427, 468
.   : milestone, 448,
iast_TELEMETRY_OFF (485.06 µs) : 463, 507
.   : milestone, 485,
tracing (443.763 µs) : 423, 465
.   : milestone, 444,
section candidate
no_agent (370.087 µs) : 350, 390
.   : milestone, 370,
iast (487.158 µs) : 466, 509
.   : milestone, 487,
iast_FULL (647.852 µs) : 626, 669
.   : milestone, 648,
iast_GLOBAL (516.465 µs) : 494, 538
.   : milestone, 516,
iast_HARDCODED_SECRET_DISABLED (488.19 µs) : 467, 510
.   : milestone, 488,
iast_INACTIVE (443.182 µs) : 423, 464
.   : milestone, 443,
iast_TELEMETRY_OFF (477.412 µs) : 455, 499
.   : milestone, 477,
tracing (445.424 µs) : 425, 466
.   : milestone, 445,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 375.204 µs [354.592 µs, 395.816 µs] -
iast 478.735 µs [457.593 µs, 499.877 µs] 103.531 µs (27.6%)
iast_FULL 647.79 µs [626.116 µs, 669.464 µs] 272.586 µs (72.7%)
iast_GLOBAL 512.629 µs [491.31 µs, 533.948 µs] 137.425 µs (36.6%)
iast_HARDCODED_SECRET_DISABLED 495.883 µs [473.294 µs, 518.472 µs] 120.679 µs (32.2%)
iast_INACTIVE 447.855 µs [427.314 µs, 468.397 µs] 72.652 µs (19.4%)
iast_TELEMETRY_OFF 485.06 µs [462.971 µs, 507.15 µs] 109.856 µs (29.3%)
tracing 443.763 µs [422.971 µs, 464.555 µs] 68.559 µs (18.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.087 µs [350.094 µs, 390.079 µs] -
iast 487.158 µs [465.7 µs, 508.616 µs] 117.071 µs (31.6%)
iast_FULL 647.852 µs [626.327 µs, 669.377 µs] 277.765 µs (75.1%)
iast_GLOBAL 516.465 µs [494.439 µs, 538.491 µs] 146.378 µs (39.6%)
iast_HARDCODED_SECRET_DISABLED 488.19 µs [466.763 µs, 509.618 µs] 118.104 µs (31.9%)
iast_INACTIVE 443.182 µs [422.538 µs, 463.827 µs] 73.096 µs (19.8%)
iast_TELEMETRY_OFF 477.412 µs [455.489 µs, 499.336 µs] 107.326 µs (29.0%)
tracing 445.424 µs [424.579 µs, 466.269 µs] 75.337 µs (20.4%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~99a337f4a8, baseline=1.44.0-SNAPSHOT~600378f050
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.337 ms) : 1318, 1356
.   : milestone, 1337,
appsec (1.761 ms) : 1736, 1785
.   : milestone, 1761,
appsec_no_iast (1.748 ms) : 1723, 1773
.   : milestone, 1748,
iast (1.485 ms) : 1463, 1507
.   : milestone, 1485,
profiling (1.516 ms) : 1492, 1541
.   : milestone, 1516,
tracing (1.471 ms) : 1447, 1496
.   : milestone, 1471,
section candidate
no_agent (1.347 ms) : 1327, 1367
.   : milestone, 1347,
appsec (1.749 ms) : 1724, 1774
.   : milestone, 1749,
appsec_no_iast (1.738 ms) : 1713, 1763
.   : milestone, 1738,
iast (1.492 ms) : 1469, 1515
.   : milestone, 1492,
profiling (1.498 ms) : 1475, 1522
.   : milestone, 1498,
tracing (1.495 ms) : 1470, 1521
.   : milestone, 1495,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.337 ms [1.318 ms, 1.356 ms] -
appsec 1.761 ms [1.736 ms, 1.785 ms] 424.345 µs (31.7%)
appsec_no_iast 1.748 ms [1.723 ms, 1.773 ms] 411.408 µs (30.8%)
iast 1.485 ms [1.463 ms, 1.507 ms] 148.39 µs (11.1%)
profiling 1.516 ms [1.492 ms, 1.541 ms] 179.508 µs (13.4%)
tracing 1.471 ms [1.447 ms, 1.496 ms] 134.709 µs (10.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.347 ms [1.327 ms, 1.367 ms] -
appsec 1.749 ms [1.724 ms, 1.774 ms] 401.657 µs (29.8%)
appsec_no_iast 1.738 ms [1.713 ms, 1.763 ms] 390.396 µs (29.0%)
iast 1.492 ms [1.469 ms, 1.515 ms] 144.572 µs (10.7%)
profiling 1.498 ms [1.475 ms, 1.522 ms] 151.078 µs (11.2%)
tracing 1.495 ms [1.47 ms, 1.521 ms] 147.774 µs (11.0%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/grizzly-prefer-active-span-check
git_commit_date 1732745437 1732751405
git_commit_sha 600378f 99a337f
release_version 1.44.0-SNAPSHOT~600378f050 1.44.0-SNAPSHOT~99a337f4a8
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1732753425 1732753425
ci_job_id 722512173 722512173
ci_pipeline_id 50088737 50088737
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~99a337f4a8, baseline=1.44.0-SNAPSHOT~600378f050
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
.   : milestone, 1479,
appsec (2.359 ms) : 2317, 2400
.   : milestone, 2359,
iast (2.099 ms) : 2047, 2152
.   : milestone, 2099,
iast_GLOBAL (2.143 ms) : 2090, 2196
.   : milestone, 2143,
profiling (1.969 ms) : 1927, 2011
.   : milestone, 1969,
tracing (1.942 ms) : 1901, 1982
.   : milestone, 1942,
section candidate
no_agent (1.479 ms) : 1468, 1491
.   : milestone, 1479,
appsec (2.367 ms) : 2326, 2409
.   : milestone, 2367,
iast (2.11 ms) : 2058, 2163
.   : milestone, 2110,
iast_GLOBAL (2.147 ms) : 2094, 2199
.   : milestone, 2147,
profiling (2.457 ms) : 2267, 2648
.   : milestone, 2457,
tracing (1.941 ms) : 1900, 1981
.   : milestone, 1941,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.479 ms [1.468 ms, 1.491 ms] -
appsec 2.359 ms [2.317 ms, 2.4 ms] 879.693 µs (59.5%)
iast 2.099 ms [2.047 ms, 2.152 ms] 620.194 µs (41.9%)
iast_GLOBAL 2.143 ms [2.09 ms, 2.196 ms] 664.031 µs (44.9%)
profiling 1.969 ms [1.927 ms, 2.011 ms] 490.064 µs (33.1%)
tracing 1.942 ms [1.901 ms, 1.982 ms] 462.284 µs (31.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.479 ms [1.468 ms, 1.491 ms] -
appsec 2.367 ms [2.326 ms, 2.409 ms] 888.245 µs (60.1%)
iast 2.11 ms [2.058 ms, 2.163 ms] 631.082 µs (42.7%)
iast_GLOBAL 2.147 ms [2.094 ms, 2.199 ms] 667.482 µs (45.1%)
profiling 2.457 ms [2.267 ms, 2.648 ms] 978.345 µs (66.1%)
tracing 1.941 ms [1.9 ms, 1.981 ms] 461.739 µs (31.2%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~99a337f4a8, baseline=1.44.0-SNAPSHOT~600378f050
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.298 s) : 15298000, 15298000
.   : milestone, 15298000,
appsec (14.826 s) : 14826000, 14826000
.   : milestone, 14826000,
iast (18.668 s) : 18668000, 18668000
.   : milestone, 18668000,
iast_GLOBAL (17.813 s) : 17813000, 17813000
.   : milestone, 17813000,
profiling (15.336 s) : 15336000, 15336000
.   : milestone, 15336000,
tracing (15.241 s) : 15241000, 15241000
.   : milestone, 15241000,
section candidate
no_agent (15.464 s) : 15464000, 15464000
.   : milestone, 15464000,
appsec (15.244 s) : 15244000, 15244000
.   : milestone, 15244000,
iast (18.704 s) : 18704000, 18704000
.   : milestone, 18704000,
iast_GLOBAL (18.033 s) : 18033000, 18033000
.   : milestone, 18033000,
profiling (15.235 s) : 15235000, 15235000
.   : milestone, 15235000,
tracing (14.885 s) : 14885000, 14885000
.   : milestone, 14885000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.298 s [15.298 s, 15.298 s] -
appsec 14.826 s [14.826 s, 14.826 s] -472.0 ms (-3.1%)
iast 18.668 s [18.668 s, 18.668 s] 3.37 s (22.0%)
iast_GLOBAL 17.813 s [17.813 s, 17.813 s] 2.515 s (16.4%)
profiling 15.336 s [15.336 s, 15.336 s] 38.0 ms (0.2%)
tracing 15.241 s [15.241 s, 15.241 s] -57.0 ms (-0.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.464 s [15.464 s, 15.464 s] -
appsec 15.244 s [15.244 s, 15.244 s] -220.0 ms (-1.4%)
iast 18.704 s [18.704 s, 18.704 s] 3.24 s (21.0%)
iast_GLOBAL 18.033 s [18.033 s, 18.033 s] 2.569 s (16.6%)
profiling 15.235 s [15.235 s, 15.235 s] -229.0 ms (-1.5%)
tracing 14.885 s [14.885 s, 14.885 s] -579.0 ms (-3.7%)

@mcculls mcculls force-pushed the mcculls/grizzly-prefer-active-span-check branch from 207c0c2 to 99a337f Compare November 27, 2024 23:50
@mcculls mcculls marked this pull request as ready for review November 27, 2024 23:50
@mcculls mcculls requested a review from a team as a code owner November 27, 2024 23:50
mcculls
mcculls commented Nov 28, 2024
View reviewed changes
...ion/grizzly-2/src/main/java/datadog/trace/instrumentation/grizzly/GrizzlyBlockingHelper.java
DECORATE.onError(span, e);
DECORATE.beforeFinish(span);
span.finish();
scope.close();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this was copy-paste from another part of the instrumentation where a scope is created and closed under different scenarios. Since the scope calls are balanced in the rest of this integration there's no need to close the scope here, it would just count as an extra close and be ignored.

@mcculls mcculls merged commit 7c67b63 into master Nov 28, 2024
103 checks passed
@mcculls mcculls deleted the mcculls/grizzly-prefer-active-span-check branch November 28, 2024 09:47
@github-actions github-actions bot added this to the 1.44.0 milestone Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarziali amarziali amarziali approved these changes

Assignees
No one assigned
Labels
inst: others All other instrumentations tag: no release notes Changes to exclude from release notes type: refactoring
Projects
None yet
Milestone
1.44.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mcculls @amarziali