Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure instrumentation class is logged if helper class fails to be injected #8009

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Ensure instrumentation class is logged if helper class fails to be injected #8009

merged 1 commit into from
Nov 28, 2024

Conversation

smola
Copy link
Member

@smola smola commented Nov 25, 2024

What Does This Do

Motivation

Errors in telemetry:

Error : Failed to inject helper classes - instrumentation.class={} instrumentation.target.classloader={} instrumentation.target.class={}

Having at least the instrumentation class, which is not a sensitive parameter, will help us group errors in telemetry.

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@smola smola added tag: no release notes Changes to exclude from release notes comp: telemetry Telemetry labels Nov 25, 2024
@smola smola force-pushed the smola/helper-class-inject-log branch from 21184d4 to edd7331 Compare November 25, 2024 11:57
@pr-commenter
Copy link

pr-commenter bot commented Nov 25, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master smola/helper-class-inject-log
git_commit_date 1732532650 1732535820
git_commit_sha f2d21ae edd7331
release_version 1.43.0-SNAPSHOT~f2d21ae588 1.44.0-SNAPSHOT~edd7331a57
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1732538270 1732538270
ci_job_id 718679520 718679520
ci_pipeline_id 49845104 49845104
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.44.0-SNAPSHOT~edd7331a57, baseline=1.43.0-SNAPSHOT~f2d21ae588

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.088 s) : 0, 1088212
Total [baseline] (10.444 s) : 0, 10443886
Agent [candidate] (1.097 s) : 0, 1096591
Total [candidate] (10.462 s) : 0, 10461717
section appsec
Agent [baseline] (1.222 s) : 0, 1221622
Total [baseline] (10.705 s) : 0, 10704840
Agent [candidate] (1.23 s) : 0, 1229523
Total [candidate] (10.715 s) : 0, 10714634
section iast
Agent [baseline] (1.217 s) : 0, 1217270
Total [baseline] (10.884 s) : 0, 10883573
Agent [candidate] (1.214 s) : 0, 1213665
Total [candidate] (10.986 s) : 0, 10986485
section profiling
Agent [baseline] (1.314 s) : 0, 1314345
Total [baseline] (10.861 s) : 0, 10861285
Agent [candidate] (1.312 s) : 0, 1311979
Total [candidate] (10.89 s) : 0, 10889706
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.088 s -
Agent appsec 1.222 s 133.41 ms (12.3%)
Agent iast 1.217 s 129.057 ms (11.9%)
Agent profiling 1.314 s 226.133 ms (20.8%)
Total tracing 10.444 s -
Total appsec 10.705 s 260.954 ms (2.5%)
Total iast 10.884 s 439.687 ms (4.2%)
Total profiling 10.861 s 417.398 ms (4.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.097 s -
Agent appsec 1.23 s 132.932 ms (12.1%)
Agent iast 1.214 s 117.074 ms (10.7%)
Agent profiling 1.312 s 215.388 ms (19.6%)
Total tracing 10.462 s -
Total appsec 10.715 s 252.918 ms (2.4%)
Total iast 10.986 s 524.768 ms (5.0%)
Total profiling 10.89 s 427.989 ms (4.1%) 
gantt
    title petclinic - break down per module: candidate=1.44.0-SNAPSHOT~edd7331a57, baseline=1.43.0-SNAPSHOT~f2d21ae588

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (692.853 ms) : 0, 692853
BytebuddyAgent [candidate] (698.346 ms) : 0, 698346
GlobalTracer [baseline] (316.762 ms) : 0, 316762
GlobalTracer [candidate] (319.191 ms) : 0, 319191
AppSec [baseline] (54.311 ms) : 0, 54311
AppSec [candidate] (54.753 ms) : 0, 54753
Remote Config [baseline] (673.306 µs) : 0, 673
Remote Config [candidate] (700.23 µs) : 0, 700
Telemetry [baseline] (9.905 ms) : 0, 9905
Telemetry [candidate] (9.908 ms) : 0, 9908
section appsec
BytebuddyAgent [baseline] (709.85 ms) : 0, 709850
BytebuddyAgent [candidate] (714.998 ms) : 0, 714998
GlobalTracer [baseline] (313.332 ms) : 0, 313332
GlobalTracer [candidate] (315.538 ms) : 0, 315538
AppSec [baseline] (166.871 ms) : 0, 166871
AppSec [candidate] (167.22 ms) : 0, 167220
IAST [baseline] (18.954 ms) : 0, 18954
IAST [candidate] (19.044 ms) : 0, 19044
Remote Config [baseline] (641.482 µs) : 0, 641
Remote Config [candidate] (652.526 µs) : 0, 653
Telemetry [baseline] (7.77 ms) : 0, 7770
Telemetry [candidate] (7.847 ms) : 0, 7847
section iast
BytebuddyAgent [baseline] (810.992 ms) : 0, 810992
BytebuddyAgent [candidate] (808.673 ms) : 0, 808673
GlobalTracer [baseline] (305.592 ms) : 0, 305592
GlobalTracer [candidate] (304.913 ms) : 0, 304913
AppSec [baseline] (57.263 ms) : 0, 57263
AppSec [candidate] (57.427 ms) : 0, 57427
IAST [baseline] (21.596 ms) : 0, 21596
IAST [candidate] (20.823 ms) : 0, 20823
Remote Config [baseline] (629.75 µs) : 0, 630
Remote Config [candidate] (637.755 µs) : 0, 638
Telemetry [baseline] (7.482 ms) : 0, 7482
Telemetry [candidate] (7.5 ms) : 0, 7500
section profiling
BytebuddyAgent [baseline] (687.457 ms) : 0, 687457
BytebuddyAgent [candidate] (686.146 ms) : 0, 686146
GlobalTracer [baseline] (432.44 ms) : 0, 432440
GlobalTracer [candidate] (432.004 ms) : 0, 432004
AppSec [baseline] (53.442 ms) : 0, 53442
AppSec [candidate] (53.586 ms) : 0, 53586
Remote Config [baseline] (664.419 µs) : 0, 664
Remote Config [candidate] (658.092 µs) : 0, 658
Telemetry [baseline] (7.757 ms) : 0, 7757
Telemetry [candidate] (7.739 ms) : 0, 7739
ProfilingAgent [baseline] (93.618 ms) : 0, 93618
ProfilingAgent [candidate] (92.951 ms) : 0, 92951
Profiling [baseline] (93.641 ms) : 0, 93641
Profiling [candidate] (92.975 ms) : 0, 92975
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.44.0-SNAPSHOT~edd7331a57, baseline=1.43.0-SNAPSHOT~f2d21ae588

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.092 s) : 0, 1091922
Total [baseline] (8.664 s) : 0, 8664433
Agent [candidate] (1.103 s) : 0, 1103159
Total [candidate] (8.699 s) : 0, 8698932
section iast
Agent [baseline] (1.222 s) : 0, 1222244
Total [baseline] (9.218 s) : 0, 9217538
Agent [candidate] (1.215 s) : 0, 1215353
Total [candidate] (9.181 s) : 0, 9181028
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.215 s) : 0, 1215242
Total [baseline] (9.154 s) : 0, 9154282
Agent [candidate] (1.224 s) : 0, 1224011
Total [candidate] (9.19 s) : 0, 9189949
section iast_TELEMETRY_OFF
Agent [baseline] (1.212 s) : 0, 1211739
Total [baseline] (9.194 s) : 0, 9194346
Agent [candidate] (1.223 s) : 0, 1223327
Total [candidate] (9.227 s) : 0, 9227069
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.092 s -
Agent iast 1.222 s 130.322 ms (11.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.215 s 123.321 ms (11.3%)
Agent iast_TELEMETRY_OFF 1.212 s 119.817 ms (11.0%)
Total tracing 8.664 s -
Total iast 9.218 s 553.106 ms (6.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.154 s 489.849 ms (5.7%)
Total iast_TELEMETRY_OFF 9.194 s 529.913 ms (6.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.103 s -
Agent iast 1.215 s 112.194 ms (10.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.224 s 120.852 ms (11.0%)
Agent iast_TELEMETRY_OFF 1.223 s 120.168 ms (10.9%)
Total tracing 8.699 s -
Total iast 9.181 s 482.096 ms (5.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.19 s 491.017 ms (5.6%)
Total iast_TELEMETRY_OFF 9.227 s 528.137 ms (6.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.44.0-SNAPSHOT~edd7331a57, baseline=1.43.0-SNAPSHOT~f2d21ae588

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (695.809 ms) : 0, 695809
BytebuddyAgent [candidate] (703.079 ms) : 0, 703079
GlobalTracer [baseline] (316.616 ms) : 0, 316616
GlobalTracer [candidate] (320.399 ms) : 0, 320399
AppSec [baseline] (54.596 ms) : 0, 54596
AppSec [candidate] (55.239 ms) : 0, 55239
Remote Config [baseline] (674.905 µs) : 0, 675
Remote Config [candidate] (686.65 µs) : 0, 687
Telemetry [baseline] (10.543 ms) : 0, 10543
Telemetry [candidate] (9.853 ms) : 0, 9853
section iast
BytebuddyAgent [baseline] (815.335 ms) : 0, 815335
BytebuddyAgent [candidate] (810.107 ms) : 0, 810107
GlobalTracer [baseline] (305.79 ms) : 0, 305790
GlobalTracer [candidate] (304.99 ms) : 0, 304990
AppSec [baseline] (58.263 ms) : 0, 58263
AppSec [candidate] (56.853 ms) : 0, 56853
IAST [baseline] (20.906 ms) : 0, 20906
IAST [candidate] (21.537 ms) : 0, 21537
Remote Config [baseline] (625.417 µs) : 0, 625
Remote Config [candidate] (631.865 µs) : 0, 632
Telemetry [baseline] (7.531 ms) : 0, 7531
Telemetry [candidate] (7.481 ms) : 0, 7481
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (809.476 ms) : 0, 809476
BytebuddyAgent [candidate] (816.81 ms) : 0, 816810
GlobalTracer [baseline] (305.281 ms) : 0, 305281
GlobalTracer [candidate] (306.482 ms) : 0, 306482
AppSec [baseline] (57.107 ms) : 0, 57107
AppSec [candidate] (57.204 ms) : 0, 57204
IAST [baseline] (21.499 ms) : 0, 21499
IAST [candidate] (21.576 ms) : 0, 21576
Remote Config [baseline] (619.25 µs) : 0, 619
Remote Config [candidate] (612.356 µs) : 0, 612
Telemetry [baseline] (7.513 ms) : 0, 7513
Telemetry [candidate] (7.522 ms) : 0, 7522
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (807.151 ms) : 0, 807151
BytebuddyAgent [candidate] (814.741 ms) : 0, 814741
GlobalTracer [baseline] (305.133 ms) : 0, 305133
GlobalTracer [candidate] (307.594 ms) : 0, 307594
AppSec [baseline] (57.615 ms) : 0, 57615
AppSec [candidate] (55.075 ms) : 0, 55075
IAST [baseline] (20.177 ms) : 0, 20177
IAST [candidate] (24.028 ms) : 0, 24028
Remote Config [baseline] (632.197 µs) : 0, 632
Remote Config [candidate] (618.755 µs) : 0, 619
Telemetry [baseline] (7.377 ms) : 0, 7377
Telemetry [candidate] (7.465 ms) : 0, 7465
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-11-25T12:09:18 2024-11-25T12:16:16
git_branch master smola/helper-class-inject-log
git_commit_date 1732532650 1732535820
git_commit_sha f2d21ae edd7331
release_version 1.43.0-SNAPSHOT~f2d21ae588 1.44.0-SNAPSHOT~edd7331a57
start_time 2024-11-25T12:09:04 2024-11-25T12:16:03
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1732537332 1732537332
ci_job_id 718679521 718679521
ci_pipeline_id 49845104 49845104
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~edd7331a57, baseline=1.43.0-SNAPSHOT~f2d21ae588
    dateFormat X
    axisFormat %s
section baseline
no_agent (374.085 µs) : 354, 394
.   : milestone, 374,
iast (492.363 µs) : 471, 514
.   : milestone, 492,
iast_FULL (652.344 µs) : 630, 675
.   : milestone, 652,
iast_GLOBAL (522.649 µs) : 500, 545
.   : milestone, 523,
iast_HARDCODED_SECRET_DISABLED (493.493 µs) : 472, 515
.   : milestone, 493,
iast_INACTIVE (448.185 µs) : 427, 469
.   : milestone, 448,
iast_TELEMETRY_OFF (484.073 µs) : 462, 506
.   : milestone, 484,
tracing (450.466 µs) : 429, 472
.   : milestone, 450,
section candidate
no_agent (373.126 µs) : 353, 394
.   : milestone, 373,
iast (499.776 µs) : 478, 522
.   : milestone, 500,
iast_FULL (655.175 µs) : 634, 677
.   : milestone, 655,
iast_GLOBAL (521.238 µs) : 499, 543
.   : milestone, 521,
iast_HARDCODED_SECRET_DISABLED (499.037 µs) : 478, 521
.   : milestone, 499,
iast_INACTIVE (452.471 µs) : 432, 473
.   : milestone, 452,
iast_TELEMETRY_OFF (481.339 µs) : 460, 503
.   : milestone, 481,
tracing (446.196 µs) : 426, 467
.   : milestone, 446,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 374.085 µs [354.475 µs, 393.695 µs] -
iast 492.363 µs [470.511 µs, 514.216 µs] 118.279 µs (31.6%)
iast_FULL 652.344 µs [630.084 µs, 674.604 µs] 278.259 µs (74.4%)
iast_GLOBAL 522.649 µs [500.103 µs, 545.196 µs] 148.565 µs (39.7%)
iast_HARDCODED_SECRET_DISABLED 493.493 µs [471.707 µs, 515.28 µs] 119.409 µs (31.9%)
iast_INACTIVE 448.185 µs [427.486 µs, 468.885 µs] 74.101 µs (19.8%)
iast_TELEMETRY_OFF 484.073 µs [462.055 µs, 506.092 µs] 109.989 µs (29.4%)
tracing 450.466 µs [428.841 µs, 472.09 µs] 76.381 µs (20.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 373.126 µs [352.684 µs, 393.568 µs] -
iast 499.776 µs [477.821 µs, 521.731 µs] 126.65 µs (33.9%)
iast_FULL 655.175 µs [633.527 µs, 676.823 µs] 282.049 µs (75.6%)
iast_GLOBAL 521.238 µs [499.324 µs, 543.152 µs] 148.113 µs (39.7%)
iast_HARDCODED_SECRET_DISABLED 499.037 µs [477.513 µs, 520.561 µs] 125.911 µs (33.7%)
iast_INACTIVE 452.471 µs [431.524 µs, 473.419 µs] 79.346 µs (21.3%)
iast_TELEMETRY_OFF 481.339 µs [459.808 µs, 502.87 µs] 108.213 µs (29.0%)
tracing 446.196 µs [425.667 µs, 466.724 µs] 73.07 µs (19.6%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~edd7331a57, baseline=1.43.0-SNAPSHOT~f2d21ae588
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.36 ms) : 1341, 1380
.   : milestone, 1360,
appsec (1.755 ms) : 1730, 1780
.   : milestone, 1755,
appsec_no_iast (1.748 ms) : 1722, 1773
.   : milestone, 1748,
iast (1.486 ms) : 1463, 1509
.   : milestone, 1486,
profiling (1.518 ms) : 1495, 1542
.   : milestone, 1518,
tracing (1.489 ms) : 1464, 1514
.   : milestone, 1489,
section candidate
no_agent (1.363 ms) : 1344, 1383
.   : milestone, 1363,
appsec (1.772 ms) : 1747, 1797
.   : milestone, 1772,
appsec_no_iast (1.754 ms) : 1730, 1778
.   : milestone, 1754,
iast (1.521 ms) : 1499, 1544
.   : milestone, 1521,
profiling (1.541 ms) : 1515, 1566
.   : milestone, 1541,
tracing (1.496 ms) : 1472, 1520
.   : milestone, 1496,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.36 ms [1.341 ms, 1.38 ms] -
appsec 1.755 ms [1.73 ms, 1.78 ms] 394.715 µs (29.0%)
appsec_no_iast 1.748 ms [1.722 ms, 1.773 ms] 387.124 µs (28.5%)
iast 1.486 ms [1.463 ms, 1.509 ms] 125.381 µs (9.2%)
profiling 1.518 ms [1.495 ms, 1.542 ms] 157.73 µs (11.6%)
tracing 1.489 ms [1.464 ms, 1.514 ms] 128.484 µs (9.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.363 ms [1.344 ms, 1.383 ms] -
appsec 1.772 ms [1.747 ms, 1.797 ms] 408.539 µs (30.0%)
appsec_no_iast 1.754 ms [1.73 ms, 1.778 ms] 391.013 µs (28.7%)
iast 1.521 ms [1.499 ms, 1.544 ms] 158.269 µs (11.6%)
profiling 1.541 ms [1.515 ms, 1.566 ms] 177.379 µs (13.0%)
tracing 1.496 ms [1.472 ms, 1.52 ms] 132.733 µs (9.7%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master smola/helper-class-inject-log
git_commit_date 1732532650 1732535820
git_commit_sha f2d21ae edd7331
release_version 1.43.0-SNAPSHOT~f2d21ae588 1.44.0-SNAPSHOT~edd7331a57
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1732537920 1732537920
ci_job_id 718679522 718679522
ci_pipeline_id 49845104 49845104
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~edd7331a57, baseline=1.43.0-SNAPSHOT~f2d21ae588
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.467 ms) : 1456, 1479
.   : milestone, 1467,
appsec (2.334 ms) : 2293, 2376
.   : milestone, 2334,
iast (2.086 ms) : 2033, 2138
.   : milestone, 2086,
iast_GLOBAL (2.127 ms) : 2074, 2180
.   : milestone, 2127,
profiling (1.953 ms) : 1911, 1995
.   : milestone, 1953,
tracing (1.927 ms) : 1887, 1967
.   : milestone, 1927,
section candidate
no_agent (1.464 ms) : 1452, 1475
.   : milestone, 1464,
appsec (2.334 ms) : 2292, 2375
.   : milestone, 2334,
iast (2.087 ms) : 2034, 2140
.   : milestone, 2087,
iast_GLOBAL (2.123 ms) : 2071, 2176
.   : milestone, 2123,
profiling (1.953 ms) : 1910, 1996
.   : milestone, 1953,
tracing (1.928 ms) : 1887, 1968
.   : milestone, 1928,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.456 ms, 1.479 ms] -
appsec 2.334 ms [2.293 ms, 2.376 ms] 866.97 µs (59.1%)
iast 2.086 ms [2.033 ms, 2.138 ms] 618.358 µs (42.1%)
iast_GLOBAL 2.127 ms [2.074 ms, 2.18 ms] 659.901 µs (45.0%)
profiling 1.953 ms [1.911 ms, 1.995 ms] 485.917 µs (33.1%)
tracing 1.927 ms [1.887 ms, 1.967 ms] 459.762 µs (31.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.464 ms [1.452 ms, 1.475 ms] -
appsec 2.334 ms [2.292 ms, 2.375 ms] 869.92 µs (59.4%)
iast 2.087 ms [2.034 ms, 2.14 ms] 623.564 µs (42.6%)
iast_GLOBAL 2.123 ms [2.071 ms, 2.176 ms] 659.717 µs (45.1%)
profiling 1.953 ms [1.91 ms, 1.996 ms] 489.263 µs (33.4%)
tracing 1.928 ms [1.887 ms, 1.968 ms] 463.985 µs (31.7%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~edd7331a57, baseline=1.43.0-SNAPSHOT~f2d21ae588
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.514 s) : 15514000, 15514000
.   : milestone, 15514000,
appsec (14.956 s) : 14956000, 14956000
.   : milestone, 14956000,
iast (18.96 s) : 18960000, 18960000
.   : milestone, 18960000,
iast_GLOBAL (18.006 s) : 18006000, 18006000
.   : milestone, 18006000,
profiling (14.771 s) : 14771000, 14771000
.   : milestone, 14771000,
tracing (15.05 s) : 15050000, 15050000
.   : milestone, 15050000,
section candidate
no_agent (15.47 s) : 15470000, 15470000
.   : milestone, 15470000,
appsec (14.969 s) : 14969000, 14969000
.   : milestone, 14969000,
iast (18.77 s) : 18770000, 18770000
.   : milestone, 18770000,
iast_GLOBAL (18.236 s) : 18236000, 18236000
.   : milestone, 18236000,
profiling (15.544 s) : 15544000, 15544000
.   : milestone, 15544000,
tracing (14.966 s) : 14966000, 14966000
.   : milestone, 14966000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.514 s [15.514 s, 15.514 s] -
appsec 14.956 s [14.956 s, 14.956 s] -558.0 ms (-3.6%)
iast 18.96 s [18.96 s, 18.96 s] 3.446 s (22.2%)
iast_GLOBAL 18.006 s [18.006 s, 18.006 s] 2.492 s (16.1%)
profiling 14.771 s [14.771 s, 14.771 s] -743.0 ms (-4.8%)
tracing 15.05 s [15.05 s, 15.05 s] -464.0 ms (-3.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.47 s [15.47 s, 15.47 s] -
appsec 14.969 s [14.969 s, 14.969 s] -501.0 ms (-3.2%)
iast 18.77 s [18.77 s, 18.77 s] 3.3 s (21.3%)
iast_GLOBAL 18.236 s [18.236 s, 18.236 s] 2.766 s (17.9%)
profiling 15.544 s [15.544 s, 15.544 s] 74.0 ms (0.5%)
tracing 14.966 s [14.966 s, 14.966 s] -504.0 ms (-3.3%)

@smola smola marked this pull request as ready for review November 28, 2024 13:18
@smola smola requested a review from a team as a code owner November 28, 2024 13:18
@smola smola requested a review from dougqh November 28, 2024 13:18
@smola smola merged commit dfe2b6d into master Nov 28, 2024
102 checks passed
@smola smola deleted the smola/helper-class-inject-log branch November 28, 2024 14:46
@github-actions github-actions bot added this to the 1.44.0 milestone Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcculls mcculls mcculls approved these changes

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: telemetry Telemetry tag: no release notes Changes to exclude from release notes
Projects
None yet
Milestone
1.44.0
Development

Successfully merging this pull request may close these issues.
2 participants
@smola @mcculls