Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude git data upload errors from telemetry logging #8027

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Exclude git data upload errors from telemetry logging #8027

merged 1 commit into from
Nov 27, 2024

Conversation

nikita-tkachenko-datadog
Copy link
Contributor

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented Nov 27, 2024 •
edited by jira bot
Loading

What Does This Do

Makes sure Failed to upload git tree data error logs are not uploaded to telemetry.

Motivation

This error happens often if git executable is not available in user's CI.

Contributor Checklist

Jira ticket: SDTEST-1267

@nikita-tkachenko-datadog nikita-tkachenko-datadog added tag: no release notes Changes to exclude from release notes comp: ci visibility Continuous Integration Visibility labels Nov 27, 2024
@nikita-tkachenko-datadog nikita-tkachenko-datadog marked this pull request as ready for review November 27, 2024 15:12
@nikita-tkachenko-datadog nikita-tkachenko-datadog requested a review from a team as a code owner November 27, 2024 15:12
@pr-commenter
Copy link

pr-commenter bot commented Nov 27, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/exclude-git-data-upload-errors-from-telemetry
git_commit_date 1732709291 1732720141
git_commit_sha 966ef84 d4db5df
release_version 1.44.0-SNAPSHOT~966ef84e87 1.44.0-SNAPSHOT~d4db5dfd6f
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1732722482 1732722482
ci_job_id 722092450 722092450
ci_pipeline_id 50064395 50064395
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 9 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.44.0-SNAPSHOT~d4db5dfd6f, baseline=1.44.0-SNAPSHOT~966ef84e87

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.088 s) : 0, 1087903
Total [baseline] (8.672 s) : 0, 8672012
Agent [candidate] (1.091 s) : 0, 1091014
Total [candidate] (8.702 s) : 0, 8701504
section iast
Agent [baseline] (1.217 s) : 0, 1217381
Total [baseline] (9.198 s) : 0, 9197938
Agent [candidate] (1.219 s) : 0, 1219206
Total [candidate] (9.241 s) : 0, 9241310
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.242 s) : 0, 1241628
Total [baseline] (9.2 s) : 0, 9200171
Agent [candidate] (1.219 s) : 0, 1218622
Total [candidate] (9.163 s) : 0, 9163177
section iast_TELEMETRY_OFF
Agent [baseline] (1.216 s) : 0, 1215558
Total [baseline] (9.181 s) : 0, 9180569
Agent [candidate] (1.214 s) : 0, 1213665
Total [candidate] (9.184 s) : 0, 9183972
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.088 s -
Agent iast 1.217 s 129.478 ms (11.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.242 s 153.725 ms (14.1%)
Agent iast_TELEMETRY_OFF 1.216 s 127.655 ms (11.7%)
Total tracing 8.672 s -
Total iast 9.198 s 525.926 ms (6.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.2 s 528.159 ms (6.1%)
Total iast_TELEMETRY_OFF 9.181 s 508.557 ms (5.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.091 s -
Agent iast 1.219 s 128.192 ms (11.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.219 s 127.608 ms (11.7%)
Agent iast_TELEMETRY_OFF 1.214 s 122.651 ms (11.2%)
Total tracing 8.702 s -
Total iast 9.241 s 539.806 ms (6.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.163 s 461.672 ms (5.3%)
Total iast_TELEMETRY_OFF 9.184 s 482.468 ms (5.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.44.0-SNAPSHOT~d4db5dfd6f, baseline=1.44.0-SNAPSHOT~966ef84e87

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (693.368 ms) : 0, 693368
BytebuddyAgent [candidate] (694.649 ms) : 0, 694649
GlobalTracer [baseline] (317.001 ms) : 0, 317001
GlobalTracer [candidate] (317.352 ms) : 0, 317352
AppSec [baseline] (54.703 ms) : 0, 54703
AppSec [candidate] (54.756 ms) : 0, 54756
Remote Config [baseline] (673.972 µs) : 0, 674
Remote Config [candidate] (672.979 µs) : 0, 673
Telemetry [baseline] (8.498 ms) : 0, 8498
Telemetry [candidate] (9.822 ms) : 0, 9822
section iast
BytebuddyAgent [baseline] (811.095 ms) : 0, 811095
BytebuddyAgent [candidate] (812.021 ms) : 0, 812021
GlobalTracer [baseline] (305.39 ms) : 0, 305390
GlobalTracer [candidate] (306.003 ms) : 0, 306003
AppSec [baseline] (58.172 ms) : 0, 58172
AppSec [candidate] (58.45 ms) : 0, 58450
Remote Config [baseline] (646.949 µs) : 0, 647
Remote Config [candidate] (651.899 µs) : 0, 652
Telemetry [baseline] (7.524 ms) : 0, 7524
Telemetry [candidate] (7.517 ms) : 0, 7517
IAST [baseline] (20.869 ms) : 0, 20869
IAST [candidate] (20.836 ms) : 0, 20836
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (829.841 ms) : 0, 829841
BytebuddyAgent [candidate] (811.154 ms) : 0, 811154
GlobalTracer [baseline] (310.648 ms) : 0, 310648
GlobalTracer [candidate] (305.96 ms) : 0, 305960
AppSec [baseline] (57.832 ms) : 0, 57832
AppSec [candidate] (56.9 ms) : 0, 56900
Remote Config [baseline] (648.233 µs) : 0, 648
Remote Config [candidate] (634.093 µs) : 0, 634
Telemetry [baseline] (7.558 ms) : 0, 7558
Telemetry [candidate] (7.598 ms) : 0, 7598
IAST [baseline] (21.099 ms) : 0, 21099
IAST [candidate] (22.67 ms) : 0, 22670
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (808.871 ms) : 0, 808871
BytebuddyAgent [candidate] (807.786 ms) : 0, 807786
GlobalTracer [baseline] (306.626 ms) : 0, 306626
GlobalTracer [candidate] (305.801 ms) : 0, 305801
AppSec [baseline] (56.56 ms) : 0, 56560
AppSec [candidate] (57.847 ms) : 0, 57847
Remote Config [baseline] (623.509 µs) : 0, 624
Remote Config [candidate] (640.349 µs) : 0, 640
Telemetry [baseline] (7.326 ms) : 0, 7326
Telemetry [candidate] (7.453 ms) : 0, 7453
IAST [baseline] (21.84 ms) : 0, 21840
IAST [candidate] (20.415 ms) : 0, 20415
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.44.0-SNAPSHOT~d4db5dfd6f, baseline=1.44.0-SNAPSHOT~966ef84e87

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.098 s) : 0, 1098307
Total [baseline] (10.474 s) : 0, 10474012
Agent [candidate] (1.097 s) : 0, 1096863
Total [candidate] (10.47 s) : 0, 10470474
section appsec
Agent [baseline] (1.232 s) : 0, 1231547
Total [baseline] (10.725 s) : 0, 10724747
Agent [candidate] (1.229 s) : 0, 1228533
Total [candidate] (10.731 s) : 0, 10731328
section iast
Agent [baseline] (1.225 s) : 0, 1224710
Total [baseline] (10.91 s) : 0, 10909909
Agent [candidate] (1.226 s) : 0, 1225681
Total [candidate] (10.913 s) : 0, 10912681
section profiling
Agent [baseline] (1.32 s) : 0, 1319826
Total [baseline] (10.893 s) : 0, 10893157
Agent [candidate] (1.317 s) : 0, 1317072
Total [candidate] (10.859 s) : 0, 10859463
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.098 s -
Agent appsec 1.232 s 133.24 ms (12.1%)
Agent iast 1.225 s 126.403 ms (11.5%)
Agent profiling 1.32 s 221.52 ms (20.2%)
Total tracing 10.474 s -
Total appsec 10.725 s 250.735 ms (2.4%)
Total iast 10.91 s 435.897 ms (4.2%)
Total profiling 10.893 s 419.145 ms (4.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.097 s -
Agent appsec 1.229 s 131.67 ms (12.0%)
Agent iast 1.226 s 128.817 ms (11.7%)
Agent profiling 1.317 s 220.208 ms (20.1%)
Total tracing 10.47 s -
Total appsec 10.731 s 260.853 ms (2.5%)
Total iast 10.913 s 442.206 ms (4.2%)
Total profiling 10.859 s 388.989 ms (3.7%) 
gantt
    title petclinic - break down per module: candidate=1.44.0-SNAPSHOT~d4db5dfd6f, baseline=1.44.0-SNAPSHOT~966ef84e87

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (698.825 ms) : 0, 698825
BytebuddyAgent [candidate] (698.893 ms) : 0, 698893
GlobalTracer [baseline] (319.296 ms) : 0, 319296
GlobalTracer [candidate] (319.495 ms) : 0, 319495
AppSec [baseline] (55.076 ms) : 0, 55076
AppSec [candidate] (54.771 ms) : 0, 54771
Remote Config [baseline] (688.193 µs) : 0, 688
Remote Config [candidate] (680.615 µs) : 0, 681
Telemetry [baseline] (10.634 ms) : 0, 10634
Telemetry [candidate] (9.255 ms) : 0, 9255
section appsec
BytebuddyAgent [baseline] (715.737 ms) : 0, 715737
BytebuddyAgent [candidate] (713.658 ms) : 0, 713658
GlobalTracer [baseline] (315.898 ms) : 0, 315898
GlobalTracer [candidate] (314.849 ms) : 0, 314849
AppSec [baseline] (167.107 ms) : 0, 167107
AppSec [candidate] (168.094 ms) : 0, 168094
Remote Config [baseline] (646.102 µs) : 0, 646
Remote Config [candidate] (641.668 µs) : 0, 642
Telemetry [baseline] (8.899 ms) : 0, 8899
Telemetry [candidate] (7.766 ms) : 0, 7766
IAST [baseline] (19.021 ms) : 0, 19021
IAST [candidate] (19.604 ms) : 0, 19604
section iast
BytebuddyAgent [baseline] (816.5 ms) : 0, 816500
BytebuddyAgent [candidate] (817.147 ms) : 0, 817147
GlobalTracer [baseline] (307.627 ms) : 0, 307627
GlobalTracer [candidate] (307.847 ms) : 0, 307847
AppSec [baseline] (57.133 ms) : 0, 57133
AppSec [candidate] (57.066 ms) : 0, 57066
Remote Config [baseline] (630.851 µs) : 0, 631
Remote Config [candidate] (632.723 µs) : 0, 633
Telemetry [baseline] (7.48 ms) : 0, 7480
Telemetry [candidate] (7.453 ms) : 0, 7453
IAST [baseline] (21.562 ms) : 0, 21562
IAST [candidate] (21.757 ms) : 0, 21757
section profiling
ProfilingAgent [baseline] (93.606 ms) : 0, 93606
ProfilingAgent [candidate] (94.07 ms) : 0, 94070
BytebuddyAgent [baseline] (689.155 ms) : 0, 689155
BytebuddyAgent [candidate] (687.93 ms) : 0, 687930
GlobalTracer [baseline] (435.456 ms) : 0, 435456
GlobalTracer [candidate] (433.719 ms) : 0, 433719
AppSec [baseline] (54.141 ms) : 0, 54141
AppSec [candidate] (53.929 ms) : 0, 53929
Remote Config [baseline] (677.13 µs) : 0, 677
Remote Config [candidate] (661.058 µs) : 0, 661
Telemetry [baseline] (7.74 ms) : 0, 7740
Telemetry [candidate] (7.756 ms) : 0, 7756
Profiling [baseline] (93.629 ms) : 0, 93629
Profiling [candidate] (94.094 ms) : 0, 94094
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-11-27T15:20:08 2024-11-27T15:27:05
git_branch master nikita-tkachenko/exclude-git-data-upload-errors-from-telemetry
git_commit_date 1732709291 1732720141
git_commit_sha 966ef84 d4db5df
release_version 1.44.0-SNAPSHOT~966ef84e87 1.44.0-SNAPSHOT~d4db5dfd6f
start_time 2024-11-27T15:19:54 2024-11-27T15:26:51
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1732721577 1732721577
ci_job_id 722092451 722092451
ci_pipeline_id 50064395 50064395
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~d4db5dfd6f, baseline=1.44.0-SNAPSHOT~966ef84e87
    dateFormat X
    axisFormat %s
section baseline
no_agent (377.558 µs) : 358, 397
.   : milestone, 378,
iast (490.191 µs) : 468, 512
.   : milestone, 490,
iast_FULL (647.152 µs) : 625, 669
.   : milestone, 647,
iast_GLOBAL (510.869 µs) : 489, 532
.   : milestone, 511,
iast_HARDCODED_SECRET_DISABLED (496.919 µs) : 475, 519
.   : milestone, 497,
iast_INACTIVE (450.027 µs) : 428, 472
.   : milestone, 450,
iast_TELEMETRY_OFF (473.077 µs) : 452, 494
.   : milestone, 473,
tracing (444.794 µs) : 424, 466
.   : milestone, 445,
section candidate
no_agent (370.439 µs) : 350, 391
.   : milestone, 370,
iast (495.785 µs) : 474, 518
.   : milestone, 496,
iast_FULL (643.238 µs) : 622, 665
.   : milestone, 643,
iast_GLOBAL (519.646 µs) : 497, 542
.   : milestone, 520,
iast_HARDCODED_SECRET_DISABLED (486.495 µs) : 464, 508
.   : milestone, 486,
iast_INACTIVE (444.815 µs) : 424, 466
.   : milestone, 445,
iast_TELEMETRY_OFF (477.07 µs) : 456, 498
.   : milestone, 477,
tracing (445.714 µs) : 424, 467
.   : milestone, 446,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 377.558 µs [357.905 µs, 397.212 µs] -
iast 490.191 µs [468.403 µs, 511.978 µs] 112.632 µs (29.8%)
iast_FULL 647.152 µs [625.399 µs, 668.904 µs] 269.593 µs (71.4%)
iast_GLOBAL 510.869 µs [489.477 µs, 532.26 µs] 133.311 µs (35.3%)
iast_HARDCODED_SECRET_DISABLED 496.919 µs [474.591 µs, 519.246 µs] 119.361 µs (31.6%)
iast_INACTIVE 450.027 µs [428.066 µs, 471.988 µs] 72.469 µs (19.2%)
iast_TELEMETRY_OFF 473.077 µs [451.816 µs, 494.337 µs] 95.519 µs (25.3%)
tracing 444.794 µs [423.883 µs, 465.705 µs] 67.236 µs (17.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.439 µs [350.274 µs, 390.605 µs] -
iast 495.785 µs [473.913 µs, 517.658 µs] 125.346 µs (33.8%)
iast_FULL 643.238 µs [621.785 µs, 664.691 µs] 272.799 µs (73.6%)
iast_GLOBAL 519.646 µs [496.916 µs, 542.375 µs] 149.206 µs (40.3%)
iast_HARDCODED_SECRET_DISABLED 486.495 µs [464.495 µs, 508.494 µs] 116.055 µs (31.3%)
iast_INACTIVE 444.815 µs [424.005 µs, 465.625 µs] 74.376 µs (20.1%)
iast_TELEMETRY_OFF 477.07 µs [455.866 µs, 498.274 µs] 106.63 µs (28.8%)
tracing 445.714 µs [424.436 µs, 466.991 µs] 75.274 µs (20.3%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~d4db5dfd6f, baseline=1.44.0-SNAPSHOT~966ef84e87
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.336 ms) : 1316, 1356
.   : milestone, 1336,
appsec (1.748 ms) : 1723, 1773
.   : milestone, 1748,
appsec_no_iast (1.739 ms) : 1715, 1764
.   : milestone, 1739,
iast (1.497 ms) : 1474, 1520
.   : milestone, 1497,
profiling (1.504 ms) : 1480, 1528
.   : milestone, 1504,
tracing (1.483 ms) : 1458, 1507
.   : milestone, 1483,
section candidate
no_agent (1.357 ms) : 1338, 1377
.   : milestone, 1357,
appsec (1.736 ms) : 1712, 1760
.   : milestone, 1736,
appsec_no_iast (1.731 ms) : 1706, 1756
.   : milestone, 1731,
iast (1.495 ms) : 1472, 1517
.   : milestone, 1495,
profiling (1.495 ms) : 1472, 1519
.   : milestone, 1495,
tracing (1.489 ms) : 1464, 1514
.   : milestone, 1489,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.336 ms [1.316 ms, 1.356 ms] -
appsec 1.748 ms [1.723 ms, 1.773 ms] 411.946 µs (30.8%)
appsec_no_iast 1.739 ms [1.715 ms, 1.764 ms] 403.313 µs (30.2%)
iast 1.497 ms [1.474 ms, 1.52 ms] 161.298 µs (12.1%)
profiling 1.504 ms [1.48 ms, 1.528 ms] 167.967 µs (12.6%)
tracing 1.483 ms [1.458 ms, 1.507 ms] 146.406 µs (11.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.357 ms [1.338 ms, 1.377 ms] -
appsec 1.736 ms [1.712 ms, 1.76 ms] 378.759 µs (27.9%)
appsec_no_iast 1.731 ms [1.706 ms, 1.756 ms] 373.606 µs (27.5%)
iast 1.495 ms [1.472 ms, 1.517 ms] 137.541 µs (10.1%)
profiling 1.495 ms [1.472 ms, 1.519 ms] 138.081 µs (10.2%)
tracing 1.489 ms [1.464 ms, 1.514 ms] 131.658 µs (9.7%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/exclude-git-data-upload-errors-from-telemetry
git_commit_date 1732709291 1732720141
git_commit_sha 966ef84 d4db5df
release_version 1.44.0-SNAPSHOT~966ef84e87 1.44.0-SNAPSHOT~d4db5dfd6f
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1732722140 1732722140
ci_job_id 722092452 722092452
ci_pipeline_id 50064395 50064395
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~d4db5dfd6f, baseline=1.44.0-SNAPSHOT~966ef84e87
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.952 s) : 14952000, 14952000
.   : milestone, 14952000,
appsec (14.875 s) : 14875000, 14875000
.   : milestone, 14875000,
iast (19.096 s) : 19096000, 19096000
.   : milestone, 19096000,
iast_GLOBAL (17.538 s) : 17538000, 17538000
.   : milestone, 17538000,
profiling (14.943 s) : 14943000, 14943000
.   : milestone, 14943000,
tracing (14.898 s) : 14898000, 14898000
.   : milestone, 14898000,
section candidate
no_agent (14.87 s) : 14870000, 14870000
.   : milestone, 14870000,
appsec (15.166 s) : 15166000, 15166000
.   : milestone, 15166000,
iast (18.989 s) : 18989000, 18989000
.   : milestone, 18989000,
iast_GLOBAL (18.001 s) : 18001000, 18001000
.   : milestone, 18001000,
profiling (14.748 s) : 14748000, 14748000
.   : milestone, 14748000,
tracing (15.066 s) : 15066000, 15066000
.   : milestone, 15066000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.952 s [14.952 s, 14.952 s] -
appsec 14.875 s [14.875 s, 14.875 s] -77.0 ms (-0.5%)
iast 19.096 s [19.096 s, 19.096 s] 4.144 s (27.7%)
iast_GLOBAL 17.538 s [17.538 s, 17.538 s] 2.586 s (17.3%)
profiling 14.943 s [14.943 s, 14.943 s] -9.0 ms (-0.1%)
tracing 14.898 s [14.898 s, 14.898 s] -54.0 ms (-0.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.87 s [14.87 s, 14.87 s] -
appsec 15.166 s [15.166 s, 15.166 s] 296.0 ms (2.0%)
iast 18.989 s [18.989 s, 18.989 s] 4.119 s (27.7%)
iast_GLOBAL 18.001 s [18.001 s, 18.001 s] 3.131 s (21.1%)
profiling 14.748 s [14.748 s, 14.748 s] -122.0 ms (-0.8%)
tracing 15.066 s [15.066 s, 15.066 s] 196.0 ms (1.3%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~d4db5dfd6f, baseline=1.44.0-SNAPSHOT~966ef84e87
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1484
.   : milestone, 1473,
appsec (2.355 ms) : 2313, 2397
.   : milestone, 2355,
iast (2.094 ms) : 2041, 2146
.   : milestone, 2094,
iast_GLOBAL (2.129 ms) : 2076, 2182
.   : milestone, 2129,
profiling (1.97 ms) : 1927, 2014
.   : milestone, 1970,
tracing (1.937 ms) : 1896, 1978
.   : milestone, 1937,
section candidate
no_agent (1.475 ms) : 1464, 1486
.   : milestone, 1475,
appsec (2.35 ms) : 2309, 2392
.   : milestone, 2350,
iast (2.098 ms) : 2045, 2151
.   : milestone, 2098,
iast_GLOBAL (2.137 ms) : 2084, 2190
.   : milestone, 2137,
profiling (1.956 ms) : 1914, 1999
.   : milestone, 1956,
tracing (1.931 ms) : 1890, 1971
.   : milestone, 1931,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.473 ms [1.461 ms, 1.484 ms] -
appsec 2.355 ms [2.313 ms, 2.397 ms] 882.442 µs (59.9%)
iast 2.094 ms [2.041 ms, 2.146 ms] 621.15 µs (42.2%)
iast_GLOBAL 2.129 ms [2.076 ms, 2.182 ms] 656.543 µs (44.6%)
profiling 1.97 ms [1.927 ms, 2.014 ms] 497.898 µs (33.8%)
tracing 1.937 ms [1.896 ms, 1.978 ms] 464.492 µs (31.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.475 ms [1.464 ms, 1.486 ms] -
appsec 2.35 ms [2.309 ms, 2.392 ms] 875.048 µs (59.3%)
iast 2.098 ms [2.045 ms, 2.151 ms] 622.745 µs (42.2%)
iast_GLOBAL 2.137 ms [2.084 ms, 2.19 ms] 661.822 µs (44.9%)
profiling 1.956 ms [1.914 ms, 1.999 ms] 481.489 µs (32.6%)
tracing 1.931 ms [1.89 ms, 1.971 ms] 455.631 µs (30.9%)

@nikita-tkachenko-datadog nikita-tkachenko-datadog merged commit ad94ba0 into master Nov 27, 2024
109 checks passed
@nikita-tkachenko-datadog nikita-tkachenko-datadog deleted the nikita-tkachenko/exclude-git-data-upload-errors-from-telemetry branch November 27, 2024 16:01
@github-actions github-actions bot added this to the 1.44.0 milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmarchenko anmarchenko anmarchenko approved these changes

@ValentinZakharov ValentinZakharov Awaiting requested review from ValentinZakharov

Assignees
No one assigned
Labels
comp: ci visibility Continuous Integration Visibility tag: no release notes Changes to exclude from release notes
Projects
None yet
Milestone
1.44.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nikita-tkachenko-datadog @anmarchenko