Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace JAVA_TOOL_OPTIONS by jvm.options OpenLiberty server configuration file #8031

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Replace JAVA_TOOL_OPTIONS by jvm.options OpenLiberty server configuration file #8031

merged 1 commit into from
Nov 29, 2024

Conversation

PerfectSlayer
Copy link
Contributor

@PerfectSlayer PerfectSlayer commented Nov 28, 2024 •
edited
Loading

What Does This Do

This PR replaces usage of the JAVA_TOOL_OPTIONS environment variable by the jvm.options server configuration file from OpenLiberty.

Motivation

The JAVA_TOOL_OPTIONS is limited to 1024 characters on some Java versions and it starts reaching the limit.
I also tried JVM_ARGS environment variable but it was not picked by our deployment method (runnable jar).

Additional Notes

As multiple specifications can use the same runnable jar at the same time (when running tests in parallel), the jar is copied before injecting configuration.
This is a fix required to enable crash-tracking more widely in our system tests #7855

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@PerfectSlayer PerfectSlayer added comp: testing Testing tag: no release notes Changes to exclude from release notes inst: opentelemetry OpenTelemetry instrumentation labels Nov 28, 2024
@PerfectSlayer PerfectSlayer requested a review from a team as a code owner November 28, 2024 10:38
@PerfectSlayer PerfectSlayer requested a review from smola November 28, 2024 10:38
@PerfectSlayer PerfectSlayer changed the title Replace JAVA_TOOL_OPTIONS by jvm.options openliberty server configuration file Replace JAVA_TOOL_OPTIONS by jvm.options OpenLiberty server configuration file Nov 28, 2024
@pr-commenter
Copy link

pr-commenter bot commented Nov 28, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/smoke-tests
git_commit_date 1732805707 1732813568
git_commit_sha 508c314 e735231
release_version 1.44.0-SNAPSHOT~508c314d67 1.44.0-SNAPSHOT~e73523127f
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1732815994 1732815994
ci_job_id 723060950 723060950
ci_pipeline_id 50117780 50117780
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 8 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.44.0-SNAPSHOT~e73523127f, baseline=1.44.0-SNAPSHOT~508c314d67

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.091 s) : 0, 1091035
Total [baseline] (8.656 s) : 0, 8656189
Agent [candidate] (1.092 s) : 0, 1092005
Total [candidate] (8.639 s) : 0, 8639393
section iast
Agent [baseline] (1.217 s) : 0, 1217473
Total [baseline] (9.231 s) : 0, 9230760
Agent [candidate] (1.221 s) : 0, 1221118
Total [candidate] (9.203 s) : 0, 9203379
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.218 s) : 0, 1217948
Total [baseline] (9.169 s) : 0, 9169023
Agent [candidate] (1.237 s) : 0, 1237103
Total [candidate] (9.3 s) : 0, 9300450
section iast_TELEMETRY_OFF
Agent [baseline] (1.22 s) : 0, 1220318
Total [baseline] (9.167 s) : 0, 9167314
Agent [candidate] (1.216 s) : 0, 1215547
Total [candidate] (9.169 s) : 0, 9168822
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.091 s -
Agent iast 1.217 s 126.437 ms (11.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.218 s 126.913 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.22 s 129.283 ms (11.8%)
Total tracing 8.656 s -
Total iast 9.231 s 574.571 ms (6.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.169 s 512.834 ms (5.9%)
Total iast_TELEMETRY_OFF 9.167 s 511.125 ms (5.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.092 s -
Agent iast 1.221 s 129.113 ms (11.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.237 s 145.098 ms (13.3%)
Agent iast_TELEMETRY_OFF 1.216 s 123.541 ms (11.3%)
Total tracing 8.639 s -
Total iast 9.203 s 563.986 ms (6.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.3 s 661.057 ms (7.7%)
Total iast_TELEMETRY_OFF 9.169 s 529.429 ms (6.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.44.0-SNAPSHOT~e73523127f, baseline=1.44.0-SNAPSHOT~508c314d67

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (694.581 ms) : 0, 694581
BytebuddyAgent [candidate] (694.981 ms) : 0, 694981
GlobalTracer [baseline] (318.853 ms) : 0, 318853
GlobalTracer [candidate] (317.561 ms) : 0, 317561
AppSec [baseline] (54.768 ms) : 0, 54768
AppSec [candidate] (55.042 ms) : 0, 55042
Remote Config [baseline] (690.196 µs) : 0, 690
Remote Config [candidate] (677.376 µs) : 0, 677
Telemetry [baseline] (8.422 ms) : 0, 8422
Telemetry [candidate] (9.877 ms) : 0, 9877
section iast
BytebuddyAgent [baseline] (810.811 ms) : 0, 810811
BytebuddyAgent [candidate] (812.805 ms) : 0, 812805
GlobalTracer [baseline] (305.525 ms) : 0, 305525
GlobalTracer [candidate] (307.0 ms) : 0, 307000
AppSec [baseline] (56.807 ms) : 0, 56807
AppSec [candidate] (58.446 ms) : 0, 58446
IAST [baseline] (22.479 ms) : 0, 22479
IAST [candidate] (20.901 ms) : 0, 20901
Remote Config [baseline] (620.877 µs) : 0, 621
Remote Config [candidate] (629.302 µs) : 0, 629
Telemetry [baseline] (7.5 ms) : 0, 7500
Telemetry [candidate] (7.557 ms) : 0, 7557
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (811.513 ms) : 0, 811513
BytebuddyAgent [candidate] (825.437 ms) : 0, 825437
GlobalTracer [baseline] (305.816 ms) : 0, 305816
GlobalTracer [candidate] (309.806 ms) : 0, 309806
AppSec [baseline] (56.834 ms) : 0, 56834
AppSec [candidate] (58.524 ms) : 0, 58524
IAST [baseline] (21.809 ms) : 0, 21809
IAST [candidate] (21.093 ms) : 0, 21093
Remote Config [baseline] (633.186 µs) : 0, 633
Remote Config [candidate] (642.037 µs) : 0, 642
Telemetry [baseline] (7.541 ms) : 0, 7541
Telemetry [candidate] (7.651 ms) : 0, 7651
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (814.012 ms) : 0, 814012
BytebuddyAgent [candidate] (808.854 ms) : 0, 808854
GlobalTracer [baseline] (305.616 ms) : 0, 305616
GlobalTracer [candidate] (306.27 ms) : 0, 306270
AppSec [baseline] (58.283 ms) : 0, 58283
AppSec [candidate] (58.106 ms) : 0, 58106
IAST [baseline] (20.498 ms) : 0, 20498
IAST [candidate] (20.486 ms) : 0, 20486
Remote Config [baseline] (632.156 µs) : 0, 632
Remote Config [candidate] (629.707 µs) : 0, 630
Telemetry [baseline] (7.451 ms) : 0, 7451
Telemetry [candidate] (7.455 ms) : 0, 7455
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.44.0-SNAPSHOT~e73523127f, baseline=1.44.0-SNAPSHOT~508c314d67

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.09 s) : 0, 1090394
Total [baseline] (10.448 s) : 0, 10448251
Agent [candidate] (1.098 s) : 0, 1098476
Total [candidate] (10.399 s) : 0, 10398871
section appsec
Agent [baseline] (1.223 s) : 0, 1222893
Total [baseline] (10.696 s) : 0, 10696075
Agent [candidate] (1.224 s) : 0, 1224310
Total [candidate] (10.731 s) : 0, 10731353
section iast
Agent [baseline] (1.217 s) : 0, 1217080
Total [baseline] (10.95 s) : 0, 10949843
Agent [candidate] (1.22 s) : 0, 1219795
Total [candidate] (11.029 s) : 0, 11028607
section profiling
Agent [baseline] (1.312 s) : 0, 1312046
Total [baseline] (10.755 s) : 0, 10754772
Agent [candidate] (1.325 s) : 0, 1324560
Total [candidate] (10.798 s) : 0, 10798063
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.09 s -
Agent appsec 1.223 s 132.499 ms (12.2%)
Agent iast 1.217 s 126.686 ms (11.6%)
Agent profiling 1.312 s 221.652 ms (20.3%)
Total tracing 10.448 s -
Total appsec 10.696 s 247.824 ms (2.4%)
Total iast 10.95 s 501.592 ms (4.8%)
Total profiling 10.755 s 306.521 ms (2.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.098 s -
Agent appsec 1.224 s 125.834 ms (11.5%)
Agent iast 1.22 s 121.319 ms (11.0%)
Agent profiling 1.325 s 226.084 ms (20.6%)
Total tracing 10.399 s -
Total appsec 10.731 s 332.482 ms (3.2%)
Total iast 11.029 s 629.736 ms (6.1%)
Total profiling 10.798 s 399.192 ms (3.8%) 
gantt
    title petclinic - break down per module: candidate=1.44.0-SNAPSHOT~e73523127f, baseline=1.44.0-SNAPSHOT~508c314d67

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (693.085 ms) : 0, 693085
BytebuddyAgent [candidate] (697.61 ms) : 0, 697610
GlobalTracer [baseline] (317.518 ms) : 0, 317518
GlobalTracer [candidate] (319.564 ms) : 0, 319564
AppSec [baseline] (54.838 ms) : 0, 54838
AppSec [candidate] (54.741 ms) : 0, 54741
Remote Config [baseline] (689.233 µs) : 0, 689
Remote Config [candidate] (679.352 µs) : 0, 679
Telemetry [baseline] (10.563 ms) : 0, 10563
Telemetry [candidate] (12.047 ms) : 0, 12047
section appsec
BytebuddyAgent [baseline] (709.788 ms) : 0, 709788
BytebuddyAgent [candidate] (710.71 ms) : 0, 710710
GlobalTracer [baseline] (313.991 ms) : 0, 313991
GlobalTracer [candidate] (314.317 ms) : 0, 314317
AppSec [baseline] (167.479 ms) : 0, 167479
AppSec [candidate] (166.511 ms) : 0, 166511
Remote Config [baseline] (639.335 µs) : 0, 639
Remote Config [candidate] (634.813 µs) : 0, 635
Telemetry [baseline] (7.416 ms) : 0, 7416
Telemetry [candidate] (8.924 ms) : 0, 8924
IAST [baseline] (19.772 ms) : 0, 19772
IAST [candidate] (18.94 ms) : 0, 18940
section iast
BytebuddyAgent [baseline] (811.035 ms) : 0, 811035
BytebuddyAgent [candidate] (812.098 ms) : 0, 812098
GlobalTracer [baseline] (306.078 ms) : 0, 306078
GlobalTracer [candidate] (306.864 ms) : 0, 306864
AppSec [baseline] (57.267 ms) : 0, 57267
AppSec [candidate] (58.039 ms) : 0, 58039
Remote Config [baseline] (634.87 µs) : 0, 635
Remote Config [candidate] (652.455 µs) : 0, 652
Telemetry [baseline] (7.504 ms) : 0, 7504
Telemetry [candidate] (7.515 ms) : 0, 7515
IAST [baseline] (20.845 ms) : 0, 20845
IAST [candidate] (20.855 ms) : 0, 20855
section profiling
BytebuddyAgent [baseline] (685.226 ms) : 0, 685226
BytebuddyAgent [candidate] (693.112 ms) : 0, 693112
GlobalTracer [baseline] (432.228 ms) : 0, 432228
GlobalTracer [candidate] (436.128 ms) : 0, 436128
AppSec [baseline] (53.77 ms) : 0, 53770
AppSec [candidate] (54.045 ms) : 0, 54045
Remote Config [baseline] (678.879 µs) : 0, 679
Remote Config [candidate] (660.416 µs) : 0, 660
Telemetry [baseline] (7.667 ms) : 0, 7667
Telemetry [candidate] (7.663 ms) : 0, 7663
ProfilingAgent [baseline] (93.537 ms) : 0, 93537
ProfilingAgent [candidate] (93.533 ms) : 0, 93533
Profiling [baseline] (93.559 ms) : 0, 93559
Profiling [candidate] (93.557 ms) : 0, 93557
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-11-28T17:16:41 2024-11-28T17:23:42
git_branch master bbujon/smoke-tests
git_commit_date 1732805707 1732813568
git_commit_sha 508c314 e735231
release_version 1.44.0-SNAPSHOT~508c314d67 1.44.0-SNAPSHOT~e73523127f
start_time 2024-11-28T17:16:27 2024-11-28T17:23:28
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1732814977 1732814977
ci_job_id 723060953 723060953
ci_pipeline_id 50117780 50117780
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~e73523127f, baseline=1.44.0-SNAPSHOT~508c314d67
    dateFormat X
    axisFormat %s
section baseline
no_agent (378.89 µs) : 359, 398
.   : milestone, 379,
iast (492.232 µs) : 470, 514
.   : milestone, 492,
iast_FULL (663.116 µs) : 641, 685
.   : milestone, 663,
iast_GLOBAL (520.846 µs) : 499, 542
.   : milestone, 521,
iast_HARDCODED_SECRET_DISABLED (497.425 µs) : 476, 519
.   : milestone, 497,
iast_INACTIVE (463.245 µs) : 442, 484
.   : milestone, 463,
iast_TELEMETRY_OFF (494.131 µs) : 473, 516
.   : milestone, 494,
tracing (465.494 µs) : 444, 487
.   : milestone, 465,
section candidate
no_agent (389.279 µs) : 370, 409
.   : milestone, 389,
iast (498.615 µs) : 477, 520
.   : milestone, 499,
iast_FULL (660.518 µs) : 639, 682
.   : milestone, 661,
iast_GLOBAL (519.888 µs) : 499, 541
.   : milestone, 520,
iast_HARDCODED_SECRET_DISABLED (500.453 µs) : 479, 522
.   : milestone, 500,
iast_INACTIVE (463.597 µs) : 442, 485
.   : milestone, 464,
iast_TELEMETRY_OFF (486.172 µs) : 465, 507
.   : milestone, 486,
tracing (458.762 µs) : 438, 479
.   : milestone, 459,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 378.89 µs [359.481 µs, 398.299 µs] -
iast 492.232 µs [470.472 µs, 513.991 µs] 113.342 µs (29.9%)
iast_FULL 663.116 µs [641.267 µs, 684.966 µs] 284.226 µs (75.0%)
iast_GLOBAL 520.846 µs [499.344 µs, 542.348 µs] 141.956 µs (37.5%)
iast_HARDCODED_SECRET_DISABLED 497.425 µs [476.061 µs, 518.788 µs] 118.535 µs (31.3%)
iast_INACTIVE 463.245 µs [442.18 µs, 484.31 µs] 84.355 µs (22.3%)
iast_TELEMETRY_OFF 494.131 µs [472.566 µs, 515.695 µs] 115.241 µs (30.4%)
tracing 465.494 µs [444.347 µs, 486.642 µs] 86.604 µs (22.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 389.279 µs [369.64 µs, 408.917 µs] -
iast 498.615 µs [477.296 µs, 519.933 µs] 109.336 µs (28.1%)
iast_FULL 660.518 µs [638.932 µs, 682.104 µs] 271.239 µs (69.7%)
iast_GLOBAL 519.888 µs [498.524 µs, 541.252 µs] 130.61 µs (33.6%)
iast_HARDCODED_SECRET_DISABLED 500.453 µs [478.75 µs, 522.157 µs] 111.175 µs (28.6%)
iast_INACTIVE 463.597 µs [441.973 µs, 485.221 µs] 74.318 µs (19.1%)
iast_TELEMETRY_OFF 486.172 µs [464.912 µs, 507.432 µs] 96.894 µs (24.9%)
tracing 458.762 µs [438.117 µs, 479.408 µs] 69.484 µs (17.8%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~e73523127f, baseline=1.44.0-SNAPSHOT~508c314d67
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.358 ms) : 1338, 1378
.   : milestone, 1358,
appsec (1.772 ms) : 1746, 1797
.   : milestone, 1772,
appsec_no_iast (1.773 ms) : 1749, 1798
.   : milestone, 1773,
iast (1.502 ms) : 1479, 1525
.   : milestone, 1502,
profiling (1.511 ms) : 1487, 1535
.   : milestone, 1511,
tracing (1.501 ms) : 1477, 1526
.   : milestone, 1501,
section candidate
no_agent (1.369 ms) : 1350, 1389
.   : milestone, 1369,
appsec (1.767 ms) : 1742, 1793
.   : milestone, 1767,
appsec_no_iast (1.753 ms) : 1728, 1778
.   : milestone, 1753,
iast (1.511 ms) : 1487, 1534
.   : milestone, 1511,
profiling (1.528 ms) : 1505, 1550
.   : milestone, 1528,
tracing (1.505 ms) : 1481, 1530
.   : milestone, 1505,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.358 ms [1.338 ms, 1.378 ms] -
appsec 1.772 ms [1.746 ms, 1.797 ms] 413.721 µs (30.5%)
appsec_no_iast 1.773 ms [1.749 ms, 1.798 ms] 415.396 µs (30.6%)
iast 1.502 ms [1.479 ms, 1.525 ms] 144.155 µs (10.6%)
profiling 1.511 ms [1.487 ms, 1.535 ms] 152.586 µs (11.2%)
tracing 1.501 ms [1.477 ms, 1.526 ms] 143.333 µs (10.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.369 ms [1.35 ms, 1.389 ms] -
appsec 1.767 ms [1.742 ms, 1.793 ms] 397.718 µs (29.0%)
appsec_no_iast 1.753 ms [1.728 ms, 1.778 ms] 383.265 µs (28.0%)
iast 1.511 ms [1.487 ms, 1.534 ms] 141.196 µs (10.3%)
profiling 1.528 ms [1.505 ms, 1.55 ms] 158.291 µs (11.6%)
tracing 1.505 ms [1.481 ms, 1.53 ms] 136.149 µs (9.9%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/smoke-tests
git_commit_date 1732805707 1732813568
git_commit_sha 508c314 e735231
release_version 1.44.0-SNAPSHOT~508c314d67 1.44.0-SNAPSHOT~e73523127f
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1732815548 1732815548
ci_job_id 723060955 723060955
ci_pipeline_id 50117780 50117780
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~e73523127f, baseline=1.44.0-SNAPSHOT~508c314d67
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.763 s) : 14763000, 14763000
.   : milestone, 14763000,
appsec (14.907 s) : 14907000, 14907000
.   : milestone, 14907000,
iast (18.98 s) : 18980000, 18980000
.   : milestone, 18980000,
iast_GLOBAL (18.033 s) : 18033000, 18033000
.   : milestone, 18033000,
profiling (14.998 s) : 14998000, 14998000
.   : milestone, 14998000,
tracing (14.916 s) : 14916000, 14916000
.   : milestone, 14916000,
section candidate
no_agent (15.617 s) : 15617000, 15617000
.   : milestone, 15617000,
appsec (14.992 s) : 14992000, 14992000
.   : milestone, 14992000,
iast (18.936 s) : 18936000, 18936000
.   : milestone, 18936000,
iast_GLOBAL (17.962 s) : 17962000, 17962000
.   : milestone, 17962000,
profiling (14.924 s) : 14924000, 14924000
.   : milestone, 14924000,
tracing (15.246 s) : 15246000, 15246000
.   : milestone, 15246000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.763 s [14.763 s, 14.763 s] -
appsec 14.907 s [14.907 s, 14.907 s] 144.0 ms (1.0%)
iast 18.98 s [18.98 s, 18.98 s] 4.217 s (28.6%)
iast_GLOBAL 18.033 s [18.033 s, 18.033 s] 3.27 s (22.1%)
profiling 14.998 s [14.998 s, 14.998 s] 235.0 ms (1.6%)
tracing 14.916 s [14.916 s, 14.916 s] 153.0 ms (1.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.617 s [15.617 s, 15.617 s] -
appsec 14.992 s [14.992 s, 14.992 s] -625.0 ms (-4.0%)
iast 18.936 s [18.936 s, 18.936 s] 3.319 s (21.3%)
iast_GLOBAL 17.962 s [17.962 s, 17.962 s] 2.345 s (15.0%)
profiling 14.924 s [14.924 s, 14.924 s] -693.0 ms (-4.4%)
tracing 15.246 s [15.246 s, 15.246 s] -371.0 ms (-2.4%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~e73523127f, baseline=1.44.0-SNAPSHOT~508c314d67
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.476 ms) : 1464, 1487
.   : milestone, 1476,
appsec (2.362 ms) : 2320, 2403
.   : milestone, 2362,
iast (2.098 ms) : 2045, 2151
.   : milestone, 2098,
iast_GLOBAL (2.138 ms) : 2085, 2191
.   : milestone, 2138,
profiling (1.981 ms) : 1938, 2024
.   : milestone, 1981,
tracing (1.94 ms) : 1899, 1981
.   : milestone, 1940,
section candidate
no_agent (1.476 ms) : 1465, 1488
.   : milestone, 1476,
appsec (2.357 ms) : 2316, 2399
.   : milestone, 2357,
iast (2.103 ms) : 2050, 2155
.   : milestone, 2103,
iast_GLOBAL (2.15 ms) : 2097, 2204
.   : milestone, 2150,
profiling (1.958 ms) : 1916, 2000
.   : milestone, 1958,
tracing (1.928 ms) : 1889, 1968
.   : milestone, 1928,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.476 ms [1.464 ms, 1.487 ms] -
appsec 2.362 ms [2.32 ms, 2.403 ms] 885.824 µs (60.0%)
iast 2.098 ms [2.045 ms, 2.151 ms] 621.879 µs (42.1%)
iast_GLOBAL 2.138 ms [2.085 ms, 2.191 ms] 662.104 µs (44.9%)
profiling 1.981 ms [1.938 ms, 2.024 ms] 505.514 µs (34.3%)
tracing 1.94 ms [1.899 ms, 1.981 ms] 464.214 µs (31.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.476 ms [1.465 ms, 1.488 ms] -
appsec 2.357 ms [2.316 ms, 2.399 ms] 881.099 µs (59.7%)
iast 2.103 ms [2.05 ms, 2.155 ms] 626.675 µs (42.5%)
iast_GLOBAL 2.15 ms [2.097 ms, 2.204 ms] 674.371 µs (45.7%)
profiling 1.958 ms [1.916 ms, 2.0 ms] 481.81 µs (32.6%)
tracing 1.928 ms [1.889 ms, 1.968 ms] 452.452 µs (30.7%)

PerfectSlayer added a commit that referenced this pull request Nov 28, 2024
@PerfectSlayer
feat: Include OpenLiberty following JAVA_TOOL_OPTIONS fix
634c68a 
See #8031
@PerfectSlayer PerfectSlayer mentioned this pull request Nov 28, 2024
Merged
@PerfectSlayer
fix(smoke-tests): Replace JAVA_TOOL_OPTIONS by jvm.options openlibert…
e735231 
…y configuration file

JAVA_TOOL_OPTIONS is limited to 1024 characters and it starts reaching the limit.
@PerfectSlayer PerfectSlayer removed the inst: opentelemetry OpenTelemetry instrumentation label Nov 28, 2024
PerfectSlayer added a commit that referenced this pull request Nov 28, 2024
@PerfectSlayer
feat: Include OpenLiberty following JAVA_TOOL_OPTIONS fix
1f9b6f6 
See #8031
@PerfectSlayer PerfectSlayer merged commit 896dd6b into master Nov 29, 2024
104 checks passed
@PerfectSlayer PerfectSlayer deleted the bbujon/smoke-tests branch November 29, 2024 07:06
@github-actions github-actions bot added this to the 1.44.0 milestone Nov 29, 2024
PerfectSlayer added a commit that referenced this pull request Nov 29, 2024
@PerfectSlayer
feat: Include OpenLiberty following JAVA_TOOL_OPTIONS fix
b77bf72 
See #8031
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarziali amarziali amarziali approved these changes

@smola smola smola approved these changes

Assignees
No one assigned
Labels
comp: testing Testing tag: no release notes Changes to exclude from release notes
Projects
None yet
Milestone
1.44.0
Development

Successfully merging this pull request may close these issues.
3 participants
@PerfectSlayer @smola @amarziali