Instrument EMR's relocated AWS SDK #8157

mcculls · 2025-01-05T22:31:11Z

What Does This Do

Uses the new support for instrumentation of repackaged libraries to instrument EMR's relocated AWS SDK under com.amazon.ws.emr.hadoop.fs.shaded.

Motivation

Provides observability of AWS SDK calls made from EMR.

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: APMAPI-860

pr-commenter · 2025-01-05T22:53:26Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/support-awssdk-relocated-under-emr
git_commit_date	1736152625	1736153953
git_commit_sha	`6bfef97`	`ae0e15b`
release_version	1.45.0-SNAPSHOT~6bfef97d85	1.45.0-SNAPSHOT~ae0e15b712

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1736156592	1736156592
ci_job_id	755028280	755028280
ci_pipeline_id	52203500	52203500
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 3 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.45.0-SNAPSHOT~ae0e15b712, baseline=1.45.0-SNAPSHOT~6bfef97d85

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1067391
Total [baseline] (8.624 s) : 0, 8623716
Agent [candidate] (1.053 s) : 0, 1053397
Total [candidate] (8.6 s) : 0, 8600202
section iast
Agent [baseline] (1.188 s) : 0, 1187708
Total [baseline] (9.199 s) : 0, 9199432
Agent [candidate] (1.18 s) : 0, 1180007
Total [candidate] (9.252 s) : 0, 9252293
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.183 s) : 0, 1183411
Total [baseline] (9.18 s) : 0, 9180026
Agent [candidate] (1.183 s) : 0, 1182995
Total [candidate] (9.2 s) : 0, 9199653
section iast_TELEMETRY_OFF
Agent [baseline] (1.181 s) : 0, 1180722
Total [baseline] (9.166 s) : 0, 9166500
Agent [candidate] (1.178 s) : 0, 1177839
Total [candidate] (9.177 s) : 0, 9177030

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.067 s	-
Agent	iast	1.188 s	120.317 ms (11.3%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.183 s	116.019 ms (10.9%)
Agent	iast_TELEMETRY_OFF	1.181 s	113.331 ms (10.6%)
Total	tracing	8.624 s	-
Total	iast	9.199 s	575.715 ms (6.7%)
Total	iast_HARDCODED_SECRET_DISABLED	9.18 s	556.31 ms (6.5%)
Total	iast_TELEMETRY_OFF	9.166 s	542.784 ms (6.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.053 s	-
Agent	iast	1.18 s	126.61 ms (12.0%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.183 s	129.597 ms (12.3%)
Agent	iast_TELEMETRY_OFF	1.178 s	124.441 ms (11.8%)
Total	tracing	8.6 s	-
Total	iast	9.252 s	652.091 ms (7.6%)
Total	iast_HARDCODED_SECRET_DISABLED	9.2 s	599.451 ms (7.0%)
Total	iast_TELEMETRY_OFF	9.177 s	576.827 ms (6.7%)

gantt
    title insecure-bank - break down per module: candidate=1.45.0-SNAPSHOT~ae0e15b712, baseline=1.45.0-SNAPSHOT~6bfef97d85

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (722.9 ms) : 0, 722900
BytebuddyAgent [candidate] (712.957 ms) : 0, 712957
GlobalTracer [baseline] (257.377 ms) : 0, 257377
GlobalTracer [candidate] (255.425 ms) : 0, 255425
AppSec [baseline] (55.49 ms) : 0, 55490
AppSec [candidate] (55.122 ms) : 0, 55122
Remote Config [baseline] (735.42 µs) : 0, 735
Remote Config [candidate] (711.536 µs) : 0, 712
Telemetry [baseline] (15.656 ms) : 0, 15656
Telemetry [candidate] (14.183 ms) : 0, 14183
section iast
BytebuddyAgent [baseline] (836.399 ms) : 0, 836399
BytebuddyAgent [candidate] (829.963 ms) : 0, 829963
GlobalTracer [baseline] (247.243 ms) : 0, 247243
GlobalTracer [candidate] (245.884 ms) : 0, 245884
AppSec [baseline] (58.255 ms) : 0, 58255
AppSec [candidate] (58.316 ms) : 0, 58316
IAST [baseline] (21.427 ms) : 0, 21427
IAST [candidate] (21.679 ms) : 0, 21679
Remote Config [baseline] (665.98 µs) : 0, 666
Remote Config [candidate] (654.145 µs) : 0, 654
Telemetry [baseline] (8.614 ms) : 0, 8614
Telemetry [candidate] (8.534 ms) : 0, 8534
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (831.021 ms) : 0, 831021
BytebuddyAgent [candidate] (832.584 ms) : 0, 832584
GlobalTracer [baseline] (248.057 ms) : 0, 248057
GlobalTracer [candidate] (246.866 ms) : 0, 246866
AppSec [baseline] (58.313 ms) : 0, 58313
AppSec [candidate] (58.202 ms) : 0, 58202
IAST [baseline] (21.778 ms) : 0, 21778
IAST [candidate] (21.155 ms) : 0, 21155
Remote Config [baseline] (664.718 µs) : 0, 665
Remote Config [candidate] (652.217 µs) : 0, 652
Telemetry [baseline] (8.574 ms) : 0, 8574
Telemetry [candidate] (8.508 ms) : 0, 8508
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (830.82 ms) : 0, 830820
BytebuddyAgent [candidate] (828.526 ms) : 0, 828526
GlobalTracer [baseline] (247.439 ms) : 0, 247439
GlobalTracer [candidate] (246.517 ms) : 0, 246517
AppSec [baseline] (57.714 ms) : 0, 57714
AppSec [candidate] (57.957 ms) : 0, 57957
IAST [baseline] (20.689 ms) : 0, 20689
IAST [candidate] (20.771 ms) : 0, 20771
Remote Config [baseline] (641.769 µs) : 0, 642
Remote Config [candidate] (648.955 µs) : 0, 649
Telemetry [baseline] (8.401 ms) : 0, 8401
Telemetry [candidate] (8.365 ms) : 0, 8365

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.45.0-SNAPSHOT~ae0e15b712, baseline=1.45.0-SNAPSHOT~6bfef97d85

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1057064
Total [baseline] (10.403 s) : 0, 10402695
Agent [candidate] (1.057 s) : 0, 1057100
Total [candidate] (10.383 s) : 0, 10383085
section appsec
Agent [baseline] (1.187 s) : 0, 1186922
Total [baseline] (10.741 s) : 0, 10741400
Agent [candidate] (1.187 s) : 0, 1187179
Total [candidate] (10.705 s) : 0, 10705488
section iast
Agent [baseline] (1.18 s) : 0, 1180446
Total [baseline] (10.938 s) : 0, 10938294
Agent [candidate] (1.181 s) : 0, 1180668
Total [candidate] (10.956 s) : 0, 10956082
section profiling
Agent [baseline] (1.277 s) : 0, 1276802
Total [baseline] (10.761 s) : 0, 10761460
Agent [candidate] (1.279 s) : 0, 1278876
Total [candidate] (10.852 s) : 0, 10852389

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.057 s	-
Agent	appsec	1.187 s	129.858 ms (12.3%)
Agent	iast	1.18 s	123.382 ms (11.7%)
Agent	profiling	1.277 s	219.739 ms (20.8%)
Total	tracing	10.403 s	-
Total	appsec	10.741 s	338.705 ms (3.3%)
Total	iast	10.938 s	535.599 ms (5.1%)
Total	profiling	10.761 s	358.765 ms (3.4%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.057 s	-
Agent	appsec	1.187 s	130.079 ms (12.3%)
Agent	iast	1.181 s	123.569 ms (11.7%)
Agent	profiling	1.279 s	221.776 ms (21.0%)
Total	tracing	10.383 s	-
Total	appsec	10.705 s	322.403 ms (3.1%)
Total	iast	10.956 s	572.997 ms (5.5%)
Total	profiling	10.852 s	469.304 ms (4.5%)

gantt
    title petclinic - break down per module: candidate=1.45.0-SNAPSHOT~ae0e15b712, baseline=1.45.0-SNAPSHOT~6bfef97d85

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (714.142 ms) : 0, 714142
BytebuddyAgent [candidate] (713.715 ms) : 0, 713715
GlobalTracer [baseline] (256.424 ms) : 0, 256424
GlobalTracer [candidate] (256.43 ms) : 0, 256430
AppSec [baseline] (55.963 ms) : 0, 55963
AppSec [candidate] (56.229 ms) : 0, 56229
Remote Config [baseline] (725.649 µs) : 0, 726
Remote Config [candidate] (712.047 µs) : 0, 712
Telemetry [baseline] (14.871 ms) : 0, 14871
Telemetry [candidate] (15.011 ms) : 0, 15011
section appsec
BytebuddyAgent [baseline] (730.509 ms) : 0, 730509
BytebuddyAgent [candidate] (729.994 ms) : 0, 729994
GlobalTracer [baseline] (252.738 ms) : 0, 252738
GlobalTracer [candidate] (253.063 ms) : 0, 253063
AppSec [baseline] (170.3 ms) : 0, 170300
AppSec [candidate] (170.956 ms) : 0, 170956
IAST [baseline] (19.486 ms) : 0, 19486
IAST [candidate] (19.226 ms) : 0, 19226
Remote Config [baseline] (664.133 µs) : 0, 664
Remote Config [candidate] (658.21 µs) : 0, 658
Telemetry [baseline] (7.975 ms) : 0, 7975
Telemetry [candidate] (7.967 ms) : 0, 7967
section iast
BytebuddyAgent [baseline] (830.973 ms) : 0, 830973
BytebuddyAgent [candidate] (830.843 ms) : 0, 830843
GlobalTracer [baseline] (246.303 ms) : 0, 246303
GlobalTracer [candidate] (246.47 ms) : 0, 246470
AppSec [baseline] (58.034 ms) : 0, 58034
AppSec [candidate] (57.966 ms) : 0, 57966
IAST [baseline] (21.043 ms) : 0, 21043
IAST [candidate] (21.213 ms) : 0, 21213
Remote Config [baseline] (638.283 µs) : 0, 638
Remote Config [candidate] (656.896 µs) : 0, 657
Telemetry [baseline] (8.418 ms) : 0, 8418
Telemetry [candidate] (8.528 ms) : 0, 8528
section profiling
BytebuddyAgent [baseline] (703.174 ms) : 0, 703174
BytebuddyAgent [candidate] (703.973 ms) : 0, 703973
GlobalTracer [baseline] (372.217 ms) : 0, 372217
GlobalTracer [candidate] (373.572 ms) : 0, 373572
AppSec [baseline] (54.774 ms) : 0, 54774
AppSec [candidate] (54.875 ms) : 0, 54875
Remote Config [baseline] (665.794 µs) : 0, 666
Remote Config [candidate] (656.206 µs) : 0, 656
Telemetry [baseline] (7.94 ms) : 0, 7940
Telemetry [candidate] (7.906 ms) : 0, 7906
ProfilingAgent [baseline] (96.366 ms) : 0, 96366
ProfilingAgent [candidate] (96.091 ms) : 0, 96091
Profiling [baseline] (96.39 ms) : 0, 96390
Profiling [candidate] (96.115 ms) : 0, 96115

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-01-06T09:08:29	2025-01-06T09:15:30
git_branch	master	mcculls/support-awssdk-relocated-under-emr
git_commit_date	1736152625	1736153953
git_commit_sha	`6bfef97`	`ae0e15b`
release_version	1.45.0-SNAPSHOT~6bfef97d85	1.45.0-SNAPSHOT~ae0e15b712
start_time	2025-01-06T09:08:16	2025-01-06T09:15:16

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1736155283	1736155283
ci_job_id	755028281	755028281
ci_pipeline_id	52203500	52203500
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~ae0e15b712, baseline=1.45.0-SNAPSHOT~6bfef97d85
    dateFormat X
    axisFormat %s
section baseline
no_agent (379.057 µs) : 358, 400
.   : milestone, 379,
iast (493.062 µs) : 471, 515
.   : milestone, 493,
iast_FULL (654.868 µs) : 633, 676
.   : milestone, 655,
iast_GLOBAL (516.611 µs) : 495, 538
.   : milestone, 517,
iast_HARDCODED_SECRET_DISABLED (489.877 µs) : 468, 511
.   : milestone, 490,
iast_INACTIVE (456.801 µs) : 435, 478
.   : milestone, 457,
iast_TELEMETRY_OFF (488.697 µs) : 467, 510
.   : milestone, 489,
tracing (453.792 µs) : 432, 475
.   : milestone, 454,
section candidate
no_agent (379.136 µs) : 359, 400
.   : milestone, 379,
iast (501.197 µs) : 479, 523
.   : milestone, 501,
iast_FULL (659.362 µs) : 638, 681
.   : milestone, 659,
iast_GLOBAL (521.213 µs) : 499, 543
.   : milestone, 521,
iast_HARDCODED_SECRET_DISABLED (491.932 µs) : 471, 513
.   : milestone, 492,
iast_INACTIVE (454.044 µs) : 433, 476
.   : milestone, 454,
iast_TELEMETRY_OFF (485.024 µs) : 463, 507
.   : milestone, 485,
tracing (455.602 µs) : 434, 478
.   : milestone, 456,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	379.057 µs [357.853 µs, 400.26 µs]	-
iast	493.062 µs [471.012 µs, 515.112 µs]	114.006 µs (30.1%)
iast_FULL	654.868 µs [633.268 µs, 676.467 µs]	275.811 µs (72.8%)
iast_GLOBAL	516.611 µs [494.858 µs, 538.364 µs]	137.554 µs (36.3%)
iast_HARDCODED_SECRET_DISABLED	489.877 µs [468.385 µs, 511.37 µs]	110.82 µs (29.2%)
iast_INACTIVE	456.801 µs [435.419 µs, 478.184 µs]	77.745 µs (20.5%)
iast_TELEMETRY_OFF	488.697 µs [467.136 µs, 510.258 µs]	109.64 µs (28.9%)
tracing	453.792 µs [432.127 µs, 475.456 µs]	74.735 µs (19.7%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	379.136 µs [358.73 µs, 399.543 µs]	-
iast	501.197 µs [479.436 µs, 522.959 µs]	122.061 µs (32.2%)
iast_FULL	659.362 µs [637.539 µs, 681.185 µs]	280.226 µs (73.9%)
iast_GLOBAL	521.213 µs [499.042 µs, 543.384 µs]	142.077 µs (37.5%)
iast_HARDCODED_SECRET_DISABLED	491.932 µs [470.518 µs, 513.346 µs]	112.796 µs (29.8%)
iast_INACTIVE	454.044 µs [432.577 µs, 475.511 µs]	74.907 µs (19.8%)
iast_TELEMETRY_OFF	485.024 µs [462.903 µs, 507.144 µs]	105.887 µs (27.9%)
tracing	455.602 µs [433.578 µs, 477.626 µs]	76.465 µs (20.2%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~ae0e15b712, baseline=1.45.0-SNAPSHOT~6bfef97d85
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.36 ms) : 1341, 1380
.   : milestone, 1360,
appsec (1.786 ms) : 1763, 1809
.   : milestone, 1786,
appsec_no_iast (1.768 ms) : 1744, 1792
.   : milestone, 1768,
iast (1.508 ms) : 1484, 1532
.   : milestone, 1508,
profiling (1.522 ms) : 1497, 1547
.   : milestone, 1522,
tracing (1.503 ms) : 1479, 1528
.   : milestone, 1503,
section candidate
no_agent (1.36 ms) : 1340, 1379
.   : milestone, 1360,
appsec (1.742 ms) : 1718, 1766
.   : milestone, 1742,
appsec_no_iast (1.772 ms) : 1749, 1795
.   : milestone, 1772,
iast (1.501 ms) : 1478, 1524
.   : milestone, 1501,
profiling (1.519 ms) : 1496, 1542
.   : milestone, 1519,
tracing (1.476 ms) : 1450, 1501
.   : milestone, 1476,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.36 ms [1.341 ms, 1.38 ms]	-
appsec	1.786 ms [1.763 ms, 1.809 ms]	425.787 µs (31.3%)
appsec_no_iast	1.768 ms [1.744 ms, 1.792 ms]	407.97 µs (30.0%)
iast	1.508 ms [1.484 ms, 1.532 ms]	147.616 µs (10.9%)
profiling	1.522 ms [1.497 ms, 1.547 ms]	161.597 µs (11.9%)
tracing	1.503 ms [1.479 ms, 1.528 ms]	142.957 µs (10.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.36 ms [1.34 ms, 1.379 ms]	-
appsec	1.742 ms [1.718 ms, 1.766 ms]	382.046 µs (28.1%)
appsec_no_iast	1.772 ms [1.749 ms, 1.795 ms]	412.129 µs (30.3%)
iast	1.501 ms [1.478 ms, 1.524 ms]	141.665 µs (10.4%)
profiling	1.519 ms [1.496 ms, 1.542 ms]	159.314 µs (11.7%)
tracing	1.476 ms [1.45 ms, 1.501 ms]	116.206 µs (8.5%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/support-awssdk-relocated-under-emr
git_commit_date	1736152625	1736153953
git_commit_sha	`6bfef97`	`ae0e15b`
release_version	1.45.0-SNAPSHOT~6bfef97d85	1.45.0-SNAPSHOT~ae0e15b712

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1736155962	1736155962
ci_job_id	755028282	755028282
ci_pipeline_id	52203500	52203500
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~ae0e15b712, baseline=1.45.0-SNAPSHOT~6bfef97d85
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.467 ms) : 1455, 1478
.   : milestone, 1467,
appsec (2.322 ms) : 2280, 2363
.   : milestone, 2322,
iast (2.083 ms) : 2030, 2136
.   : milestone, 2083,
iast_GLOBAL (2.122 ms) : 2069, 2175
.   : milestone, 2122,
profiling (1.941 ms) : 1899, 1983
.   : milestone, 1941,
tracing (1.928 ms) : 1887, 1969
.   : milestone, 1928,
section candidate
no_agent (1.471 ms) : 1459, 1482
.   : milestone, 1471,
appsec (2.345 ms) : 2302, 2387
.   : milestone, 2345,
iast (2.09 ms) : 2035, 2144
.   : milestone, 2090,
iast_GLOBAL (2.133 ms) : 2078, 2187
.   : milestone, 2133,
profiling (1.967 ms) : 1923, 2011
.   : milestone, 1967,
tracing (1.922 ms) : 1881, 1963
.   : milestone, 1922,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.467 ms [1.455 ms, 1.478 ms]	-
appsec	2.322 ms [2.28 ms, 2.363 ms]	854.874 µs (58.3%)
iast	2.083 ms [2.03 ms, 2.136 ms]	616.495 µs (42.0%)
iast_GLOBAL	2.122 ms [2.069 ms, 2.175 ms]	655.471 µs (44.7%)
profiling	1.941 ms [1.899 ms, 1.983 ms]	474.465 µs (32.4%)
tracing	1.928 ms [1.887 ms, 1.969 ms]	461.287 µs (31.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.471 ms [1.459 ms, 1.482 ms]	-
appsec	2.345 ms [2.302 ms, 2.387 ms]	873.866 µs (59.4%)
iast	2.09 ms [2.035 ms, 2.144 ms]	618.86 µs (42.1%)
iast_GLOBAL	2.133 ms [2.078 ms, 2.187 ms]	661.922 µs (45.0%)
profiling	1.967 ms [1.923 ms, 2.011 ms]	496.345 µs (33.8%)
tracing	1.922 ms [1.881 ms, 1.963 ms]	451.277 µs (30.7%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~ae0e15b712, baseline=1.45.0-SNAPSHOT~6bfef97d85
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.912 s) : 14912000, 14912000
.   : milestone, 14912000,
appsec (15.18 s) : 15180000, 15180000
.   : milestone, 15180000,
iast (18.484 s) : 18484000, 18484000
.   : milestone, 18484000,
iast_GLOBAL (17.792 s) : 17792000, 17792000
.   : milestone, 17792000,
profiling (15.15 s) : 15150000, 15150000
.   : milestone, 15150000,
tracing (15.121 s) : 15121000, 15121000
.   : milestone, 15121000,
section candidate
no_agent (14.981 s) : 14981000, 14981000
.   : milestone, 14981000,
appsec (15.089 s) : 15089000, 15089000
.   : milestone, 15089000,
iast (18.825 s) : 18825000, 18825000
.   : milestone, 18825000,
iast_GLOBAL (17.774 s) : 17774000, 17774000
.   : milestone, 17774000,
profiling (14.98 s) : 14980000, 14980000
.   : milestone, 14980000,
tracing (15.027 s) : 15027000, 15027000
.   : milestone, 15027000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.912 s [14.912 s, 14.912 s]	-
appsec	15.18 s [15.18 s, 15.18 s]	268.0 ms (1.8%)
iast	18.484 s [18.484 s, 18.484 s]	3.572 s (24.0%)
iast_GLOBAL	17.792 s [17.792 s, 17.792 s]	2.88 s (19.3%)
profiling	15.15 s [15.15 s, 15.15 s]	238.0 ms (1.6%)
tracing	15.121 s [15.121 s, 15.121 s]	209.0 ms (1.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.981 s [14.981 s, 14.981 s]	-
appsec	15.089 s [15.089 s, 15.089 s]	108.0 ms (0.7%)
iast	18.825 s [18.825 s, 18.825 s]	3.844 s (25.7%)
iast_GLOBAL	17.774 s [17.774 s, 17.774 s]	2.793 s (18.6%)
profiling	14.98 s [14.98 s, 14.98 s]	-1.0 ms (-0.0%)
tracing	15.027 s [15.027 s, 15.027 s]	46.0 ms (0.3%)

amarziali

Data jobs folks were waiting for this. Thanks

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.api.grpc:proto-google-common-protos](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.50.0` -> `2.50.1` | | [com.google.cloud:google-cloud-core-http](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.49.0` -> `2.49.1` | | [com.google.cloud:google-cloud-core](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.49.0` -> `2.49.1` | | [com.google.api:gax](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.59.0` -> `2.59.1` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.44.1` -> `1.45.0` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.44.1` -> `1.45.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.45.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.45.0): 1.45.0 ##### Breaking changes > \[!WARNING]\ > Support for custom scope manager using OpenTelemetry tracer artifact (`dd-trace-ot`) is dropped. > Tracing with OpenTracing API and custom scope manager will continue to work on 1.44.x releases. ##### Components ##### Application Security Management (IAST) - ✨ Add propagation to URI#toURL method ([#8146](DataDog/dd-trace-java#8146) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Increase IAST propagation to StringBuilder setLength ([#8119](DataDog/dd-trace-java#8119) - [@Mariovido](https://github.com/Mariovido)) - ✨ Increase IAST propagation to StringBuffer append ([#8082](DataDog/dd-trace-java#8082) - [@Mariovido](https://github.com/Mariovido)) - ✨ Handle IAST security controls custom validation and sanitization methods ([#7997](DataDog/dd-trace-java#7997) - [@jandro996](https://github.com/jandro996)) ##### Application Security Management (WAF) - ✨ Update user lifecycle tracking to V3 ([#8108](DataDog/dd-trace-java#8108) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Exploit prevention for Shell Injection / Command Injection ([#7615](DataDog/dd-trace-java#7615) - [@jandro996](https://github.com/jandro996)) ##### Build & Tooling - 💡 Support instrumentation of repackaged libraries ([#8153](DataDog/dd-trace-java#8153) - [@mcculls](https://github.com/mcculls)) - ✨ Configure native image build setting for JDK-22 based GraalVM ([#8092](DataDog/dd-trace-java#8092) - [@MattAlp](https://github.com/MattAlp)) ##### Database Monitoring - ✨ Add full APM/DBM mode for Oracle ([#8090](DataDog/dd-trace-java#8090) - [@nenadnoveljic](https://github.com/nenadnoveljic)) ##### Dynamic Instrumentation - 🐛 make local var hoisting disabled by default ([#8158](DataDog/dd-trace-java#8158) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix var hoisting issue when no previous store ([#8122](DataDog/dd-trace-java#8122) - [@jpbempel](https://github.com/jpbempel)) - ✨ Only decorate spans without code origin information ([#8105](DataDog/dd-trace-java#8105) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Fix suspend Kotlin methods instrumentation ([#8080](DataDog/dd-trace-java#8080) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix class file version detection ([#8057](DataDog/dd-trace-java#8057) - [@jpbempel](https://github.com/jpbempel)) ##### GraalVM native-image - ✨ Configure native image build setting for JDK-22 based GraalVM ([#8092](DataDog/dd-trace-java#8092) - [@MattAlp](https://github.com/MattAlp)) ##### ML Observability (LLMObs) - ✨🧪 Add LLMObs configuration ([#8076](DataDog/dd-trace-java#8076) - [@gary-huang](https://github.com/gary-huang)) ##### Metrics - Bump integrations-core submodule to 7.60.0 ([#8098](DataDog/dd-trace-java#8098) - [@mcculls](https://github.com/mcculls)) - Upgrade to java-dogstatsd-client v4.4.3 ([#8096](DataDog/dd-trace-java#8096) - [@mcculls](https://github.com/mcculls)) ##### OpenTracing - ⚠️🧹 Remove custom scope manager support ([#8164](DataDog/dd-trace-java#8164) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Telemetry - ✨ Retry telemetry requests if CI Visibility is enabled ([#8147](DataDog/dd-trace-java#8147) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add configurable Dependency service resolution period ([#8079](DataDog/dd-trace-java#8079) - [@jandro996](https://github.com/jandro996)) ##### Testing - 🐛 Remove restriction to not run vertx4 latest tests on java 17 ([#8133](DataDog/dd-trace-java#8133) - [@vandonr](https://github.com/vandonr)) ##### Tracer core - ✨ Defer remote components to avoid OkHttp class-loading side-effects ([#8131](DataDog/dd-trace-java#8131) - [@mcculls](https://github.com/mcculls)) - ✨ Improve Context API null handling and Javadoc ([#8129](DataDog/dd-trace-java#8129) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 🐛⚡ Avoid performing blocking I/O operation on application thread ([#8120](DataDog/dd-trace-java#8120) - [@mcculls](https://github.com/mcculls)) - 💡 Introduce a shared context component, independent of tracing ([#8117](DataDog/dd-trace-java#8117) - [@mcculls](https://github.com/mcculls)) - ✨ Improves ServiceNameCollector ([#8109](DataDog/dd-trace-java#8109) - [@amarziali](https://github.com/amarziali)) - Upgrade to ASM 9.7.1 (adds new constant for Java 24) ([#8097](DataDog/dd-trace-java#8097) - [@mcculls](https://github.com/mcculls)) - 🐛 Dynamically evaluate service name for message consumers ([#8088](DataDog/dd-trace-java#8088) - [@amarziali](https://github.com/amarziali)) ##### Serverless - 🐛 Add avoid double instrumenting lambda non-streaming handlers. ([#8073](DataDog/dd-trace-java#8073) - [@purple4reina](https://github.com/purple4reina)) ##### Instrumentations ##### AWS SDK instrumentation - 💡 Instrument EMR's relocated AWS SDK ([#8157](DataDog/dd-trace-java#8157) - [@mcculls](https://github.com/mcculls)) ##### Eclipse Vert.x instrumentation - 🐛 Remove restriction to not run vertx4 latest tests on java 17 ([#8133](DataDog/dd-trace-java#8133) - [@vandonr](https://github.com/vandonr)) ##### JDBC instrumentation - ✨ Add full APM/DBM mode for Oracle ([#8090](DataDog/dd-trace-java#8090) - [@nenadnoveljic](https://github.com/nenadnoveljic)) ##### Jetty instrumentation - 🐛 Ensure jetty 12 has servlet.path starting with / ([#8093](DataDog/dd-trace-java#8093) - [@github-actions](https://github.com/github-actions)\[bot]) ##### JMS instrumentation - 🧹 Re-use `javax` JMS module for `jakarta` namespace ([#8155](DataDog/dd-trace-java#8155) - [@mcculls](https://github.com/mcculls)) - 🧹 Group `javax.jms` instrumentations under a single module ([#8154](DataDog/dd-trace-java#8154) - [@mcculls](https://github.com/mcculls)) ##### Reactor instrumentation - 🐛 Reactor: early propagate span in context when subscribing ([#8166](DataDog/dd-trace-java#8166) - [@amarziali](https://github.com/amarziali)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: ba2355aa4e2e39ab1fee27319cc4176238efd90b

mcculls added type: feature request inst: aws sdk AWS SDK instrumentation labels Jan 5, 2025

mcculls force-pushed the mcculls/support-awssdk-relocated-under-emr branch from 7653857 to 4db8e0c Compare January 5, 2025 22:49

mcculls force-pushed the mcculls/support-awssdk-relocated-under-emr branch from 4db8e0c to 4560d8d Compare January 5, 2025 23:20

mcculls marked this pull request as ready for review January 5, 2025 23:47

mcculls requested a review from a team as a code owner January 5, 2025 23:47

mcculls requested a review from amarziali January 5, 2025 23:47

amarziali approved these changes Jan 6, 2025

View reviewed changes

Base automatically changed from mcculls/support-instrumenting-repackaged-libraries to master January 6, 2025 08:37

mcculls requested a review from a team as a code owner January 6, 2025 08:37

mcculls requested a review from nayeem-kamal January 6, 2025 08:37

mcculls mentioned this pull request Jan 6, 2025

Support instrumentation of repackaged libraries #8153

Merged

mcculls added 2 commits January 6, 2025 08:59

Support configuring a different namespace in AWS-SDK module

43a1747

Instrument EMR's relocated AWS SDK

ae0e15b

mcculls force-pushed the mcculls/support-awssdk-relocated-under-emr branch from 4560d8d to ae0e15b Compare January 6, 2025 08:59

mcculls enabled auto-merge (squash) January 6, 2025 09:06

mcculls added tag: no release notes Changes to exclude from release notes and removed tag: no release notes Changes to exclude from release notes labels Jan 6, 2025

mcculls merged commit 6ef294d into master Jan 6, 2025
150 checks passed

mcculls deleted the mcculls/support-awssdk-relocated-under-emr branch January 6, 2025 10:03

github-actions bot added this to the 1.45.0 milestone Jan 6, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Instrument EMR's relocated AWS SDK #8157

Instrument EMR's relocated AWS SDK #8157

mcculls commented Jan 5, 2025 •

edited by jira bot

Loading

pr-commenter bot commented Jan 5, 2025 •

edited

Loading

amarziali left a comment

Instrument EMR's relocated AWS SDK #8157

Instrument EMR's relocated AWS SDK #8157

Conversation

mcculls commented Jan 5, 2025 • edited by jira bot Loading

What Does This Do

Motivation

Contributor Checklist

pr-commenter bot commented Jan 5, 2025 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

amarziali left a comment

Choose a reason for hiding this comment

mcculls commented Jan 5, 2025 •

edited by jira bot

Loading

pr-commenter bot commented Jan 5, 2025 •

edited

Loading