-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cancel running PR check jobs #8165
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PerfectSlayer
added
tag: no release notes
Changes to exclude from release notes
comp: tooling
Build & Tooling
labels
Jan 8, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 3 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.45.0-SNAPSHOT~977d625c18, baseline=1.45.0-SNAPSHOT~54d4a6f433
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.058 s) : 0, 1058097
Total [baseline] (8.678 s) : 0, 8678010
Agent [candidate] (1.058 s) : 0, 1058178
Total [candidate] (8.63 s) : 0, 8629501
section iast
Agent [baseline] (1.193 s) : 0, 1193140
Total [baseline] (9.322 s) : 0, 9322144
Agent [candidate] (1.184 s) : 0, 1183773
Total [candidate] (9.237 s) : 0, 9236640
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.183 s) : 0, 1182562
Total [baseline] (9.157 s) : 0, 9156750
Agent [candidate] (1.191 s) : 0, 1190859
Total [candidate] (9.229 s) : 0, 9228740
section iast_TELEMETRY_OFF
Agent [baseline] (1.186 s) : 0, 1186260
Total [baseline] (9.238 s) : 0, 9238167
Agent [candidate] (1.176 s) : 0, 1176406
Total [candidate] (9.235 s) : 0, 9234593
gantt
title insecure-bank - break down per module: candidate=1.45.0-SNAPSHOT~977d625c18, baseline=1.45.0-SNAPSHOT~54d4a6f433
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (714.88 ms) : 0, 714880
BytebuddyAgent [candidate] (716.811 ms) : 0, 716811
GlobalTracer [baseline] (256.897 ms) : 0, 256897
GlobalTracer [candidate] (256.468 ms) : 0, 256468
AppSec [baseline] (56.236 ms) : 0, 56236
AppSec [candidate] (56.85 ms) : 0, 56850
Remote Config [baseline] (732.18 µs) : 0, 732
Remote Config [candidate] (718.794 µs) : 0, 719
Telemetry [baseline] (14.314 ms) : 0, 14314
Telemetry [candidate] (12.206 ms) : 0, 12206
section iast
BytebuddyAgent [baseline] (839.532 ms) : 0, 839532
BytebuddyAgent [candidate] (832.934 ms) : 0, 832934
GlobalTracer [baseline] (248.732 ms) : 0, 248732
GlobalTracer [candidate] (247.193 ms) : 0, 247193
AppSec [baseline] (58.596 ms) : 0, 58596
AppSec [candidate] (58.139 ms) : 0, 58139
Remote Config [baseline] (671.405 µs) : 0, 671
Remote Config [candidate] (655.486 µs) : 0, 655
Telemetry [baseline] (8.908 ms) : 0, 8908
Telemetry [candidate] (8.712 ms) : 0, 8712
IAST [baseline] (21.591 ms) : 0, 21591
IAST [candidate] (21.052 ms) : 0, 21052
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (831.534 ms) : 0, 831534
BytebuddyAgent [candidate] (837.499 ms) : 0, 837499
GlobalTracer [baseline] (247.039 ms) : 0, 247039
GlobalTracer [candidate] (248.409 ms) : 0, 248409
AppSec [baseline] (58.276 ms) : 0, 58276
AppSec [candidate] (58.67 ms) : 0, 58670
Remote Config [baseline] (658.254 µs) : 0, 658
Remote Config [candidate] (671.261 µs) : 0, 671
Telemetry [baseline] (8.767 ms) : 0, 8767
Telemetry [candidate] (8.836 ms) : 0, 8836
IAST [baseline] (21.283 ms) : 0, 21283
IAST [candidate] (21.544 ms) : 0, 21544
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (833.797 ms) : 0, 833797
BytebuddyAgent [candidate] (826.438 ms) : 0, 826438
GlobalTracer [baseline] (248.161 ms) : 0, 248161
GlobalTracer [candidate] (246.838 ms) : 0, 246838
AppSec [baseline] (58.439 ms) : 0, 58439
AppSec [candidate] (58.169 ms) : 0, 58169
Remote Config [baseline] (660.071 µs) : 0, 660
Remote Config [candidate] (644.242 µs) : 0, 644
Telemetry [baseline] (8.767 ms) : 0, 8767
Telemetry [candidate] (8.655 ms) : 0, 8655
IAST [baseline] (21.379 ms) : 0, 21379
IAST [candidate] (20.677 ms) : 0, 20677
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.45.0-SNAPSHOT~977d625c18, baseline=1.45.0-SNAPSHOT~54d4a6f433
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1055792
Total [baseline] (10.508 s) : 0, 10508119
Agent [candidate] (1.056 s) : 0, 1055725
Total [candidate] (10.451 s) : 0, 10451312
section appsec
Agent [baseline] (1.19 s) : 0, 1189740
Total [baseline] (10.693 s) : 0, 10692590
Agent [candidate] (1.19 s) : 0, 1189866
Total [candidate] (10.704 s) : 0, 10704068
section iast
Agent [baseline] (1.201 s) : 0, 1200789
Total [baseline] (10.943 s) : 0, 10943297
Agent [candidate] (1.187 s) : 0, 1186721
Total [candidate] (11.048 s) : 0, 11048182
section profiling
Agent [baseline] (1.282 s) : 0, 1282391
Total [baseline] (10.915 s) : 0, 10915072
Agent [candidate] (1.281 s) : 0, 1281292
Total [candidate] (10.819 s) : 0, 10819226
gantt
title petclinic - break down per module: candidate=1.45.0-SNAPSHOT~977d625c18, baseline=1.45.0-SNAPSHOT~54d4a6f433
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (714.024 ms) : 0, 714024
BytebuddyAgent [candidate] (715.566 ms) : 0, 715566
GlobalTracer [baseline] (256.0 ms) : 0, 256000
GlobalTracer [candidate] (256.58 ms) : 0, 256580
AppSec [baseline] (57.012 ms) : 0, 57012
AppSec [candidate] (55.311 ms) : 0, 55311
Remote Config [baseline] (719.308 µs) : 0, 719
Remote Config [candidate] (723.935 µs) : 0, 724
Telemetry [baseline] (13.023 ms) : 0, 13023
Telemetry [candidate] (12.472 ms) : 0, 12472
section appsec
BytebuddyAgent [baseline] (732.311 ms) : 0, 732311
BytebuddyAgent [candidate] (732.212 ms) : 0, 732212
GlobalTracer [baseline] (253.173 ms) : 0, 253173
GlobalTracer [candidate] (253.748 ms) : 0, 253748
AppSec [baseline] (170.743 ms) : 0, 170743
AppSec [candidate] (170.336 ms) : 0, 170336
Remote Config [baseline] (659.811 µs) : 0, 660
Remote Config [candidate] (662.239 µs) : 0, 662
Telemetry [baseline] (8.168 ms) : 0, 8168
Telemetry [candidate] (8.221 ms) : 0, 8221
IAST [baseline] (19.389 ms) : 0, 19389
IAST [candidate] (19.31 ms) : 0, 19310
section iast
BytebuddyAgent [baseline] (844.963 ms) : 0, 844963
BytebuddyAgent [candidate] (834.51 ms) : 0, 834510
GlobalTracer [baseline] (251.161 ms) : 0, 251161
GlobalTracer [candidate] (248.322 ms) : 0, 248322
AppSec [baseline] (58.526 ms) : 0, 58526
AppSec [candidate] (58.221 ms) : 0, 58221
Remote Config [baseline] (665.184 µs) : 0, 665
Remote Config [candidate] (661.134 µs) : 0, 661
Telemetry [baseline] (8.847 ms) : 0, 8847
Telemetry [candidate] (8.707 ms) : 0, 8707
IAST [baseline] (21.425 ms) : 0, 21425
IAST [candidate] (21.149 ms) : 0, 21149
section profiling
BytebuddyAgent [baseline] (708.484 ms) : 0, 708484
BytebuddyAgent [candidate] (706.752 ms) : 0, 706752
GlobalTracer [baseline] (373.832 ms) : 0, 373832
GlobalTracer [candidate] (373.249 ms) : 0, 373249
AppSec [baseline] (53.958 ms) : 0, 53958
AppSec [candidate] (54.346 ms) : 0, 54346
Remote Config [baseline] (657.652 µs) : 0, 658
Remote Config [candidate] (677.88 µs) : 0, 678
Telemetry [baseline] (8.052 ms) : 0, 8052
Telemetry [candidate] (8.063 ms) : 0, 8063
ProfilingAgent [baseline] (95.297 ms) : 0, 95297
ProfilingAgent [candidate] (96.133 ms) : 0, 96133
Profiling [baseline] (95.321 ms) : 0, 95321
Profiling [candidate] (96.157 ms) : 0, 96157
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~977d625c18, baseline=1.45.0-SNAPSHOT~54d4a6f433
dateFormat X
axisFormat %s
section baseline
no_agent (1.356 ms) : 1337, 1376
. : milestone, 1356,
appsec (1.742 ms) : 1718, 1766
. : milestone, 1742,
appsec_no_iast (1.744 ms) : 1718, 1769
. : milestone, 1744,
iast (1.509 ms) : 1486, 1532
. : milestone, 1509,
profiling (1.512 ms) : 1488, 1536
. : milestone, 1512,
tracing (1.505 ms) : 1481, 1529
. : milestone, 1505,
section candidate
no_agent (1.363 ms) : 1343, 1382
. : milestone, 1363,
appsec (1.743 ms) : 1719, 1767
. : milestone, 1743,
appsec_no_iast (1.758 ms) : 1733, 1783
. : milestone, 1758,
iast (1.505 ms) : 1482, 1528
. : milestone, 1505,
profiling (1.552 ms) : 1527, 1577
. : milestone, 1552,
tracing (1.47 ms) : 1445, 1496
. : milestone, 1470,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~977d625c18, baseline=1.45.0-SNAPSHOT~54d4a6f433
dateFormat X
axisFormat %s
section baseline
no_agent (378.646 µs) : 357, 400
. : milestone, 379,
iast (500.127 µs) : 478, 522
. : milestone, 500,
iast_FULL (654.193 µs) : 632, 676
. : milestone, 654,
iast_GLOBAL (527.913 µs) : 504, 551
. : milestone, 528,
iast_HARDCODED_SECRET_DISABLED (488.969 µs) : 467, 510
. : milestone, 489,
iast_INACTIVE (454.511 µs) : 433, 476
. : milestone, 455,
iast_TELEMETRY_OFF (484.106 µs) : 463, 505
. : milestone, 484,
tracing (468.188 µs) : 444, 493
. : milestone, 468,
section candidate
no_agent (376.554 µs) : 356, 397
. : milestone, 377,
iast (499.578 µs) : 478, 521
. : milestone, 500,
iast_FULL (657.245 µs) : 636, 679
. : milestone, 657,
iast_GLOBAL (532.439 µs) : 510, 555
. : milestone, 532,
iast_HARDCODED_SECRET_DISABLED (491.931 µs) : 470, 514
. : milestone, 492,
iast_INACTIVE (455.488 µs) : 434, 477
. : milestone, 455,
iast_TELEMETRY_OFF (491.936 µs) : 470, 514
. : milestone, 492,
tracing (443.318 µs) : 423, 464
. : milestone, 443,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~977d625c18, baseline=1.45.0-SNAPSHOT~54d4a6f433
dateFormat X
axisFormat %s
section baseline
no_agent (1.48 ms) : 1468, 1492
. : milestone, 1480,
appsec (2.348 ms) : 2306, 2390
. : milestone, 2348,
iast (2.113 ms) : 2059, 2166
. : milestone, 2113,
iast_GLOBAL (2.141 ms) : 2087, 2195
. : milestone, 2141,
profiling (1.984 ms) : 1939, 2028
. : milestone, 1984,
tracing (1.935 ms) : 1894, 1976
. : milestone, 1935,
section candidate
no_agent (1.466 ms) : 1455, 1478
. : milestone, 1466,
appsec (2.355 ms) : 2312, 2398
. : milestone, 2355,
iast (2.098 ms) : 2044, 2152
. : milestone, 2098,
iast_GLOBAL (2.144 ms) : 2090, 2198
. : milestone, 2144,
profiling (1.956 ms) : 1912, 1999
. : milestone, 1956,
tracing (1.933 ms) : 1892, 1975
. : milestone, 1933,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~977d625c18, baseline=1.45.0-SNAPSHOT~54d4a6f433
dateFormat X
axisFormat %s
section baseline
no_agent (15.44 s) : 15440000, 15440000
. : milestone, 15440000,
appsec (15.198 s) : 15198000, 15198000
. : milestone, 15198000,
iast (18.686 s) : 18686000, 18686000
. : milestone, 18686000,
iast_GLOBAL (17.895 s) : 17895000, 17895000
. : milestone, 17895000,
profiling (15.14 s) : 15140000, 15140000
. : milestone, 15140000,
tracing (14.908 s) : 14908000, 14908000
. : milestone, 14908000,
section candidate
no_agent (15.23 s) : 15230000, 15230000
. : milestone, 15230000,
appsec (14.914 s) : 14914000, 14914000
. : milestone, 14914000,
iast (18.805 s) : 18805000, 18805000
. : milestone, 18805000,
iast_GLOBAL (18.269 s) : 18269000, 18269000
. : milestone, 18269000,
profiling (15.226 s) : 15226000, 15226000
. : milestone, 15226000,
tracing (15.01 s) : 15010000, 15010000
. : milestone, 15010000,
|
amarziali
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR tries to improve blocked PR checks by cancelling already running checks.
Motivation
Previously, only pending jobs were canceled. Cancelling running checks might help to have the latest trigger to run instead of being cancelled, leaving the PR check requirements blocked.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: LANGPLAT-116