Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report profiler initialization and configuration errors to telemetry #8171

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Report profiler initialization and configuration errors to telemetry #8171

merged 2 commits into from
Jan 9, 2025

Conversation

jbachorik
Copy link
Contributor

@jbachorik jbachorik commented Jan 8, 2025 •
edited by jira bot
Loading

What Does This Do

It adds shipping profiler initialization and configuration issues to telemetry.

Motivation

Improve the support story for the Java profiler

Additional Notes

Contributor Checklist

Jira ticket: PROF-11074

@jbachorik jbachorik force-pushed the jb/profiler_telemetry branch from f4c08ac to fe36e56 Compare January 8, 2025 14:44
@jbachorik jbachorik marked this pull request as ready for review January 8, 2025 14:56
@jbachorik jbachorik requested a review from a team as a code owner January 8, 2025 14:56
@jbachorik jbachorik requested a review from MattAlp January 8, 2025 14:56
@pr-commenter
Copy link

pr-commenter bot commented Jan 8, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jb/profiler_telemetry
git_commit_date 1736436386 1736437084
git_commit_sha f768f02 c1f546e
release_version 1.46.0-SNAPSHOT~f768f0218b 1.46.0-SNAPSHOT~c1f546e80a
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1736439405 1736439405
ci_job_id 760418455 760418455
ci_pipeline_id 52558889 52558889
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~c1f546e80a, baseline=1.46.0-SNAPSHOT~f768f0218b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.053 s) : 0, 1053477
Total [baseline] (8.603 s) : 0, 8603212
Agent [candidate] (1.054 s) : 0, 1054435
Total [candidate] (8.635 s) : 0, 8635022
section iast
Agent [baseline] (1.19 s) : 0, 1189518
Total [baseline] (9.21 s) : 0, 9210390
Agent [candidate] (1.202 s) : 0, 1201730
Total [candidate] (9.263 s) : 0, 9262728
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.179 s) : 0, 1178986
Total [baseline] (9.173 s) : 0, 9173332
Agent [candidate] (1.204 s) : 0, 1203962
Total [candidate] (9.219 s) : 0, 9219491
section iast_TELEMETRY_OFF
Agent [baseline] (1.176 s) : 0, 1176231
Total [baseline] (9.176 s) : 0, 9175583
Agent [candidate] (1.186 s) : 0, 1185702
Total [candidate] (9.197 s) : 0, 9197183
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.053 s -
Agent iast 1.19 s 136.042 ms (12.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.179 s 125.509 ms (11.9%)
Agent iast_TELEMETRY_OFF 1.176 s 122.754 ms (11.7%)
Total tracing 8.603 s -
Total iast 9.21 s 607.178 ms (7.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.173 s 570.12 ms (6.6%)
Total iast_TELEMETRY_OFF 9.176 s 572.371 ms (6.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.054 s -
Agent iast 1.202 s 147.295 ms (14.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.204 s 149.527 ms (14.2%)
Agent iast_TELEMETRY_OFF 1.186 s 131.267 ms (12.4%)
Total tracing 8.635 s -
Total iast 9.263 s 627.705 ms (7.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.219 s 584.469 ms (6.8%)
Total iast_TELEMETRY_OFF 9.197 s 562.16 ms (6.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~c1f546e80a, baseline=1.46.0-SNAPSHOT~f768f0218b

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (712.229 ms) : 0, 712229
BytebuddyAgent [candidate] (712.51 ms) : 0, 712510
GlobalTracer [baseline] (255.744 ms) : 0, 255744
GlobalTracer [candidate] (255.632 ms) : 0, 255632
AppSec [baseline] (56.105 ms) : 0, 56105
AppSec [candidate] (55.329 ms) : 0, 55329
Remote Config [baseline] (722.196 µs) : 0, 722
Remote Config [candidate] (721.907 µs) : 0, 722
Telemetry [baseline] (13.751 ms) : 0, 13751
Telemetry [candidate] (15.188 ms) : 0, 15188
section iast
BytebuddyAgent [baseline] (837.651 ms) : 0, 837651
BytebuddyAgent [candidate] (845.344 ms) : 0, 845344
GlobalTracer [baseline] (247.308 ms) : 0, 247308
GlobalTracer [candidate] (250.085 ms) : 0, 250085
AppSec [baseline] (58.368 ms) : 0, 58368
AppSec [candidate] (59.264 ms) : 0, 59264
IAST [baseline] (21.574 ms) : 0, 21574
IAST [candidate] (21.948 ms) : 0, 21948
Remote Config [baseline] (703.366 µs) : 0, 703
Remote Config [candidate] (698.834 µs) : 0, 699
Telemetry [baseline] (8.839 ms) : 0, 8839
Telemetry [candidate] (9.063 ms) : 0, 9063
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (828.632 ms) : 0, 828632
BytebuddyAgent [candidate] (846.619 ms) : 0, 846619
GlobalTracer [baseline] (246.503 ms) : 0, 246503
GlobalTracer [candidate] (250.702 ms) : 0, 250702
AppSec [baseline] (58.211 ms) : 0, 58211
AppSec [candidate] (59.398 ms) : 0, 59398
IAST [baseline] (21.207 ms) : 0, 21207
IAST [candidate] (21.965 ms) : 0, 21965
Remote Config [baseline] (668.804 µs) : 0, 669
Remote Config [candidate] (698.35 µs) : 0, 698
Telemetry [baseline] (8.787 ms) : 0, 8787
Telemetry [candidate] (9.128 ms) : 0, 9128
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (827.368 ms) : 0, 827368
BytebuddyAgent [candidate] (833.7 ms) : 0, 833700
GlobalTracer [baseline] (246.104 ms) : 0, 246104
GlobalTracer [candidate] (248.623 ms) : 0, 248623
AppSec [baseline] (57.901 ms) : 0, 57901
AppSec [candidate] (58.18 ms) : 0, 58180
IAST [baseline] (20.725 ms) : 0, 20725
IAST [candidate] (20.745 ms) : 0, 20745
Remote Config [baseline] (647.954 µs) : 0, 648
Remote Config [candidate] (650.325 µs) : 0, 650
Telemetry [baseline] (8.552 ms) : 0, 8552
Telemetry [candidate] (8.664 ms) : 0, 8664
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~c1f546e80a, baseline=1.46.0-SNAPSHOT~f768f0218b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1060651
Total [baseline] (10.454 s) : 0, 10454214
Agent [candidate] (1.058 s) : 0, 1057644
Total [candidate] (10.41 s) : 0, 10410439
section appsec
Agent [baseline] (1.188 s) : 0, 1188467
Total [baseline] (10.696 s) : 0, 10695560
Agent [candidate] (1.191 s) : 0, 1190922
Total [candidate] (10.721 s) : 0, 10720934
section iast
Agent [baseline] (1.183 s) : 0, 1182858
Total [baseline] (10.975 s) : 0, 10974574
Agent [candidate] (1.181 s) : 0, 1181482
Total [candidate] (10.941 s) : 0, 10941076
section profiling
Agent [baseline] (1.271 s) : 0, 1271465
Total [baseline] (10.851 s) : 0, 10850517
Agent [candidate] (1.274 s) : 0, 1274494
Total [candidate] (10.789 s) : 0, 10789093
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.061 s -
Agent appsec 1.188 s 127.816 ms (12.1%)
Agent iast 1.183 s 122.207 ms (11.5%)
Agent profiling 1.271 s 210.814 ms (19.9%)
Total tracing 10.454 s -
Total appsec 10.696 s 241.347 ms (2.3%)
Total iast 10.975 s 520.36 ms (5.0%)
Total profiling 10.851 s 396.304 ms (3.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.058 s -
Agent appsec 1.191 s 133.278 ms (12.6%)
Agent iast 1.181 s 123.839 ms (11.7%)
Agent profiling 1.274 s 216.85 ms (20.5%)
Total tracing 10.41 s -
Total appsec 10.721 s 310.495 ms (3.0%)
Total iast 10.941 s 530.637 ms (5.1%)
Total profiling 10.789 s 378.654 ms (3.6%) 
gantt
    title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~c1f546e80a, baseline=1.46.0-SNAPSHOT~f768f0218b

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.882 ms) : 0, 717882
BytebuddyAgent [candidate] (715.747 ms) : 0, 715747
GlobalTracer [baseline] (257.562 ms) : 0, 257562
GlobalTracer [candidate] (256.351 ms) : 0, 256351
AppSec [baseline] (56.409 ms) : 0, 56409
AppSec [candidate] (56.179 ms) : 0, 56179
Remote Config [baseline] (736.524 µs) : 0, 737
Remote Config [candidate] (717.868 µs) : 0, 718
Telemetry [baseline] (13.097 ms) : 0, 13097
Telemetry [candidate] (13.6 ms) : 0, 13600
section appsec
BytebuddyAgent [baseline] (731.215 ms) : 0, 731215
BytebuddyAgent [candidate] (732.539 ms) : 0, 732539
GlobalTracer [baseline] (252.537 ms) : 0, 252537
GlobalTracer [candidate] (253.457 ms) : 0, 253457
AppSec [baseline] (171.093 ms) : 0, 171093
AppSec [candidate] (171.249 ms) : 0, 171249
Remote Config [baseline] (670.506 µs) : 0, 671
Remote Config [candidate] (675.348 µs) : 0, 675
Telemetry [baseline] (8.229 ms) : 0, 8229
Telemetry [candidate] (8.25 ms) : 0, 8250
IAST [baseline] (19.536 ms) : 0, 19536
IAST [candidate] (19.406 ms) : 0, 19406
section iast
BytebuddyAgent [baseline] (832.599 ms) : 0, 832599
BytebuddyAgent [candidate] (830.829 ms) : 0, 830829
GlobalTracer [baseline] (246.812 ms) : 0, 246812
GlobalTracer [candidate] (246.666 ms) : 0, 246666
AppSec [baseline] (57.686 ms) : 0, 57686
AppSec [candidate] (58.037 ms) : 0, 58037
Remote Config [baseline] (668.724 µs) : 0, 669
Remote Config [candidate] (676.943 µs) : 0, 677
Telemetry [baseline] (8.697 ms) : 0, 8697
Telemetry [candidate] (8.755 ms) : 0, 8755
IAST [baseline] (21.461 ms) : 0, 21461
IAST [candidate] (21.442 ms) : 0, 21442
section profiling
BytebuddyAgent [baseline] (701.342 ms) : 0, 701342
BytebuddyAgent [candidate] (704.181 ms) : 0, 704181
GlobalTracer [baseline] (369.449 ms) : 0, 369449
GlobalTracer [candidate] (369.258 ms) : 0, 369258
AppSec [baseline] (54.053 ms) : 0, 54053
AppSec [candidate] (53.802 ms) : 0, 53802
Remote Config [baseline] (694.143 µs) : 0, 694
Remote Config [candidate] (696.017 µs) : 0, 696
Telemetry [baseline] (8.797 ms) : 0, 8797
Telemetry [candidate] (8.843 ms) : 0, 8843
ProfilingAgent [baseline] (95.36 ms) : 0, 95360
ProfilingAgent [candidate] (95.801 ms) : 0, 95801
Profiling [baseline] (95.384 ms) : 0, 95384
Profiling [candidate] (95.827 ms) : 0, 95827
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-01-09T15:49:08 2025-01-09T15:56:07
git_branch master jb/profiler_telemetry
git_commit_date 1736436386 1736437084
git_commit_sha f768f02 c1f546e
release_version 1.46.0-SNAPSHOT~f768f0218b 1.46.0-SNAPSHOT~c1f546e80a
start_time 2025-01-09T15:48:54 2025-01-09T15:55:54
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1736438521 1736438521
ci_job_id 760418456 760418456
ci_pipeline_id 52558889 52558889
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~c1f546e80a, baseline=1.46.0-SNAPSHOT~f768f0218b
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.342 ms) : 1322, 1362
.   : milestone, 1342,
appsec (1.782 ms) : 1759, 1805
.   : milestone, 1782,
appsec_no_iast (1.764 ms) : 1741, 1787
.   : milestone, 1764,
iast (1.496 ms) : 1472, 1519
.   : milestone, 1496,
profiling (1.55 ms) : 1525, 1575
.   : milestone, 1550,
tracing (1.484 ms) : 1459, 1509
.   : milestone, 1484,
section candidate
no_agent (1.354 ms) : 1335, 1373
.   : milestone, 1354,
appsec (1.756 ms) : 1732, 1780
.   : milestone, 1756,
appsec_no_iast (1.768 ms) : 1745, 1792
.   : milestone, 1768,
iast (1.501 ms) : 1478, 1525
.   : milestone, 1501,
profiling (1.505 ms) : 1481, 1528
.   : milestone, 1505,
tracing (1.5 ms) : 1476, 1524
.   : milestone, 1500,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.342 ms [1.322 ms, 1.362 ms] -
appsec 1.782 ms [1.759 ms, 1.805 ms] 439.661 µs (32.8%)
appsec_no_iast 1.764 ms [1.741 ms, 1.787 ms] 421.996 µs (31.4%)
iast 1.496 ms [1.472 ms, 1.519 ms] 153.583 µs (11.4%)
profiling 1.55 ms [1.525 ms, 1.575 ms] 207.908 µs (15.5%)
tracing 1.484 ms [1.459 ms, 1.509 ms] 141.841 µs (10.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.354 ms [1.335 ms, 1.373 ms] -
appsec 1.756 ms [1.732 ms, 1.78 ms] 401.904 µs (29.7%)
appsec_no_iast 1.768 ms [1.745 ms, 1.792 ms] 414.114 µs (30.6%)
iast 1.501 ms [1.478 ms, 1.525 ms] 146.98 µs (10.9%)
profiling 1.505 ms [1.481 ms, 1.528 ms] 150.388 µs (11.1%)
tracing 1.5 ms [1.476 ms, 1.524 ms] 145.795 µs (10.8%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~c1f546e80a, baseline=1.46.0-SNAPSHOT~f768f0218b
    dateFormat X
    axisFormat %s
section baseline
no_agent (372.039 µs) : 352, 392
.   : milestone, 372,
iast (500.226 µs) : 478, 523
.   : milestone, 500,
iast_FULL (655.36 µs) : 634, 677
.   : milestone, 655,
iast_GLOBAL (522.764 µs) : 501, 545
.   : milestone, 523,
iast_HARDCODED_SECRET_DISABLED (497.03 µs) : 475, 519
.   : milestone, 497,
iast_INACTIVE (458.6 µs) : 437, 480
.   : milestone, 459,
iast_TELEMETRY_OFF (478.534 µs) : 457, 500
.   : milestone, 479,
tracing (451.128 µs) : 430, 473
.   : milestone, 451,
section candidate
no_agent (380.063 µs) : 360, 400
.   : milestone, 380,
iast (498.399 µs) : 477, 520
.   : milestone, 498,
iast_FULL (659.476 µs) : 638, 681
.   : milestone, 659,
iast_GLOBAL (518.648 µs) : 497, 540
.   : milestone, 519,
iast_HARDCODED_SECRET_DISABLED (492.362 µs) : 471, 514
.   : milestone, 492,
iast_INACTIVE (454.397 µs) : 433, 476
.   : milestone, 454,
iast_TELEMETRY_OFF (484.762 µs) : 463, 507
.   : milestone, 485,
tracing (448.417 µs) : 428, 469
.   : milestone, 448,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 372.039 µs [352.1 µs, 391.978 µs] -
iast 500.226 µs [477.824 µs, 522.627 µs] 128.187 µs (34.5%)
iast_FULL 655.36 µs [633.638 µs, 677.081 µs] 283.321 µs (76.2%)
iast_GLOBAL 522.764 µs [500.95 µs, 544.579 µs] 150.726 µs (40.5%)
iast_HARDCODED_SECRET_DISABLED 497.03 µs [475.072 µs, 518.987 µs] 124.991 µs (33.6%)
iast_INACTIVE 458.6 µs [436.795 µs, 480.406 µs] 86.562 µs (23.3%)
iast_TELEMETRY_OFF 478.534 µs [457.291 µs, 499.778 µs] 106.496 µs (28.6%)
tracing 451.128 µs [429.644 µs, 472.612 µs] 79.089 µs (21.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 380.063 µs [360.261 µs, 399.865 µs] -
iast 498.399 µs [476.797 µs, 520.0 µs] 118.336 µs (31.1%)
iast_FULL 659.476 µs [638.014 µs, 680.938 µs] 279.413 µs (73.5%)
iast_GLOBAL 518.648 µs [496.805 µs, 540.491 µs] 138.585 µs (36.5%)
iast_HARDCODED_SECRET_DISABLED 492.362 µs [470.931 µs, 513.792 µs] 112.299 µs (29.5%)
iast_INACTIVE 454.397 µs [433.089 µs, 475.705 µs] 74.334 µs (19.6%)
iast_TELEMETRY_OFF 484.762 µs [462.848 µs, 506.676 µs] 104.699 µs (27.5%)
tracing 448.417 µs [427.995 µs, 468.838 µs] 68.353 µs (18.0%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jb/profiler_telemetry
git_commit_date 1736436386 1736437084
git_commit_sha f768f02 c1f546e
release_version 1.46.0-SNAPSHOT~f768f0218b 1.46.0-SNAPSHOT~c1f546e80a
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1736439134 1736439134
ci_job_id 760418457 760418457
ci_pipeline_id 52558889 52558889
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~c1f546e80a, baseline=1.46.0-SNAPSHOT~f768f0218b
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.885 s) : 14885000, 14885000
.   : milestone, 14885000,
appsec (14.915 s) : 14915000, 14915000
.   : milestone, 14915000,
iast (18.899 s) : 18899000, 18899000
.   : milestone, 18899000,
iast_GLOBAL (18.054 s) : 18054000, 18054000
.   : milestone, 18054000,
profiling (15.135 s) : 15135000, 15135000
.   : milestone, 15135000,
tracing (14.939 s) : 14939000, 14939000
.   : milestone, 14939000,
section candidate
no_agent (15.641 s) : 15641000, 15641000
.   : milestone, 15641000,
appsec (14.984 s) : 14984000, 14984000
.   : milestone, 14984000,
iast (18.799 s) : 18799000, 18799000
.   : milestone, 18799000,
iast_GLOBAL (18.295 s) : 18295000, 18295000
.   : milestone, 18295000,
profiling (15.026 s) : 15026000, 15026000
.   : milestone, 15026000,
tracing (15.187 s) : 15187000, 15187000
.   : milestone, 15187000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.885 s [14.885 s, 14.885 s] -
appsec 14.915 s [14.915 s, 14.915 s] 30.0 ms (0.2%)
iast 18.899 s [18.899 s, 18.899 s] 4.014 s (27.0%)
iast_GLOBAL 18.054 s [18.054 s, 18.054 s] 3.169 s (21.3%)
profiling 15.135 s [15.135 s, 15.135 s] 250.0 ms (1.7%)
tracing 14.939 s [14.939 s, 14.939 s] 54.0 ms (0.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.641 s [15.641 s, 15.641 s] -
appsec 14.984 s [14.984 s, 14.984 s] -657.0 ms (-4.2%)
iast 18.799 s [18.799 s, 18.799 s] 3.158 s (20.2%)
iast_GLOBAL 18.295 s [18.295 s, 18.295 s] 2.654 s (17.0%)
profiling 15.026 s [15.026 s, 15.026 s] -615.0 ms (-3.9%)
tracing 15.187 s [15.187 s, 15.187 s] -454.0 ms (-2.9%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~c1f546e80a, baseline=1.46.0-SNAPSHOT~f768f0218b
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.48 ms) : 1468, 1491
.   : milestone, 1480,
appsec (2.381 ms) : 2338, 2424
.   : milestone, 2381,
iast (2.104 ms) : 2050, 2158
.   : milestone, 2104,
iast_GLOBAL (2.161 ms) : 2107, 2216
.   : milestone, 2161,
profiling (1.977 ms) : 1934, 2021
.   : milestone, 1977,
tracing (1.957 ms) : 1915, 1999
.   : milestone, 1957,
section candidate
no_agent (1.473 ms) : 1461, 1484
.   : milestone, 1473,
appsec (2.376 ms) : 2333, 2419
.   : milestone, 2376,
iast (2.115 ms) : 2061, 2169
.   : milestone, 2115,
iast_GLOBAL (2.161 ms) : 2106, 2216
.   : milestone, 2161,
profiling (1.994 ms) : 1950, 2039
.   : milestone, 1994,
tracing (1.966 ms) : 1923, 2008
.   : milestone, 1966,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.48 ms [1.468 ms, 1.491 ms] -
appsec 2.381 ms [2.338 ms, 2.424 ms] 901.565 µs (60.9%)
iast 2.104 ms [2.05 ms, 2.158 ms] 624.212 µs (42.2%)
iast_GLOBAL 2.161 ms [2.107 ms, 2.216 ms] 681.445 µs (46.0%)
profiling 1.977 ms [1.934 ms, 2.021 ms] 497.545 µs (33.6%)
tracing 1.957 ms [1.915 ms, 1.999 ms] 476.765 µs (32.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.473 ms [1.461 ms, 1.484 ms] -
appsec 2.376 ms [2.333 ms, 2.419 ms] 903.766 µs (61.4%)
iast 2.115 ms [2.061 ms, 2.169 ms] 642.27 µs (43.6%)
iast_GLOBAL 2.161 ms [2.106 ms, 2.216 ms] 688.303 µs (46.7%)
profiling 1.994 ms [1.95 ms, 2.039 ms] 521.594 µs (35.4%)
tracing 1.966 ms [1.923 ms, 2.008 ms] 493.032 µs (33.5%)

MattAlp
MattAlp approved these changes Jan 9, 2025
View reviewed changes
...iling-controller/src/main/java/com/datadog/profiling/controller/ProfilerSettingsSupport.java Outdated
return "{"
+ "kind='"
+ profilerKind()
+ '\''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move these ' to the same line as what they wrap for readability? Minor nit, ignore if spotless is driving this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i.e.

+ "kind='" + profilerKind() + "\'"

or using Patterns if the overhead is acceptable. Mild preference for down the line if/when we need to debug the state space of env-VM-config misconfigurations.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotless :(
I will add suppression and return the original formatting

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Spotless can be annoying 😞

PerfectSlayer
PerfectSlayer approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be helpful 👍

@jbachorik jbachorik force-pushed the jb/profiler_telemetry branch from fe36e56 to c1f546e Compare January 9, 2025 15:38
@jbachorik jbachorik added tag: do not merge Do not merge changes and removed tag: do not merge Do not merge changes labels Jan 9, 2025
@jbachorik jbachorik merged commit 03478c8 into master Jan 9, 2025
173 of 174 checks passed
@jbachorik jbachorik deleted the jb/profiler_telemetry branch January 9, 2025 17:46
@github-actions github-actions bot added this to the 1.46.0 milestone Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattAlp MattAlp MattAlp approved these changes

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

Assignees
No one assigned
Labels
comp: profiling Profiling type: enhancement
Projects
None yet
Milestone
1.46.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jbachorik @PerfectSlayer @MattAlp