-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repo: mandatory issue templates #8177
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~0df6817a16, baseline=1.46.0-SNAPSHOT~03478c8e5c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1054754
Total [baseline] (8.629 s) : 0, 8629478
Agent [candidate] (1.061 s) : 0, 1061203
Total [candidate] (8.633 s) : 0, 8632628
section iast
Agent [baseline] (1.187 s) : 0, 1187435
Total [baseline] (9.205 s) : 0, 9204826
Agent [candidate] (1.181 s) : 0, 1180835
Total [candidate] (9.195 s) : 0, 9194557
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.179 s) : 0, 1179003
Total [baseline] (9.211 s) : 0, 9211104
Agent [candidate] (1.178 s) : 0, 1178153
Total [candidate] (9.186 s) : 0, 9186239
section iast_TELEMETRY_OFF
Agent [baseline] (1.176 s) : 0, 1175964
Total [baseline] (9.213 s) : 0, 9212984
Agent [candidate] (1.181 s) : 0, 1181375
Total [candidate] (9.249 s) : 0, 9248735
gantt
title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~0df6817a16, baseline=1.46.0-SNAPSHOT~03478c8e5c
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (713.877 ms) : 0, 713877
BytebuddyAgent [candidate] (718.154 ms) : 0, 718154
GlobalTracer [baseline] (256.218 ms) : 0, 256218
GlobalTracer [candidate] (257.298 ms) : 0, 257298
AppSec [baseline] (55.301 ms) : 0, 55301
AppSec [candidate] (55.654 ms) : 0, 55654
Remote Config [baseline] (737.06 µs) : 0, 737
Remote Config [candidate] (735.345 µs) : 0, 735
Telemetry [baseline] (13.647 ms) : 0, 13647
Telemetry [candidate] (14.272 ms) : 0, 14272
section iast
BytebuddyAgent [baseline] (835.649 ms) : 0, 835649
BytebuddyAgent [candidate] (830.236 ms) : 0, 830236
GlobalTracer [baseline] (247.729 ms) : 0, 247729
GlobalTracer [candidate] (246.53 ms) : 0, 246530
AppSec [baseline] (57.966 ms) : 0, 57966
AppSec [candidate] (58.162 ms) : 0, 58162
IAST [baseline] (21.597 ms) : 0, 21597
IAST [candidate] (21.388 ms) : 0, 21388
Remote Config [baseline] (669.407 µs) : 0, 669
Remote Config [candidate] (669.269 µs) : 0, 669
Telemetry [baseline] (8.773 ms) : 0, 8773
Telemetry [candidate] (8.781 ms) : 0, 8781
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (829.118 ms) : 0, 829118
BytebuddyAgent [candidate] (828.124 ms) : 0, 828124
GlobalTracer [baseline] (245.884 ms) : 0, 245884
GlobalTracer [candidate] (246.013 ms) : 0, 246013
AppSec [baseline] (58.476 ms) : 0, 58476
AppSec [candidate] (58.16 ms) : 0, 58160
IAST [baseline] (21.127 ms) : 0, 21127
IAST [candidate] (21.398 ms) : 0, 21398
Remote Config [baseline] (669.478 µs) : 0, 669
Remote Config [candidate] (670.887 µs) : 0, 671
Telemetry [baseline] (8.724 ms) : 0, 8724
Telemetry [candidate] (8.761 ms) : 0, 8761
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (827.046 ms) : 0, 827046
BytebuddyAgent [candidate] (831.195 ms) : 0, 831195
GlobalTracer [baseline] (245.904 ms) : 0, 245904
GlobalTracer [candidate] (247.11 ms) : 0, 247110
AppSec [baseline] (57.856 ms) : 0, 57856
AppSec [candidate] (57.831 ms) : 0, 57831
IAST [baseline] (20.833 ms) : 0, 20833
IAST [candidate] (20.853 ms) : 0, 20853
Remote Config [baseline] (658.183 µs) : 0, 658
Remote Config [candidate] (669.116 µs) : 0, 669
Telemetry [baseline] (8.611 ms) : 0, 8611
Telemetry [candidate] (8.657 ms) : 0, 8657
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~0df6817a16, baseline=1.46.0-SNAPSHOT~03478c8e5c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1055183
Total [baseline] (10.422 s) : 0, 10421958
Agent [candidate] (1.052 s) : 0, 1051759
Total [candidate] (10.477 s) : 0, 10476557
section appsec
Agent [baseline] (1.187 s) : 0, 1186930
Total [baseline] (10.704 s) : 0, 10703720
Agent [candidate] (1.189 s) : 0, 1189083
Total [candidate] (10.727 s) : 0, 10726976
section iast
Agent [baseline] (1.18 s) : 0, 1180147
Total [baseline] (10.978 s) : 0, 10978234
Agent [candidate] (1.18 s) : 0, 1179835
Total [candidate] (10.981 s) : 0, 10980946
section profiling
Agent [baseline] (1.272 s) : 0, 1271722
Total [baseline] (10.903 s) : 0, 10903293
Agent [candidate] (1.271 s) : 0, 1271345
Total [candidate] (10.8 s) : 0, 10799809
gantt
title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~0df6817a16, baseline=1.46.0-SNAPSHOT~03478c8e5c
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (712.852 ms) : 0, 712852
BytebuddyAgent [candidate] (711.462 ms) : 0, 711462
GlobalTracer [baseline] (255.75 ms) : 0, 255750
GlobalTracer [candidate] (255.828 ms) : 0, 255828
AppSec [baseline] (55.866 ms) : 0, 55866
AppSec [candidate] (55.056 ms) : 0, 55056
Remote Config [baseline] (728.123 µs) : 0, 728
Remote Config [candidate] (731.332 µs) : 0, 731
Telemetry [baseline] (14.996 ms) : 0, 14996
Telemetry [candidate] (13.651 ms) : 0, 13651
section appsec
BytebuddyAgent [baseline] (728.993 ms) : 0, 728993
BytebuddyAgent [candidate] (731.211 ms) : 0, 731211
GlobalTracer [baseline] (253.099 ms) : 0, 253099
GlobalTracer [candidate] (253.11 ms) : 0, 253110
AppSec [baseline] (170.963 ms) : 0, 170963
AppSec [candidate] (170.718 ms) : 0, 170718
IAST [baseline] (20.115 ms) : 0, 20115
IAST [candidate] (19.381 ms) : 0, 19381
Remote Config [baseline] (664.298 µs) : 0, 664
Remote Config [candidate] (656.322 µs) : 0, 656
Telemetry [baseline] (8.19 ms) : 0, 8190
Telemetry [candidate] (8.606 ms) : 0, 8606
section iast
BytebuddyAgent [baseline] (829.984 ms) : 0, 829984
BytebuddyAgent [candidate] (829.66 ms) : 0, 829660
GlobalTracer [baseline] (246.64 ms) : 0, 246640
GlobalTracer [candidate] (246.602 ms) : 0, 246602
AppSec [baseline] (57.9 ms) : 0, 57900
AppSec [candidate] (57.828 ms) : 0, 57828
IAST [baseline] (21.231 ms) : 0, 21231
IAST [candidate] (21.207 ms) : 0, 21207
Remote Config [baseline] (686.877 µs) : 0, 687
Remote Config [candidate] (669.886 µs) : 0, 670
Telemetry [baseline] (8.743 ms) : 0, 8743
Telemetry [candidate] (8.826 ms) : 0, 8826
section profiling
BytebuddyAgent [baseline] (702.417 ms) : 0, 702417
BytebuddyAgent [candidate] (701.601 ms) : 0, 701601
GlobalTracer [baseline] (369.119 ms) : 0, 369119
GlobalTracer [candidate] (368.561 ms) : 0, 368561
AppSec [baseline] (53.736 ms) : 0, 53736
AppSec [candidate] (53.852 ms) : 0, 53852
Remote Config [baseline] (698.52 µs) : 0, 699
Remote Config [candidate] (707.392 µs) : 0, 707
Telemetry [baseline] (8.804 ms) : 0, 8804
Telemetry [candidate] (8.842 ms) : 0, 8842
ProfilingAgent [baseline] (95.098 ms) : 0, 95098
ProfilingAgent [candidate] (95.885 ms) : 0, 95885
Profiling [baseline] (95.125 ms) : 0, 95125
Profiling [candidate] (95.912 ms) : 0, 95912
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~0df6817a16, baseline=1.46.0-SNAPSHOT~03478c8e5c
dateFormat X
axisFormat %s
section baseline
no_agent (1.354 ms) : 1334, 1374
. : milestone, 1354,
appsec (1.766 ms) : 1743, 1790
. : milestone, 1766,
appsec_no_iast (1.763 ms) : 1738, 1788
. : milestone, 1763,
iast (1.512 ms) : 1490, 1535
. : milestone, 1512,
profiling (1.518 ms) : 1493, 1542
. : milestone, 1518,
tracing (1.493 ms) : 1467, 1518
. : milestone, 1493,
section candidate
no_agent (1.344 ms) : 1324, 1364
. : milestone, 1344,
appsec (1.764 ms) : 1741, 1788
. : milestone, 1764,
appsec_no_iast (1.776 ms) : 1752, 1800
. : milestone, 1776,
iast (1.525 ms) : 1502, 1549
. : milestone, 1525,
profiling (1.532 ms) : 1509, 1555
. : milestone, 1532,
tracing (1.488 ms) : 1462, 1514
. : milestone, 1488,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~0df6817a16, baseline=1.46.0-SNAPSHOT~03478c8e5c
dateFormat X
axisFormat %s
section baseline
no_agent (379.212 µs) : 360, 399
. : milestone, 379,
iast (502.031 µs) : 480, 524
. : milestone, 502,
iast_FULL (663.683 µs) : 642, 686
. : milestone, 664,
iast_GLOBAL (533.557 µs) : 512, 556
. : milestone, 534,
iast_HARDCODED_SECRET_DISABLED (504.423 µs) : 483, 526
. : milestone, 504,
iast_INACTIVE (461.842 µs) : 441, 483
. : milestone, 462,
iast_TELEMETRY_OFF (493.415 µs) : 471, 516
. : milestone, 493,
tracing (461.185 µs) : 440, 483
. : milestone, 461,
section candidate
no_agent (387.001 µs) : 367, 407
. : milestone, 387,
iast (503.362 µs) : 481, 525
. : milestone, 503,
iast_FULL (662.846 µs) : 641, 685
. : milestone, 663,
iast_GLOBAL (528.785 µs) : 507, 550
. : milestone, 529,
iast_HARDCODED_SECRET_DISABLED (502.13 µs) : 481, 524
. : milestone, 502,
iast_INACTIVE (460.664 µs) : 440, 482
. : milestone, 461,
iast_TELEMETRY_OFF (489.344 µs) : 468, 511
. : milestone, 489,
tracing (450.949 µs) : 430, 471
. : milestone, 451,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~0df6817a16, baseline=1.46.0-SNAPSHOT~03478c8e5c
dateFormat X
axisFormat %s
section baseline
no_agent (15.351 s) : 15351000, 15351000
. : milestone, 15351000,
appsec (15.094 s) : 15094000, 15094000
. : milestone, 15094000,
iast (18.833 s) : 18833000, 18833000
. : milestone, 18833000,
iast_GLOBAL (17.988 s) : 17988000, 17988000
. : milestone, 17988000,
profiling (15.014 s) : 15014000, 15014000
. : milestone, 15014000,
tracing (14.877 s) : 14877000, 14877000
. : milestone, 14877000,
section candidate
no_agent (15.532 s) : 15532000, 15532000
. : milestone, 15532000,
appsec (14.735 s) : 14735000, 14735000
. : milestone, 14735000,
iast (18.689 s) : 18689000, 18689000
. : milestone, 18689000,
iast_GLOBAL (17.795 s) : 17795000, 17795000
. : milestone, 17795000,
profiling (15.858 s) : 15858000, 15858000
. : milestone, 15858000,
tracing (14.982 s) : 14982000, 14982000
. : milestone, 14982000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~0df6817a16, baseline=1.46.0-SNAPSHOT~03478c8e5c
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (2.349 ms) : 2306, 2391
. : milestone, 2349,
iast (2.096 ms) : 2042, 2150
. : milestone, 2096,
iast_GLOBAL (2.136 ms) : 2082, 2190
. : milestone, 2136,
profiling (1.957 ms) : 1914, 2000
. : milestone, 1957,
tracing (1.934 ms) : 1893, 1976
. : milestone, 1934,
section candidate
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (2.335 ms) : 2293, 2377
. : milestone, 2335,
iast (2.095 ms) : 2041, 2149
. : milestone, 2095,
iast_GLOBAL (2.145 ms) : 2090, 2199
. : milestone, 2145,
profiling (1.95 ms) : 1907, 1992
. : milestone, 1950,
tracing (1.932 ms) : 1890, 1973
. : milestone, 1932,
|
Closing this duplicate as I merged the original one (that got the review feedback). |
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: AIDM-429