-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement impacted tests detection #8188
Draft
nikita-tkachenko-datadog
wants to merge
13
commits into
master
Choose a base branch
from
nikita-tkachenko/impacted-tests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-tkachenko-datadog
added
tag: no release notes
Changes to exclude from release notes
type: refactoring
comp: ci visibility
Continuous Integration Visibility
labels
Jan 13, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 59 metrics, 3 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~41bfd9f9e3, baseline=1.46.0-SNAPSHOT~fbb36f9b5b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1057052
Total [baseline] (10.498 s) : 0, 10497751
Agent [candidate] (1.055 s) : 0, 1054950
Total [candidate] (10.464 s) : 0, 10464438
section appsec
Agent [baseline] (1.19 s) : 0, 1189661
Total [baseline] (10.774 s) : 0, 10773502
Agent [candidate] (1.194 s) : 0, 1194232
Total [candidate] (10.73 s) : 0, 10729678
section iast
Agent [baseline] (1.205 s) : 0, 1204797
Total [baseline] (11.015 s) : 0, 11015072
Agent [candidate] (1.185 s) : 0, 1185130
Total [candidate] (11.012 s) : 0, 11012265
section profiling
Agent [baseline] (1.261 s) : 0, 1260614
Total [baseline] (10.861 s) : 0, 10860791
Agent [candidate] (1.273 s) : 0, 1272699
Total [candidate] (10.895 s) : 0, 10894932
gantt
title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~41bfd9f9e3, baseline=1.46.0-SNAPSHOT~fbb36f9b5b
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (713.35 ms) : 0, 713350
BytebuddyAgent [candidate] (713.375 ms) : 0, 713375
GlobalTracer [baseline] (255.807 ms) : 0, 255807
GlobalTracer [candidate] (256.688 ms) : 0, 256688
AppSec [baseline] (56.296 ms) : 0, 56296
AppSec [candidate] (56.747 ms) : 0, 56747
Remote Config [baseline] (743.285 µs) : 0, 743
Remote Config [candidate] (724.157 µs) : 0, 724
Telemetry [baseline] (15.896 ms) : 0, 15896
Telemetry [candidate] (12.356 ms) : 0, 12356
section appsec
BytebuddyAgent [baseline] (731.526 ms) : 0, 731526
BytebuddyAgent [candidate] (734.72 ms) : 0, 734720
GlobalTracer [baseline] (252.991 ms) : 0, 252991
GlobalTracer [candidate] (254.398 ms) : 0, 254398
AppSec [baseline] (171.571 ms) : 0, 171571
AppSec [candidate] (171.084 ms) : 0, 171084
Remote Config [baseline] (672.362 µs) : 0, 672
Remote Config [candidate] (665.563 µs) : 0, 666
Telemetry [baseline] (8.252 ms) : 0, 8252
Telemetry [candidate] (8.227 ms) : 0, 8227
IAST [baseline] (19.331 ms) : 0, 19331
IAST [candidate] (20.124 ms) : 0, 20124
section iast
BytebuddyAgent [baseline] (849.614 ms) : 0, 849614
BytebuddyAgent [candidate] (834.404 ms) : 0, 834404
GlobalTracer [baseline] (249.625 ms) : 0, 249625
GlobalTracer [candidate] (246.405 ms) : 0, 246405
AppSec [baseline] (58.685 ms) : 0, 58685
AppSec [candidate] (58.209 ms) : 0, 58209
Remote Config [baseline] (670.979 µs) : 0, 671
Remote Config [candidate] (679.605 µs) : 0, 680
Telemetry [baseline] (9.005 ms) : 0, 9005
Telemetry [candidate] (8.842 ms) : 0, 8842
IAST [baseline] (21.91 ms) : 0, 21910
IAST [candidate] (21.489 ms) : 0, 21489
section profiling
BytebuddyAgent [baseline] (706.4 ms) : 0, 706400
BytebuddyAgent [candidate] (702.612 ms) : 0, 702612
GlobalTracer [baseline] (351.169 ms) : 0, 351169
GlobalTracer [candidate] (369.282 ms) : 0, 369282
AppSec [baseline] (55.041 ms) : 0, 55041
AppSec [candidate] (54.127 ms) : 0, 54127
Remote Config [baseline] (712.983 µs) : 0, 713
Remote Config [candidate] (707.453 µs) : 0, 707
Telemetry [baseline] (8.864 ms) : 0, 8864
Telemetry [candidate] (8.843 ms) : 0, 8843
ProfilingAgent [baseline] (96.228 ms) : 0, 96228
ProfilingAgent [candidate] (95.149 ms) : 0, 95149
Profiling [baseline] (96.255 ms) : 0, 96255
Profiling [candidate] (95.176 ms) : 0, 95176
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~41bfd9f9e3, baseline=1.46.0-SNAPSHOT~fbb36f9b5b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1054936
Total [baseline] (8.627 s) : 0, 8626746
Agent [candidate] (1.055 s) : 0, 1054636
Total [candidate] (8.623 s) : 0, 8623488
section iast
Agent [baseline] (1.181 s) : 0, 1181339
Total [baseline] (9.175 s) : 0, 9174956
Agent [candidate] (1.183 s) : 0, 1182993
Total [candidate] (9.232 s) : 0, 9232307
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.185 s) : 0, 1184851
Total [baseline] (9.218 s) : 0, 9217792
Agent [candidate] (1.183 s) : 0, 1182646
Total [candidate] (9.172 s) : 0, 9171759
section iast_TELEMETRY_OFF
Agent [baseline] (1.178 s) : 0, 1177989
Total [baseline] (9.197 s) : 0, 9196838
Agent [candidate] (1.177 s) : 0, 1177303
Total [candidate] (9.225 s) : 0, 9225318
gantt
title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~41bfd9f9e3, baseline=1.46.0-SNAPSHOT~fbb36f9b5b
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (714.375 ms) : 0, 714375
BytebuddyAgent [candidate] (713.242 ms) : 0, 713242
GlobalTracer [baseline] (255.651 ms) : 0, 255651
GlobalTracer [candidate] (256.323 ms) : 0, 256323
AppSec [baseline] (55.514 ms) : 0, 55514
AppSec [candidate] (56.45 ms) : 0, 56450
Remote Config [baseline] (731.678 µs) : 0, 732
Remote Config [candidate] (718.24 µs) : 0, 718
Telemetry [baseline] (13.666 ms) : 0, 13666
Telemetry [candidate] (12.952 ms) : 0, 12952
section iast
BytebuddyAgent [baseline] (830.946 ms) : 0, 830946
BytebuddyAgent [candidate] (831.258 ms) : 0, 831258
GlobalTracer [baseline] (246.491 ms) : 0, 246491
GlobalTracer [candidate] (247.177 ms) : 0, 247177
AppSec [baseline] (57.831 ms) : 0, 57831
AppSec [candidate] (58.39 ms) : 0, 58390
IAST [baseline] (21.488 ms) : 0, 21488
IAST [candidate] (21.619 ms) : 0, 21619
Remote Config [baseline] (680.552 µs) : 0, 681
Remote Config [candidate] (696.266 µs) : 0, 696
Telemetry [baseline] (8.876 ms) : 0, 8876
Telemetry [candidate] (8.866 ms) : 0, 8866
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (831.819 ms) : 0, 831819
BytebuddyAgent [candidate] (831.357 ms) : 0, 831357
GlobalTracer [baseline] (248.281 ms) : 0, 248281
GlobalTracer [candidate] (247.194 ms) : 0, 247194
AppSec [baseline] (58.464 ms) : 0, 58464
AppSec [candidate] (58.291 ms) : 0, 58291
IAST [baseline] (21.661 ms) : 0, 21661
IAST [candidate] (21.335 ms) : 0, 21335
Remote Config [baseline] (680.864 µs) : 0, 681
Remote Config [candidate] (671.288 µs) : 0, 671
Telemetry [baseline] (8.946 ms) : 0, 8946
Telemetry [candidate] (8.752 ms) : 0, 8752
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (828.364 ms) : 0, 828364
BytebuddyAgent [candidate] (827.916 ms) : 0, 827916
GlobalTracer [baseline] (246.39 ms) : 0, 246390
GlobalTracer [candidate] (246.785 ms) : 0, 246785
AppSec [baseline] (58.033 ms) : 0, 58033
AppSec [candidate] (57.81 ms) : 0, 57810
IAST [baseline] (20.871 ms) : 0, 20871
IAST [candidate] (20.626 ms) : 0, 20626
Remote Config [baseline] (665.325 µs) : 0, 665
Remote Config [candidate] (664.647 µs) : 0, 665
Telemetry [baseline] (8.692 ms) : 0, 8692
Telemetry [candidate] (8.511 ms) : 0, 8511
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~41bfd9f9e3, baseline=1.46.0-SNAPSHOT~fbb36f9b5b
dateFormat X
axisFormat %s
section baseline
no_agent (1.363 ms) : 1344, 1383
. : milestone, 1363,
appsec (1.756 ms) : 1733, 1780
. : milestone, 1756,
appsec_no_iast (1.761 ms) : 1738, 1784
. : milestone, 1761,
iast (1.509 ms) : 1485, 1534
. : milestone, 1509,
profiling (1.519 ms) : 1496, 1542
. : milestone, 1519,
tracing (1.486 ms) : 1461, 1511
. : milestone, 1486,
section candidate
no_agent (1.366 ms) : 1346, 1386
. : milestone, 1366,
appsec (1.758 ms) : 1734, 1782
. : milestone, 1758,
appsec_no_iast (1.773 ms) : 1749, 1798
. : milestone, 1773,
iast (1.496 ms) : 1473, 1520
. : milestone, 1496,
profiling (1.519 ms) : 1496, 1542
. : milestone, 1519,
tracing (1.509 ms) : 1485, 1534
. : milestone, 1509,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~41bfd9f9e3, baseline=1.46.0-SNAPSHOT~fbb36f9b5b
dateFormat X
axisFormat %s
section baseline
no_agent (384.863 µs) : 364, 405
. : milestone, 385,
iast (512.838 µs) : 491, 535
. : milestone, 513,
iast_FULL (745.283 µs) : 723, 767
. : milestone, 745,
iast_GLOBAL (562.149 µs) : 540, 585
. : milestone, 562,
iast_HARDCODED_SECRET_DISABLED (517.247 µs) : 495, 539
. : milestone, 517,
iast_INACTIVE (468.132 µs) : 446, 490
. : milestone, 468,
iast_TELEMETRY_OFF (500.046 µs) : 478, 522
. : milestone, 500,
tracing (452.92 µs) : 432, 474
. : milestone, 453,
section candidate
no_agent (377.493 µs) : 358, 397
. : milestone, 377,
iast (504.34 µs) : 483, 526
. : milestone, 504,
iast_FULL (661.198 µs) : 640, 683
. : milestone, 661,
iast_GLOBAL (523.029 µs) : 502, 544
. : milestone, 523,
iast_HARDCODED_SECRET_DISABLED (501.525 µs) : 480, 523
. : milestone, 502,
iast_INACTIVE (464.244 µs) : 443, 486
. : milestone, 464,
iast_TELEMETRY_OFF (495.4 µs) : 473, 518
. : milestone, 495,
tracing (452.552 µs) : 432, 473
. : milestone, 453,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~41bfd9f9e3, baseline=1.46.0-SNAPSHOT~fbb36f9b5b
dateFormat X
axisFormat %s
section baseline
no_agent (15.548 s) : 15548000, 15548000
. : milestone, 15548000,
appsec (15.001 s) : 15001000, 15001000
. : milestone, 15001000,
iast (19.044 s) : 19044000, 19044000
. : milestone, 19044000,
iast_GLOBAL (18.034 s) : 18034000, 18034000
. : milestone, 18034000,
profiling (15.578 s) : 15578000, 15578000
. : milestone, 15578000,
tracing (14.931 s) : 14931000, 14931000
. : milestone, 14931000,
section candidate
no_agent (15.161 s) : 15161000, 15161000
. : milestone, 15161000,
appsec (15.077 s) : 15077000, 15077000
. : milestone, 15077000,
iast (18.618 s) : 18618000, 18618000
. : milestone, 18618000,
iast_GLOBAL (18.323 s) : 18323000, 18323000
. : milestone, 18323000,
profiling (15.033 s) : 15033000, 15033000
. : milestone, 15033000,
tracing (15.177 s) : 15177000, 15177000
. : milestone, 15177000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~41bfd9f9e3, baseline=1.46.0-SNAPSHOT~fbb36f9b5b
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (2.366 ms) : 2323, 2409
. : milestone, 2366,
iast (2.113 ms) : 2059, 2167
. : milestone, 2113,
iast_GLOBAL (2.15 ms) : 2095, 2204
. : milestone, 2150,
profiling (1.966 ms) : 1923, 2009
. : milestone, 1966,
tracing (1.956 ms) : 1914, 1997
. : milestone, 1956,
section candidate
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (2.361 ms) : 2318, 2403
. : milestone, 2361,
iast (2.108 ms) : 2054, 2163
. : milestone, 2108,
iast_GLOBAL (2.151 ms) : 2097, 2206
. : milestone, 2151,
profiling (1.974 ms) : 1930, 2019
. : milestone, 1974,
tracing (1.949 ms) : 1907, 1991
. : milestone, 1949,
|
nikita-tkachenko-datadog
force-pushed
the
nikita-tkachenko/impacted-tests
branch
from
January 16, 2025 17:49
0cfd616
to
8a25380
Compare
nikita-tkachenko-datadog
changed the title
Pass test source data to retry policy factory
Implement impacted tests detection
Jan 16, 2025
nikita-tkachenko-datadog
added
type: enhancement
and removed
tag: no release notes
Changes to exclude from release notes
type: refactoring
labels
Jan 16, 2025
…+ extract a no-op git client implementation to avoid spamming logs with exceptions in envs where git executable is not available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: SDTEST-1389