Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance log probes to honor debug session tags #8215

Merged
merged 4 commits into from
Jan 17, 2025
Merged

Enhance log probes to honor debug session tags #8215

merged 4 commits into from
Jan 17, 2025

Conversation

evanchooly
Copy link
Contributor

@evanchooly evanchooly commented Jan 15, 2025 •
edited by jira bot
Loading

What Does This Do

Enhances log probes to honor session id tags for live debugger support.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: DEBUG-2955

@evanchooly evanchooly added the comp: debugger Dynamic Instrumentation label Jan 15, 2025
@evanchooly evanchooly requested review from jpbempel and shatzi January 15, 2025 20:49
@evanchooly evanchooly requested a review from a team as a code owner January 15, 2025 20:49
@github-actions GitHub Actions
Copy link
Contributor

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@pr-commenter
Copy link

pr-commenter bot commented Jan 15, 2025 •
edited
Loading

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1737125061 1737125430
end_time 2025-01-17T14:45:38 2025-01-17T14:51:47
git_branch master evanchooly/DEBUG-2955
git_commit_sha fbb36f9 db4aefa
start_time 2025-01-17T14:44:22 2025-01-17T14:50:31
See matching parameters
Baseline Candidate
ci_job_id 770814896 770814896
ci_pipeline_id 53314617 53314617
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1737124474 1737124474

Summary

Found 0 performance improvements and 2 performance regressions! Performance is the same for 7 metrics, 6 unstable metrics.

scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:loop worse
[+122.425µs; +137.150µs] or [+1.242%; +1.391%]		 worse
[+114.537µs; +173.672µs] or [+1.146%; +1.737%]		 unsure
[+93.710µs; +189.278µs] or [+0.927%; +1.873%]		 unsure
[+30.984µs; +342.505µs] or [+0.298%; +3.296%]		 unsure
[-2.666op/s; -0.203op/s] or [-2.706%; -0.206%]
See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-18.569µs; +42.016µs] or [-6.928%; +15.676%]		 unstable
[-29.226µs; +55.616µs] or [-9.517%; +18.111%]		 unstable
[-38.207µs; +65.576µs] or [-11.934%; +20.482%]		 unstable
[-89.495µs; +189.710µs] or [-15.397%; +32.638%]		 same
scenario:basic same same same unstable
[-156.409µs; +90.071µs] or [-27.196%; +15.661%]		 unstable
[-165.521op/s; +165.521op/s] or [-6.621%; +6.621%]
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (307.093 µs) : 285, 329
.   : milestone, 307,
basic (312.278 µs) : 303, 321
.   : milestone, 312,
loop (9.998 ms) : 9977, 10019
.   : milestone, 9998,
section candidate
noprobe (320.288 µs) : 268, 373
.   : milestone, 320,
basic (314.915 µs) : 304, 326
.   : milestone, 315,
loop (10.142 ms) : 10110, 10175
.   : milestone, 10142,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 307.093 µs [285.102 µs, 329.084 µs]
basic 312.278 µs [303.199 µs, 321.356 µs]
loop 9.998 ms [9.977 ms, 10.019 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 320.288 µs [267.5 µs, 373.075 µs]
basic 314.915 µs [303.691 µs, 326.139 µs]
loop 10.142 ms [10.11 ms, 10.175 ms]

@pr-commenter
Copy link

pr-commenter bot commented Jan 15, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master evanchooly/DEBUG-2955
git_commit_date 1737124507 1737124474
git_commit_sha fbb36f9 db4aefa
release_version 1.46.0-SNAPSHOT~fbb36f9b5b 1.46.0-SNAPSHOT~db4aefa14b
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1737126809 1737126809
ci_job_id 770814890 770814890
ci_pipeline_id 53314617 53314617
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 5 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:petclinic:profiling:Remote Config better
[-82.824µs; -31.406µs] or [-11.633%; -4.411%]		 654.846µs 711.960µs
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~db4aefa14b, baseline=1.46.0-SNAPSHOT~fbb36f9b5b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1053610
Total [baseline] (10.481 s) : 0, 10480905
Agent [candidate] (1.061 s) : 0, 1060892
Total [candidate] (10.572 s) : 0, 10572292
section appsec
Agent [baseline] (1.193 s) : 0, 1192701
Total [baseline] (10.698 s) : 0, 10697641
Agent [candidate] (1.192 s) : 0, 1192482
Total [candidate] (10.747 s) : 0, 10747405
section iast
Agent [baseline] (1.203 s) : 0, 1203055
Total [baseline] (11.099 s) : 0, 11099351
Agent [candidate] (1.199 s) : 0, 1198807
Total [candidate] (11.005 s) : 0, 11004994
section profiling
Agent [baseline] (1.253 s) : 0, 1253192
Total [baseline] (10.795 s) : 0, 10795119
Agent [candidate] (1.253 s) : 0, 1253133
Total [candidate] (10.847 s) : 0, 10846681
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.054 s -
Agent appsec 1.193 s 139.091 ms (13.2%)
Agent iast 1.203 s 149.445 ms (14.2%)
Agent profiling 1.253 s 199.583 ms (18.9%)
Total tracing 10.481 s -
Total appsec 10.698 s 216.736 ms (2.1%)
Total iast 11.099 s 618.446 ms (5.9%)
Total profiling 10.795 s 314.214 ms (3.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.061 s -
Agent appsec 1.192 s 131.59 ms (12.4%)
Agent iast 1.199 s 137.915 ms (13.0%)
Agent profiling 1.253 s 192.24 ms (18.1%)
Total tracing 10.572 s -
Total appsec 10.747 s 175.113 ms (1.7%)
Total iast 11.005 s 432.703 ms (4.1%)
Total profiling 10.847 s 274.39 ms (2.6%) 
gantt
    title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~db4aefa14b, baseline=1.46.0-SNAPSHOT~fbb36f9b5b

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (713.072 ms) : 0, 713072
BytebuddyAgent [candidate] (717.49 ms) : 0, 717490
GlobalTracer [baseline] (255.796 ms) : 0, 255796
GlobalTracer [candidate] (257.177 ms) : 0, 257177
AppSec [baseline] (56.125 ms) : 0, 56125
AppSec [candidate] (55.697 ms) : 0, 55697
Remote Config [baseline] (738.969 µs) : 0, 739
Remote Config [candidate] (734.879 µs) : 0, 735
Telemetry [baseline] (12.875 ms) : 0, 12875
Telemetry [candidate] (14.651 ms) : 0, 14651
section appsec
BytebuddyAgent [baseline] (733.922 ms) : 0, 733922
BytebuddyAgent [candidate] (733.364 ms) : 0, 733364
GlobalTracer [baseline] (253.644 ms) : 0, 253644
GlobalTracer [candidate] (253.949 ms) : 0, 253949
AppSec [baseline] (171.487 ms) : 0, 171487
AppSec [candidate] (171.503 ms) : 0, 171503
IAST [baseline] (19.429 ms) : 0, 19429
IAST [candidate] (19.454 ms) : 0, 19454
Remote Config [baseline] (668.397 µs) : 0, 668
Remote Config [candidate] (666.839 µs) : 0, 667
Telemetry [baseline] (8.217 ms) : 0, 8217
Telemetry [candidate] (8.209 ms) : 0, 8209
section iast
BytebuddyAgent [baseline] (848.08 ms) : 0, 848080
BytebuddyAgent [candidate] (843.62 ms) : 0, 843620
GlobalTracer [baseline] (249.491 ms) : 0, 249491
GlobalTracer [candidate] (249.557 ms) : 0, 249557
AppSec [baseline] (58.708 ms) : 0, 58708
AppSec [candidate] (58.541 ms) : 0, 58541
IAST [baseline] (21.867 ms) : 0, 21867
IAST [candidate] (21.989 ms) : 0, 21989
Remote Config [baseline] (674.54 µs) : 0, 675
Remote Config [candidate] (682.634 µs) : 0, 683
Telemetry [baseline] (8.95 ms) : 0, 8950
Telemetry [candidate] (8.95 ms) : 0, 8950
section profiling
BytebuddyAgent [baseline] (702.889 ms) : 0, 702889
BytebuddyAgent [candidate] (702.262 ms) : 0, 702262
GlobalTracer [baseline] (348.862 ms) : 0, 348862
GlobalTracer [candidate] (350.325 ms) : 0, 350325
AppSec [baseline] (54.931 ms) : 0, 54931
AppSec [candidate] (53.442 ms) : 0, 53442
Remote Config [baseline] (711.96 µs) : 0, 712
Remote Config [candidate] (654.846 µs) : 0, 655
Telemetry [baseline] (8.815 ms) : 0, 8815
Telemetry [candidate] (8.825 ms) : 0, 8825
ProfilingAgent [baseline] (95.065 ms) : 0, 95065
ProfilingAgent [candidate] (95.543 ms) : 0, 95543
Profiling [baseline] (95.088 ms) : 0, 95088
Profiling [candidate] (95.567 ms) : 0, 95567
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~db4aefa14b, baseline=1.46.0-SNAPSHOT~fbb36f9b5b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1065521
Total [baseline] (8.686 s) : 0, 8686464
Agent [candidate] (1.054 s) : 0, 1054218
Total [candidate] (8.624 s) : 0, 8623779
section iast
Agent [baseline] (1.188 s) : 0, 1188404
Total [baseline] (9.21 s) : 0, 9209527
Agent [candidate] (1.182 s) : 0, 1182102
Total [candidate] (9.199 s) : 0, 9199438
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.185 s) : 0, 1184805
Total [baseline] (9.167 s) : 0, 9166692
Agent [candidate] (1.196 s) : 0, 1195872
Total [candidate] (9.28 s) : 0, 9279565
section iast_TELEMETRY_OFF
Agent [baseline] (1.179 s) : 0, 1178550
Total [baseline] (9.219 s) : 0, 9219169
Agent [candidate] (1.177 s) : 0, 1176703
Total [candidate] (9.218 s) : 0, 9218021
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.066 s -
Agent iast 1.188 s 122.883 ms (11.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.185 s 119.284 ms (11.2%)
Agent iast_TELEMETRY_OFF 1.179 s 113.029 ms (10.6%)
Total tracing 8.686 s -
Total iast 9.21 s 523.063 ms (6.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.167 s 480.228 ms (5.5%)
Total iast_TELEMETRY_OFF 9.219 s 532.705 ms (6.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.054 s -
Agent iast 1.182 s 127.884 ms (12.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.196 s 141.654 ms (13.4%)
Agent iast_TELEMETRY_OFF 1.177 s 122.485 ms (11.6%)
Total tracing 8.624 s -
Total iast 9.199 s 575.659 ms (6.7%)
Total iast_HARDCODED_SECRET_DISABLED 9.28 s 655.786 ms (7.6%)
Total iast_TELEMETRY_OFF 9.218 s 594.242 ms (6.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~db4aefa14b, baseline=1.46.0-SNAPSHOT~fbb36f9b5b

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (723.228 ms) : 0, 723228
BytebuddyAgent [candidate] (712.746 ms) : 0, 712746
GlobalTracer [baseline] (259.275 ms) : 0, 259275
GlobalTracer [candidate] (255.723 ms) : 0, 255723
AppSec [baseline] (56.859 ms) : 0, 56859
AppSec [candidate] (55.793 ms) : 0, 55793
Remote Config [baseline] (749.022 µs) : 0, 749
Remote Config [candidate] (725.336 µs) : 0, 725
Telemetry [baseline] (10.194 ms) : 0, 10194
Telemetry [candidate] (14.246 ms) : 0, 14246
section iast
BytebuddyAgent [baseline] (836.041 ms) : 0, 836041
BytebuddyAgent [candidate] (831.156 ms) : 0, 831156
GlobalTracer [baseline] (247.31 ms) : 0, 247310
GlobalTracer [candidate] (247.023 ms) : 0, 247023
AppSec [baseline] (58.496 ms) : 0, 58496
AppSec [candidate] (57.961 ms) : 0, 57961
IAST [baseline] (21.806 ms) : 0, 21806
IAST [candidate] (21.552 ms) : 0, 21552
Remote Config [baseline] (697.192 µs) : 0, 697
Remote Config [candidate] (683.646 µs) : 0, 684
Telemetry [baseline] (8.961 ms) : 0, 8961
Telemetry [candidate] (8.761 ms) : 0, 8761
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (832.53 ms) : 0, 832530
BytebuddyAgent [candidate] (840.687 ms) : 0, 840687
GlobalTracer [baseline] (247.257 ms) : 0, 247257
GlobalTracer [candidate] (248.875 ms) : 0, 248875
AppSec [baseline] (58.638 ms) : 0, 58638
AppSec [candidate] (58.936 ms) : 0, 58936
IAST [baseline] (21.656 ms) : 0, 21656
IAST [candidate] (22.275 ms) : 0, 22275
Remote Config [baseline] (674.818 µs) : 0, 675
Remote Config [candidate] (705.673 µs) : 0, 706
Telemetry [baseline] (9.005 ms) : 0, 9005
Telemetry [candidate] (9.175 ms) : 0, 9175
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (828.408 ms) : 0, 828408
BytebuddyAgent [candidate] (827.345 ms) : 0, 827345
GlobalTracer [baseline] (246.996 ms) : 0, 246996
GlobalTracer [candidate] (246.291 ms) : 0, 246291
AppSec [baseline] (57.992 ms) : 0, 57992
AppSec [candidate] (57.9 ms) : 0, 57900
IAST [baseline] (20.794 ms) : 0, 20794
IAST [candidate] (20.875 ms) : 0, 20875
Remote Config [baseline] (662.324 µs) : 0, 662
Remote Config [candidate] (659.2 µs) : 0, 659
Telemetry [baseline] (8.679 ms) : 0, 8679
Telemetry [candidate] (8.602 ms) : 0, 8602
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-01-17T14:43:25 2025-01-17T14:50:29
git_branch master evanchooly/DEBUG-2955
git_commit_date 1737124507 1737124474
git_commit_sha fbb36f9 db4aefa
release_version 1.46.0-SNAPSHOT~fbb36f9b5b 1.46.0-SNAPSHOT~db4aefa14b
start_time 2025-01-17T14:43:11 2025-01-17T14:50:16
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1737125788 1737125788
ci_job_id 770814891 770814891
ci_pipeline_id 53314617 53314617
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~db4aefa14b, baseline=1.46.0-SNAPSHOT~fbb36f9b5b
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.366 ms) : 1346, 1385
.   : milestone, 1366,
appsec (1.748 ms) : 1724, 1772
.   : milestone, 1748,
appsec_no_iast (1.754 ms) : 1731, 1776
.   : milestone, 1754,
iast (1.506 ms) : 1481, 1530
.   : milestone, 1506,
profiling (1.51 ms) : 1486, 1534
.   : milestone, 1510,
tracing (1.489 ms) : 1464, 1514
.   : milestone, 1489,
section candidate
no_agent (1.364 ms) : 1344, 1384
.   : milestone, 1364,
appsec (1.753 ms) : 1729, 1776
.   : milestone, 1753,
appsec_no_iast (1.776 ms) : 1752, 1800
.   : milestone, 1776,
iast (1.518 ms) : 1494, 1542
.   : milestone, 1518,
profiling (1.528 ms) : 1504, 1552
.   : milestone, 1528,
tracing (1.479 ms) : 1454, 1503
.   : milestone, 1479,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.366 ms [1.346 ms, 1.385 ms] -
appsec 1.748 ms [1.724 ms, 1.772 ms] 382.513 µs (28.0%)
appsec_no_iast 1.754 ms [1.731 ms, 1.776 ms] 387.798 µs (28.4%)
iast 1.506 ms [1.481 ms, 1.53 ms] 139.753 µs (10.2%)
profiling 1.51 ms [1.486 ms, 1.534 ms] 144.301 µs (10.6%)
tracing 1.489 ms [1.464 ms, 1.514 ms] 123.51 µs (9.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.364 ms [1.344 ms, 1.384 ms] -
appsec 1.753 ms [1.729 ms, 1.776 ms] 388.707 µs (28.5%)
appsec_no_iast 1.776 ms [1.752 ms, 1.8 ms] 412.121 µs (30.2%)
iast 1.518 ms [1.494 ms, 1.542 ms] 153.888 µs (11.3%)
profiling 1.528 ms [1.504 ms, 1.552 ms] 164.028 µs (12.0%)
tracing 1.479 ms [1.454 ms, 1.503 ms] 114.732 µs (8.4%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~db4aefa14b, baseline=1.46.0-SNAPSHOT~fbb36f9b5b
    dateFormat X
    axisFormat %s
section baseline
no_agent (385.578 µs) : 366, 406
.   : milestone, 386,
iast (509.385 µs) : 488, 531
.   : milestone, 509,
iast_FULL (740.557 µs) : 719, 762
.   : milestone, 741,
iast_GLOBAL (563.735 µs) : 541, 587
.   : milestone, 564,
iast_HARDCODED_SECRET_DISABLED (508.006 µs) : 486, 530
.   : milestone, 508,
iast_INACTIVE (467.199 µs) : 445, 489
.   : milestone, 467,
iast_TELEMETRY_OFF (510.89 µs) : 489, 533
.   : milestone, 511,
tracing (449.996 µs) : 429, 471
.   : milestone, 450,
section candidate
no_agent (379.352 µs) : 359, 399
.   : milestone, 379,
iast (507.138 µs) : 486, 529
.   : milestone, 507,
iast_FULL (740.636 µs) : 719, 762
.   : milestone, 741,
iast_GLOBAL (562.178 µs) : 539, 585
.   : milestone, 562,
iast_HARDCODED_SECRET_DISABLED (513.018 µs) : 491, 535
.   : milestone, 513,
iast_INACTIVE (466.211 µs) : 444, 489
.   : milestone, 466,
iast_TELEMETRY_OFF (496.926 µs) : 475, 519
.   : milestone, 497,
tracing (447.913 µs) : 428, 468
.   : milestone, 448,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 385.578 µs [365.636 µs, 405.52 µs] -
iast 509.385 µs [487.77 µs, 531.001 µs] 123.807 µs (32.1%)
iast_FULL 740.557 µs [718.821 µs, 762.293 µs] 354.979 µs (92.1%)
iast_GLOBAL 563.735 µs [540.82 µs, 586.65 µs] 178.157 µs (46.2%)
iast_HARDCODED_SECRET_DISABLED 508.006 µs [486.014 µs, 529.999 µs] 122.428 µs (31.8%)
iast_INACTIVE 467.199 µs [444.975 µs, 489.423 µs] 81.62 µs (21.2%)
iast_TELEMETRY_OFF 510.89 µs [488.941 µs, 532.839 µs] 125.311 µs (32.5%)
tracing 449.996 µs [428.677 µs, 471.316 µs] 64.418 µs (16.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 379.352 µs [359.226 µs, 399.477 µs] -
iast 507.138 µs [485.637 µs, 528.639 µs] 127.786 µs (33.7%)
iast_FULL 740.636 µs [718.811 µs, 762.461 µs] 361.284 µs (95.2%)
iast_GLOBAL 562.178 µs [539.134 µs, 585.222 µs] 182.826 µs (48.2%)
iast_HARDCODED_SECRET_DISABLED 513.018 µs [491.46 µs, 534.577 µs] 133.667 µs (35.2%)
iast_INACTIVE 466.211 µs [443.697 µs, 488.725 µs] 86.859 µs (22.9%)
iast_TELEMETRY_OFF 496.926 µs [475.199 µs, 518.653 µs] 117.574 µs (31.0%)
tracing 447.913 µs [427.518 µs, 468.308 µs] 68.561 µs (18.1%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master evanchooly/DEBUG-2955
git_commit_date 1737124507 1737124474
git_commit_sha fbb36f9 db4aefa
release_version 1.46.0-SNAPSHOT~fbb36f9b5b 1.46.0-SNAPSHOT~db4aefa14b
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1737126363 1737126363
ci_job_id 770814892 770814892
ci_pipeline_id 53314617 53314617
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~db4aefa14b, baseline=1.46.0-SNAPSHOT~fbb36f9b5b
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.465 ms) : 1454, 1477
.   : milestone, 1465,
appsec (2.36 ms) : 2317, 2403
.   : milestone, 2360,
iast (2.107 ms) : 2052, 2162
.   : milestone, 2107,
iast_GLOBAL (2.152 ms) : 2096, 2207
.   : milestone, 2152,
profiling (1.972 ms) : 1928, 2016
.   : milestone, 1972,
tracing (1.943 ms) : 1901, 1985
.   : milestone, 1943,
section candidate
no_agent (1.468 ms) : 1457, 1480
.   : milestone, 1468,
appsec (2.346 ms) : 2303, 2389
.   : milestone, 2346,
iast (2.102 ms) : 2048, 2157
.   : milestone, 2102,
iast_GLOBAL (2.151 ms) : 2096, 2206
.   : milestone, 2151,
profiling (1.949 ms) : 1906, 1993
.   : milestone, 1949,
tracing (1.941 ms) : 1899, 1983
.   : milestone, 1941,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.465 ms [1.454 ms, 1.477 ms] -
appsec 2.36 ms [2.317 ms, 2.403 ms] 894.343 µs (61.0%)
iast 2.107 ms [2.052 ms, 2.162 ms] 641.48 µs (43.8%)
iast_GLOBAL 2.152 ms [2.096 ms, 2.207 ms] 686.172 µs (46.8%)
profiling 1.972 ms [1.928 ms, 2.016 ms] 506.755 µs (34.6%)
tracing 1.943 ms [1.901 ms, 1.985 ms] 477.607 µs (32.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.468 ms [1.457 ms, 1.48 ms] -
appsec 2.346 ms [2.303 ms, 2.389 ms] 877.505 µs (59.8%)
iast 2.102 ms [2.048 ms, 2.157 ms] 633.969 µs (43.2%)
iast_GLOBAL 2.151 ms [2.096 ms, 2.206 ms] 682.604 µs (46.5%)
profiling 1.949 ms [1.906 ms, 1.993 ms] 481.302 µs (32.8%)
tracing 1.941 ms [1.899 ms, 1.983 ms] 472.486 µs (32.2%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~db4aefa14b, baseline=1.46.0-SNAPSHOT~fbb36f9b5b
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.644 s) : 14644000, 14644000
.   : milestone, 14644000,
appsec (15.104 s) : 15104000, 15104000
.   : milestone, 15104000,
iast (18.505 s) : 18505000, 18505000
.   : milestone, 18505000,
iast_GLOBAL (17.94 s) : 17940000, 17940000
.   : milestone, 17940000,
profiling (15.007 s) : 15007000, 15007000
.   : milestone, 15007000,
tracing (14.956 s) : 14956000, 14956000
.   : milestone, 14956000,
section candidate
no_agent (15.587 s) : 15587000, 15587000
.   : milestone, 15587000,
appsec (14.901 s) : 14901000, 14901000
.   : milestone, 14901000,
iast (18.694 s) : 18694000, 18694000
.   : milestone, 18694000,
iast_GLOBAL (17.867 s) : 17867000, 17867000
.   : milestone, 17867000,
profiling (14.968 s) : 14968000, 14968000
.   : milestone, 14968000,
tracing (15.032 s) : 15032000, 15032000
.   : milestone, 15032000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.644 s [14.644 s, 14.644 s] -
appsec 15.104 s [15.104 s, 15.104 s] 460.0 ms (3.1%)
iast 18.505 s [18.505 s, 18.505 s] 3.861 s (26.4%)
iast_GLOBAL 17.94 s [17.94 s, 17.94 s] 3.296 s (22.5%)
profiling 15.007 s [15.007 s, 15.007 s] 363.0 ms (2.5%)
tracing 14.956 s [14.956 s, 14.956 s] 312.0 ms (2.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.587 s [15.587 s, 15.587 s] -
appsec 14.901 s [14.901 s, 14.901 s] -686.0 ms (-4.4%)
iast 18.694 s [18.694 s, 18.694 s] 3.107 s (19.9%)
iast_GLOBAL 17.867 s [17.867 s, 17.867 s] 2.28 s (14.6%)
profiling 14.968 s [14.968 s, 14.968 s] -619.0 ms (-4.0%)
tracing 15.032 s [15.032 s, 15.032 s] -555.0 ms (-3.6%)

@evanchooly evanchooly requested a review from jpbempel January 16, 2025 20:07
@jpbempel jpbempel added comp: debugger Dynamic Instrumentation and removed comp: debugger Dynamic Instrumentation labels Jan 17, 2025
@evanchooly evanchooly merged commit 5010e26 into master Jan 17, 2025
177 of 178 checks passed
@evanchooly evanchooly deleted the evanchooly/DEBUG-2955 branch January 17, 2025 17:25
@github-actions github-actions bot added this to the 1.46.0 milestone Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbempel jpbempel jpbempel approved these changes

@shatzi shatzi Awaiting requested review from shatzi

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation type: enhancement
Projects
None yet
Milestone
1.46.0
Development

Successfully merging this pull request may close these issues.
2 participants
@evanchooly @jpbempel