Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test http server requests in parallel #8222

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Test http server requests in parallel #8222

merged 3 commits into from
Jan 16, 2025

Conversation

amarziali
Copy link
Collaborator

What Does This Do

Use parallelism to execute http server request for the scenario test success with #count requests

Motivation

Improves issue detection of multithreaded cases. I'll need also to test a fix for vertx worker context propagation in case of multiple parallel requests

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali amarziali requested a review from a team as a code owner January 16, 2025 09:48
@amarziali amarziali requested a review from mcculls January 16, 2025 09:48
@github-actions GitHub Actions
Copy link
Contributor

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@pr-commenter
Copy link

pr-commenter bot commented Jan 16, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/test-http-parallel
git_commit_date 1737040366 1737041004
git_commit_sha 679f9e2 adf899d
release_version 1.46.0-SNAPSHOT~679f9e2ece 1.46.0-SNAPSHOT~adf899d34f
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1737043332 1737043332
ci_job_id 769163456 769163456
ci_pipeline_id 53197386 53197386
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~adf899d34f, baseline=1.46.0-SNAPSHOT~679f9e2ece

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1060464
Total [baseline] (8.655 s) : 0, 8654645
Agent [candidate] (1.069 s) : 0, 1068560
Total [candidate] (8.672 s) : 0, 8672396
section iast
Agent [baseline] (1.184 s) : 0, 1183811
Total [baseline] (9.206 s) : 0, 9205688
Agent [candidate] (1.182 s) : 0, 1182308
Total [candidate] (9.243 s) : 0, 9242715
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.185 s) : 0, 1184715
Total [baseline] (9.191 s) : 0, 9191110
Agent [candidate] (1.183 s) : 0, 1183026
Total [candidate] (9.226 s) : 0, 9226427
section iast_TELEMETRY_OFF
Agent [baseline] (1.177 s) : 0, 1177373
Total [baseline] (9.174 s) : 0, 9174147
Agent [candidate] (1.183 s) : 0, 1183211
Total [candidate] (9.212 s) : 0, 9212108
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.06 s -
Agent iast 1.184 s 123.347 ms (11.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.185 s 124.251 ms (11.7%)
Agent iast_TELEMETRY_OFF 1.177 s 116.909 ms (11.0%)
Total tracing 8.655 s -
Total iast 9.206 s 551.043 ms (6.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.191 s 536.465 ms (6.2%)
Total iast_TELEMETRY_OFF 9.174 s 519.502 ms (6.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.069 s -
Agent iast 1.182 s 113.748 ms (10.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.183 s 114.465 ms (10.7%)
Agent iast_TELEMETRY_OFF 1.183 s 114.651 ms (10.7%)
Total tracing 8.672 s -
Total iast 9.243 s 570.319 ms (6.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.226 s 554.031 ms (6.4%)
Total iast_TELEMETRY_OFF 9.212 s 539.711 ms (6.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~adf899d34f, baseline=1.46.0-SNAPSHOT~679f9e2ece

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.492 ms) : 0, 717492
BytebuddyAgent [candidate] (724.313 ms) : 0, 724313
GlobalTracer [baseline] (257.207 ms) : 0, 257207
GlobalTracer [candidate] (259.188 ms) : 0, 259188
AppSec [baseline] (55.446 ms) : 0, 55446
AppSec [candidate] (57.342 ms) : 0, 57342
Remote Config [baseline] (733.223 µs) : 0, 733
Remote Config [candidate] (735.876 µs) : 0, 736
Telemetry [baseline] (14.426 ms) : 0, 14426
Telemetry [candidate] (11.726 ms) : 0, 11726
section iast
BytebuddyAgent [baseline] (832.805 ms) : 0, 832805
BytebuddyAgent [candidate] (831.978 ms) : 0, 831978
GlobalTracer [baseline] (246.812 ms) : 0, 246812
GlobalTracer [candidate] (246.538 ms) : 0, 246538
AppSec [baseline] (58.173 ms) : 0, 58173
AppSec [candidate] (57.728 ms) : 0, 57728
IAST [baseline] (21.518 ms) : 0, 21518
IAST [candidate] (21.521 ms) : 0, 21521
Remote Config [baseline] (668.778 µs) : 0, 669
Remote Config [candidate] (662.821 µs) : 0, 663
Telemetry [baseline] (8.808 ms) : 0, 8808
Telemetry [candidate] (8.817 ms) : 0, 8817
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (833.177 ms) : 0, 833177
BytebuddyAgent [candidate] (832.136 ms) : 0, 832136
GlobalTracer [baseline] (247.28 ms) : 0, 247280
GlobalTracer [candidate] (246.778 ms) : 0, 246778
AppSec [baseline] (58.062 ms) : 0, 58062
AppSec [candidate] (57.979 ms) : 0, 57979
IAST [baseline] (21.545 ms) : 0, 21545
IAST [candidate] (21.563 ms) : 0, 21563
Remote Config [baseline] (674.726 µs) : 0, 675
Remote Config [candidate] (670.361 µs) : 0, 670
Telemetry [baseline] (8.918 ms) : 0, 8918
Telemetry [candidate] (8.844 ms) : 0, 8844
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (827.951 ms) : 0, 827951
BytebuddyAgent [candidate] (833.323 ms) : 0, 833323
GlobalTracer [baseline] (246.297 ms) : 0, 246297
GlobalTracer [candidate] (246.599 ms) : 0, 246599
AppSec [baseline] (57.883 ms) : 0, 57883
AppSec [candidate] (57.776 ms) : 0, 57776
IAST [baseline] (20.948 ms) : 0, 20948
IAST [candidate] (21.066 ms) : 0, 21066
Remote Config [baseline] (676.984 µs) : 0, 677
Remote Config [candidate] (650.848 µs) : 0, 651
Telemetry [baseline] (8.667 ms) : 0, 8667
Telemetry [candidate] (8.647 ms) : 0, 8647
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~adf899d34f, baseline=1.46.0-SNAPSHOT~679f9e2ece

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1054772
Total [baseline] (10.481 s) : 0, 10481006
Agent [candidate] (1.056 s) : 0, 1056494
Total [candidate] (10.54 s) : 0, 10539837
section appsec
Agent [baseline] (1.188 s) : 0, 1187509
Total [baseline] (10.709 s) : 0, 10708673
Agent [candidate] (1.191 s) : 0, 1191280
Total [candidate] (10.714 s) : 0, 10714420
section iast
Agent [baseline] (1.184 s) : 0, 1183681
Total [baseline] (10.962 s) : 0, 10961644
Agent [candidate] (1.182 s) : 0, 1182167
Total [candidate] (10.969 s) : 0, 10969150
section profiling
Agent [baseline] (1.255 s) : 0, 1255264
Total [baseline] (10.88 s) : 0, 10880213
Agent [candidate] (1.253 s) : 0, 1253335
Total [candidate] (10.823 s) : 0, 10822753
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.055 s -
Agent appsec 1.188 s 132.737 ms (12.6%)
Agent iast 1.184 s 128.909 ms (12.2%)
Agent profiling 1.255 s 200.493 ms (19.0%)
Total tracing 10.481 s -
Total appsec 10.709 s 227.667 ms (2.2%)
Total iast 10.962 s 480.639 ms (4.6%)
Total profiling 10.88 s 399.207 ms (3.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.056 s -
Agent appsec 1.191 s 134.786 ms (12.8%)
Agent iast 1.182 s 125.672 ms (11.9%)
Agent profiling 1.253 s 196.841 ms (18.6%)
Total tracing 10.54 s -
Total appsec 10.714 s 174.584 ms (1.7%)
Total iast 10.969 s 429.314 ms (4.1%)
Total profiling 10.823 s 282.916 ms (2.7%) 
gantt
    title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~adf899d34f, baseline=1.46.0-SNAPSHOT~679f9e2ece

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (714.141 ms) : 0, 714141
BytebuddyAgent [candidate] (714.383 ms) : 0, 714383
GlobalTracer [baseline] (255.671 ms) : 0, 255671
GlobalTracer [candidate] (255.737 ms) : 0, 255737
AppSec [baseline] (55.187 ms) : 0, 55187
AppSec [candidate] (57.444 ms) : 0, 57444
Remote Config [baseline] (725.657 µs) : 0, 726
Remote Config [candidate] (722.241 µs) : 0, 722
Telemetry [baseline] (14.017 ms) : 0, 14017
Telemetry [candidate] (13.131 ms) : 0, 13131
section appsec
BytebuddyAgent [baseline] (730.187 ms) : 0, 730187
BytebuddyAgent [candidate] (732.553 ms) : 0, 732553
GlobalTracer [baseline] (252.836 ms) : 0, 252836
GlobalTracer [candidate] (253.701 ms) : 0, 253701
AppSec [baseline] (170.997 ms) : 0, 170997
AppSec [candidate] (170.719 ms) : 0, 170719
Remote Config [baseline] (664.391 µs) : 0, 664
Remote Config [candidate] (668.617 µs) : 0, 669
Telemetry [baseline] (8.19 ms) : 0, 8190
Telemetry [candidate] (8.559 ms) : 0, 8559
IAST [baseline] (19.364 ms) : 0, 19364
IAST [candidate] (20.051 ms) : 0, 20051
section iast
BytebuddyAgent [baseline] (832.555 ms) : 0, 832555
BytebuddyAgent [candidate] (831.558 ms) : 0, 831558
GlobalTracer [baseline] (246.792 ms) : 0, 246792
GlobalTracer [candidate] (246.573 ms) : 0, 246573
AppSec [baseline] (58.123 ms) : 0, 58123
AppSec [candidate] (58.007 ms) : 0, 58007
Remote Config [baseline] (668.203 µs) : 0, 668
Remote Config [candidate] (678.065 µs) : 0, 678
Telemetry [baseline] (8.821 ms) : 0, 8821
Telemetry [candidate] (8.772 ms) : 0, 8772
IAST [baseline] (21.761 ms) : 0, 21761
IAST [candidate] (21.517 ms) : 0, 21517
section profiling
ProfilingAgent [baseline] (95.805 ms) : 0, 95805
ProfilingAgent [candidate] (94.782 ms) : 0, 94782
BytebuddyAgent [baseline] (703.222 ms) : 0, 703222
BytebuddyAgent [candidate] (703.496 ms) : 0, 703496
GlobalTracer [baseline] (350.043 ms) : 0, 350043
GlobalTracer [candidate] (349.186 ms) : 0, 349186
AppSec [baseline] (54.701 ms) : 0, 54701
AppSec [candidate] (54.311 ms) : 0, 54311
Remote Config [baseline] (663.478 µs) : 0, 663
Remote Config [candidate] (676.964 µs) : 0, 677
Telemetry [baseline] (8.85 ms) : 0, 8850
Telemetry [candidate] (8.905 ms) : 0, 8905
Profiling [baseline] (95.829 ms) : 0, 95829
Profiling [candidate] (94.807 ms) : 0, 94807
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-01-16T15:32:10 2025-01-16T15:39:14
git_branch master andrea.marziali/test-http-parallel
git_commit_date 1737040366 1737041004
git_commit_sha 679f9e2 adf899d
release_version 1.46.0-SNAPSHOT~679f9e2ece 1.46.0-SNAPSHOT~adf899d34f
start_time 2025-01-16T15:31:56 2025-01-16T15:39:00
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1737042312 1737042312
ci_job_id 769163457 769163457
ci_pipeline_id 53197386 53197386
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~adf899d34f, baseline=1.46.0-SNAPSHOT~679f9e2ece
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.354 ms) : 1333, 1374
.   : milestone, 1354,
appsec (1.754 ms) : 1730, 1777
.   : milestone, 1754,
appsec_no_iast (1.759 ms) : 1734, 1784
.   : milestone, 1759,
iast (1.53 ms) : 1506, 1554
.   : milestone, 1530,
profiling (1.527 ms) : 1503, 1551
.   : milestone, 1527,
tracing (1.483 ms) : 1458, 1508
.   : milestone, 1483,
section candidate
no_agent (1.356 ms) : 1336, 1376
.   : milestone, 1356,
appsec (1.738 ms) : 1714, 1762
.   : milestone, 1738,
appsec_no_iast (1.768 ms) : 1745, 1790
.   : milestone, 1768,
iast (1.541 ms) : 1516, 1565
.   : milestone, 1541,
profiling (1.508 ms) : 1484, 1532
.   : milestone, 1508,
tracing (1.471 ms) : 1446, 1496
.   : milestone, 1471,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.354 ms [1.333 ms, 1.374 ms] -
appsec 1.754 ms [1.73 ms, 1.777 ms] 400.191 µs (29.6%)
appsec_no_iast 1.759 ms [1.734 ms, 1.784 ms] 405.683 µs (30.0%)
iast 1.53 ms [1.506 ms, 1.554 ms] 176.3 µs (13.0%)
profiling 1.527 ms [1.503 ms, 1.551 ms] 173.517 µs (12.8%)
tracing 1.483 ms [1.458 ms, 1.508 ms] 129.365 µs (9.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.356 ms [1.336 ms, 1.376 ms] -
appsec 1.738 ms [1.714 ms, 1.762 ms] 382.169 µs (28.2%)
appsec_no_iast 1.768 ms [1.745 ms, 1.79 ms] 411.813 µs (30.4%)
iast 1.541 ms [1.516 ms, 1.565 ms] 184.877 µs (13.6%)
profiling 1.508 ms [1.484 ms, 1.532 ms] 152.051 µs (11.2%)
tracing 1.471 ms [1.446 ms, 1.496 ms] 115.308 µs (8.5%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~adf899d34f, baseline=1.46.0-SNAPSHOT~679f9e2ece
    dateFormat X
    axisFormat %s
section baseline
no_agent (379.999 µs) : 358, 402
.   : milestone, 380,
iast (509.568 µs) : 488, 532
.   : milestone, 510,
iast_FULL (741.821 µs) : 719, 764
.   : milestone, 742,
iast_GLOBAL (552.072 µs) : 530, 574
.   : milestone, 552,
iast_HARDCODED_SECRET_DISABLED (506.574 µs) : 485, 528
.   : milestone, 507,
iast_INACTIVE (459.586 µs) : 438, 481
.   : milestone, 460,
iast_TELEMETRY_OFF (491.462 µs) : 470, 513
.   : milestone, 491,
tracing (457.431 µs) : 436, 478
.   : milestone, 457,
section candidate
no_agent (373.616 µs) : 354, 394
.   : milestone, 374,
iast (506.387 µs) : 485, 528
.   : milestone, 506,
iast_FULL (746.707 µs) : 725, 769
.   : milestone, 747,
iast_GLOBAL (558.226 µs) : 535, 581
.   : milestone, 558,
iast_HARDCODED_SECRET_DISABLED (503.636 µs) : 482, 525
.   : milestone, 504,
iast_INACTIVE (461.445 µs) : 440, 483
.   : milestone, 461,
iast_TELEMETRY_OFF (495.163 µs) : 473, 517
.   : milestone, 495,
tracing (451.571 µs) : 431, 472
.   : milestone, 452,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 379.999 µs [358.216 µs, 401.782 µs] -
iast 509.568 µs [487.581 µs, 531.555 µs] 129.569 µs (34.1%)
iast_FULL 741.821 µs [719.422 µs, 764.22 µs] 361.822 µs (95.2%)
iast_GLOBAL 552.072 µs [529.729 µs, 574.415 µs] 172.073 µs (45.3%)
iast_HARDCODED_SECRET_DISABLED 506.574 µs [484.86 µs, 528.289 µs] 126.575 µs (33.3%)
iast_INACTIVE 459.586 µs [438.158 µs, 481.014 µs] 79.587 µs (20.9%)
iast_TELEMETRY_OFF 491.462 µs [469.928 µs, 512.996 µs] 111.463 µs (29.3%)
tracing 457.431 µs [436.442 µs, 478.419 µs] 77.431 µs (20.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 373.616 µs [353.625 µs, 393.607 µs] -
iast 506.387 µs [484.507 µs, 528.267 µs] 132.771 µs (35.5%)
iast_FULL 746.707 µs [724.65 µs, 768.764 µs] 373.091 µs (99.9%)
iast_GLOBAL 558.226 µs [535.197 µs, 581.255 µs] 184.61 µs (49.4%)
iast_HARDCODED_SECRET_DISABLED 503.636 µs [482.234 µs, 525.037 µs] 130.019 µs (34.8%)
iast_INACTIVE 461.445 µs [439.668 µs, 483.223 µs] 87.829 µs (23.5%)
iast_TELEMETRY_OFF 495.163 µs [473.044 µs, 517.282 µs] 121.547 µs (32.5%)
tracing 451.571 µs [430.799 µs, 472.343 µs] 77.955 µs (20.9%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/test-http-parallel
git_commit_date 1737040366 1737041004
git_commit_sha 679f9e2 adf899d
release_version 1.46.0-SNAPSHOT~679f9e2ece 1.46.0-SNAPSHOT~adf899d34f
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1737043018 1737043018
ci_job_id 769163459 769163459
ci_pipeline_id 53197386 53197386
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~adf899d34f, baseline=1.46.0-SNAPSHOT~679f9e2ece
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.476 ms) : 1464, 1487
.   : milestone, 1476,
appsec (2.356 ms) : 2313, 2398
.   : milestone, 2356,
iast (2.114 ms) : 2060, 2169
.   : milestone, 2114,
iast_GLOBAL (2.162 ms) : 2106, 2217
.   : milestone, 2162,
profiling (1.962 ms) : 1919, 2005
.   : milestone, 1962,
tracing (1.955 ms) : 1913, 1997
.   : milestone, 1955,
section candidate
no_agent (1.475 ms) : 1464, 1487
.   : milestone, 1475,
appsec (2.372 ms) : 2329, 2415
.   : milestone, 2372,
iast (2.12 ms) : 2065, 2174
.   : milestone, 2120,
iast_GLOBAL (2.154 ms) : 2099, 2208
.   : milestone, 2154,
profiling (1.977 ms) : 1933, 2021
.   : milestone, 1977,
tracing (1.945 ms) : 1904, 1987
.   : milestone, 1945,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.476 ms [1.464 ms, 1.487 ms] -
appsec 2.356 ms [2.313 ms, 2.398 ms] 879.569 µs (59.6%)
iast 2.114 ms [2.06 ms, 2.169 ms] 638.429 µs (43.3%)
iast_GLOBAL 2.162 ms [2.106 ms, 2.217 ms] 685.644 µs (46.5%)
profiling 1.962 ms [1.919 ms, 2.005 ms] 485.826 µs (32.9%)
tracing 1.955 ms [1.913 ms, 1.997 ms] 478.846 µs (32.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.475 ms [1.464 ms, 1.487 ms] -
appsec 2.372 ms [2.329 ms, 2.415 ms] 896.268 µs (60.7%)
iast 2.12 ms [2.065 ms, 2.174 ms] 644.314 µs (43.7%)
iast_GLOBAL 2.154 ms [2.099 ms, 2.208 ms] 678.082 µs (46.0%)
profiling 1.977 ms [1.933 ms, 2.021 ms] 501.742 µs (34.0%)
tracing 1.945 ms [1.904 ms, 1.987 ms] 470.018 µs (31.9%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~adf899d34f, baseline=1.46.0-SNAPSHOT~679f9e2ece
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.022 s) : 15022000, 15022000
.   : milestone, 15022000,
appsec (15.201 s) : 15201000, 15201000
.   : milestone, 15201000,
iast (18.748 s) : 18748000, 18748000
.   : milestone, 18748000,
iast_GLOBAL (18.091 s) : 18091000, 18091000
.   : milestone, 18091000,
profiling (15.727 s) : 15727000, 15727000
.   : milestone, 15727000,
tracing (15.001 s) : 15001000, 15001000
.   : milestone, 15001000,
section candidate
no_agent (14.627 s) : 14627000, 14627000
.   : milestone, 14627000,
appsec (14.821 s) : 14821000, 14821000
.   : milestone, 14821000,
iast (18.561 s) : 18561000, 18561000
.   : milestone, 18561000,
iast_GLOBAL (18.111 s) : 18111000, 18111000
.   : milestone, 18111000,
profiling (14.981 s) : 14981000, 14981000
.   : milestone, 14981000,
tracing (15.138 s) : 15138000, 15138000
.   : milestone, 15138000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.022 s [15.022 s, 15.022 s] -
appsec 15.201 s [15.201 s, 15.201 s] 179.0 ms (1.2%)
iast 18.748 s [18.748 s, 18.748 s] 3.726 s (24.8%)
iast_GLOBAL 18.091 s [18.091 s, 18.091 s] 3.069 s (20.4%)
profiling 15.727 s [15.727 s, 15.727 s] 705.0 ms (4.7%)
tracing 15.001 s [15.001 s, 15.001 s] -21.0 ms (-0.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.627 s [14.627 s, 14.627 s] -
appsec 14.821 s [14.821 s, 14.821 s] 194.0 ms (1.3%)
iast 18.561 s [18.561 s, 18.561 s] 3.934 s (26.9%)
iast_GLOBAL 18.111 s [18.111 s, 18.111 s] 3.484 s (23.8%)
profiling 14.981 s [14.981 s, 14.981 s] 354.0 ms (2.4%)
tracing 15.138 s [15.138 s, 15.138 s] 511.0 ms (3.5%)

smola
smola approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@smola smola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Hopefully it doesn't lead to increased flakiness, worth a try.

@amarziali amarziali requested a review from a team as a code owner January 16, 2025 14:44
@amarziali amarziali force-pushed the andrea.marziali/test-http-parallel branch from 92e8ad6 to adf899d Compare January 16, 2025 15:23
@amarziali amarziali enabled auto-merge (squash) January 16, 2025 15:34
@amarziali amarziali added comp: api Tracer public API and removed comp: api Tracer public API labels Jan 16, 2025
@amarziali amarziali merged commit f1d359b into master Jan 16, 2025
173 of 174 checks passed
@amarziali amarziali deleted the andrea.marziali/test-http-parallel branch January 16, 2025 16:17
@github-actions github-actions bot added this to the 1.46.0 milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcculls mcculls mcculls approved these changes

@smola smola smola approved these changes

Assignees
No one assigned
Labels
comp: testing Testing type: enhancement
Projects
None yet
Milestone
1.46.0
Development

Successfully merging this pull request may close these issues.
3 participants
@amarziali @smola @mcculls