-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple test JDK and gradle JDK in karate latestDepTest #8234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smola
added
comp: testing
Testing
tag: no release notes
Changes to exclude from release notes
comp: ci visibility
Continuous Integration Visibility
labels
Jan 16, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 6 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~4e03bf9bad, baseline=1.46.0-SNAPSHOT~f1d359b93f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1055625
Total [baseline] (10.453 s) : 0, 10452932
Agent [candidate] (1.056 s) : 0, 1056491
Total [candidate] (10.5 s) : 0, 10500152
section appsec
Agent [baseline] (1.189 s) : 0, 1188588
Total [baseline] (10.687 s) : 0, 10686689
Agent [candidate] (1.189 s) : 0, 1189393
Total [candidate] (10.733 s) : 0, 10732533
section iast
Agent [baseline] (1.184 s) : 0, 1183608
Total [baseline] (10.982 s) : 0, 10982487
Agent [candidate] (1.191 s) : 0, 1190992
Total [candidate] (10.998 s) : 0, 10998303
section profiling
Agent [baseline] (1.253 s) : 0, 1252593
Total [baseline] (10.731 s) : 0, 10730610
Agent [candidate] (1.264 s) : 0, 1263606
Total [candidate] (10.889 s) : 0, 10889021
gantt
title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~4e03bf9bad, baseline=1.46.0-SNAPSHOT~f1d359b93f
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (714.156 ms) : 0, 714156
BytebuddyAgent [candidate] (716.027 ms) : 0, 716027
GlobalTracer [baseline] (256.011 ms) : 0, 256011
GlobalTracer [candidate] (257.585 ms) : 0, 257585
AppSec [baseline] (56.125 ms) : 0, 56125
AppSec [candidate] (56.194 ms) : 0, 56194
Remote Config [baseline] (730.143 µs) : 0, 730
Remote Config [candidate] (725.85 µs) : 0, 726
Telemetry [baseline] (13.658 ms) : 0, 13658
Telemetry [candidate] (10.918 ms) : 0, 10918
section appsec
BytebuddyAgent [baseline] (730.957 ms) : 0, 730957
BytebuddyAgent [candidate] (730.997 ms) : 0, 730997
GlobalTracer [baseline] (252.883 ms) : 0, 252883
GlobalTracer [candidate] (253.18 ms) : 0, 253180
AppSec [baseline] (170.912 ms) : 0, 170912
AppSec [candidate] (170.132 ms) : 0, 170132
Remote Config [baseline] (662.236 µs) : 0, 662
Remote Config [candidate] (669.525 µs) : 0, 670
Telemetry [baseline] (8.229 ms) : 0, 8229
Telemetry [candidate] (8.965 ms) : 0, 8965
IAST [baseline] (20.023 ms) : 0, 20023
IAST [candidate] (20.95 ms) : 0, 20950
section iast
BytebuddyAgent [baseline] (832.135 ms) : 0, 832135
BytebuddyAgent [candidate] (838.213 ms) : 0, 838213
GlobalTracer [baseline] (247.095 ms) : 0, 247095
GlobalTracer [candidate] (248.419 ms) : 0, 248419
AppSec [baseline] (58.147 ms) : 0, 58147
AppSec [candidate] (58.126 ms) : 0, 58126
Remote Config [baseline] (687.123 µs) : 0, 687
Remote Config [candidate] (670.015 µs) : 0, 670
Telemetry [baseline] (8.929 ms) : 0, 8929
Telemetry [candidate] (8.786 ms) : 0, 8786
IAST [baseline] (21.551 ms) : 0, 21551
IAST [candidate] (21.588 ms) : 0, 21588
section profiling
BytebuddyAgent [baseline] (702.172 ms) : 0, 702172
BytebuddyAgent [candidate] (705.382 ms) : 0, 705382
GlobalTracer [baseline] (348.402 ms) : 0, 348402
GlobalTracer [candidate] (354.688 ms) : 0, 354688
AppSec [baseline] (54.885 ms) : 0, 54885
AppSec [candidate] (54.637 ms) : 0, 54637
Remote Config [baseline] (685.619 µs) : 0, 686
Remote Config [candidate] (684.843 µs) : 0, 685
Telemetry [baseline] (8.828 ms) : 0, 8828
Telemetry [candidate] (9.056 ms) : 0, 9056
ProfilingAgent [baseline] (95.708 ms) : 0, 95708
ProfilingAgent [candidate] (97.181 ms) : 0, 97181
Profiling [baseline] (95.737 ms) : 0, 95737
Profiling [candidate] (97.211 ms) : 0, 97211
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~4e03bf9bad, baseline=1.46.0-SNAPSHOT~f1d359b93f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1053789
Total [baseline] (8.621 s) : 0, 8621286
Agent [candidate] (1.056 s) : 0, 1055606
Total [candidate] (8.613 s) : 0, 8612770
section iast
Agent [baseline] (1.2 s) : 0, 1199846
Total [baseline] (9.277 s) : 0, 9276904
Agent [candidate] (1.185 s) : 0, 1185349
Total [candidate] (9.202 s) : 0, 9202133
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.191 s) : 0, 1190831
Total [baseline] (9.205 s) : 0, 9205074
Agent [candidate] (1.185 s) : 0, 1184650
Total [candidate] (9.151 s) : 0, 9151201
section iast_TELEMETRY_OFF
Agent [baseline] (1.175 s) : 0, 1175427
Total [baseline] (9.22 s) : 0, 9220461
Agent [candidate] (1.178 s) : 0, 1178233
Total [candidate] (9.193 s) : 0, 9193269
gantt
title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~4e03bf9bad, baseline=1.46.0-SNAPSHOT~f1d359b93f
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (714.304 ms) : 0, 714304
BytebuddyAgent [candidate] (713.409 ms) : 0, 713409
GlobalTracer [baseline] (255.652 ms) : 0, 255652
GlobalTracer [candidate] (256.144 ms) : 0, 256144
AppSec [baseline] (55.968 ms) : 0, 55968
AppSec [candidate] (55.994 ms) : 0, 55994
Remote Config [baseline] (719.939 µs) : 0, 720
Remote Config [candidate] (738.312 µs) : 0, 738
Telemetry [baseline] (12.131 ms) : 0, 12131
Telemetry [candidate] (14.238 ms) : 0, 14238
section iast
BytebuddyAgent [baseline] (844.204 ms) : 0, 844204
BytebuddyAgent [candidate] (834.036 ms) : 0, 834036
GlobalTracer [baseline] (249.861 ms) : 0, 249861
GlobalTracer [candidate] (247.229 ms) : 0, 247229
AppSec [baseline] (58.731 ms) : 0, 58731
AppSec [candidate] (58.059 ms) : 0, 58059
Remote Config [baseline] (707.766 µs) : 0, 708
Remote Config [candidate] (667.023 µs) : 0, 667
Telemetry [baseline] (9.095 ms) : 0, 9095
Telemetry [candidate] (8.809 ms) : 0, 8809
IAST [baseline] (22.132 ms) : 0, 22132
IAST [candidate] (21.528 ms) : 0, 21528
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (837.777 ms) : 0, 837777
BytebuddyAgent [candidate] (832.531 ms) : 0, 832531
GlobalTracer [baseline] (248.571 ms) : 0, 248571
GlobalTracer [candidate] (247.783 ms) : 0, 247783
AppSec [baseline] (58.352 ms) : 0, 58352
AppSec [candidate] (58.278 ms) : 0, 58278
Remote Config [baseline] (671.888 µs) : 0, 672
Remote Config [candidate] (670.409 µs) : 0, 670
Telemetry [baseline] (8.873 ms) : 0, 8873
Telemetry [candidate] (8.764 ms) : 0, 8764
IAST [baseline] (21.459 ms) : 0, 21459
IAST [candidate] (21.63 ms) : 0, 21630
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (825.987 ms) : 0, 825987
BytebuddyAgent [candidate] (828.269 ms) : 0, 828269
GlobalTracer [baseline] (246.301 ms) : 0, 246301
GlobalTracer [candidate] (247.015 ms) : 0, 247015
AppSec [baseline] (57.895 ms) : 0, 57895
AppSec [candidate] (57.792 ms) : 0, 57792
Remote Config [baseline] (679.232 µs) : 0, 679
Remote Config [candidate] (666.225 µs) : 0, 666
Telemetry [baseline] (8.673 ms) : 0, 8673
Telemetry [candidate] (8.659 ms) : 0, 8659
IAST [baseline] (21.032 ms) : 0, 21032
IAST [candidate] (20.798 ms) : 0, 20798
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~4e03bf9bad, baseline=1.46.0-SNAPSHOT~f1d359b93f
dateFormat X
axisFormat %s
section baseline
no_agent (1.355 ms) : 1334, 1375
. : milestone, 1355,
appsec (1.775 ms) : 1752, 1798
. : milestone, 1775,
appsec_no_iast (1.754 ms) : 1731, 1777
. : milestone, 1754,
iast (1.495 ms) : 1470, 1520
. : milestone, 1495,
profiling (1.518 ms) : 1494, 1543
. : milestone, 1518,
tracing (1.485 ms) : 1460, 1510
. : milestone, 1485,
section candidate
no_agent (1.368 ms) : 1348, 1387
. : milestone, 1368,
appsec (1.761 ms) : 1737, 1786
. : milestone, 1761,
appsec_no_iast (1.756 ms) : 1734, 1779
. : milestone, 1756,
iast (1.501 ms) : 1476, 1525
. : milestone, 1501,
profiling (1.577 ms) : 1542, 1612
. : milestone, 1577,
tracing (1.481 ms) : 1456, 1506
. : milestone, 1481,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~4e03bf9bad, baseline=1.46.0-SNAPSHOT~f1d359b93f
dateFormat X
axisFormat %s
section baseline
no_agent (378.032 µs) : 359, 398
. : milestone, 378,
iast (512.857 µs) : 490, 535
. : milestone, 513,
iast_FULL (741.421 µs) : 719, 763
. : milestone, 741,
iast_GLOBAL (552.086 µs) : 531, 573
. : milestone, 552,
iast_HARDCODED_SECRET_DISABLED (508.113 µs) : 486, 530
. : milestone, 508,
iast_INACTIVE (460.288 µs) : 439, 482
. : milestone, 460,
iast_TELEMETRY_OFF (494.973 µs) : 473, 517
. : milestone, 495,
tracing (460.386 µs) : 439, 481
. : milestone, 460,
section candidate
no_agent (377.626 µs) : 358, 397
. : milestone, 378,
iast (515.763 µs) : 493, 538
. : milestone, 516,
iast_FULL (749.505 µs) : 728, 771
. : milestone, 750,
iast_GLOBAL (553.636 µs) : 532, 575
. : milestone, 554,
iast_HARDCODED_SECRET_DISABLED (511.864 µs) : 490, 534
. : milestone, 512,
iast_INACTIVE (452.667 µs) : 432, 474
. : milestone, 453,
iast_TELEMETRY_OFF (498.379 µs) : 477, 520
. : milestone, 498,
tracing (449.464 µs) : 429, 470
. : milestone, 449,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~4e03bf9bad, baseline=1.46.0-SNAPSHOT~f1d359b93f
dateFormat X
axisFormat %s
section baseline
no_agent (15.242 s) : 15242000, 15242000
. : milestone, 15242000,
appsec (15.079 s) : 15079000, 15079000
. : milestone, 15079000,
iast (18.999 s) : 18999000, 18999000
. : milestone, 18999000,
iast_GLOBAL (17.736 s) : 17736000, 17736000
. : milestone, 17736000,
profiling (15.79 s) : 15790000, 15790000
. : milestone, 15790000,
tracing (14.985 s) : 14985000, 14985000
. : milestone, 14985000,
section candidate
no_agent (15.075 s) : 15075000, 15075000
. : milestone, 15075000,
appsec (15.171 s) : 15171000, 15171000
. : milestone, 15171000,
iast (18.894 s) : 18894000, 18894000
. : milestone, 18894000,
iast_GLOBAL (18.008 s) : 18008000, 18008000
. : milestone, 18008000,
profiling (15.175 s) : 15175000, 15175000
. : milestone, 15175000,
tracing (15.281 s) : 15281000, 15281000
. : milestone, 15281000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~4e03bf9bad, baseline=1.46.0-SNAPSHOT~f1d359b93f
dateFormat X
axisFormat %s
section baseline
no_agent (1.464 ms) : 1453, 1476
. : milestone, 1464,
appsec (2.352 ms) : 2309, 2395
. : milestone, 2352,
iast (2.093 ms) : 2039, 2147
. : milestone, 2093,
iast_GLOBAL (2.136 ms) : 2082, 2191
. : milestone, 2136,
profiling (1.964 ms) : 1920, 2008
. : milestone, 1964,
tracing (1.923 ms) : 1882, 1964
. : milestone, 1923,
section candidate
no_agent (1.464 ms) : 1453, 1475
. : milestone, 1464,
appsec (2.345 ms) : 2303, 2388
. : milestone, 2345,
iast (2.095 ms) : 2041, 2150
. : milestone, 2095,
iast_GLOBAL (2.138 ms) : 2083, 2192
. : milestone, 2138,
profiling (1.945 ms) : 1902, 1988
. : milestone, 1945,
tracing (1.924 ms) : 1883, 1965
. : milestone, 1924,
|
PerfectSlayer
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: ci visibility
Continuous Integration Visibility
comp: testing
Testing
tag: no release notes
Changes to exclude from release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Avoid using the version of the JDK used to run gradle (always 8 in CI) to select karate version to test. Before this PR,
test
tested karate 1.0.0, andlatestDepTest
always tested karate 1.3.1 and never 1.4.0+ (in CI). Now:test
-> 1.0.0karate131Test
-> 1.3.1latestDepTest
-> 1.4.0+Motivation
Part of fixes to decouple the JDK used for compile/test from the one used by gradle.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]