Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add failing Kotlin coroutine tests #8238

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Add failing Kotlin coroutine tests #8238

merged 1 commit into from
Jan 17, 2025
+124 −0

Conversation

PerfectSlayer
Copy link
Contributor

@PerfectSlayer PerfectSlayer commented Jan 17, 2025 •
edited by jira bot
Loading

What Does This Do

This PR adds uses case from #7215 to the test suite.

Motivation

The current context tracking improvements might help with tackling such issues.
Adding them to the test suite to check our improvements against the failing cases.

Additional Notes

Contributor Checklist

Jira ticket: LANGPLAT-40

@PerfectSlayer PerfectSlayer added type: bug inst: kotlin Kotlin instrumentation labels Jan 17, 2025
@PerfectSlayer PerfectSlayer requested a review from a team as a code owner January 17, 2025 10:19
@pr-commenter
Copy link

pr-commenter bot commented Jan 17, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/context-tracking-kotlin
git_commit_date 1737044223 1737108954
git_commit_sha f1d359b 1431734
release_version 1.46.0-SNAPSHOT~f1d359b93f 1.46.0-SNAPSHOT~1431734d98
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1737111545 1737111545
ci_job_id 770413751 770413751
ci_pipeline_id 53290141 53290141
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~1431734d98, baseline=1.46.0-SNAPSHOT~f1d359b93f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1059791
Total [baseline] (8.661 s) : 0, 8661039
Agent [candidate] (1.057 s) : 0, 1056802
Total [candidate] (8.622 s) : 0, 8621846
section iast
Agent [baseline] (1.181 s) : 0, 1181013
Total [baseline] (9.18 s) : 0, 9180457
Agent [candidate] (1.184 s) : 0, 1184317
Total [candidate] (9.198 s) : 0, 9198485
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.181 s) : 0, 1180992
Total [baseline] (9.2 s) : 0, 9199555
Agent [candidate] (1.196 s) : 0, 1196498
Total [candidate] (9.323 s) : 0, 9322691
section iast_TELEMETRY_OFF
Agent [baseline] (1.179 s) : 0, 1178568
Total [baseline] (9.265 s) : 0, 9265016
Agent [candidate] (1.189 s) : 0, 1188777
Total [candidate] (9.236 s) : 0, 9235505
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.06 s -
Agent iast 1.181 s 121.223 ms (11.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.181 s 121.202 ms (11.4%)
Agent iast_TELEMETRY_OFF 1.179 s 118.777 ms (11.2%)
Total tracing 8.661 s -
Total iast 9.18 s 519.419 ms (6.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.2 s 538.516 ms (6.2%)
Total iast_TELEMETRY_OFF 9.265 s 603.977 ms (7.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.057 s -
Agent iast 1.184 s 127.515 ms (12.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.196 s 139.696 ms (13.2%)
Agent iast_TELEMETRY_OFF 1.189 s 131.975 ms (12.5%)
Total tracing 8.622 s -
Total iast 9.198 s 576.639 ms (6.7%)
Total iast_HARDCODED_SECRET_DISABLED 9.323 s 700.845 ms (8.1%)
Total iast_TELEMETRY_OFF 9.236 s 613.659 ms (7.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~1431734d98, baseline=1.46.0-SNAPSHOT~f1d359b93f

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (715.721 ms) : 0, 715721
BytebuddyAgent [candidate] (714.202 ms) : 0, 714202
GlobalTracer [baseline] (257.696 ms) : 0, 257696
GlobalTracer [candidate] (255.743 ms) : 0, 255743
AppSec [baseline] (57.047 ms) : 0, 57047
AppSec [candidate] (55.324 ms) : 0, 55324
Remote Config [baseline] (731.038 µs) : 0, 731
Remote Config [candidate] (728.314 µs) : 0, 728
Telemetry [baseline] (13.621 ms) : 0, 13621
Telemetry [candidate] (15.843 ms) : 0, 15843
section iast
BytebuddyAgent [baseline] (830.846 ms) : 0, 830846
BytebuddyAgent [candidate] (833.16 ms) : 0, 833160
GlobalTracer [baseline] (246.061 ms) : 0, 246061
GlobalTracer [candidate] (247.046 ms) : 0, 247046
AppSec [baseline] (57.98 ms) : 0, 57980
AppSec [candidate] (58.097 ms) : 0, 58097
Remote Config [baseline] (655.019 µs) : 0, 655
Remote Config [candidate] (688.451 µs) : 0, 688
Telemetry [baseline] (8.767 ms) : 0, 8767
Telemetry [candidate] (8.728 ms) : 0, 8728
IAST [baseline] (21.67 ms) : 0, 21670
IAST [candidate] (21.599 ms) : 0, 21599
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (830.455 ms) : 0, 830455
BytebuddyAgent [candidate] (842.883 ms) : 0, 842883
GlobalTracer [baseline] (246.715 ms) : 0, 246715
GlobalTracer [candidate] (248.225 ms) : 0, 248225
AppSec [baseline] (57.906 ms) : 0, 57906
AppSec [candidate] (58.648 ms) : 0, 58648
Remote Config [baseline] (658.939 µs) : 0, 659
Remote Config [candidate] (687.989 µs) : 0, 688
Telemetry [baseline] (8.862 ms) : 0, 8862
Telemetry [candidate] (8.933 ms) : 0, 8933
IAST [baseline] (21.442 ms) : 0, 21442
IAST [candidate] (21.975 ms) : 0, 21975
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (828.944 ms) : 0, 828944
BytebuddyAgent [candidate] (836.242 ms) : 0, 836242
GlobalTracer [baseline] (246.643 ms) : 0, 246643
GlobalTracer [candidate] (248.693 ms) : 0, 248693
AppSec [baseline] (57.838 ms) : 0, 57838
AppSec [candidate] (58.172 ms) : 0, 58172
Remote Config [baseline] (675.109 µs) : 0, 675
Remote Config [candidate] (673.57 µs) : 0, 674
Telemetry [baseline] (8.665 ms) : 0, 8665
Telemetry [candidate] (8.761 ms) : 0, 8761
IAST [baseline] (20.832 ms) : 0, 20832
IAST [candidate] (21.098 ms) : 0, 21098
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~1431734d98, baseline=1.46.0-SNAPSHOT~f1d359b93f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1060662
Total [baseline] (10.473 s) : 0, 10472531
Agent [candidate] (1.056 s) : 0, 1055770
Total [candidate] (10.611 s) : 0, 10610909
section appsec
Agent [baseline] (1.19 s) : 0, 1189730
Total [baseline] (10.755 s) : 0, 10754964
Agent [candidate] (1.194 s) : 0, 1193589
Total [candidate] (10.735 s) : 0, 10734608
section iast
Agent [baseline] (1.201 s) : 0, 1200616
Total [baseline] (11.1 s) : 0, 11099550
Agent [candidate] (1.202 s) : 0, 1202036
Total [candidate] (11.174 s) : 0, 11173600
section profiling
Agent [baseline] (1.263 s) : 0, 1262602
Total [baseline] (10.826 s) : 0, 10825626
Agent [candidate] (1.256 s) : 0, 1255596
Total [candidate] (10.822 s) : 0, 10822156
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.061 s -
Agent appsec 1.19 s 129.069 ms (12.2%)
Agent iast 1.201 s 139.954 ms (13.2%)
Agent profiling 1.263 s 201.941 ms (19.0%)
Total tracing 10.473 s -
Total appsec 10.755 s 282.433 ms (2.7%)
Total iast 11.1 s 627.019 ms (6.0%)
Total profiling 10.826 s 353.095 ms (3.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.056 s -
Agent appsec 1.194 s 137.82 ms (13.1%)
Agent iast 1.202 s 146.266 ms (13.9%)
Agent profiling 1.256 s 199.826 ms (18.9%)
Total tracing 10.611 s -
Total appsec 10.735 s 123.699 ms (1.2%)
Total iast 11.174 s 562.691 ms (5.3%)
Total profiling 10.822 s 211.247 ms (2.0%) 
gantt
    title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~1431734d98, baseline=1.46.0-SNAPSHOT~f1d359b93f

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.847 ms) : 0, 717847
BytebuddyAgent [candidate] (714.455 ms) : 0, 714455
GlobalTracer [baseline] (256.771 ms) : 0, 256771
GlobalTracer [candidate] (255.919 ms) : 0, 255919
AppSec [baseline] (56.386 ms) : 0, 56386
AppSec [candidate] (55.982 ms) : 0, 55982
Remote Config [baseline] (728.111 µs) : 0, 728
Remote Config [candidate] (717.724 µs) : 0, 718
Telemetry [baseline] (13.836 ms) : 0, 13836
Telemetry [candidate] (13.592 ms) : 0, 13592
section appsec
BytebuddyAgent [baseline] (731.732 ms) : 0, 731732
BytebuddyAgent [candidate] (734.428 ms) : 0, 734428
GlobalTracer [baseline] (253.638 ms) : 0, 253638
GlobalTracer [candidate] (254.286 ms) : 0, 254286
AppSec [baseline] (170.436 ms) : 0, 170436
AppSec [candidate] (171.17 ms) : 0, 171170
Remote Config [baseline] (661.234 µs) : 0, 661
Remote Config [candidate] (675.033 µs) : 0, 675
Telemetry [baseline] (8.603 ms) : 0, 8603
Telemetry [candidate] (8.233 ms) : 0, 8233
IAST [baseline] (19.43 ms) : 0, 19430
IAST [candidate] (19.583 ms) : 0, 19583
section iast
BytebuddyAgent [baseline] (846.085 ms) : 0, 846085
BytebuddyAgent [candidate] (846.354 ms) : 0, 846354
GlobalTracer [baseline] (249.814 ms) : 0, 249814
GlobalTracer [candidate] (249.84 ms) : 0, 249840
AppSec [baseline] (58.24 ms) : 0, 58240
AppSec [candidate] (58.741 ms) : 0, 58741
Remote Config [baseline] (675.885 µs) : 0, 676
Remote Config [candidate] (690.141 µs) : 0, 690
Telemetry [baseline] (8.908 ms) : 0, 8908
Telemetry [candidate] (9.093 ms) : 0, 9093
IAST [baseline] (21.637 ms) : 0, 21637
IAST [candidate] (22.149 ms) : 0, 22149
section profiling
BytebuddyAgent [baseline] (707.428 ms) : 0, 707428
BytebuddyAgent [candidate] (704.202 ms) : 0, 704202
GlobalTracer [baseline] (352.065 ms) : 0, 352065
GlobalTracer [candidate] (350.436 ms) : 0, 350436
AppSec [baseline] (55.152 ms) : 0, 55152
AppSec [candidate] (54.011 ms) : 0, 54011
Remote Config [baseline] (664.923 µs) : 0, 665
Remote Config [candidate] (657.121 µs) : 0, 657
Telemetry [baseline] (8.934 ms) : 0, 8934
Telemetry [candidate] (8.859 ms) : 0, 8859
ProfilingAgent [baseline] (96.185 ms) : 0, 96185
ProfilingAgent [candidate] (95.376 ms) : 0, 95376
Profiling [baseline] (96.209 ms) : 0, 96209
Profiling [candidate] (95.4 ms) : 0, 95400
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-01-17T10:32:01 2025-01-17T10:39:05
git_branch master bbujon/context-tracking-kotlin
git_commit_date 1737044223 1737108954
git_commit_sha f1d359b 1431734
release_version 1.46.0-SNAPSHOT~f1d359b93f 1.46.0-SNAPSHOT~1431734d98
start_time 2025-01-17T10:31:47 2025-01-17T10:38:51
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1737110702 1737110702
ci_job_id 770413752 770413752
ci_pipeline_id 53290141 53290141
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~1431734d98, baseline=1.46.0-SNAPSHOT~f1d359b93f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.379 ms) : 1360, 1399
.   : milestone, 1379,
appsec (1.759 ms) : 1735, 1783
.   : milestone, 1759,
appsec_no_iast (1.761 ms) : 1738, 1784
.   : milestone, 1761,
iast (1.518 ms) : 1493, 1543
.   : milestone, 1518,
profiling (1.502 ms) : 1479, 1525
.   : milestone, 1502,
tracing (1.49 ms) : 1466, 1515
.   : milestone, 1490,
section candidate
no_agent (1.356 ms) : 1336, 1375
.   : milestone, 1356,
appsec (1.759 ms) : 1735, 1782
.   : milestone, 1759,
appsec_no_iast (1.746 ms) : 1723, 1769
.   : milestone, 1746,
iast (1.51 ms) : 1486, 1534
.   : milestone, 1510,
profiling (1.506 ms) : 1483, 1530
.   : milestone, 1506,
tracing (1.501 ms) : 1477, 1526
.   : milestone, 1501,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.379 ms [1.36 ms, 1.399 ms] -
appsec 1.759 ms [1.735 ms, 1.783 ms] 379.94 µs (27.5%)
appsec_no_iast 1.761 ms [1.738 ms, 1.784 ms] 381.462 µs (27.7%)
iast 1.518 ms [1.493 ms, 1.543 ms] 138.727 µs (10.1%)
profiling 1.502 ms [1.479 ms, 1.525 ms] 122.815 µs (8.9%)
tracing 1.49 ms [1.466 ms, 1.515 ms] 110.911 µs (8.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.356 ms [1.336 ms, 1.375 ms] -
appsec 1.759 ms [1.735 ms, 1.782 ms] 402.569 µs (29.7%)
appsec_no_iast 1.746 ms [1.723 ms, 1.769 ms] 390.088 µs (28.8%)
iast 1.51 ms [1.486 ms, 1.534 ms] 153.772 µs (11.3%)
profiling 1.506 ms [1.483 ms, 1.53 ms] 150.391 µs (11.1%)
tracing 1.501 ms [1.477 ms, 1.526 ms] 145.426 µs (10.7%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~1431734d98, baseline=1.46.0-SNAPSHOT~f1d359b93f
    dateFormat X
    axisFormat %s
section baseline
no_agent (381.342 µs) : 361, 401
.   : milestone, 381,
iast (509.167 µs) : 487, 531
.   : milestone, 509,
iast_FULL (746.324 µs) : 725, 768
.   : milestone, 746,
iast_GLOBAL (554.678 µs) : 533, 576
.   : milestone, 555,
iast_HARDCODED_SECRET_DISABLED (508.498 µs) : 487, 530
.   : milestone, 508,
iast_INACTIVE (460.4 µs) : 439, 482
.   : milestone, 460,
iast_TELEMETRY_OFF (498.065 µs) : 476, 520
.   : milestone, 498,
tracing (448.513 µs) : 428, 469
.   : milestone, 449,
section candidate
no_agent (381.384 µs) : 362, 401
.   : milestone, 381,
iast (504.138 µs) : 482, 526
.   : milestone, 504,
iast_FULL (749.459 µs) : 728, 771
.   : milestone, 749,
iast_GLOBAL (562.582 µs) : 540, 585
.   : milestone, 563,
iast_HARDCODED_SECRET_DISABLED (503.846 µs) : 482, 525
.   : milestone, 504,
iast_INACTIVE (460.527 µs) : 439, 482
.   : milestone, 461,
iast_TELEMETRY_OFF (496.94 µs) : 475, 519
.   : milestone, 497,
tracing (449.922 µs) : 429, 470
.   : milestone, 450,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 381.342 µs [361.191 µs, 401.493 µs] -
iast 509.167 µs [487.392 µs, 530.942 µs] 127.825 µs (33.5%)
iast_FULL 746.324 µs [724.575 µs, 768.074 µs] 364.982 µs (95.7%)
iast_GLOBAL 554.678 µs [533.076 µs, 576.28 µs] 173.336 µs (45.5%)
iast_HARDCODED_SECRET_DISABLED 508.498 µs [487.023 µs, 529.973 µs] 127.156 µs (33.3%)
iast_INACTIVE 460.4 µs [438.75 µs, 482.05 µs] 79.058 µs (20.7%)
iast_TELEMETRY_OFF 498.065 µs [476.119 µs, 520.011 µs] 116.723 µs (30.6%)
tracing 448.513 µs [427.77 µs, 469.257 µs] 67.171 µs (17.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 381.384 µs [361.62 µs, 401.149 µs] -
iast 504.138 µs [482.408 µs, 525.868 µs] 122.754 µs (32.2%)
iast_FULL 749.459 µs [727.553 µs, 771.364 µs] 368.074 µs (96.5%)
iast_GLOBAL 562.582 µs [539.833 µs, 585.33 µs] 181.197 µs (47.5%)
iast_HARDCODED_SECRET_DISABLED 503.846 µs [482.351 µs, 525.342 µs] 122.462 µs (32.1%)
iast_INACTIVE 460.527 µs [438.575 µs, 482.479 µs] 79.143 µs (20.8%)
iast_TELEMETRY_OFF 496.94 µs [475.262 µs, 518.618 µs] 115.556 µs (30.3%)
tracing 449.922 µs [429.445 µs, 470.399 µs] 68.538 µs (18.0%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/context-tracking-kotlin
git_commit_date 1737044223 1737108954
git_commit_sha f1d359b 1431734
release_version 1.46.0-SNAPSHOT~f1d359b93f 1.46.0-SNAPSHOT~1431734d98
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1737111302 1737111302
ci_job_id 770413753 770413753
ci_pipeline_id 53290141 53290141
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~1431734d98, baseline=1.46.0-SNAPSHOT~f1d359b93f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.465 ms) : 1453, 1476
.   : milestone, 1465,
appsec (2.354 ms) : 2311, 2397
.   : milestone, 2354,
iast (2.095 ms) : 2041, 2150
.   : milestone, 2095,
iast_GLOBAL (2.13 ms) : 2076, 2185
.   : milestone, 2130,
profiling (1.97 ms) : 1926, 2015
.   : milestone, 1970,
tracing (1.932 ms) : 1890, 1974
.   : milestone, 1932,
section candidate
no_agent (1.462 ms) : 1450, 1473
.   : milestone, 1462,
appsec (2.33 ms) : 2288, 2373
.   : milestone, 2330,
iast (2.107 ms) : 2052, 2161
.   : milestone, 2107,
iast_GLOBAL (2.136 ms) : 2082, 2191
.   : milestone, 2136,
profiling (1.976 ms) : 1932, 2021
.   : milestone, 1976,
tracing (1.93 ms) : 1888, 1971
.   : milestone, 1930,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.465 ms [1.453 ms, 1.476 ms] -
appsec 2.354 ms [2.311 ms, 2.397 ms] 889.335 µs (60.7%)
iast 2.095 ms [2.041 ms, 2.15 ms] 630.557 µs (43.0%)
iast_GLOBAL 2.13 ms [2.076 ms, 2.185 ms] 665.248 µs (45.4%)
profiling 1.97 ms [1.926 ms, 2.015 ms] 505.58 µs (34.5%)
tracing 1.932 ms [1.89 ms, 1.974 ms] 467.145 µs (31.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.462 ms [1.45 ms, 1.473 ms] -
appsec 2.33 ms [2.288 ms, 2.373 ms] 868.641 µs (59.4%)
iast 2.107 ms [2.052 ms, 2.161 ms] 645.063 µs (44.1%)
iast_GLOBAL 2.136 ms [2.082 ms, 2.191 ms] 674.411 µs (46.1%)
profiling 1.976 ms [1.932 ms, 2.021 ms] 514.692 µs (35.2%)
tracing 1.93 ms [1.888 ms, 1.971 ms] 468.127 µs (32.0%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~1431734d98, baseline=1.46.0-SNAPSHOT~f1d359b93f
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.015 s) : 15015000, 15015000
.   : milestone, 15015000,
appsec (15.162 s) : 15162000, 15162000
.   : milestone, 15162000,
iast (18.928 s) : 18928000, 18928000
.   : milestone, 18928000,
iast_GLOBAL (18.191 s) : 18191000, 18191000
.   : milestone, 18191000,
profiling (14.989 s) : 14989000, 14989000
.   : milestone, 14989000,
tracing (15.03 s) : 15030000, 15030000
.   : milestone, 15030000,
section candidate
no_agent (14.984 s) : 14984000, 14984000
.   : milestone, 14984000,
appsec (14.998 s) : 14998000, 14998000
.   : milestone, 14998000,
iast (18.885 s) : 18885000, 18885000
.   : milestone, 18885000,
iast_GLOBAL (17.68 s) : 17680000, 17680000
.   : milestone, 17680000,
profiling (15.138 s) : 15138000, 15138000
.   : milestone, 15138000,
tracing (14.926 s) : 14926000, 14926000
.   : milestone, 14926000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.015 s [15.015 s, 15.015 s] -
appsec 15.162 s [15.162 s, 15.162 s] 147.0 ms (1.0%)
iast 18.928 s [18.928 s, 18.928 s] 3.913 s (26.1%)
iast_GLOBAL 18.191 s [18.191 s, 18.191 s] 3.176 s (21.2%)
profiling 14.989 s [14.989 s, 14.989 s] -26.0 ms (-0.2%)
tracing 15.03 s [15.03 s, 15.03 s] 15.0 ms (0.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.984 s [14.984 s, 14.984 s] -
appsec 14.998 s [14.998 s, 14.998 s] 14.0 ms (0.1%)
iast 18.885 s [18.885 s, 18.885 s] 3.901 s (26.0%)
iast_GLOBAL 17.68 s [17.68 s, 17.68 s] 2.696 s (18.0%)
profiling 15.138 s [15.138 s, 15.138 s] 154.0 ms (1.0%)
tracing 14.926 s [14.926 s, 14.926 s] -58.0 ms (-0.4%)

@PerfectSlayer PerfectSlayer requested a review from mcculls January 17, 2025 12:24
amarziali
amarziali approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@amarziali amarziali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @PerfectSlayer Should we use instead @Flaky in order to let them have executed locally but not on the CI for the moment?

@PerfectSlayer
Copy link
Contributor Author

I would leave them as disabled as it will break any local build otherwise.
We will enable them as part of later context changes I think.

@PerfectSlayer PerfectSlayer merged commit 06fade9 into master Jan 17, 2025
176 of 178 checks passed
@PerfectSlayer PerfectSlayer deleted the bbujon/context-tracking-kotlin branch January 17, 2025 13:33
@github-actions github-actions bot added this to the 1.46.0 milestone Jan 17, 2025
@ericloe-cash ericloe-cash mentioned this pull request Jan 17, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarziali amarziali amarziali approved these changes

@mcculls mcculls Awaiting requested review from mcculls

Assignees
No one assigned
Labels
inst: kotlin Kotlin instrumentation type: bug
Projects
None yet
Milestone
1.46.0
Development

Successfully merging this pull request may close these issues.
2 participants
@PerfectSlayer @amarziali