Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nodejs] Enable path_params blocking tests #1625

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

simon-id
Copy link
Member

@simon-id simon-id commented Sep 26, 2023

Motivation

Enabling path parameter blocking test (under Suspicious request blocking feat)

Changes

  • Enable these tests for Node.js express4 and express4-typescript variants. NextJS is not supported.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

APPSEC-8367

@simon-id simon-id self-assigned this Sep 26, 2023
@simon-id simon-id changed the title enable path params blocking for nodejs [node.js] Enable path_params blocking tests Sep 26, 2023
@cbeauchesne
Copy link
Collaborator

Hi @simon-id , do you still plan to work on this ?

@simon-id
Copy link
Member Author

simon-id commented Sep 5, 2024

@cbeauchesne yes :)

@CarlesDD CarlesDD self-assigned this Oct 11, 2024
@CarlesDD CarlesDD changed the title [node.js] Enable path_params blocking tests [nodejs] Enable path_params blocking tests Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants