improve aws tests #3035
improve aws tests #3035
Conversation
|
i guess it's still in progress? So I converted to draft. If no, please revert 😃 |
This is the full PR. Simply ensuring no periods and other special characters make it into the queue name |
|
All system tests ci runs within each tracer's CI has been updated to include the new AWS env variables, can we get this merged? |
tests/integrations/utils.py
Outdated
| @@ -154,6 +155,22 @@ def get_span_from_agent(weblog_request): | |||
| raise ValueError(f"Span is not found for {weblog_request.request.url}") | |||
|
|
|||
|
|
|||
| # set AWS credentials for runner | |||
| os.environ["AWS_ACCESS_KEY_ID"] = os.environ.get("SYSTEM_TESTS_AWS_ACCESS_KEY_ID", "") | |||
There was a problem hiding this comment.
Is there a way to pass those value to the sdk directly ? If it's possible to not hack to much os.environ, it's better.
There was a problem hiding this comment.
Changed this code, the code now just instantiates an AWS client session, and uses the appropriate variables without modifying the user's env.
|
Ive added info to the AWS authentication error message on how to setup authentication (it uses |
| @@ -1120,3 +1115,23 @@ def post_start(self): | |||
|
|
|||
| logger.stdout(f"Library: {self.library}") | |||
| logger.stdout(f"Image: {self.image.name}") | |||
|
|
|||
|
|
|||
| def set_aws_auth_environment(image): | |||
There was a problem hiding this comment.
Make it private to prevent external usage :
| def set_aws_auth_environment(image): | |
| def _set_aws_auth_environment(image): |
| @@ -23,6 +26,18 @@ def _get_unique_id(replay: bool, host_log_folder: str) -> str: | |||
| return unique_id | |||
|
|
|||
|
|
|||
| def _check_aws_variables(scenario: EndToEndScenario): | |||
There was a problem hiding this comment.
Would it be more clean to make this a method of EndToEndScenario ?
class EndToEndScenario:
...
def _check_aws_variables(self):
...
Motivation
Fixes
., an illegal queue name characterAWS_REGIONtous-east-1.SYSTEM_TESTS_[AWS Var name]INTEGRATIONSandCROSSED_TRACING_LIBRARIESsuites, and throw an error if the variables are not set. The message provides info on how to authenticate with AWS to run the test suite.Changes
Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present