Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Apply native plugins when profiling and tracing is disabled #3202

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

randomanderson
Copy link
Contributor

Motivation

The build for the native application is broken when the with-profiling and without-profiling profiles are both disabled. They are both disabled when trying to run the native app without any instrumentation.

Changes

spring-boot-maven-plugin and native-maven-plugin are defined in <pluginManagement> in spring-boot-parent. To activate them, they have to be defined in <plugins>. This PR always applies the plugins then uses the two profiles to change the build args.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@randomanderson randomanderson marked this pull request as ready for review October 8, 2024 20:48
@randomanderson randomanderson requested review from a team as code owners October 8, 2024 20:48
@cbeauchesne
Copy link
Collaborator

I let the java team have an educated eye on this one.

Copy link
Contributor

@MattAlp MattAlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This came up as some work between myself and Laplie; we're reusing the system tests within relenv, so while we don't need to support a scenario here where neither profile is used we do want this to be available.

@MattAlp MattAlp merged commit 84f55c4 into main Oct 9, 2024
115 of 116 checks passed
@MattAlp MattAlp deleted the landerson/spring-boot-native-baseline branch October 9, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants