Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] fix return value for endpoint in fastapi weblog #3217

Conversation

christophe-papazian
Copy link
Contributor

@christophe-papazian christophe-papazian commented Oct 10, 2024

Motivation

tests/appsec/iast/sink/test_ssrf.py::TestSSRF::test_secure is generating an error log on fastapi

Changes

fix the corresponding endpoint in the fastapi weblog

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@christophe-papazian christophe-papazian added the python Pull requests that update Python code label Oct 10, 2024
@christophe-papazian christophe-papazian marked this pull request as ready for review October 10, 2024 15:43
@christophe-papazian christophe-papazian requested review from P403n1x87 and erikayasuda and removed request for a team October 10, 2024 15:43
@christophe-papazian christophe-papazian merged commit 5c2cdc1 into main Oct 10, 2024
80 of 81 checks passed
@christophe-papazian christophe-papazian deleted the christophe-papazian/fix_fastapi_weblog_iast_ssrf_test_secure_endpoint branch October 10, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants