Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RC product name in Test_Lfi_RC_CustomAction #3226

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iunanua
Copy link
Contributor

@iunanua iunanua commented Oct 11, 2024

Motivation

Rulesets are sent through ASM_DD product, not ASM

Changes

Change RC config product name

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@iunanua iunanua assigned iunanua and simon-id and unassigned iunanua Oct 11, 2024
@iunanua iunanua mentioned this pull request Oct 11, 2024
7 tasks
@simon-id simon-id changed the title Fix RC product name Fix RC product name in Test_Lfi_RC_CustomAction Oct 11, 2024
@simon-id simon-id marked this pull request as ready for review October 11, 2024 16:03
@simon-id simon-id requested review from a team as code owners October 11, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants