Instrument Gradle Launcher instead of directly instrumenting Gradle Daemon (to preserve org.gradle.jvmargs if it is specified) #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aemon (to preserve org.gradle.jvmargs if it is specified)
This was referenced Nov 25, 2024
juan-fernandez
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates instrumentation logic for Gradle so that the Java tracer is injected into the Gradle Launcher instead of the Gradle Daemon: injecting the tracer into the daemon required overwriting its
org.gradle.jvmargssystem property which cancelled out whatever settings the user specified for the Gradle Daemon JVM (see DataDog/dd-trace-java#8001 for more details).Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes