Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DelayedQueryWithDtoCtorParamTest test #259

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SergeiPavlov
Copy link
Contributor

No description provided.

@alex-kulakov
Copy link
Contributor

I would throw an exception in such cases instead of not caching query. The query is not cacheable by default. We can mislead user and not cache query and user will go back to us and ask why we don't cache his query, or we can tell the truth that we cannot cache such query and offer user to declare a local variable that will be processed just fine. The third option is providing a way to pass such objects to the query and somehow put such objects to ParameterContext and resolve all the constants that outside of closure to some variable in ParameterContext instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants