Merge for v25.0.1 Approved (#855)

* Update v25 Approved (#854) * Updated rule 161 US to improve performance. * Updated rule 0128 for IFRS for performance improvement * Recompile ruleset .zip files Python 3.12.4 || Arelle 2.30.21 || XULE 30024 for v25.0.1 --------- Co-authored-by: campbellpryde
DataQualityCommittee · Oct 4, 2024 · c179abc · c179abc
1 parent a756fbb
commit c179abc
Show file tree

Hide file tree

Showing 21 changed files with 8 additions and 8 deletions.
diff --git a/dqc_us_rules/dqc-esef-2020-V25-ruleset.zip b/dqc_us_rules/dqc-esef-2020-V25-ruleset.zip
diff --git a/dqc_us_rules/dqc-esef-2021-V25-ruleset.zip b/dqc_us_rules/dqc-esef-2021-V25-ruleset.zip
diff --git a/dqc_us_rules/dqc-esef-2022-V25-ruleset.zip b/dqc_us_rules/dqc-esef-2022-V25-ruleset.zip
diff --git a/dqc_us_rules/dqc-ifrs-2020-V25-ruleset.zip b/dqc_us_rules/dqc-ifrs-2020-V25-ruleset.zip
diff --git a/dqc_us_rules/dqc-ifrs-2021-V25-ruleset.zip b/dqc_us_rules/dqc-ifrs-2021-V25-ruleset.zip
diff --git a/dqc_us_rules/dqc-ifrs-2022-V25-ruleset.zip b/dqc_us_rules/dqc-ifrs-2022-V25-ruleset.zip
diff --git a/dqc_us_rules/dqc-ifrs-2023-V25-ruleset.zip b/dqc_us_rules/dqc-ifrs-2023-V25-ruleset.zip
diff --git a/dqc_us_rules/dqc-ifrs-2024-V25-ruleset.zip b/dqc_us_rules/dqc-ifrs-2024-V25-ruleset.zip
diff --git a/dqc_us_rules/dqc-us-2020-V25-ruleset.zip b/dqc_us_rules/dqc-us-2020-V25-ruleset.zip
diff --git a/dqc_us_rules/dqc-us-2021-V25-ruleset.zip b/dqc_us_rules/dqc-us-2021-V25-ruleset.zip
diff --git a/dqc_us_rules/dqc-us-2022-V25-ruleset.zip b/dqc_us_rules/dqc-us-2022-V25-ruleset.zip
diff --git a/dqc_us_rules/dqc-us-2023-V25-ruleset.zip b/dqc_us_rules/dqc-us-2023-V25-ruleset.zip
diff --git a/dqc_us_rules/dqc-us-2024-V25-ruleset.zip b/dqc_us_rules/dqc-us-2024-V25-ruleset.zip
diff --git a/dqc_us_rules/source/ifrs/2021/DQC_IFRS_0128.xule b/dqc_us_rules/source/ifrs/2021/DQC_IFRS_0128.xule
@@ -35,7 +35,7 @@ $collective_dimensions = if $srttaxonomy
 
 for $dimension in $collective_dimensions
                 $dimension_fact =[nonils @@concept in $MONETARY_NON_NEGS @$dimension = *]
-                $default_value_of_dimension = [nonils];
+                $default_value_of_dimension = [nonils @@concept in $MONETARY_NON_NEGS];
                 $dimension_fact > $default_value_of_dimension
                 and $dimension_fact.decimals ==  $default_value_of_dimension.decimals
 

diff --git a/dqc_us_rules/source/ifrs/2022/DQC_IFRS_0128.xule b/dqc_us_rules/source/ifrs/2022/DQC_IFRS_0128.xule
@@ -35,7 +35,7 @@ $collective_dimensions = if $srttaxonomy
 
 for $dimension in $collective_dimensions
                 $dimension_fact =[nonils @@concept in $MONETARY_NON_NEGS @$dimension = *]
-                $default_value_of_dimension = [nonils];
+                $default_value_of_dimension = [nonils @@concept in $MONETARY_NON_NEGS];
                 $dimension_fact > $default_value_of_dimension
                 and $dimension_fact.decimals ==  $default_value_of_dimension.decimals
 

diff --git a/dqc_us_rules/source/ifrs/2023/DQC_IFRS_0128.xule b/dqc_us_rules/source/ifrs/2023/DQC_IFRS_0128.xule
@@ -35,7 +35,7 @@ $collective_dimensions = if $srttaxonomy
 
 for $dimension in $collective_dimensions
                 $dimension_fact =[nonils @@concept in $MONETARY_NON_NEGS @$dimension = *]
-                $default_value_of_dimension = [nonils];
+                $default_value_of_dimension = [nonils @@concept in $MONETARY_NON_NEGS];  // Massive performance improvement by doing @@concept in $MONETARY_NON_NEGS ?
                 $dimension_fact > $default_value_of_dimension
                 and $dimension_fact.decimals ==  $default_value_of_dimension.decimals
 

diff --git a/dqc_us_rules/source/ifrs/2024/DQC_IFRS_0128.xule b/dqc_us_rules/source/ifrs/2024/DQC_IFRS_0128.xule
@@ -35,7 +35,7 @@ $collective_dimensions = if $srttaxonomy
 
 for $dimension in $collective_dimensions
                 $dimension_fact =[nonils @@concept in $MONETARY_NON_NEGS @$dimension = *]
-                $default_value_of_dimension = [nonils];
+                $default_value_of_dimension = [nonils @@concept in $MONETARY_NON_NEGS];
                 $dimension_fact > $default_value_of_dimension
                 and $dimension_fact.decimals ==  $default_value_of_dimension.decimals
 

diff --git a/dqc_us_rules/source/lib/version.xule b/dqc_us_rules/source/lib/version.xule
@@ -9,7 +9,7 @@ DQC Rules
 
 /** Define the rule version and release candidate (RC) **/
 
-constant $ruleVersion = '25.0.0'
+constant $ruleVersion = '25.0.1'
 
 /** Define Additional Attribute types that can be associated with a rule **/
 

diff --git a/dqc_us_rules/source/us/2022/DQC_0161.xule b/dqc_us_rules/source/us/2022/DQC_0161.xule
@@ -32,7 +32,7 @@ for $cube in $all_cubes
                     if count(navigate dimensions descendants from $domain drs-role $cube.drs-role cube $cube.cube-concept()) == 1
                         $count_values = count(list({@cube = $cube @$dim = *}#PrimaryConcept));
 
-                        $count_values == 1 and (not exists({@$dim = none}))
+                         $count_values == 1 and (not exists({@cube = $cube @$dim = none}))
                     else
                         skip
             else

diff --git a/dqc_us_rules/source/us/2023/DQC_0161.xule b/dqc_us_rules/source/us/2023/DQC_0161.xule
@@ -32,7 +32,7 @@ for $cube in $all_cubes
                     if count(navigate dimensions descendants from $domain drs-role $cube.drs-role cube $cube.cube-concept()) == 1
                         $count_values = count(list({@cube = $cube @$dim = *}#PrimaryConcept));
 
-                        $count_values == 1 and (not exists({@$dim = none}))
+                        $count_values == 1 and (not exists({@cube = $cube @$dim = none}))
                     else
                         skip
             else

diff --git a/dqc_us_rules/source/us/2024/DQC_0161.xule b/dqc_us_rules/source/us/2024/DQC_0161.xule
@@ -37,7 +37,7 @@ else
                         if count(navigate dimensions descendants from $domain drs-role $cube.drs-role cube $cube.cube-concept()) == 1
                             $count_values = count(list({@cube = $cube @$dim = *}#PrimaryConcept));
 
-                            $count_values == 1 and (not exists({@$dim = none}))
+                            $count_values == 1 and (not exists({@cube = $cube @$dim = none}))
                         else
                             skip
                 else