Merge v6 for release (#355)

* Updated function to handle nil values when comparing assets to liabilities * Added rupdated ruleset files for version 6
DataQualityCommittee · Aug 24, 2018 · dffdd4d · dffdd4d
1 parent 16ad961
commit dffdd4d
Show file tree

Hide file tree

Showing 8 changed files with 40 additions and 0 deletions.
diff --git a/dqc_us_rules/dqc-us-2015-V6-ruleset.zip b/dqc_us_rules/dqc-us-2015-V6-ruleset.zip
diff --git a/dqc_us_rules/dqc-us-2016-V6-ruleset.zip b/dqc_us_rules/dqc-us-2016-V6-ruleset.zip
diff --git a/dqc_us_rules/dqc-us-2017-V6-ruleset.zip b/dqc_us_rules/dqc-us-2017-V6-ruleset.zip
diff --git a/dqc_us_rules/dqc-us-2018-V6-ruleset.zip b/dqc_us_rules/dqc-us-2018-V6-ruleset.zip
diff --git a/dqc_us_rules/source/us/2015/functions.xule b/dqc_us_rules/source/us/2015/functions.xule
@@ -85,6 +85,16 @@ $tolerance1 = if ($left.decimals < $right.decimals)
 					$right.decimals;
 $tolerance2 = (10.power(-1 * $tolerance1)) * $decimal_tolerance_factor;
 
+$left = if $left == none
+			0
+		else
+			$left;
+
+$right = if $right == none
+			0
+		else
+			$right;
+
 if (abs(round($left,$tolerance1) - round($right,$tolerance1)) > $tolerance2) 
 	true
 else 

diff --git a/dqc_us_rules/source/us/2016/functions.xule b/dqc_us_rules/source/us/2016/functions.xule
@@ -85,6 +85,16 @@ $tolerance1 = if ($left.decimals < $right.decimals)
 					$right.decimals;
 $tolerance2 = (10.power(-1 * $tolerance1)) * $decimal_tolerance_factor;
 
+$left = if $left == none
+			0
+		else
+			$left;
+
+$right = if $right == none
+			0
+		else
+			$right;
+
 if (abs(round($left,$tolerance1) - round($right,$tolerance1)) > $tolerance2) 
 	true
 else 

diff --git a/dqc_us_rules/source/us/2017/functions.xule b/dqc_us_rules/source/us/2017/functions.xule
@@ -88,6 +88,16 @@ $tolerance2 = if ($tolerance1 == inf)
 					0
 				else 	
 					(10.power(-1 * $tolerance1)) * $decimal_tolerance_factor;
+
+$left = if $left == none
+			0
+		else
+			$left;
+
+$right = if $right == none
+			0
+		else
+			$right;
 
 if (abs(round($left,$tolerance1) - round($right,$tolerance1)) > $tolerance2) 
 	true

diff --git a/dqc_us_rules/source/us/2018/functions.xule b/dqc_us_rules/source/us/2018/functions.xule
@@ -88,6 +88,16 @@ $tolerance2 = if ($tolerance1 == inf)
 					0
 				else 	
 					(10.power(-1 * $tolerance1)) * $decimal_tolerance_factor;
+
+$left = if $left == none
+			0
+		else
+			$left;
+
+$right = if $right == none
+			0
+		else
+			$right;
 
 if (abs(round($left,$tolerance1) - round($right,$tolerance1)) > $tolerance2) 
 	true