esmf: update to 8.6.0

* Update esmf 8.5.0 --> 8.6.0.
* Remove install name fixes.  Was fixed upstream.
* Remove allow-argument-mismatch.  Was fixed upstream.
* Clean up github controls.
* Add myself as co-maintainer.

science/esmf/Portfile

@@ -7,27 +7,27 @@ PortGroup           github 1.0
 
 compilers.choose    f90 cxx
 compilers.setup     require_fortran -clang
-compilers.allow_arguments_mismatch \
-                    yes
 mpi.setup
 mpi.enforce_variant netcdf-fortran
 
-github.setup        esmf-org esmf 8.5.0 v
+github.setup        esmf-org esmf 8.6.0
+github.tarball_from archive
 revision            0
-checksums           rmd160  3d1edb514d5b09b46f1f60047e3f5cd3c0bf7b43 \
-                    sha256  acd0b2641587007cc3ca318427f47b9cae5bfd2da8d2a16ea778f637107c29c4 \
-                    size    14091400
+checksums           rmd160  c0ceb96807cbfffab87151982ec7cf8920e19c7d \
+                    sha256  ed057eaddb158a3cce2afc0712b49353b7038b45b29aee86180f381457c0ebe7 \
+                    size    14154182
 
-version             [string map {_ .} ${github.version}]
 categories          science devel
 license             NCSA
-maintainers         {takeshi @tenomoto} openmaintainer
+maintainers         {takeshi @tenomoto} \
+                    {@Dave-Allured noaa.gov:dave.allured} \
+                    openmaintainer
+
 description         software for building and coupling weather, climate, and related models
 long_description    The ESMF defines an architecture for composing complex, coupled \
                     modeling systems and includes data structures \
                     and utilities for developing individual models.
 homepage            https://earthsystemmodeling.org
-github.tarball_from archive
 
 depends_build       bin:ranlib:cctools
 
@@ -44,8 +44,6 @@ if {${os.platform} eq "darwin" && ${os.major} < 12} {
     }
 }
 
-patchfiles          install_name.patch
-
 post-patch {
     if {[variant_isset openmpi]} {
         foreach c {g95 gfortran gfortranclang} {
@@ -179,22 +177,6 @@ post-destroot {
     system -W ${destroot}${prefix}/lib "ranlib libesmf.a"
     system -W ${destroot}${prefix}/lib "ranlib libesmftrace_static.a"
     file delete ${destroot}${prefix}/lib/preload.sh
-# Adhoc fix
-    foreach f {ESMF_PrintInfo ESMF_Regrid ESMF_Scrip2Unstruct \
-            ESMF_PrintInfoC ESMF_RegridWeightGen ESMF_WebServController} {
-        system -W ${destroot}${prefix}/bin \
-                "install_name_tool -change ${destroot}${prefix}/lib/libesmf.dylib ${prefix}/lib/libesmf.dylib ${f}"
-        foreach l {gfortran.5 quadmath.0} {
-            system -W ${destroot}${prefix}/bin \
-                "install_name_tool -change @rpath/lib${l}.dylib ${prefix}/lib/libgcc/lib${l}.dylib ${f}"
-        }
-    }
-    foreach f {esmf esmftrace_preload esmf_fullylinked} {
-        system -W ${destroot}${prefix}/lib \
-                "install_name_tool -change @rpath/libgfortran.5.dylib ${prefix}/lib/libgcc/libgfortran.5.dylib lib${f}.dylib"
-        system -W ${destroot}${prefix}/lib \
-                "install_name_tool -change ${worksrcpath}/lib${f}.dylib ${prefix}/lib/lib${f}.dylib lib${f}.dylib"
-    }
 }
 
 # Exclude pre-release candidates