Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Walter Kolczynski - NOAA <Walter.Kolczynski@noaa.gov>
  • Loading branch information
DavidHuber-NOAA and WalterKolczynski-NOAA authored Nov 6, 2024
1 parent 39872bd commit 86c66f9
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion parm/config/gefs/config.base
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ export MAKE_NSSTBUFR="@MAKE_NSSTBUFR@"
export MAKE_ACFTBUFR="@MAKE_ACFTBUFR@"

# Verification options
export DO_METP="@DO_METP@" # Run METPLUS jobs - set METPLUS settings in config.metp
export DO_METP="NO" # Run METPLUS jobs - set METPLUS settings in config.metp
export DO_FIT2OBS="NO" # Run fit to observations package

# Archiving options
Expand Down
2 changes: 1 addition & 1 deletion workflow/hosts/wcoss2.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ RESERVATION: ''
CHGRP_RSTPROD: 'YES'
CLUSTERS: ''
CHGRP_CMD: 'chgrp rstprod'
HPSSARCH: 'YES'
HPSSARCH: 'NO'
HPSS_PROJECT: emc-global
LOCALARCH: 'NO'
ATARDIR: '/NCEPDEV/${HPSS_PROJECT}/1year/${USER}/${machine}/scratch/${PSLOT}'
Expand Down
3 changes: 2 additions & 1 deletion workflow/setup_expt.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,12 @@ def _update_defaults(dict_in: dict) -> dict:
# Replace values in ['defaults']['config_name']['var1'] with ['config_name']['var1']
# and return the ['defaults'] subdictionary as its own new dictionary.
defaults = dict_in.pop('defaults', AttrDict())
if 'defaults' in defaults:
_update_defaults(defaults)
defaults.update(dict_in)
return defaults

# Convert the inputs to an AttrDict
# data = AttrDict(**inputs.__dict__)
data = AttrDict(host.info, **inputs.__dict__)

# Read in the YAML file to fill out templates
Expand Down

0 comments on commit 86c66f9

Please sign in to comment.