Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Optim] change vectors of "heap stuff" into tensor structures #21

Open
4 tasks
DavidLapous opened this issue Sep 23, 2024 · 0 comments
Open
4 tasks

[Optim] change vectors of "heap stuff" into tensor structures #21

DavidLapous opened this issue Sep 23, 2024 · 0 comments
Labels
enhancement New feature or request optimization

Comments

@DavidLapous
Copy link
Owner

DavidLapous commented Sep 23, 2024

Commit 80c699c suggests (with internal benchmarks)
that non-tensor (or vectors of stuff in the heap) structures can induce significantly slower performances.
Some structures could hence be changed to ensure contiguous stack structures:

  • replaces vectors by small vectors for filtration values (with different capacity, chosen during runtime in python) -> TODO: benchmark this
  • replace the multifiltration structure by the one used for degree-rips-like filtrations when 2 parameters
  • use 2d tensors for multicritical filtrations
  • Optimize current tensor implementation
@DavidLapous DavidLapous added the enhancement New feature or request label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request optimization
Projects
None yet
Development

No branches or pull requests

1 participant