Single record mode and root false tweaks #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables `single_record: true` to work when the ruby array serializer is used as a fallback which should avoid confusion when mixing database and ruby serializers.
This change allows to use `single_record: true` mode with collections without having to specify the `root: 'singular_name'` option. The root key is only singularized if it was not manually specified via the options or on the serializer itself.
| @@ -51,7 +62,9 @@ def _include_relation_in_root(relation, *args) | |||
| end | |||
|
|
|||
| _serializer = serializer_class.new klass.new, options | |||
| root_key = local_options.fetch(:root, _serializer.root_name.to_s.pluralize).to_s | |||
There was a problem hiding this comment.
This code was buggy, because root option could be nil, causing the fallback to not be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
root: falseoption (until we add support for it)root: 'singular_name'is now optional)There currently are no tests for the fallback and single_record behavior, but we should add it after #53 is implemented.