Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jellyfish-testing): Add TestingWrapper as an abstraction layer approach 2 #1114

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

surangap
Copy link
Contributor

What this PR does / why we need it:

Approach using generics and union for testing refactor

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

@codeclimate
Copy link

codeclimate bot commented Feb 28, 2022

Code Climate has analyzed commit eef40b6 and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented Feb 28, 2022

✔️ Deploy Preview for jellyfish-defi ready!

🔨 Explore the source changes: eef40b6

🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/621c73a790f94b0007e0ebfc

😎 Browse the preview: https://deploy-preview-1114--jellyfish-defi.netlify.app

@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #1114 (eef40b6) into main (ddc6b7f) will decrease coverage by 2.35%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1114      +/-   ##
==========================================
- Coverage   95.69%   93.34%   -2.36%     
==========================================
  Files         169      171       +2     
  Lines        5045     5066      +21     
  Branches      657      658       +1     
==========================================
- Hits         4828     4729      -99     
- Misses        208      323     +115     
- Partials        9       14       +5     
Impacted Files Coverage Δ
packages/jellyfish-testing/src/testing.ts 95.12% <90.00%> (-4.88%) ⬇️
packages/jellyfish-testing/src/anchor.ts 100.00% <100.00%> (ø)
packages/jellyfish-testing/src/fixture.ts 100.00% <100.00%> (ø)
packages/jellyfish-testing/src/icxorderbook.ts 100.00% <100.00%> (ø)
packages/jellyfish-wallet-encrypted/src/hd_node.ts 12.12% <0.00%> (-87.88%) ⬇️
...s/legacy-api/src/controllers/PoolPairController.ts 35.00% <0.00%> (-65.00%) ⬇️
...nsaction-builder/src/txn/txn_builder_masternode.ts 40.00% <0.00%> (-60.00%) ⬇️
packages/jellyfish-address/src/script/P2SH.ts 45.45% <0.00%> (-50.00%) ⬇️
...ckages/jellyfish-network/src/TransactionSkipped.ts 37.50% <0.00%> (-50.00%) ⬇️
...action-builder/src/txn/txn_builder_icxorderbook.ts 64.28% <0.00%> (-35.72%) ⬇️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddc6b7f...eef40b6. Read the comment docs.

@surangap surangap changed the title feat(jellyfish-testing):Add TestingWrapper as an abstraction layer approach 2 [WIP]feat(jellyfish-testing):Add TestingWrapper as an abstraction layer approach 2 Feb 28, 2022
@fuxingloh fuxingloh changed the title [WIP]feat(jellyfish-testing):Add TestingWrapper as an abstraction layer approach 2 feat(jellyfish-testing): Add TestingWrapper as an abstraction layer approach 2 Jan 19, 2023
@github-actions github-actions bot added the kind/feature New feature request label Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants