-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(apps/whale): refactor to jellyfish conventions #1277
base: main
Are you sure you want to change the base?
Conversation
Code Climate has analyzed commit 32d5b35 and detected 170 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
✅ Deploy Preview for jellyfish-defi ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## main #1277 +/- ##
==========================================
+ Coverage 86.50% 88.84% +2.33%
==========================================
Files 331 331
Lines 9582 9582
Branches 1174 1174
==========================================
+ Hits 8289 8513 +224
+ Misses 1223 1018 -205
+ Partials 70 51 -19
Continue to review full report at Codecov.
|
Docker build preview for jellyfish/apps is ready! Built with commit 60d55c9
|
To merge after build and release workflow is ready
Then we can freeze whale and move everyone over for 100% feature parity and release stability before performing the refactor
What this PR does / why we need it:
Follow-up PR to adapt whale code / structure to jellyfish conventions:
__tests__
with mirrored directory structureWhich issue(s) does this PR fixes?:
/apps/whale-api
- Consolidation & Migration #977Additional comments?:
_module
files as it helps to distinguish the entrypoint of each moduleStatus
On hold - let's complete the migration first with 100% feature parity before we proceed with refactoring