Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jellyfish-api-core): added net.getVersionInfo() and its respective test getVersionInfo.tes… #1976

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

greggtan
Copy link

What this PR does / why we need it:

/kind feature

  • Added a new feature getVersionInfo() in Jellyfish SDK which is consistent with ain/net.cpp method getversioninfo()

Which issue(s) does this PR fixes?:

Implemented type for RPC: #48

  1. net.getVersionInfo()

@netlify
Copy link

netlify bot commented Jan 16, 2023

Deploy Preview for jellyfishsdk ready!

Name Link
🔨 Latest commit 7b44fbd
🔍 Latest deploy log https://app.netlify.com/sites/jellyfishsdk/deploys/63ca25477c1633000866dd90
😎 Deploy Preview https://deploy-preview-1976--jellyfishsdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Jan 16, 2023

Code Climate has analyzed commit 7b44fbd and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Base: 92.28% // Head: 93.08% // Increases project coverage by +0.79% 🎉

Coverage data is based on head (7b44fbd) compared to base (d8260a9).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1976      +/-   ##
==========================================
+ Coverage   92.28%   93.08%   +0.79%     
==========================================
  Files         365      365              
  Lines       10905    10907       +2     
  Branches     1417     1417              
==========================================
+ Hits        10064    10153      +89     
+ Misses        807      718      -89     
- Partials       34       36       +2     
Impacted Files Coverage Δ
packages/jellyfish-api-core/src/category/net.ts 100.00% <100.00%> (ø)
...hale-api/src/module.api/legacy.subgraph.service.ts 16.12% <0.00%> (-70.17%) ⬇️
apps/libs/caches/src/LegacyCache.ts 33.33% <0.00%> (-66.67%) ⬇️
apps/whale-api/src/module.api/legacy.controller.ts 36.84% <0.00%> (-63.16%) ⬇️
packages/testcontainers/src/utils.ts 91.66% <0.00%> (-8.34%) ⬇️
...ages/jellyfish-api-core/src/category/blockchain.ts 91.11% <0.00%> (-4.45%) ⬇️
packages/jellyfish-crypto/src/der.ts 92.59% <0.00%> (-3.71%) ⬇️
...s/testcontainers/src/containers/DockerContainer.ts 94.64% <0.00%> (-3.58%) ⬇️
...s/legacy-api/src/controllers/PoolPairController.ts 85.22% <0.00%> (-1.14%) ⬇️
...ellyfish-transaction-signature/src/tx_signature.ts 90.90% <0.00%> (ø)
... and 36 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Greg Tan and others added 3 commits January 16, 2023 17:45
…responding test file getVersionInfo.test.ts
Co-authored-by: Eli <31790206+eli-lim@users.noreply.github.com>
Signed-off-by: Greg G Tan <63829446+greggtan@users.noreply.github.com>
Copy link
Author

@greggtan greggtan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes made to getVersionInfo.test.ts

@greggtan greggtan changed the title added net.getVersionInfo() and its respective test getVersionInfo.tes… feat(jellyfish-api-core):added net.getVersionInfo() and its respective test getVersionInfo.tes… Jan 16, 2023
Copy link
Contributor

@eli-lim eli-lim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

title should be

feat(jellyfish-api-core): added ...

instead of

feat(jellyfish-api-core):added ...

@fuxingloh fuxingloh marked this pull request as draft January 19, 2023 07:24
@greggtan greggtan changed the title feat(jellyfish-api-core):added net.getVersionInfo() and its respective test getVersionInfo.tes… feat(jellyfish-api-core): added net.getVersionInfo() and its respective test getVersionInfo.tes… Jan 20, 2023
@github-actions github-actions bot added the kind/feature New feature request label Jan 20, 2023
@greggtan greggtan marked this pull request as ready for review January 20, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants