-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jellyfish-api-core): added net.getVersionInfo() and its respective test getVersionInfo.tes… #1976
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for jellyfishsdk ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Code Climate has analyzed commit 7b44fbd and detected 0 issues on this pull request. View more on Code Climate. |
packages/jellyfish-api-core/__tests__/category/net/getVersionInfo.test.ts
Outdated
Show resolved
Hide resolved
Codecov ReportBase: 92.28% // Head: 93.08% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1976 +/- ##
==========================================
+ Coverage 92.28% 93.08% +0.79%
==========================================
Files 365 365
Lines 10905 10907 +2
Branches 1417 1417
==========================================
+ Hits 10064 10153 +89
+ Misses 807 718 -89
- Partials 34 36 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…responding test file getVersionInfo.test.ts
Co-authored-by: Eli <31790206+eli-lim@users.noreply.github.com> Signed-off-by: Greg G Tan <63829446+greggtan@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes made to getVersionInfo.test.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title should be
feat(jellyfish-api-core): added ...
instead of
feat(jellyfish-api-core):added ...
What this PR does / why we need it:
/kind feature
Which issue(s) does this PR fixes?:
Implemented type for RPC: #48