Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resolvable profile error for setting/getting textures. #245

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Olzie-12
Copy link

@Olzie-12 Olzie-12 commented Sep 19, 2024

I've created a fix for the new commit that Spigot has made here that changes the CraftMetaSkull class to use a new component ResolveableProfile, that prevented from setting/getting textures due to this change.

@Olzie-12
Copy link
Author

Olzie-12 commented Sep 20, 2024

Here is the compiled jar file, this has not been tested yet. Please let me know how you get along with it.
DecentHolograms-2.8.11.zip

@TH3N3WN00B
Copy link

Just tested it

[00:34:07] [Server thread/INFO]: [DecentHolograms] Enabling DecentHolograms v2.8.11 [00:34:07] [Server thread/ERROR]: Error occurred while enabling DecentHolograms v2.8.11 (Is it up to date?) java.lang.IllegalStateException: DecentHolograms is not running (yet). Do you have DecentHolograms plugin installed? at DecentHolograms-2.8.11.jar/eu.decentsoftware.holograms.api.DecentHologramsAPI.get(DecentHologramsAPI.java:96) ~[DecentHolograms-2.8.11.jar:?] at DecentHolograms-2.8.11.jar/eu.decentsoftware.holograms.plugin.DecentHologramsPlugin.onEnable(DecentHologramsPlugin.java:40) ~[DecentHolograms-2.8.11.jar:?] at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:288) ~[paper-mojangapi-1.21.1-R0.1-SNAPSHOT.jar:?] at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.enablePlugin(PaperPluginInstanceManager.java:202) ~[purpur-1.21.1.jar:1.21.1-2308-8332fa4] at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.enablePlugin(PaperPluginManagerImpl.java:109) ~[purpur-1.21.1.jar:1.21.1-2308-8332fa4] at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:520) ~[paper-mojangapi-1.21.1-R0.1-SNAPSHOT.jar:?] at org.bukkit.craftbukkit.CraftServer.enablePlugin(CraftServer.java:654) ~[purpur-1.21.1.jar:1.21.1-2308-8332fa4] at org.bukkit.craftbukkit.CraftServer.enablePlugins(CraftServer.java:603) ~[purpur-1.21.1.jar:1.21.1-2308-8332fa4] at net.minecraft.server.MinecraftServer.loadWorld0(MinecraftServer.java:758) ~[purpur-1.21.1.jar:1.21.1-2308-8332fa4] at net.minecraft.server.MinecraftServer.loadLevel(MinecraftServer.java:520) ~[purpur-1.21.1.jar:1.21.1-2308-8332fa4] at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:366) ~[purpur-1.21.1.jar:1.21.1-2308-8332fa4] at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1231) ~[purpur-1.21.1.jar:1.21.1-2308-8332fa4] at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:334) ~[purpur-1.21.1.jar:1.21.1-2308-8332fa4] at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?] [00:34:07] [Server thread/INFO]: [DecentHolograms] Disabling DecentHolograms v2.8.11

@Olzie-12
Copy link
Author

DecentHolograms-2.8.11.zip
My fault! Uploaded the wrong jar.

@TH3N3WN00B
Copy link

DecentHolograms-2.8.11.zip My fault! Uploaded the wrong jar.

That one worked fine!! thanks

@Olzie-12
Copy link
Author

Here's a new fix to people getting a NPE with skulls that's got no texture. DecentHolograms-2.8.12.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants