Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

depgraph.sh generates the dependency graph of the project (#154) #383

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

depgraph.sh generates the dependency graph of the project (#154) #383

wants to merge 4 commits into from

Conversation

Rehan-MALAK
Copy link
Contributor

@gabrielhdt
Copy link
Member

Just a side note, on developing shell scripts, I couldn't recommend enough ShellCheck (can be installed and used by flycheck).

@Rehan-MALAK
Copy link
Contributor Author

Nice tool !
I corrected most of the errors/warnings (mostly due to double quoting missing around arrays and not checking if a directory doesn't exist)
But I took the liberty to add a .shellcheckrc disabling
''SC2086 Double quote array expansions to avoid re-splitting elements'' because most of the time, if the string is splitted, the script wouldn't be working properly anyway.

@Rehan-MALAK
Copy link
Contributor Author

sorry, correcting with shellcheck suggestions actually broke something

@Rehan-MALAK
Copy link
Contributor Author

Ok, now this should be ok.

git clean -dffx && rm -vf graph.png graph.dot && make install && cd tools/depgraph/ && ./depgraph.sh

graph

@fblanqui fblanqui requested a review from gabrielhdt April 30, 2020 13:45
gabrielhdt
gabrielhdt requested changes May 1, 2020
View reviewed changes
Copy link
Member

@gabrielhdt gabrielhdt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have some suggestions. Thank you @Rehan-MALAK!

tools/depgraph/.shellcheckrc Outdated Show resolved Hide resolved
tools/depgraph/depgraph.sh Outdated Show resolved Hide resolved
tools/depgraph/depgraph.sh Outdated Show resolved Hide resolved
@fblanqui
Copy link
Member

fblanqui commented May 8, 2020

@Rehan-MALAK @gabrielhdt what is the status of this PR? Thanks to tell me when it will be ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielhdt gabrielhdt gabrielhdt requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rehan-MALAK @gabrielhdt @fblanqui