Support mop autowash interval #677
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #677 +/- ##
==========================================
+ Coverage 86.39% 86.54% +0.14%
==========================================
Files 96 98 +2
Lines 3551 3589 +38
Branches 307 308 +1
==========================================
+ Hits 3068 3106 +38
Misses 429 429
Partials 54 54 ☔ View full report in Codecov by Sentry. |
XxInvictus
force-pushed
the
support_mop_autowash_interval
branch
3 times, most recently
from
32e6f0c to
cdb91bf
Compare
|
Finally have all pre-commit.ci checks passing 🎉 |
|
Can you confirm that the T20 ( |
|
I can't confirm one way or the other, this isn't a feature which is advertised in marketing material so it's completely unknown. Given I can't say with 100% certainty happy to update to split T30 Omni and X5 Pro Omni into their own file to ensure there is no clash. |
|
Looks like I just managed to confirm it, mentions it in this review
|
Ref DeebotUniverse#555 - Add support for Mop Auto-Wash Frequency - Add Capability to T20/T30 Omni/X5 Pro Omni via `p1jij8.py` Fix missing list seperator Make pre-commit happy Fix error in SetAutoMopWashFrequency test case Small fix to resolve Mop Auto Wash and checkers not agreeing with int Ruff lint/format Ruff Linting/Fixes
XxInvictus
force-pushed
the
support_mop_autowash_interval
branch
from
af4ff42 to
84a34c8
Compare
| class MopAutoWashFrequency(IntEnum): | ||
| """Enum class for all possible mop auto-wash frequencies.""" | ||
|
|
||
| TEN_MINUTES = 10 |
There was a problem hiding this comment.
As the values are numbers, can we also set the interval to 1 minute? And would the bot respect this set one minute?
There was a problem hiding this comment.
It doesn't seem like it, there may be some other magic values but these are the available presets for the X5 Pro Omni.
There was a problem hiding this comment.
In the App from T30 I can only chose between 10, 15 and 25 minutes for time based mop auto wash.
The other option is mop after room
Ref #555
p1jij8.pyTested/Validated with X5 Pro Omni:
