[Embedding] Add memory and performance tests of EmbeddingVariable. (#913

) Signed-off-by: lixy9474 <lxy268263@alibaba-inc.com>
DeepRec-AI · Jul 17, 2023 · 14c25d8 · 14c25d8
1 parent 616e9e4
commit 14c25d8
Show file tree

Hide file tree

Showing 5 changed files with 402 additions and 119 deletions.
diff --git a/tensorflow/core/framework/embedding/embedding_var.h b/tensorflow/core/framework/embedding/embedding_var.h
@@ -141,8 +141,8 @@ class EmbeddingVar : public ResourceBase {
       memcpy(default_value_, &default_tensor_flat(0),
           default_tensor.TotalBytes());
 
-      default_value_no_permission_ = TypedAllocator::Allocate<V>(alloc_,
-          value_len_, AllocationAttributes());
+      default_value_no_permission_ = TypedAllocator::Allocate<V>(
+          default_value_alloc_, value_len_, AllocationAttributes());
       for (int i = 0; i < value_len_; ++i) {
         default_value_no_permission_[i] = static_cast<V>(
             emb_config_.default_value_no_permission);
@@ -755,7 +755,8 @@ class EmbeddingVar : public ResourceBase {
     TypedAllocator::Deallocate(default_value_alloc_, default_value_,
         value_len_ * emb_config_.default_value_dim);
     if (default_value_no_permission_) {
-      TypedAllocator::Deallocate(alloc_, default_value_no_permission_,
+      TypedAllocator::Deallocate(default_value_alloc_,
+          default_value_no_permission_,
           value_len_);
     }
     if (filter_) {

diff --git a/tensorflow/core/kernels/BUILD b/tensorflow/core/kernels/BUILD
@@ -461,8 +461,33 @@ tf_cuda_cc_test(
 )
 
 tf_cuda_cc_test(
-    name = "embedding_variable_memory_performance_test",
-    srcs = ["embedding_variable_memory_performance_test.cc"],
+    name = "embedding_variable_performance_test",
+    srcs = ["embedding_variable_performance_test.cc",
+            "embedding_variable_test.h"],
+    extra_copts = ["-fexceptions", "-g"],
+    deps = [
+        ":io",
+        ":ops_testutil",
+        ":ops_util",
+        "//tensorflow/core:all_kernels",
+        "//tensorflow/core:core_cpu",
+        "//tensorflow/core:core_cpu_internal",
+        "//tensorflow/core:direct_session_internal",
+        "//tensorflow/core/util/tensor_bundle",
+        "//tensorflow/core:framework",
+        "//tensorflow/core:lib",
+        "//tensorflow/core:test",
+        "//tensorflow/core:protos_all_cc",
+        "//tensorflow/core:testlib",
+        "//third_party/eigen3",
+        "//tensorflow/core:test_main",
+    ],
+)
+
+tf_cuda_cc_test(
+    name = "embedding_variable_memory_test",
+    srcs = ["embedding_variable_memory_test.cc",
+            "embedding_variable_test.h"],
     extra_copts = ["-fexceptions", "-g"],
     deps = [
         ":io",

diff --git a/tensorflow/core/kernels/embedding_variable_memory_test.cc b/tensorflow/core/kernels/embedding_variable_memory_test.cc
@@ -0,0 +1,76 @@
+/* Copyright 2022 The DeepRec Authors. All Rights Reserved.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+======================================================================*/
+#include "tensorflow/core/kernels/embedding_variable_test.h"
+
+namespace tensorflow {
+namespace embedding {
+float PerfMemory(Tensor& default_value,
+                const std::vector<int64>& id_list,
+                int value_size, int64 default_value_dim,
+                int64 filter_freq = 0) {
+  auto ev = CreateEmbeddingVar(value_size, default_value,
+                               default_value_dim, filter_freq);
+  ValuePtr<float>* value_ptr = nullptr;
+  bool is_filter = false;
+  double start_mem, end_mem;
+  start_mem = getResident() * getpagesize();
+  for (int i = 0; i < id_list.size(); i++) {
+    ev->LookupOrCreateKey(id_list[i], &value_ptr, &is_filter, false);
+    if (is_filter)
+      ev->flat(value_ptr, id_list[i]);
+  }
+  end_mem = getResident() * getpagesize();
+  double used_mb = (end_mem - start_mem)/1000000;
+  LOG(INFO)<<"[TestMemory]Use Memory: "<<used_mb;
+  return used_mb;
+}
+
+TEST(EmbeddingVariabelMemoryTest, TestMemory) {
+  int value_size = 32;
+  int64 default_value_dim = 4096;
+  int filter_freq = 2;
+  Tensor default_value(
+      DT_FLOAT, TensorShape({default_value_dim, value_size}));
+  auto default_value_matrix = default_value.matrix<float>();
+	for (int i = 0; i < default_value_dim; i++) {
+		for (int j = 0 ; j < value_size; j++) {
+			default_value_matrix(i, j) = i * value_size + j;
+		}
+	}
+
+  int num_of_ids = 1000000;
+  std::vector<int64> id_list(num_of_ids);
+  for (int i = 0; i < num_of_ids; i++) {
+    id_list[i] = i;
+  }
+  float used_mb = PerfMemory(default_value, id_list,
+                             value_size, default_value_dim);
+  float theoritical_mb =
+      50 + num_of_ids * (32 + 32 + value_size * sizeof(float))/ 1000000;
+  EXPECT_TRUE((used_mb > theoritical_mb * 0.99) &&
+              (used_mb < theoritical_mb * 1.01));
+
+  for (int i = 0; i < num_of_ids / 2; i++) {
+    id_list.emplace_back(i);
+  }
+  used_mb = PerfMemory(default_value, id_list, value_size,
+                       default_value_dim, filter_freq);
+  theoritical_mb =
+      50 + num_of_ids * (32 + 32 + 16 + value_size * sizeof(float)/2)/ 1000000;
+  EXPECT_TRUE((used_mb > theoritical_mb * 0.99) &&
+              (used_mb < theoritical_mb * 1.01));
+}
+} //namespace embedding
+} //namespace tensorflow